[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

[Ashadeepa]

Github user Ashadeepa commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1957#discussion_r10411
  
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 
---
@@ -621,6 +627,10 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 sc.setParameters("username", username);
 }
 
+if (keyword!= null) {
--- End diff --

@ustcweizhou : My bad. Amended the changes . Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1957#discussion_r102209429
  
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 
---
@@ -621,6 +627,10 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 sc.setParameters("username", username);
 }
 
+if (keyword!= null) {
--- End diff --

it seems line 630 to 633 are not needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

[Ashadeepa]

GitHub user Ashadeepa opened a pull request:

https://github.com/apache/cloudstack/pull/1957

CLOUDSTACK-9748:VPN Users search functionality broken

VPN Users search functionality broken
If you try to search VPN users with it’s user name, you will not be able 
to search.

Fixed the same.

Parent PR : https://github.com/apache/cloudstack/pull/1910

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9748

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1957


commit 588ececd045c9175b33647375fd702e3e37f2126
Author: root 
Date:   2017-01-17T18:09:17Z

CLOUDSTACK-9748:VPN Users search functionality broken




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---