[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1991


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104414236
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

Updated the patch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104405081
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

Spaces will not cause any issues. Anyway I removed the spaces, tested and 
update the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104393162
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

is the space after "-N". "-F" . "-X" needed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

[jayapalu]

GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1991

CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone

Fixed issue in deploying vm in basic zone. 
There is issue in ipset command with xenserver 6.5. In util.pread2 ipset 
and -N is passed as single string and it caused the issue in command failure.

 util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9821

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1991


commit c8819c0876582ffa1685b26bbb5aa4ed145d4723
Author: Jayapal 
Date:   2017-03-06T11:10:05Z

CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---