[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-298206491 This one should be ready to merge... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297789368 @borisstoyanov or @rhtyd can one of you kick of the tests? Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297789368 @borisstoyanov or @rhtyd can one of you kick of the tests? Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297783705 I have fixed the issue around VPN user changes dropping existing VPN connections. In working on this, I found bugs that the VPN users were not correctly being removed from the `/etc/ppp/chap-secrets` file. This had a lot of unwanted side effects, including: - VPN connections could be established using deleted users. - VPN connections could not be established for a new user if a user was deleted and added again with a different password (the original password would work, but new one would not). All of these bugs have been fixed as well as the original problem of VPN connections dropping when users are added/removed. Now remote access VPN connections will no longer drop when network changes are made. This PR is ready for testing again. Please run CI against it again and I will poke the people who are manually testing this as well. Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297765224 Regarding the Remote Access VPN connection being dropped when users are added and deleted is because the entire VPN user databag is reprocessed on each VPN user change. This means that every user is removed and then added back again after. Since each user is removed, if they had an active VPN session, the session is obviously dropped. Since there is no way to modify an existing VPN user (like change password), I should be able to find a way to selectively reconfigure the relevant VPN users. I will update this PR once I have a solution to this specific sub-problem. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297525299 Haijiao from the mailing list has confirmed that the majority of the cases are fixed, but the connection still drops when a new VPN user is added/removed. I have tested and can reproduce the behavior. I am working on a solution for that problem... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297232153 Is there a label for `run CI on this`? I feel like that would be useful. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
