Re: API Break in pods API

[Rene Moser]

Thanks Nicolas for the pointer.

Breaking the API is bad, even worse that the API docs still suggest to
update start/end ips by the API updatePod AND no errors returned (silent
fail).

We left users behind here.


On 08/17/2018 01:31 AM, Nicolas Vazquez wrote:
> Hi Rene,
> 
> 
> As you mentioned it was part of the work introduced by PR 2048. I've been 
> taking a look at its FS on this link: 
> 
>  
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range
> 
> 
> Under
>  'Architecture and Design Description' I found out these points:
> 
>   *   Now, we can only update the name, gateway and netmask of a Pod using 
> updatePod API.
>   *   We cannot update StartIp and EndIp of the pod. Because we cannot 
> replace them with just one range.
>   *   Even if we pass startIp and endIp parameters in updatePod API. It is 
> considered as NULL thereafter.

This should not be handled it as NULL because as a user, you can't see
that the updating of the start/end IP did not work. Instead an error
must be returned saying how to update the IPs

Regards
René

Re: API Break in pods API

[Nicolas Vazquez]

Hi Rene,


As you mentioned it was part of the work introduced by PR 2048. I've been 
taking a look at its FS on this link: 
<https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range#ExpansionofManagementIPRange-createManagementNetworkIpRange>
 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range


<https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range#ExpansionofManagementIPRange-createManagementNetworkIpRange><https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range>Under
 'Architecture and Design Description' I found out these points:

  *   Now, we can only update the name, gateway and netmask of a Pod using 
updatePod API.
  *   We cannot update StartIp and EndIp of the pod. Because we cannot replace 
them with just one range.
  *   Even if we pass startIp and endIp parameters in updatePod API. It is 
considered as NULL thereafter.


Regards,

Nicolas Vazquez


From: Rene Moser 
Sent: Friday, August 10, 2018 11:13:28 AM
To: dev@cloudstack.apache.org
Subject: API Break in pods API

Hi

In https://cloudstack.apache.org/api/apidocs-4.11/apis/updatePod.html
the updatePod API shows that startip and endip could be updated.
However, since 4.11, I can't anymore.

Can anyone confirm? Did I miss a thing?

This (possible) API break in 4.11 for pods seems to be introduced by
https://github.com/apache/cloudstack/pull/2048

See Issues
- https://github.com/apache/cloudstack/issues/2797
- https://github.com/apache/cloudstack/issues/2735

I don't get any answers of the author. How do we proceed to restore the API?

Regards
René



nicolas.vazq...@shapeblue.com 
www.shapeblue.com
,   
@shapeblue
  
 

API Break in pods API

[Rene Moser]

Hi

In https://cloudstack.apache.org/api/apidocs-4.11/apis/updatePod.html
the updatePod API shows that startip and endip could be updated.
However, since 4.11, I can't anymore.

Can anyone confirm? Did I miss a thing?

This (possible) API break in 4.11 for pods seems to be introduced by
https://github.com/apache/cloudstack/pull/2048

See Issues
- https://github.com/apache/cloudstack/issues/2797
- https://github.com/apache/cloudstack/issues/2735

I don't get any answers of the author. How do we proceed to restore the API?

Regards
René