Re: [PR] deployment.yaml: add tolerations [cloudstack-kubernetes-provider]
vishesh92 merged PR #38: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
vishesh92 commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2154597439 I tested the above PR with kuberentes 1.28. It doesn't seem to be adding the zone or region labels. I assume it's because this needs some more changes in the implementation of `InstancesV2` interface. Moving this PR to milestone for next release for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
vishesh92 commented on code in PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#discussion_r1629766415 ## util.go: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package cloudstack + +import ( + "fmt" + "regexp" + "strings" +) + +// If Instances.InstanceID or cloudprovider.GetInstanceProviderID is changed, the regexp should be changed too. +var providerIDRegexp = regexp.MustCompile(`^` + ProviderName + `://([^/]*)/([^/]+)$`) Review Comment: ```suggestion var providerIDRegexp = regexp.MustCompile(`^` + ProviderName + `://?([^/]*)/([^/]+)$`) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
weizhouapache commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152665390 > Yes. I did change that. Before that pod was crashing due to wrong provider name. According to the pr, the providerID should have 3 slashes instead of 2. cloudstack://2d35066b should be cloudstack:///2d35066b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
vishesh92 commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152646446 Yes. I did change that. Before that pod was crashing due to wrong provider name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
weizhouapache commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152641282 > I am seeing the below errors after applying the changes. I am not sure about the root cause. > I launched a CKS cluster and updated the image. > ```go > E0606 13:02:31.408425 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:36.515139 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:37.025198 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:37.025248 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:37.025255 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:37.025261 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:37.025267 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:41.584449 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" > E0606 13:02:46.648644 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" > ``` @vishesh92 did you change the provider name from external-cloudstack to cloudstack? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
vishesh92 commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152411619 I am seeing the below errors after applying the changes. I am not sure about the root cause. I launched a CKS cluster and updated the image. ```go E0606 13:02:31.408425 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:36.515139 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:37.025198 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:37.025248 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:37.025255 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:37.025261 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:37.025267 1 node_controller.go:249] Error getting instance metadata for node addresses: ProviderID "" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:41.584449 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" E0606 13:02:46.648644 1 node_lifecycle_controller.go:149] error checking if node k8s-1273-node-18f3588c91c exists: ProviderID "cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected format "cloudstack://region/InstanceID" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.20.0 to 0.46.0 [cloudstack-kubernetes-provider]
rohityadavcloud closed pull request #54: Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.20.0 to 0.46.0 URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.20.0 to 0.46.0 [cloudstack-kubernetes-provider]
rohityadavcloud commented on PR #54: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/54#issuecomment-2141517078 @vishesh92 has advised to upgrade dependencies as a separate PR, closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/crypto from 0.1.0 to 0.17.0 [cloudstack-kubernetes-provider]
dependabot[bot] commented on PR #55: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/55#issuecomment-2141517381 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/crypto from 0.1.0 to 0.17.0 [cloudstack-kubernetes-provider]
rohityadavcloud commented on PR #55: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/55#issuecomment-2141517331 @vishesh92 has advised to upgrade dependencies as a separate PR, closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/crypto from 0.1.0 to 0.17.0 [cloudstack-kubernetes-provider]
rohityadavcloud closed pull request #55: Bump golang.org/x/crypto from 0.1.0 to 0.17.0 URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.20.0 to 0.46.0 [cloudstack-kubernetes-provider]
dependabot[bot] commented on PR #54: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/54#issuecomment-2141517160 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add github action for golangci-lint [cloudstack-kubernetes-provider]
rohityadavcloud merged PR #62: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]
weizhouapache commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2135116093 @hrak @vishesh92 it looks this requires some other changes like https://github.com/Leaseweb/cloudstack-kubernetes-provider/commit/323b493f9d35dc0b6c0f6c0910e73043aac1ded6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Strip domain from node.Name before matching with vm names [cloudstack-kubernetes-provider]
weizhouapache merged PR #47: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]
weizhouapache merged PR #48: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]
vishesh92 commented on PR #48: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/48#issuecomment-2125262104 @weizhouapache I am not able to reproduce the issue, but I can verify the functionality is working as expected. For why hostname is required as part of the loadbalancerStatus, check: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#loadbalanceringress-v1-core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Implement persistent volume support [cloudstack-kubernetes-provider]
weizhouapache closed issue #14: Implement persistent volume support URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Support static public ip address as a Load balancer IP [cloudstack-kubernetes-provider]
weizhouapache commented on issue #51: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/51#issuecomment-2124288747 this could be implemented via annotation, for example `service.beta.kubernetes.io/cloudstack-load-balancer-external-ip` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] feat: Cluster API support [cloudstack-kubernetes-provider]
weizhouapache closed issue #37: feat: Cluster API support URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]
weizhouapache commented on PR #48: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/48#issuecomment-2124138528 > Did some manual testing. After this change, I have verified that the service created has external IP equal to hostname set in `service.beta.kubernetes.io/cloudstack-load-balancer-hostname`. And the same hostname is also set in the status of the service. cool, thanks @vishesh92 can you test ipvs mode if the issue can be reproduced and fixed by this change ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]
vishesh92 commented on PR #48: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/48#issuecomment-2124115258 Did some testing. After this change, I have verified that the service created has external IP equal to hostname set in `service.beta.kubernetes.io/cloudstack-load-balancer-hostname`. And the same hostname is also set in the status of the service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to auto-scale Kubernetes cluster [cloudstack-kubernetes-provider]
weizhouapache commented on issue #52: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/52#issuecomment-2124110440 I notice @saffronjam used a regular user to deploy the CKS cluster, would it be related to the issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List virtual machines with details=min,nics [cloudstack-kubernetes-provider]
rohityadavcloud merged PR #60: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump chart for new provider release v1.1.0 [cloudstack-kubernetes-provider]
hrak closed pull request #61: Bump chart for new provider release v1.1.0 URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump chart for new provider release v1.1.0 [cloudstack-kubernetes-provider]
hrak opened a new pull request, #61: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/61 Bump chart for new provider release v1.1.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List virtual machines with details=min,nics [cloudstack-kubernetes-provider]
weizhouapache commented on PR #60: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/60#issuecomment-2078887527 did a quick testing, it looks ok the API command is ` 2024-04-26T08:20:25,740 DEBUG [c.c.a.ApiServlet] (qtp1375394559-21:[ctx-8dc8b523]) (logid:10e8a469) ===START=== 10.0.53.169 -- GET apiKey=FbdMHXgGot3JuiEmoldLwOo3ZWh4fGjSDTsLz5qXDZn05Q7CSh4ZXSFVJfNYUwWct5YBwHlLZKFVLR-NFKnLkw=listVirtualMachines=min%2Cnics=true=json=K3US18HTxZvG2pJ29nnP8N3PYRg%3D` the parameter ` (details=min%2Cnics)` is set as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/crypto from 0.1.0 to 0.17.0 [cloudstack-kubernetes-provider]
DaanHoogland commented on PR #55: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/55#issuecomment-2078840250 shall we merge this @rohityadavcloud @vishesh92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to get the loadbalancer IP's in a Cloudstack vmware env [cloudstack-kubernetes-provider]
kiranchavala closed issue #59: Unable to get the loadbalancer IP's in a Cloudstack vmware env URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to get the loadbalancer IP's in a Cloudstack vmware env [cloudstack-kubernetes-provider]
kiranchavala commented on issue #59: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/59#issuecomment-1973090353 Closing this issue as it turned out to be a latency issue with my network -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to get the loadbalancer IP's in a Cloudstack vmware env [cloudstack-kubernetes-provider]
kiranchavala commented on issue #59: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/59#issuecomment-1972631985 @weizhouapache 4.19 release There are no revelant logs in management server as ccm pod logs says timeout and syncing issues ``` 0301 07:08:21.326934 1 node_controller.go:245] Error getting node addresses for node "k8s-node-18df4fc61a6": error fetching node by provider ID: error retrieving node addresses: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listVirtualMachines==json=id2tgVgUyc7kyNVTCIvyk8FIQM8%3D: dial tcp 10.0.32.174:8080: i/o timeout, and error by node name: error retrieving node addresses: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listVirtualMachines=k8s-node-18df4fc61a6=json=N%2BFbJah8TFPnjpUff2CtgmMa3WY%3D: dial tcp 10.0.32.174:8080: i/o timeout E0301 07:08:49.786379 1 controller.go:244] error processing service default/nginx-deployment2 (will retry): failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listLoadBalancerRules=a145271aedaef46d8a8f1f0288961164=true=json=bCk2Dw5rsQTW1EPw2sk3IVcBnRg%3D: dial tcp 10.0.32.174:8080: i/o timeout I0301 07:08:49.786654 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"nginx-deployment2", UID:"145271ae-daef-46d8-a8f1-f02889611641", APIVersion:"v1", ResourceVersion:"201324", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncing load balancer: failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listLoadBalancerRules=a145271aedaef46d8a8f1f0288961164=true=json=bCk2Dw5rsQTW1EPw2sk3IVcBnRg%3D: dial tcp 10.0.32.174:8080: i/o timeout I0301 07:08:59.787837 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"nginx-deployment2", UID:"145271ae-daef-46d8-a8f1-f02889611641", APIVersion:"v1", ResourceVersion:"201324", FieldPath:""}): type: 'Normal' reason: 'EnsuringLoadBalancer' Ensuring load balancer E0301 07:09:29.787756 1 controller.go:244] error processing service default/nginx-deployment2 (will retry): failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listLoadBalancerRules=a145271aedaef46d8a8f1f0288961164=true=json=bCk2Dw5rsQTW1EPw2sk3IVcBnRg%3D: dial tcp 10.0.32.174:8080: i/o timeout I0301 07:09:29.788238 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"nginx-deployment2", UID:"145271ae-daef-46d8-a8f1-f02889611641", APIVersion:"v1", ResourceVersion:"201324", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncing load balancer: failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listLoadBalancerRules=a145271aedaef46d8a8f1f0288961164=true=json=bCk2Dw5rsQTW1EPw2sk3IVcBnRg%3D: dial tcp 10.0.32.174:8080: i/o timeout I0301 07:09:37.274735 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"d122fa8c-a7d5-46d5-8dbe-558fba87f89b", APIVersion:"v1", ResourceVersion:"201674", FieldPath:""}): type: 'Normal' reason: 'EnsuringLoadBalancer' Ensuring load balancer E0301 07:10:07.287471 1 controller.go:244] error processing service default/hello-node (will retry): failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.32.174:8080/client/api?apiKey=vX9-RJ1Bq0Gpl-fjTY5leRPsq01hfVeft3AGT07_5lEhFmNPQxv7IAeUkE0vzjYpRzHVLbHUXgHkMhavMbHKrg=listLoadBalancerRules=ad122fa8ca7d546d58dbe558fba87f89=true=json=f3%2FryEVsD2ylQnOZCHWuVJgrJ70%3D: dial tcp 10.0.32.174:8080: i/o timeout I0301 07:10:07.288338 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"d122fa8c-a7d5-46d5-8dbe-558fba87f89b", APIVersion:"v1", ResourceVersion:"201674", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncin
Re: [I] Unable to get the loadbalancer IP's in a Cloudstack vmware env [cloudstack-kubernetes-provider]
weizhouapache commented on issue #59: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/59#issuecomment-1972615678 @kiranchavala what's the ACS version ? any mgmt server logs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Unable to get the loadbalancer IP's in a Cloudstack vmware env [cloudstack-kubernetes-provider]
kiranchavala opened a new issue, #59: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/59 Steps to reproduce the issue 1. Create a Cloudstack environment with vmware hypervisor 2. Register the kubernetes iso (http://download.cloudstack.org/cks/setup-1.28.4.iso) 3. Launch a K8s cluster and Wait till the cluster is in running state 4. Deploy a Kubernetes application ``` kubectl create deployment hello-node --image=registry.k8s.io/e2e-test-images/agnhost:2.39 -- /agnhost netexec --http-port=80 ``` 5. Expose the deployment ``` kubectl expose deploy/hello-node --port=80 --type=LoadBalancer ``` 6. The public ip is in pending state ``` kubectl get svc NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S)AGE hello-node LoadBalancer 10.111.230.13180:31779/TCP 10s kubernetes ClusterIP 10.96.0.1443/TCP13m ``` 6. Check the logs from ``` kubectl logs -f cloud-controller-manager-574bcb86c-b4746 -n kube-system ``` Logs ``` tCl4N_MsUZYzGdvRs4Ohv51fFyku_KMBr2w=listVirtualMachines==json=EyHmAMvkfv2dWFcHuF1nkN0dbeM%3D: dial tcp 10.0.33.196:8080: i/o timeout, and error by node name: error retrieving node addresses: Get http://10.0.33.196:8080/client/api?apiKey=rwdmqchJKcIEbblvkpwidbkHFdw4TxQPvAsF6gGbCqZ9Y_Ht_u1tCl4N_MsUZYzGdvRs4Ohv51fFyku_KMBr2w=listVirtualMachines=vbn-node-18deb94a80c=json=sBJoU1JnfjRSqo5gDK4CSTLcnMM%3D: dial tcp 10.0.33.196:8080: i/o timeout I0227 17:36:47.802356 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"ffe28375-8929-4d35-a8ed-fb47860c6a9b", APIVersion:"v1", ResourceVersion:"2737", FieldPath:""}): type: 'Normal' reason: 'EnsuringLoadBalancer' Ensuring load balancer E0227 17:37:17.835369 1 controller.go:244] error processing service default/hello-node (will retry): failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.33.196:8080/client/api?apiKey=rwdmqchJKcIEbblvkpwidbkHFdw4TxQPvAsF6gGbCqZ9Y_Ht_u1tCl4N_MsUZYzGdvRs4Ohv51fFyku_KMBr2w=listLoadBalancerRules=affe2837589294d35a8edfb47860c6a9=true=json=sA7IG%2BPIfK28UEYizdqwyXX8qpE%3D: dial tcp 10.0.33.196:8080: i/o timeout I0227 17:37:17.835604 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"ffe28375-8929-4d35-a8ed-fb47860c6a9b", APIVersion:"v1", ResourceVersion:"2737", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncing load balancer: failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.33.196:8080/client/api?apiKey=rwdmqchJKcIEbblvkpwidbkHFdw4TxQPvAsF6gGbCqZ9Y_Ht_u1tCl4N_MsUZYzGdvRs4Ohv51fFyku_KMBr2w=listLoadBalancerRules=affe2837589294d35a8edfb47860c6a9=true=json=sA7IG%2BPIfK28UEYizdqwyXX8qpE%3D: dial tcp 10.0.33.196:8080: i/o timeout I0227 17:37:22.836100 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"ffe28375-8929-4d35-a8ed-fb47860c6a9b", APIVersion:"v1", ResourceVersion:"2742", FieldPath:""}): type: 'Normal' reason: 'EnsuringLoadBalancer' Ensuring load balancer E0227 17:37:52.836411 1 controller.go:244] error processing service default/hello-node (will retry): failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.33.196:8080/client/api?apiKey=rwdmqchJKcIEbblvkpwidbkHFdw4TxQPvAsF6gGbCqZ9Y_Ht_u1tCl4N_MsUZYzGdvRs4Ohv51fFyku_KMBr2w=listLoadBalancerRules=affe2837589294d35a8edfb47860c6a9=true=json=sA7IG%2BPIfK28UEYizdqwyXX8qpE%3D: dial tcp 10.0.33.196:8080: i/o timeout I0227 17:37:52.837738 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"ffe28375-8929-4d35-a8ed-fb47860c6a9b", APIVersion:"v1", ResourceVersion:"2742", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncing load balancer: failed to ensure load balancer: error retrieving load balancer rules: Get http://10.0.33.196:8080/client/api?apiKey=rwdmqchJKcIEbblvkpwidbkHFdw4TxQPvAsF6gGbCqZ9Y_Ht_u1tCl4N_MsUZYzGdvRs4Ohv51fFyku_KMBr2w=listLoadBalancerRules=affe2837589294d35a8edfb47860c6a9=true=json=sA7IG%2BPIfK28UEYizdqwyXX8qpE%3D: dial tcp 10.0.33.196:8080: i/o timeout I0227 17:38:02.837331 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"hello-node", UID:"ffe28375-8929-4d35-a8ed-fb47860c6a9b", APIVersion:"v1", Resource
Re: [I] Unable to auto-scale Kubernetes cluster [cloudstack-kubernetes-provider]
kiranchavala commented on issue #52: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/52#issuecomment-1968230660 Hi @saffronjam The autoscaling feature works fine on a k8s cluster deployed by CKS. Please find the steps that i have followed After you enable autoscaling on the cluster ![Screenshot 2024-02-28 at 10 10 20 AM](https://github.com/apache/cloudstack-kubernetes-provider/assets/1401014/d356d4a2-1015-492a-baa3-51ea496b6348) Make sure the autoscaling pod is deployed in the cluster ``` kubectl get pods -A NAMESPACE NAME READY STATUSRESTARTS AGE kube-systemcluster-autoscaler-8d8894d6c-q8r4h 1/1 Running 0 19m ``` Before scaling ``` ➜ ~ k get nodes -A NAME STATUS ROLES AGE VERSION gh-control-18debd77e18 Readycontrol-plane 10h v1.28.4 gh-node-18debd8440c Ready 10h v1.28.4 ``` Deploy a application `kubectl create deployment hello-node --image=registry.k8s.io/e2e-test-images/agnhost:2.39 -- /agnhost netexec --http-port=80` ``` ➜ ~ k get pods -A NAMESPACE NAME READY STATUSRESTARTS AGE defaulthello-node-7c6c5fb9d8-bgd69 1/1 Running 0 10h ``` Scale the application `kubectl scale --replicas=150 deployment/hello-node` logs from the autoscaler pod ``` I0228 04:51:46.798087 1 reflector.go:536] /home/djumani/lab/autoscaler/cluster-autoscaler/utils/kubernetes/listers.go:356: Watch close - *v1.StatefulSet total 9 items received I0228 04:51:51.244004 1 static_autoscaler.go:235] Starting main loop I0228 04:51:51.244382 1 client.go:169] NewAPIRequest API request URL:http://10.0.34.2:8080/client/api?apiKey=***=listKubernetesClusters=14b42c5d-e7e6-4c41-b638-5facb98b0a93=json=*** I0228 04:51:51.279721 1 client.go:175] NewAPIRequest response status code:200 I0228 04:51:51.280798 1 cloudstack_manager.go:88] Got cluster : &{14b42c5d-e7e6-4c41-b638-5facb98b0a93 gh 2 3 1 1 [0xc0013bfad0 0xc0013bfb00] map[gh-control-18debd77e18:0xc0013bfad0 gh-node-18debd8440c:0xc0013bfb00]} W0228 04:51:51.292009 1 clusterstate.go:590] Failed to get nodegroup for dc95f481-15a3-4629-bb78-055fbe4a7139: Unable to find node dc95f481-15a3-4629-bb78-055fbe4a7139 in cluster W0228 04:51:51.292052 1 clusterstate.go:590] Failed to get nodegroup for facdd040-53fe-4984-8654-c186a7cdde9b: Unable to find node facdd040-53fe-4984-8654-c186a7cdde9b in cluster I0228 04:51:51.292095 1 static_autoscaler.go:341] 2 unregistered nodes present I0228 04:51:51.292105 1 static_autoscaler.go:624] Removing unregistered node dc95f481-15a3-4629-bb78-055fbe4a7139 W0228 04:51:51.292126 1 static_autoscaler.go:627] Failed to get node group for dc95f481-15a3-4629-bb78-055fbe4a7139: Unable to find node dc95f481-15a3-4629-bb78-055fbe4a7139 in cluster W0228 04:51:51.292137 1 static_autoscaler.go:346] Failed to remove unregistered nodes: Unable to find node dc95f481-15a3-4629-bb78-055fbe4a7139 in cluster I0228 04:51:51.292569 1 filter_out_schedulable.go:65] Filtering out schedulables I0228 04:51:51.292590 1 filter_out_schedulable.go:137] Filtered out 0 pods using hints I0228 04:51:51.624523 1 filter_out_schedulable.go:175] 44 pods were kept as unschedulable based on caching I0228 04:51:51.624568 1 filter_out_schedulable.go:176] 0 pods marked as unschedulable can be scheduled. I0228 04:51:51.624667 1 filter_out_schedulable.go:87] No schedulable pods I0228 04:51:51.870314 1 static_autoscaler.go:480] Calculating unneeded nodes I0228 04:51:51.870353 1 pre_filtering_processor.go:66] Skipping gh-control-18debd77e18 - node group min size reached I0228 04:51:51.870361 1 pre_filtering_processor.go:66] Skipping gh-node-18debd8440c - node group min size reached I0228 04:51:51.870413 1 static_autoscaler.go:534] Scale down status: unneededOnly=false lastScaleUpTime=2024-02-27 17:39:33.032517071 + UTC m=-3594.093061754 lastScaleDownDeleteTime=2024-02-27 17:39:33.032517071 + UTC m=-3594.093061754 lastScaleDownFailTime=2024-02-27 17:39:33.032517071 + UTC m=-3594.093061754 scaleDownForbidden=false isDeleteInProgress=false scaleDownInCooldown=false I0228 04:52:22.258545 1 scale_up.go:468] Best option to resize: 14b42c5d-e7e6-4c41-b638-5facb98b0a93 I0228 04:52:22.258602 1 scale_up.go:472] Estimated 1 nodes needed in 14b42c5d-e7e6-4c41-b638-5facb98b0a93 I0228 04:52:22.266675 1 scale_up.go:595] Final scale-up plan: [{14b42c5d-e7e6-4c41-
[I] help with manual installation [cloudstack-kubernetes-provider]
Dav-11 opened a new issue, #58: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/58 Hello, I have installed a new cluster using [RKE2](https://docs.rke2.io/) and cilium as CNI. I followed the installation guide and deployed both the controller (https://github.com/apache/cloudstack-kubernetes-provider/blob/main/deployment.yaml) and [traefik-ingress-controller.yml](https://github.com/apache/cloudstack-kubernetes-provider/blob/main/traefik-ingress-controller.yml). But the load balancer resource is in pending state: ``` kubectl -n traefik get services NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE traefik LoadBalancer 10.43.184.45 80:30836/TCP,443:30387/TCP 8h ``` The controller logs report this: ``` E0207 07:44:58.325932 1 controller.go:244] error processing service traefik/traefik (will retry): failed to ensure load balancer: could not find network I0207 07:44:58.326064 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"traefik", Name:"traefik", UID:"4759be13-4f20-41df-a491-fa51efa1bb10", APIVersion:"v1", ResourceVersion:"44762", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncing load balancer: failed to ensure load balancer: could not find network I0207 07:49:58.326490 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"traefik", Name:"traefik", UID:"4759be13-4f20-41df-a491-fa51efa1bb10", APIVersion:"v1", ResourceVersion:"44762", FieldPath:""}): type: 'Normal' reason: 'EnsuringLoadBalancer' Ensuring load balancer I0207 07:49:58.326878 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"traefik", Name:"traefik", UID:"4759be13-4f20-41df-a491-fa51efa1bb10", APIVersion:"v1", ResourceVersion:"44762", FieldPath:""}): type: 'Warning' reason: 'UnAvailableLoadBalancer' There are no available nodes for LoadBalancer E0207 07:49:59.889606 1 controller.go:244] error processing service traefik/traefik (will retry): failed to ensure load balancer: could not find network I0207 07:49:59.889676 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"traefik", Name:"traefik", UID:"4759be13-4f20-41df-a491-fa51efa1bb10", APIVersion:"v1", ResourceVersion:"44762", FieldPath:""}): type: 'Warning' reason: 'SyncLoadBalancerFailed' Error syncing load balancer: failed to ensure load balancer: could not find network I0207 07:54:59.890211 1 event.go:278] Event(v1.ObjectReference{Kind:"Service", Namespace:"traefik", Name:"traefik", UID:"4759be13-4f20-41df-a491-fa51efa1bb10", APIVersion:"v1", ResourceVersion:"44762", FieldPath:""}): type: 'Normal' reason: 'EnsuringLoadBalancer' Ensuring load balancer ``` If I trigger the node labels generation by using ``` kubectl taint nodes node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule ``` I get errors: ``` I0207 08:10:24.487510 1 node_controller.go:325] Initializing node mynode0.mydomain.example with cloud provider E0207 08:10:24.526907 1 node_controller.go:370] failed to initialize node mynode0.mydomain.example at cloudprovider: error fetching node by provider ID: instance not found, and error by node name: instance not found ``` The cluster is running inside three VMs using an isolated network with the kubernetes network offering. Can you please help me understanding what went wrong ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers [cloudstack-kubernetes-provider]
Pearl1594 commented on PR #56: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/56#issuecomment-1900806045 Thank you so much @weizhouapache for testing!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers [cloudstack-kubernetes-provider]
weizhouapache merged PR #56: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers [cloudstack-kubernetes-provider]
weizhouapache commented on PR #56: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/56#issuecomment-1900804889 @Pearl1594 tested ok ``` root@cks-vpc-control-18d21c9d231:~# kubectl get svc NAMETYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE kubernetes ClusterIP 10.96.0.1443/TCP 4h26m nginx-service LoadBalancer 10.107.131.221 10.0.53.175 80:31387/TCP 2m4s ``` ![image](https://github.com/apache/cloudstack-kubernetes-provider/assets/57355700/87f80e5e-13cf-430b-9953-43cf852cbf89) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers [cloudstack-kubernetes-provider]
weizhouapache commented on PR #56: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/56#issuecomment-1900486299 @Pearl1594 I tested with CKS cluster deployment and nginx deployment/service. without this change ``` E0119 13:23:09.742798 1 controller.go:244] error processing service default/nginx-service (will retry): failed to ensure load balancer: error creating new firewall rule for public IP cd17cbc3-538a-439b-b7a0-4f493d8443f5, proto tcp, port 80, allowed [0.0.0.0/0]: CloudStack API error 431 (CSExceptionErrorCode: ): There is no new provider for IP 10.0.53.175 of service Firewall! ``` with this change, it crashed at line 166 ``` I0119 14:05:45.321563 1 event.go:294] "Event occurred" object="default/nginx-service" fieldPath="" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer" E0119 14:05:52.775883 1 runtime.go:79] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference) goroutine 299 [running]: k8s.io/apimachinery/pkg/util/runtime.logPanic({0x1d8c880?, 0x33f2140}) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/runtime/runtime.go:75 +0x99 k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc0007756e0?}) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/runtime/runtime.go:49 +0x75 panic({0x1d8c880, 0x33f2140}) /usr/local/go/src/runtime/panic.go:884 +0x212 github.com/apache/cloudstack-go/v2/cloudstack.(*NetworkService).GetNetworkByID(0xc00041dce0, {0xc0005cdb30, 0x24}, {0xc12fc0, 0x1, 0x50?}) /go/pkg/mod/github.com/apache/cloudstack-go/v2@v2.15.0/cloudstack/NetworkService.go:3557 +0x1b6 github.com/apache/cloudstack-kubernetes-provider.(*CSCloud).EnsureLoadBalancer(0xc0004a7980, {0xc00068f800?, 0x21fca68?}, {0x20f7fd6, 0xa}, 0xc0007b6000, {0xc12db8, 0x1, 0x1}) /go/src/github.com/apache/cloudstack-kubernetes-provider/cloudstack_loadbalancer.go:166 +0x1543 k8s.io/cloud-provider/controllers/service.(*Controller).ensureLoadBalancer(0xc00044d260, {0x23f4d70, 0xc00065e240}, 0x20f1674?) /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:459 +0x117 k8s.io/cloud-provider/controllers/service.(*Controller).syncLoadBalancerIfNeeded(0xc00044d260, {0x23f4d70, 0xc00065e240}, 0xc0007b6000, {0xc5cd08, 0x15}) /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:414 +0x6cc k8s.io/cloud-provider/controllers/service.(*Controller).processServiceCreateOrUpdate(0xc00044d260, {0x23f4d70, 0xc00065e240}, 0xc0007b6000, {0xc5cd08, 0x15}) /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:346 +0x146 k8s.io/cloud-provider/controllers/service.(*Controller).syncService(0xc00044d260, {0x23f4d70, 0xc00065e240}, {0xc5cd08, 0x15}) /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:887 +0x257 k8s.io/cloud-provider/controllers/service.(*Controller).processNextWorkItem(0xc00044d260, {0x23f4d70, 0xc00065e240}) /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:304 +0x127 k8s.io/cloud-provider/controllers/service.(*Controller).worker(0xc0008e0600?, {0x23f4d70, 0xc00065e240}) /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:283 +0x39 k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1() /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/wait/wait.go:190 +0x25 k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0x603c86b68e?) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/wait/wait.go:157 +0x3e k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0x0?, {0x23d9960, 0xc0008e0600}, 0x1, 0xc00066a300) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/wait/wait.go:158 +0xb6 k8s.io/apimachinery/pkg/util/wait.JitterUntil(0x2fea4e8bf0db330b?, 0x3b9aca00, 0x0, 0xe2?, 0x714083b09f70d83c?) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/wait/wait.go:135 +0x89 k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext({0x23f4d70, 0xc00065e240}, 0xc00068e7c0, 0xac5c70001ad37c31?, 0x255bd85d5287fd9c?, 0xe2?) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/wait/wait.go:190 +0x99 k8s.io/apimachinery/pkg/util/wait.UntilWithContext({0x23f4d70?, 0xc00065e240?}, 0x0?, 0x0?) /go/pkg/mod/k8s.io/apimachinery@v0.24.12/pkg/util/wait/wait.go:101 +0x2b created by k8s.io/cloud-provider/controllers/service.(*Controller).Run /go/pkg/mod/k8s.io/cloud-provider@v0.24.12/controllers/service/controller.go:241 +0x246 panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: in
[PR] NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers [cloudstack-kubernetes-provider]
Pearl1594 opened a new pull request, #56: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/56 Currently CKP does not setup NetworkACLs for CKS clusters on VPC tiers, and fails to add Firewall rules - as Firewall isn't supported on VPCs. This is a partial fix, to skip setting up Firewall rules if the network doesn't support the service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump golang.org/x/crypto from 0.1.0 to 0.17.0 [cloudstack-kubernetes-provider]
dependabot[bot] opened a new pull request, #55: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/55 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.1.0 to 0.17.0. Commits https://github.com/golang/crypto/commit/9d2ee975ef9fe627bf0a6f01c1f69e8ef1d4f05d;>9d2ee97 ssh: implement strict KEX protocol changes https://github.com/golang/crypto/commit/4e5a26183ecb4f9a0f85c8f8dbe7982885435436;>4e5a261 ssh: close net.Conn on all NewServerConn errors https://github.com/golang/crypto/commit/152cdb1503ebc13bc0fbb68f92ee189ebf9e3d00;>152cdb1 x509roots/fallback: update bundle https://github.com/golang/crypto/commit/fdfe1f8531a1adcc300c8eba98cb372044826d62;>fdfe1f8 ssh: defer channel window adjustment https://github.com/golang/crypto/commit/b8ffc16e10063067bac0e15c6d7f7995937503ce;>b8ffc16 blake2b: drop Go 1.6, Go 1.8 compatibility https://github.com/golang/crypto/commit/7e6fbd82c804e1760feb603fe21caecb0af0a124;>7e6fbd8 ssh: wrap errors from client handshake https://github.com/golang/crypto/commit/bda2f3f5cfce3f27039acccd823693f6d67c2a74;>bda2f3f argon2: avoid clobbering BP https://github.com/golang/crypto/commit/325b735346247f48971d2b37d24dd180a35f391f;>325b735 ssh/test: skip TestSSHCLIAuth on Windows https://github.com/golang/crypto/commit/1eadac50a566dfaa1b603ca15e8ad3cbd1c77b20;>1eadac5 go.mod: update golang.org/x dependencies https://github.com/golang/crypto/commit/b2d7c26edb17864f117d8b0ee73c1843bcc6090f;>b2d7c26 ssh: add (*Client).DialContext method Additional commits viewable in https://github.com/golang/crypto/compare/v0.1.0...v0.17.0;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/crypto=go_modules=0.1.0=0.17.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/cloudstack-kubernetes-provider/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.20.0 to 0.46.0 [cloudstack-kubernetes-provider]
DaanHoogland commented on PR #54: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/54#issuecomment-1807618196 Seems to work, should we allow this one @joschi36 @onitake @hrak ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.20.0 to 0.46.0 [cloudstack-kubernetes-provider]
dependabot[bot] opened a new pull request, #54: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/54 Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.20.0 to 0.46.0. Release notes Sourced from https://github.com/open-telemetry/opentelemetry-go-contrib/releases;>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's releases. Release v0.36.2 Changed Upgrade dependencies of the OpenTelemetry Go Metric SDK to use the new https://github.com/open-telemetry/opentelemetry-go/releases/tag/sdk%2Fmetric%2Fv0.32.2;>v0.32.2 release Avoid getting a new Tracer for every RPC in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2835;>#2835) Conditionally compute message size for tracing events using proto v2 API rather than legacy v1 API in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2647;>#2647) Deprecated The Inject function in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc is deprecated. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2838;>#2838) The Extract function in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc is deprecated. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2838;>#2838) Release v0.36.1 Changed Upgrade dependencies of the OpenTelemetry Go Metric SDK to use the new https://github.com/open-telemetry/opentelemetry-go/releases/tag/metric%2Fv0.32.1;>v0.32.1 release. Release v0.36.0 Changed Upgrade dependencies of the OpenTelemetry Go Metric SDK to use the new https://github.com/open-telemetry/opentelemetry-go/releases/tag/sdk%2Fmetric%2Fv0.32.0;>v0.32.0 release. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2781;>#2781, https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2756;>#2756, https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2758;>#2758, https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2760;>#2760, https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/2762;>#2762) Release v0.24.0 0.24.0 - 2021-09-21 Update dependency on the go.opentelemetry.io/otel project to v1.0.0. v0.23.0 0.23.0 - 2021-09-09 Added Add WithoutSubSpans, WithRedactedHeaders, WithoutHeaders, and WithInsecureHeaders options for otelhttptrace.NewClientTrace. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/879;>#879) Changed Split go.opentelemetry.io/contrib/propagators module into b3, jaeger, ot modules. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/985;>#985) otelmongodb span attributes, name and span status now conform to specification. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/769;>#769) Migrated EC2 resource detector support from root module go.opentelemetry.io/contrib/detectors/aws to a separate EC2 resource detector module go.opentelemetry.io/contrib/detectors/aws/ec2 (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/1017;>#1017) Add cloud.provider and cloud.platform to AWS detectors. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/1043;>#1043) otelhttptrace.NewClientTrace now redacts known sensitive headers by default. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/879;>#879) Fixed Fix span not marked as error in otelhttp.Transport when RoundTrip fails with an error. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/950;>#950) Release v0.22.0 Added Add the zpages span processor. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/894;>#894) ... (truncated) Changelog Sourced from https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md;>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's changelog. [1.21.0/0.46.0/0.15.0/0.1.0] - 2023-11-10 Added Add go.opentelemetry.io/contrib/samplers/jaegerremote.WithSamplingStrategyFetcher which sets custom fetcher implementation. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045;>#4045) Add go.opentelemetry.io/contrib/config package that includes configuration models generated via go-jsonschema. (https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4376;
Re: [I] LB IP cannot be created when Kubernetes is in VPC [cloudstack-kubernetes-provider]
FilipBB commented on issue #53: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/53#issuecomment-1802525577 I ran into this as well, thank you for the workaround @mierea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/emicklei/go-restful from 2.9.5+incompatible to 2.16.0+incompatible [cloudstack-kubernetes-provider]
dependabot[bot] commented on PR #45: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/45#issuecomment-1792298792 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/emicklei/go-restful from 2.9.5+incompatible to 2.16.0+incompatible [cloudstack-kubernetes-provider]
rohityadavcloud closed pull request #45: Bump github.com/emicklei/go-restful from 2.9.5+incompatible to 2.16.0+incompatible URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump google.golang.org/grpc from 1.49.0 to 1.53.0 [cloudstack-kubernetes-provider]
dependabot[bot] commented on PR #50: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/50#issuecomment-1792298695 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump google.golang.org/grpc from 1.49.0 to 1.53.0 [cloudstack-kubernetes-provider]
rohityadavcloud closed pull request #50: Bump google.golang.org/grpc from 1.49.0 to 1.53.0 URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on issue #52: Unable to auto-scale Kubernetes cluster
rohityadavcloud commented on issue #52: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/52#issuecomment-1668091677 cc @Pearl1594 @weizhouapache @DaanHoogland pl help triage when you've time @saffronjam this looks like an issue with k8s autoscaler (https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/cloudstack/README.md) or with CKS (upstream https://github.com/apache/cloudstack) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] saffronjam opened a new issue, #52: Unable to auto-scale Kubernetes cluster
saffronjam opened a new issue, #52: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/52 Hi! I am unable to auto-scale Kubernetes clusters. As I understand, it create a "cluster-autoscaler" deployment that decides whether to scale or not. However, it does not seem to work, since it logs multiple errors and warnings in the pod, even though it is a completely clean cluster. Normal scaling seems to work just fine. # Setup A "default" CloudStack setup running KVMs. ## Settings (relevant) - Cloud kubernetes service enabled **true** - Cloud kubernetes cluster experimental features enabled **true** - Cloud kubernetes cluster max size **50** The nodes uses the following service offering: - 2 CPU x 2.05 Ghz - 2048 MB memory - 8 GB root disk # Replicate 1. Create a new cluster using Kubernets 1.24 ISO found here: http://download.cloudstack.org/cks/ 2. Enable forced auto-scaling Since the cluster starts with only one worker node, auto-scaling with 3-5 nodes should trigger an upscale (I assume) ![Screenshot from 2023-08-07 16-55-00](https://github.com/apache/cloudstack-kubernetes-provider/assets/26722370/9b92cc88-b107-42cb-8268-4ae3af25c1f6) 4. Check the logs for cluster-autoscaler in the Kubernetes cluster Some notable entries: ``` E0807 14:41:30.317148 1 reflector.go:138] k8s.io/client-go/informers/factory.go:134: Failed to watch *v1.CSIDriver: failed to list *v1.CSIDriver: csidrivers.storage.k8s.io is forbidden: User "system:serviceaccount:kube-system:cluster-autoscaler" cannot list resource "csidrivers" in API group "storage.k8s.io" at the cluster scope E0807 14:41:32.388828 1 reflector.go:138] k8s.io/client-go/informers/factory.go:134: Failed to watch *v1beta1.CSIStorageCapacity: failed to list *v1beta1.CSIStorageCapacity: csistoragecapacities.storage.k8s.io is forbidden: User "system:serviceaccount:kube-system:cluster-autoscaler" cannot list resource "csistoragecapacities" in API group "storage.k8s.io" at the cluster scope ``` Even though I have not edited anything myself, it is a clean CKS cluster ``` W0807 14:41:43.251280 1 clusterstate.go:590] Failed to get nodegroup for 6a4c91a3-9694-4596-9ddd-dc86e60136ff: Unable to find node 6a4c91a3-9694-4596-9ddd-dc86e60136ff in cluster W0807 14:41:43.251361 1 clusterstate.go:590] Failed to get nodegroup for bd0b855f-6dc6-4678-9bea-b52329333024: Unable to find node bd0b855f-6dc6-4678-9bea-b52329333024 in cluster I0807 14:57:06.667061 1 static_autoscaler.go:341] 2 unregistered nodes present ``` The entire log: [logs-from-cluster-autoscaler-in-cluster-autoscaler-5bf887ddd8-hxg2g.log](https://github.com/apache/cloudstack-kubernetes-provider/files/12281530/logs-from-cluster-autoscaler-in-cluster-autoscaler-5bf887ddd8-hxg2g.log) Please tell me if you need more logs to look at, or if I should try some other configuration. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] kiranchavala opened a new issue, #51: Support static public ip address as a Load balancer IP
kiranchavala opened a new issue, #51: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/51 ISSUE TYPE * Enhancement request COMPONENT NAME Component: Kubernetes/Networking CLOUDSTACK VERSION Cloudstack 4.18 SUMMARY Support static public ip address as a Load balancer IP STEPS TO REPRODUCE 1. Deploy Kubernetes cluster on Cloudstack 2. Create a deployment for example a nginx deployment ``` apiVersion: apps/v1 kind: Deployment metadata: name: nginx-deployment spec: selector: matchLabels: app: nginx replicas: 2 # tells deployment to run 2 pods matching the template template: metadata: labels: app: nginx spec: containers: - name: nginx image: nginx:1.14.2 ports: - containerPort: 80 ``` 3. Expose the deployment as a loadbalancer service `kubectl expose deploy/nginx-deployment --port=80 --type=LoadBalancer` 4. Cloudstack then randomly allocated a public ip as external ip ``` ❯ kubectl get svc nginx-deployment NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE nginx-deployment LoadBalancer 10.109.88.98 10.0.54.8380:32739/TCP 4m24s ``` 5. Suppose a user wants a specific public ip as a loadbalancer ip Currently it's not possible even if we manually edit the service.yaml, cloudstack again allocates a random public ip ``` apiVersion: v1 kind: Service metadata: creationTimestamp: "2023-07-25T04:31:03Z" finalizers: - service.kubernetes.io/load-balancer-cleanup name: nginx-deployment namespace: default resourceVersion: "995303" uid: 224691be-fa86-4b07-938c-c86d948b99fb spec: allocateLoadBalancerNodePorts: true clusterIP: 10.109.88.98 clusterIPs: - 10.109.88.98 externalTrafficPolicy: Cluster internalTrafficPolicy: Cluster ipFamilies: - IPv4 ipFamilyPolicy: SingleStack ports: - nodePort: 32739 port: 80 protocol: TCP targetPort: 80 selector: app: nginx sessionAffinity: None type: LoadBalancer status: apiVersion: v1 loadBalancer: apiVersion: v1 ingress: - ip: 10.0.54.83 ``` EXPECTED RESULTS Cloudstack should allocate the specified public ip address ACTUAL RESULTS Clodudstack is allocating a radom public ip address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] dependabot[bot] opened a new pull request, #50: Bump google.golang.org/grpc from 1.49.0 to 1.53.0
dependabot[bot] opened a new pull request, #50: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/50 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.49.0 to 1.53.0. Release notes Sourced from https://github.com/grpc/grpc-go/releases;>google.golang.org/grpc's releases. Release 1.53.0 API Changes balancer: support injection of per-call metadata from LB policies (https://redirect.github.com/grpc/grpc-go/issues/5853;>#5853) resolver: remove deprecated field resolver.Target.Endpoint and replace with resolver.Target.Endpoint() (https://redirect.github.com/grpc/grpc-go/issues/5852;>#5852) Special Thanks: https://github.com/kylejb;>@kylejb New Features xds/ringhash: introduce GRPC_RING_HASH_CAP environment variable to override the maximum ring size. (https://redirect.github.com/grpc/grpc-go/issues/5884;>#5884) rls: propagate headers received in RLS response to backends (https://redirect.github.com/grpc/grpc-go/issues/5883;>#5883) Bug Fixes transport: drain client transport when streamID approaches MaxStreamID (https://redirect.github.com/grpc/grpc-go/issues/5889;>#5889) server: after GracefulStop, ensure connections are closed when final RPC completes (https://redirect.github.com/grpc/grpc-go/issues/5968;>#5968) server: fix a few issues where grpc server uses RST_STREAM for non-HTTP/2 errors (https://redirect.github.com/grpc/grpc-go/issues/5893;>#5893) xdsclient: fix race which can happen when multiple load reporting calls are made at the same time. (https://redirect.github.com/grpc/grpc-go/issues/5927;>#5927) rls: fix a data race involving the LRU cache (https://redirect.github.com/grpc/grpc-go/issues/5925;>#5925) xds: fix panic involving double close of channel in xDS transport (https://redirect.github.com/grpc/grpc-go/issues/5959;>#5959) gcp/observability: update method name validation (https://redirect.github.com/grpc/grpc-go/issues/5951;>#5951) Documentation credentials/oauth: mark NewOauthAccess as deprecated (https://redirect.github.com/grpc/grpc-go/issues/5882;>#5882) Special Thanks: https://github.com/buzzsurfr;>@buzzsurfr Release 1.52.3 Bug Fixes Fix user-agent version Release 1.52.2 Bug Fixes xds: fix panic involving double close of channel in xDS transport (https://redirect.github.com/grpc/grpc-go/issues/5959;>#5959) Release 1.52.1 Bug Fixes grpclb: rename grpclbstate package back to state (https://redirect.github.com/grpc/grpc-go/issues/5963;>#5963) Release 1.52.0 New Features xdsclient: log node ID with verbosity INFO (https://redirect.github.com/grpc/grpc-go/issues/5860;>#5860) ringhash: impose cap on max_ring_size to reduce possibility of OOMs (https://redirect.github.com/grpc/grpc-go/issues/5801;>#5801) Behavior Changes ... (truncated) Commits https://github.com/grpc/grpc-go/commit/dba26e15a07f43875ccf806a2dd6cbcbc1c12eab;>dba26e1 Change version to 1.53.0 (https://redirect.github.com/grpc/grpc-go/issues/5983;>#5983) https://github.com/grpc/grpc-go/commit/2a1e9348ff7b5d9f4b5039e84e6c9873b5b3e26e;>2a1e934 server: after GracefulStop, ensure connections are closed when final RPC comp... https://github.com/grpc/grpc-go/commit/e2d69aa076dd070e3668784c4dc8bcf7131b3f67;>e2d69aa tests: fix spelling of variable (https://redirect.github.com/grpc/grpc-go/issues/5966;>#5966) https://github.com/grpc/grpc-go/commit/a6376c9893f56fc3819bee9ef5d71f55cc2d38dd;>a6376c9 xds/resolver: cleanup tests to use real xDS client 3/n (https://redirect.github.com/grpc/grpc-go/issues/5953;>#5953) https://github.com/grpc/grpc-go/commit/bf8fc46fa6eb913e4ed0f6dee6c6a7b75e85fbf0;>bf8fc46 xds/resolver: cleanup tests to use real xDS client 5/n (https://redirect.github.com/grpc/grpc-go/issues/5955;>#5955) https://github.com/grpc/grpc-go/commit/3930549b38c0fc4cd94a95efccf7cef5f90515fd;>3930549 resolver: replace resolver.Target.Endpoint field with Endpoint() method (https://redirect.github.com/grpc/grpc-go/issues/5852;>#5852) https://github.com/grpc/grpc-go/commit/894816c487f8dd48fc971c45a7c5baa4b86ef7de;>894816c grpclb: rename grpclbstate package back to state (https://redirect.github.com/grpc/grpc-go/issues/5962;>#5962) https://github.com/grpc/grpc-go/commit/e5a0237a46a5f95fa571624929be10c7afebb180;>e5a0237 encoding: fix duplicate compressor names (https://redirect.github.com/grpc/grpc-go/issues/5958;>#5958) https://github.com/grpc/grpc-go/commit/4adb2a7a00d8b62df5ea34d520fe3ca13bffd31a;>4adb2a7 xds/resolver: cleanup tests to use real xDS client 2/n (https://redirect.github.com/grpc/grpc-go/issues/5952;>#5952) https://github.com/grpc/grpc-go/commit/52a8392f374b8cd60e176b67925a7f8c1605d014;>52a8392
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #49: Fix spelling
rohityadavcloud merged PR #49: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] weizhouapache closed pull request #32: Update Kubernetes version to 1.20.6
weizhouapache closed pull request #32: Update Kubernetes version to 1.20.6 URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #32: Update Kubernetes version to 1.20.6
hrak commented on PR #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-1535795139 This PR can be closed (already merged as part of #44 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #45: Bump github.com/emicklei/go-restful from 2.9.5+incompatible to 2.16.0+incompatible
hrak commented on PR #45: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/45#issuecomment-1535783273 this is a indirect dependency pulled in by kube apiserver 1.24.x. It can be solved by updating the provider to depend on 1.25 instead. This may not be a bad idea since 1.24 is EOL now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak opened a new pull request, #47: Strip domain from node.Name before matching with vm names
hrak opened a new pull request, #47: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/47 Kubernetes node.Name can contain a FQDN instead of just a hostname in some setups. This PR makes sure to strip the domain part before trying to match with VM names from the CS API, since CloudStack does not have the concept of FQDN VM names. It also adds some sanity checking in case verifyHosts is about to return an empty hostIDs array or empty networkID (this is how i ran into this issue) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #46: Fix providerID handling + label sanitizing
hrak commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-1535771035 I realize that these changes should probably be reflected in the README. Will address that shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak opened a new pull request, #46: Fix providerID handling + label sanitizing
hrak opened a new pull request, #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46 This PR changes the way the CloudStack Cloud Controller Manager handles kubelet providerID into a more standardized way that is more common around several other CCM's like the Openstack or vSphere one. The changes were needed to make node labels work again. The providerID is configured by either setting the kubelet command line flag `--provider-id` (deprecated) or using the `providerID` setting in [kubelet config yaml](https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/). The format of the value is `://region/instance-id` so in case of CloudStack for a platform without region f.e. : `cloudstack:///4e7689bc-99ea-43d8-8c37-5ff511c01665`. It also implements the two interface methods `InstanceShutdownByProviderID` and `InstanceShutdown`. And it fixes the way node labels are sanitized. The old regex approach would in some cases strip off allowed characters, for example zone name `Development-Internal` would turn into `DevelopmentInternal`, although the `-` is allowed in label values. The new approach converts all chars that are not allowed in a label value to underscores: `Development-Internal` -> `Development-Internal` `Small Instance (4 GB / 2 CPU)` -> `Small_Instance__4_GB___2_CPU` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] dependabot[bot] opened a new pull request, #45: Bump github.com/emicklei/go-restful from 2.9.5+incompatible to 2.16.0+incompatible
dependabot[bot] opened a new pull request, #45: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/45 Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible. Changelog Sourced from https://github.com/emicklei/go-restful/blob/v3/CHANGES.md;>github.com/emicklei/go-restful's changelog. Change history of go-restful [v3.10.2] - 2023-03-09 introduced MergePathStrategy to be able to revert behaviour of path concatenation to 3.9.0 see comment in Readme how to customize this behaviour. [v3.10.1] - 2022-11-19 fix broken 3.10.0 by using path package for joining paths [v3.10.0] - 2022-10-11 - BROKEN changed tokenizer to match std route match behavior; do not trimright the path (https://redirect.github.com/emicklei/go-restful/issues/511;>#511) Add MIME_ZIP (https://redirect.github.com/emicklei/go-restful/issues/512;>#512) Add MIME_ZIP and HEADER_ContentDisposition (https://redirect.github.com/emicklei/go-restful/issues/513;>#513) Changed how to get query parameter issue https://redirect.github.com/emicklei/go-restful/issues/510;>#510 [v3.9.0] - 2022-07-21 add support for http.Handler implementations to work as FilterFunction, issue https://redirect.github.com/emicklei/go-restful/issues/504;>#504 (thanks to https://github.com/ggicci;>https://github.com/ggicci) [v3.8.0] - 2022-06-06 use exact matching of allowed domain entries, issue https://redirect.github.com/emicklei/go-restful/issues/489;>#489 (https://redirect.github.com/emicklei/go-restful/issues/493;>#493) this changes fixes [security] Authorization Bypass Through User-Controlled Key by changing the behaviour of the AllowedDomains setting in the CORS filter. To support the previous behaviour, the CORS filter type now has a AllowedDomainFunc callback mechanism which is called when a simple domain match fails. add test and fix for POST without body and Content-type, issue https://redirect.github.com/emicklei/go-restful/issues/492;>#492 (https://redirect.github.com/emicklei/go-restful/issues/496;>#496) [Minor] Bad practice to have a mix of Receiver types. (https://redirect.github.com/emicklei/go-restful/issues/491;>#491) [v3.7.2] - 2021-11-24 restored FilterChain (https://redirect.github.com/emicklei/go-restful/issues/482;>#482 by SVilgelm) [v3.7.1] - 2021-10-04 fix problem with contentEncodingEnabled setting (https://redirect.github.com/emicklei/go-restful/issues/479;>#479) [v3.7.0] - 2021-09-24 feat(parameter): adds additional openapi mappings (https://redirect.github.com/emicklei/go-restful/issues/478;>#478) [v3.6.0] - 2021-09-18 add support for vendor extensions (https://redirect.github.com/emicklei/go-restful/issues/477;>#477 thx erraggy) [v3.5.2] - 2021-07-14 ... (truncated) Commits https://github.com/emicklei/go-restful/commit/ac666c045e035603f2704c98c59e979fccbfa94f;>ac666c0 update changes https://github.com/emicklei/go-restful/commit/926662532deb450272956c7bc573978464aae74e;>9266625 use exact matching of allowed domain entries, issue https://redirect.github.com/emicklei/go-restful/issues/489;>#489 (https://redirect.github.com/emicklei/go-restful/issues/493;>#493) (https://redirect.github.com/emicklei/go-restful/issues/503;>#503) https://github.com/emicklei/go-restful/commit/d9c71e118c95f152ff2e0d884d7504aa726d3618;>d9c71e1 support multipart/form-data (https://redirect.github.com/emicklei/go-restful/issues/502;>#502) https://github.com/emicklei/go-restful/commit/1e8c63ce7906ee023956e8068ce4c54d634c2d2b;>1e8c63c add access to Route from Request, issue https://redirect.github.com/emicklei/go-restful/issues/459;>#459 (https://redirect.github.com/emicklei/go-restful/issues/462;>#462) https://github.com/emicklei/go-restful/commit/0d68a53f8da6e2fcdf2ba7ffd90305ee037e5467;>0d68a53 fix typo (https://redirect.github.com/emicklei/go-restful/issues/465;>#465) https://github.com/emicklei/go-restful/commit/a22b51de949f628f359177cff8d8975261b3292f;>a22b51d add check for wildcard (https://redirect.github.com/emicklei/go-restful/issues/463;>#463) https://github.com/emicklei/go-restful/commit/8dd9eb88e2526fab4b4768e46d6b75e72d471fb9;>8dd9eb8 update chg https://github.com/emicklei/go-restful/commit/e5d317549b87950b816947cbba10142378c328e6;>e5d3175 add options shortcut (https://redirect.github.com/emicklei/go-restful/issues/455;>#455) https://github.com/emicklei/go-restful/commit/1f7f1def5cb588c5bd7e8b9e23b1df771a749c7f;>1f7f1de fix link to example https://github.com/emicklei/go-restful/commit/601692bdb9017788c3b10d573c5b4473eba505bc;>601692b examples use v3 Additional commits viewable in https://github.com/emicklei/go-
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
rohityadavcloud merged PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
rohityadavcloud commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1508288264 Thanks @RolphH @hrak I'll merge this based on your tests and feedback. Pl do followup with other changes you think we need for the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1508127314 > We are running this without any issues so far on Cloudstack 4.17. We have some more changes in the pipeline once this is merged. Well, maybe i should clarify: The part that works is the loadbalancer/firewall rules part. Most of the logic surrounding instance metadata is broken ever since this was turned into and external cloud provider. `GetZone` assumes this is running inside kubelet and that hostname=instance hostname, but it isn't, since the provider runs in a pod, causing it to try to look up the instance based on the pod hostname: ``` I0414 07:08:41.827320 1 cloudstack.go:175] GetZone called from /go/src/github.com/apache/cloudstack-kubernetes-provider/cloudstack_instances.go#198 E0414 07:08:41.874064 1 node_controller.go:220] error syncing 'k8s-mgmt-cp-dev-02': failed to get instance metadata for node k8s-mgmt-cp-dev-02: could not find instance for retrieving the zone: No match found for cloud-controller-manager-789b9fb546-dg46l: &{Count:0 VirtualMachines:[]}, requeuing ``` Then there are issues with ProviderID, since the provider is currently called `external-cloudstack` and should probably be called `cloudstack`, so the [logic here](https://github.com/kubernetes/cloud-provider/blob/322c087411fe027de06291c6ad974ed7bcbf2eea/cloud.go#L114) matches the kubelet arguments `--cloud-provider=external --provider-id=cloudstack:///8411c37d-8d63-4920-8cb2-01fa512c3377` in the same way that this works for f.e. the Openstack CCM. I am working on fixes for all these issues but i would really like to get this in first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1506928795 > @davidjumani could you have a quick look and help merge it. > > @RolphH @hrak could you advise what testing you’ve done against any/various versions of CloudStack? We are running this without any issues so far on Cloudstack 4.17. We have some more changes in the pipeline once this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
rohityadavcloud commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1506914074 @davidjumani could you have a quick look and help merge it. @RolphH @hrak could you advise what testing you’ve done against any/various versions of CloudStack? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] RolphH commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
RolphH commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1506845292 @rohityadavcloud can you help getting this one merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.11 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1505004907 Added a switch to klog v2 + updated PR for k8s 1.24.12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.11 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1494067532 Ship it? Or does anything else need to happen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.11 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450369462 Updated PR to use Kubernetes v1.24.11 instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.26.2 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450281799 > If you have the time I would really appreciate if there is a version in between. For instance 1.24. yeah i was afraid of that already, i suddenly realized that compiling this against 1.26 probably means losing compatibility with 1.24 and 1.25 which are still supported. I will get on it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #44: Update to Kubernetes 1.26.2 + Use Go 1.19
joschi36 commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450260367 If you have the time I would really appreciate if there is a version in between. For instance 1.24. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.26.2 + Use Go 1.19
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450156357 Please let me know if 1.26 i a bit too ambitious, i will gladly adapt for 1.24 or 1.25. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak opened a new pull request, #44: Update to Kubernetes 1.26.2 + Use Go 1.18
hrak opened a new pull request, #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44 This PR is a continuation of the work in #32 and contains the following changes: - Use Go 1.18 - Update Kubernetes deps to 1.26.2 - Move the cloudstack-go dep to its new home in the apache org I can provide a test container image if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] memorais commented on issue #37: feat: Cluster API support
memorais commented on issue #37: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/37#issuecomment-100421 As an workaround I revoke the "delete" verb on resource "nodes". CCM give up from delete the node after a while and everything work as expected. This seems some bug when listing nodes and joining new nodes on the cluster. If anyone have interest on solving that, I can provide steps to reproduce the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] memorais commented on issue #37: feat: Cluster API support
memorais commented on issue #37: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/37#issuecomment-1444202937 Hi, I'm trying to setup cloudstack-kubernetes-provider on a cluster created with cloudstack cluster-api provider. After install cloudstack-kubernetes-provider on that cluster, any scale up on machinedeployments results on the following scenario: `I0224 18:19:01.882948 1 event.go:278] Event(v1.ObjectReference{Kind:"Node", Namespace:"", Name:"demo-md-0-cbh9n", UID:"8e3f0ee3-16d4-43ec-a855-1574a8117012", APIVersion:"", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'Deleting node demo-md-0-cbh9n because it does not exist in the cloud provider' Node demo-md-0-cbh9n event: DeletingNode` CCM delete the node that recently joined with that message "it does not exist in the cloud provider". Why it deletes the node, what that message specific means? There is any workaround for this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] DaanHoogland closed pull request #38: deployment.yaml: add tolerations
DaanHoogland closed pull request #38: deployment.yaml: add tolerations URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #41: Allow case insensitive vm names while creating lb rules
davidjumani commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1420574877 My bad @rohityadavcloud I had tested this myself and verified the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #41: Allow case insensitive vm names while creating lb rules
rohityadavcloud merged PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #41: Allow case insensitive vm names while creating lb rules
rohityadavcloud commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1420328483 I meant to say, in terms of testing and review @davidjumani I'll merge this however as changes make sense to me and Build has passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #41: Allow case insensitive vm names while creating lb rules
davidjumani commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1420194318 Just click the merge button :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #41: Allow case insensitive vm names while creating lb rules
rohityadavcloud commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1415068946 LGTM @davidjumani what do we need to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] kiwiflyer commented on pull request #41: Allow case insensitive vm names while creating lb rules
kiwiflyer commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1413932723 > @kiwiflyer cloudstack-kubernetes-provider is a standalone project, which has different release cycle as cloudstack Got it, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] DaanHoogland closed pull request #41: Allow case insensitive vm names while creating lb rules
DaanHoogland closed pull request #41: Allow case insensitive vm names while creating lb rules URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] weizhouapache commented on pull request #41: Allow case insensitive vm names while creating lb rules
weizhouapache commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1413923310 @kiwiflyer cloudstack-kubernetes-provider is a standalone project, which has different release cycle as cloudstack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] kiwiflyer commented on pull request #41: Allow case insensitive vm names while creating lb rules
kiwiflyer commented on PR #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1413919275 @DaanHoogland Is it too late to pull this in for 4.18? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] schlapzz opened a new pull request, #32: Update Kubernetes version to 1.20.6
schlapzz opened a new pull request, #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32 Kubernetes Version to 1.20.6 and Golang Version to 1.15 Docker image for testing: docker.io/swisstxt/cloudstack-kubernetes-provider:v1.20.6-ae73327f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud closed pull request #32: Update Kubernetes version to 1.20.6
rohityadavcloud closed pull request #32: Update Kubernetes version to 1.20.6 URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud closed pull request #38: deployment.yaml: add tolerations
rohityadavcloud closed pull request #38: deployment.yaml: add tolerations URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud closed pull request #41: Allow case insensitive vm names while creating lb rules
rohityadavcloud closed pull request #41: Allow case insensitive vm names while creating lb rules URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #43: GitHub actions 1
rohityadavcloud merged PR #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rahulbcn27 commented on a diff in pull request #43: GitHub actions 1
rahulbcn27 commented on code in PR #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43#discussion_r1086486015 ## .github/workflows/github-actions.yml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Github-Actions + +on: [push, pull_request] + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + build: +runs-on: ubuntu-22.04 + +steps: +- uses: actions/checkout@v3 + +- name: Set up Go + uses: actions/setup-go@v3 + with: +go-version: 1.19.x Review Comment: Go version changed to 1.13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rahulbcn27 commented on a diff in pull request #43: GitHub actions 1
rahulbcn27 commented on code in PR #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43#discussion_r1086485586 ## .github/workflows/github-actions.yml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Github-Actions + +on: [push, pull_request] + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + build: +runs-on: ubuntu-22.04 + +steps: +- uses: actions/checkout@v3 + +- name: Set up Go + uses: actions/setup-go@v3 + with: +go-version: 1.19.x +- name: Run Script + run: make all Review Comment: version and script type changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rahulbcn27 commented on a diff in pull request #43: GitHub actions 1
rahulbcn27 commented on code in PR #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43#discussion_r1086485102 ## .github/workflows/github-actions.yml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Github-Actions Review Comment: Name changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on a diff in pull request #43: GitHub actions 1
rohityadavcloud commented on code in PR #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43#discussion_r1086329316 ## .github/workflows/github-actions.yml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Github-Actions Review Comment: Give an appropriate name to the build job and file name. Build may be appropriate if this only does basic build test. ## .github/workflows/github-actions.yml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Github-Actions + +on: [push, pull_request] + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + build: +runs-on: ubuntu-22.04 + +steps: +- uses: actions/checkout@v3 + +- name: Set up Go + uses: actions/setup-go@v3 + with: +go-version: 1.19.x Review Comment: You may want to check implications of bumping go version. In such cases you can also build locally to check. ## .github/workflows/github-actions.yml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Github-Actions + +on: [push, pull_request] + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + build: +runs-on: ubuntu-22.04 + +steps: +- uses: actions/checkout@v3 + +- name: Set up Go + uses: actions/setup-go@v3 + with: +go-version: 1.19.x +- name: Run Script + run: make all Review Comment: See Travis yml what it was doing. Don’t simply copy paste from cloud monkey. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rahulbcn27 commented on pull request #43: GitHub actions 1
rahulbcn27 commented on PR #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43#issuecomment-1403208280 @rohityadavcloud Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rahulbcn27 opened a new pull request, #43: GitHub actions 1
rahulbcn27 opened a new pull request, #43: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/43 PR to migrate from Travis CI to Github Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] cfredericksen opened a new issue, #42: Feature request: Support Windows nodes
cfredericksen opened a new issue, #42: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/42 Windows nodes support is lacking for EKS Anywhere and Cluster API, ie, other kubernetes cluster mgmt platforms. Adding Windows nodes support would be great and unique. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request, #41: Allow case insensitive vm names while creating lb rules
davidjumani opened a new pull request, #41: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41 In kubernetes, node names are in lower case but a VM can have an upper case name in cloudstack This can cause issues mapping kuberenetes nodes to cloudstack VMs Fixes this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] tenvecera closed issue #40: Affinity group for nodes
tenvecera closed issue #40: Affinity group for nodes URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org