Re: Resizing a volume

2016-04-27 Thread Tutkowski, Mike 
I opened the following ticket:

https://issues.apache.org/jira/browse/CLOUDSTACK-9371

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 7:12 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

It appears the offending code was added here: 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=d6e21f74163212b198731ddf23dd48bc4c787b84

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 5:33 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

I see the problem.

It's in storage.js

if (jsonObj.hypervisor == "KVM" || jsonObj.hypervisor == "XenServer" || 
jsonObj.hypervisor == "VMware") {
if (jsonObj.state == "Ready" || jsonObj.state == "Allocated") {
allowedActions.push("resize");
}
}

jsonObj.hypervisor is equal to undefined (it has the correct hypervisor type 
when I'm logged in as an admin).

We appear to have other code in the vicinity that depends on jsonObj.hypervisor 
and is probably misbehaving.

Maybe a GUI developer can fill us in as to what's expected here?

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 5:13 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Here's a pic:

http://imgur.com/2k380Yd

It's for a volume on KVM, but I see the same behavior on XenServer and VMware, 
too.

I'm logged in as a regular user.

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 4:23 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Hi Wido,

I'm referring to the commands.properties file, where you can set permissions 
for a given API.

However, I see volumeResize has the following setting, which should enable 
users to access it:

resizeVolume=15

Perhaps there's just a bug in the GUI not showing the button?

Talk to you later,
Mike

From: Wido den Hollander <w...@widodh.nl>
Sent: Wednesday, April 27, 2016 1:33 AM
To: Tutkowski, Mike; dev@cloudstack.apache.org
Subject: Re: Resizing a volume

> Op 26 april 2016 om 22:37 schreef "Tutkowski, Mike" 
> <mike.tutkow...@netapp.com>:
>
>
> ??Hi,
>
>
> I noticed that by default non-admins cannot resize a volume to a different 
> disk offering.
>
>
> Anyone know why that's the default behavior? I would think that would be an 
> expected operation for end users.
>

You mean that it's a setting? I'd say it is preferred that they can do so 
indeed by default.

Wido

>
> Thanks,
>
> Mike

Re: Resizing a volume

2016-04-27 Thread Tutkowski, Mike 
It appears the offending code was added here: 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=d6e21f74163212b198731ddf23dd48bc4c787b84

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 5:33 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

I see the problem.

It's in storage.js

if (jsonObj.hypervisor == "KVM" || jsonObj.hypervisor == "XenServer" || 
jsonObj.hypervisor == "VMware") {
if (jsonObj.state == "Ready" || jsonObj.state == "Allocated") {
allowedActions.push("resize");
}
}

jsonObj.hypervisor is equal to undefined (it has the correct hypervisor type 
when I'm logged in as an admin).

We appear to have other code in the vicinity that depends on jsonObj.hypervisor 
and is probably misbehaving.

Maybe a GUI developer can fill us in as to what's expected here?

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 5:13 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Here's a pic:

http://imgur.com/2k380Yd

It's for a volume on KVM, but I see the same behavior on XenServer and VMware, 
too.

I'm logged in as a regular user.

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 4:23 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Hi Wido,

I'm referring to the commands.properties file, where you can set permissions 
for a given API.

However, I see volumeResize has the following setting, which should enable 
users to access it:

resizeVolume=15

Perhaps there's just a bug in the GUI not showing the button?

Talk to you later,
Mike

From: Wido den Hollander <w...@widodh.nl>
Sent: Wednesday, April 27, 2016 1:33 AM
To: Tutkowski, Mike; dev@cloudstack.apache.org
Subject: Re: Resizing a volume

> Op 26 april 2016 om 22:37 schreef "Tutkowski, Mike" 
> <mike.tutkow...@netapp.com>:
>
>
> ??Hi,
>
>
> I noticed that by default non-admins cannot resize a volume to a different 
> disk offering.
>
>
> Anyone know why that's the default behavior? I would think that would be an 
> expected operation for end users.
>

You mean that it's a setting? I'd say it is preferred that they can do so 
indeed by default.

Wido

>
> Thanks,
>
> Mike

Re: Resizing a volume

2016-04-27 Thread Tutkowski, Mike 
I see the problem.

It's in storage.js

if (jsonObj.hypervisor == "KVM" || jsonObj.hypervisor == "XenServer" || 
jsonObj.hypervisor == "VMware") {
if (jsonObj.state == "Ready" || jsonObj.state == "Allocated") {
allowedActions.push("resize");
}
}

jsonObj.hypervisor is equal to undefined (it has the correct hypervisor type 
when I'm logged in as an admin).

We appear to have other code in the vicinity that depends on jsonObj.hypervisor 
and is probably misbehaving.

Maybe a GUI developer can fill us in as to what's expected here?

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 5:13 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Here's a pic:

http://imgur.com/2k380Yd

It's for a volume on KVM, but I see the same behavior on XenServer and VMware, 
too.

I'm logged in as a regular user.

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 4:23 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Hi Wido,

I'm referring to the commands.properties file, where you can set permissions 
for a given API.

However, I see volumeResize has the following setting, which should enable 
users to access it:

resizeVolume=15

Perhaps there's just a bug in the GUI not showing the button?

Talk to you later,
Mike

From: Wido den Hollander <w...@widodh.nl>
Sent: Wednesday, April 27, 2016 1:33 AM
To: Tutkowski, Mike; dev@cloudstack.apache.org
Subject: Re: Resizing a volume

> Op 26 april 2016 om 22:37 schreef "Tutkowski, Mike" 
> <mike.tutkow...@netapp.com>:
>
>
> ??Hi,
>
>
> I noticed that by default non-admins cannot resize a volume to a different 
> disk offering.
>
>
> Anyone know why that's the default behavior? I would think that would be an 
> expected operation for end users.
>

You mean that it's a setting? I'd say it is preferred that they can do so 
indeed by default.

Wido

>
> Thanks,
>
> Mike

Re: Resizing a volume

2016-04-27 Thread Tutkowski, Mike 
Here's a pic:

http://imgur.com/2k380Yd

It's for a volume on KVM, but I see the same behavior on XenServer and VMware, 
too.

I'm logged in as a regular user.

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Wednesday, April 27, 2016 4:23 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume

Hi Wido,

I'm referring to the commands.properties file, where you can set permissions 
for a given API.

However, I see volumeResize has the following setting, which should enable 
users to access it:

resizeVolume=15

Perhaps there's just a bug in the GUI not showing the button?

Talk to you later,
Mike

From: Wido den Hollander <w...@widodh.nl>
Sent: Wednesday, April 27, 2016 1:33 AM
To: Tutkowski, Mike; dev@cloudstack.apache.org
Subject: Re: Resizing a volume

> Op 26 april 2016 om 22:37 schreef "Tutkowski, Mike" 
> <mike.tutkow...@netapp.com>:
>
>
> ??Hi,
>
>
> I noticed that by default non-admins cannot resize a volume to a different 
> disk offering.
>
>
> Anyone know why that's the default behavior? I would think that would be an 
> expected operation for end users.
>

You mean that it's a setting? I'd say it is preferred that they can do so 
indeed by default.

Wido

>
> Thanks,
>
> Mike

Re: Resizing a volume

2016-04-27 Thread Tutkowski, Mike 
Hi Wido,

I'm referring to the commands.properties file, where you can set permissions 
for a given API.

However, I see volumeResize has the following setting, which should enable 
users to access it:

resizeVolume=15

Perhaps there's just a bug in the GUI not showing the button?

Talk to you later,
Mike

From: Wido den Hollander <w...@widodh.nl>
Sent: Wednesday, April 27, 2016 1:33 AM
To: Tutkowski, Mike; dev@cloudstack.apache.org
Subject: Re: Resizing a volume

> Op 26 april 2016 om 22:37 schreef "Tutkowski, Mike" 
> <mike.tutkow...@netapp.com>:
>
>
> ??Hi,
>
>
> I noticed that by default non-admins cannot resize a volume to a different 
> disk offering.
>
>
> Anyone know why that's the default behavior? I would think that would be an 
> expected operation for end users.
>

You mean that it's a setting? I'd say it is preferred that they can do so 
indeed by default.

Wido

>
> Thanks,
>
> Mike

Re: Resizing a volume

2016-04-27 Thread Wido den Hollander 

> Op 26 april 2016 om 22:37 schreef "Tutkowski, Mike" 
> :
> 
> 
> ??Hi,
> 
> 
> I noticed that by default non-admins cannot resize a volume to a different 
> disk offering.
> 
> 
> Anyone know why that's the default behavior? I would think that would be an 
> expected operation for end users.
> 

You mean that it's a setting? I'd say it is preferred that they can do so 
indeed by default.

Wido

> 
> Thanks,
> 
> Mike

Resizing a volume

2016-04-26 Thread Tutkowski, Mike 
??Hi,


I noticed that by default non-admins cannot resize a volume to a different disk 
offering.


Anyone know why that's the default behavior? I would think that would be an 
expected operation for end users.


Thanks,

Mike