Review Request 13266: CLOUDSTACK-3925: Allow Root Admin to deploy VMs on Zone dedicated to any domain/account

2013-08-05 Thread Saksham Srivastava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13266/
---

Review request for cloudstack, Devdeep Singh and Prachi Damle.


Bugs: 3925


Repository: cloudstack-git


Description
---

Currently Root admin cannot deploy vms on a zone dedicated to sub-domain, the 
fix will ensure the private zone functionality is maintained.
The fix allows root admin to deploy vms on zone dedicated to any other domain 
by both the methods:
1)Using affinity group Explicit Dedication
2)Not using any affinity group.


Diffs
-

  
plugins/affinity-group-processors/explicit-dedication/src/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java
 a0eb56c 
  server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c 
  server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java 10e23d7 

Diff: https://reviews.apache.org/r/13266/diff/


Testing
---

Root admin is now able to deploy vms on a zone dedicated to a sub domain.
Build is successful.


Thanks,

Saksham Srivastava



Re: Review Request 13266: CLOUDSTACK-3925: Allow Root Admin to deploy VMs on Zone dedicated to any domain/account

2013-08-05 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13266/#review24641
---


Review 13266 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #112 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/112/

- Jenkins Cloudstack.org


On Aug. 5, 2013, 10:57 a.m., Saksham Srivastava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13266/
 ---
 
 (Updated Aug. 5, 2013, 10:57 a.m.)
 
 
 Review request for cloudstack, Devdeep Singh and Prachi Damle.
 
 
 Bugs: 3925
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently Root admin cannot deploy vms on a zone dedicated to sub-domain, the 
 fix will ensure the private zone functionality is maintained.
 The fix allows root admin to deploy vms on zone dedicated to any other domain 
 by both the methods:
 1)Using affinity group Explicit Dedication
 2)Not using any affinity group.
 
 
 Diffs
 -
 
   
 plugins/affinity-group-processors/explicit-dedication/src/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java
  a0eb56c 
   server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c 
   server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java 10e23d7 
 
 Diff: https://reviews.apache.org/r/13266/diff/
 
 
 Testing
 ---
 
 Root admin is now able to deploy vms on a zone dedicated to a sub domain.
 Build is successful.
 
 
 Thanks,
 
 Saksham Srivastava