Re: Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/#review29484
---

Ship it!


d19688103ba7f7c53c264fb67cb534dd693c95cd (remarks are about the old code not 
this patch)


awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java


code in comment (not as comment). this should be removed



awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java


code in comment (not as comment). this should be removed



awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java


code in comment (not as comment). this should be removed


- daan Hoogland


On Nov. 26, 2013, 1:06 p.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15647/
> ---
> 
> (Updated Nov. 26, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing coverity issues related to resource leak on FileInputStream being 
> created anonymously.
> 
> This patch fixed the following Coverity issues:
> 
> cv_1116497
> cv_1116681
> cv_1116694
> cv_1116567
> cv_1116495
> 
> 
> Diffs
> -
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 
> deb886f 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 
>   framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 
> 0d28e09 
> 
> Diff: https://reviews.apache.org/r/15647/diff/
> 
> 
> Testing
> ---
> 
> A build full build was executed on top of the branch created for these 
> changes. After committed and patched, the a brand new branch was created from 
> Master and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.

[Wilder Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/
---

(Updated Nov. 26, 2013, 1:06 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Making use of the ec2PropFile variable, it got lost after the merge with Alex 
Huang changes.


Repository: cloudstack-git


Description
---

Fixing coverity issues related to resource leak on FileInputStream being 
created anonymously.

This patch fixed the following Coverity issues:

cv_1116497
cv_1116681
cv_1116694
cv_1116567
cv_1116495


Diffs (updated)
-

  awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 
deb886f 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 
  framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f 
  services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 
0d28e09 

Diff: https://reviews.apache.org/r/15647/diff/


Testing
---

A build full build was executed on top of the branch created for these changes. 
After committed and patched, the a brand new branch was created from Master and 
patched with this patch. Everything worked fine.

No new feature was added.


Thanks,

Wilder Rodrigues

Re: Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/#review29424
---



awsapi/src/com/cloud/bridge/service/EC2RestServlet.java


you don't seem to be using ec2PropFile for anything here?


- Hugo Trippaers


On Nov. 25, 2013, 3:15 p.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15647/
> ---
> 
> (Updated Nov. 25, 2013, 3:15 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing coverity issues related to resource leak on FileInputStream being 
> created anonymously.
> 
> This patch fixed the following Coverity issues:
> 
> cv_1116497
> cv_1116681
> cv_1116694
> cv_1116567
> cv_1116495
> 
> 
> Diffs
> -
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 
> deb886f 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 
>   framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 
> 0d28e09 
> 
> Diff: https://reviews.apache.org/r/15647/diff/
> 
> 
> Testing
> ---
> 
> A build full build was executed on top of the branch created for these 
> changes. After committed and patched, the a brand new branch was created from 
> Master and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.

[Wilder Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/
---

(Updated Nov. 25, 2013, 3:15 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

rebasing my changes with Alex Huang changes (which removed whitespaces trailing)


Repository: cloudstack-git


Description
---

Fixing coverity issues related to resource leak on FileInputStream being 
created anonymously.

This patch fixed the following Coverity issues:

cv_1116497
cv_1116681
cv_1116694
cv_1116567
cv_1116495


Diffs (updated)
-

  awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 
deb886f 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 
  framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f 
  services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 
0d28e09 

Diff: https://reviews.apache.org/r/15647/diff/


Testing
---

A build full build was executed on top of the branch created for these changes. 
After committed and patched, the a brand new branch was created from Master and 
patched with this patch. Everything worked fine.

No new feature was added.


Thanks,

Wilder Rodrigues

Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.

[Wilder Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/
---

Review request for cloudstack and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Fixing coverity issues related to resource leak on FileInputStream being 
created anonymously.

This patch fixed the following Coverity issues:

cv_1116497
cv_1116681
cv_1116694
cv_1116567
cv_1116495


Diffs
-

  awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 1ef04a4 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 
0854741 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cb13977 
  framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95 
  services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 
2abce56 

Diff: https://reviews.apache.org/r/15647/diff/


Testing
---

A build full build was executed on top of the branch created for these changes. 
After committed and patched, the a brand new branch was created from Master and 
patched with this patch. Everything worked fine.

No new feature was added.


Thanks,

Wilder Rodrigues