Re: Review Request 18412: Gluster should store disk images in qcow2 format

2014-11-28 Thread Sebastien Goasguen


 On Feb. 25, 2014, 10:21 a.m., Wido den Hollander wrote:
  Ship It!

This is present in 4.4, 4.5 and master


- Sebastien


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18412/#review35381
---


On Feb. 23, 2014, 7:20 p.m., Niels de Vos wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18412/
 ---
 
 (Updated Feb. 23, 2014, 7:20 p.m.)
 
 
 Review request for cloudstack and Wido den Hollander.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 By default all network disks are in RAW format. Gluster works fine with
 QCOW2 which has some advantages.
 
 Disks are by default in QCOW2 format. It is possible to run into
 a mismatch, where the disk is in QCOW2 format, but QEMU gets started
 with format=raw. This causes the virtual machines to lockup on boot.
 
 Failures to start a virtual machine can be verified by checking the log
 of the virtual machine, and compare the output of 'qemu-img info'.
 
 In /var/log/libvirt/qemu/VM.log find the URL for the drive:
 
 -drive file=gluster+tcp://...,format=raw,..
 
 Compare this with the 'qemu-img info' output of the same file, mounted
 under /mnt/pool-uuid/img-uuid:
 
 # qemu-img info /mnt/pool-uuid/img-uuid
 ...
 file format: qcow2
 ...
 
 This change makes passes the format when creating a disk located on RBD
 (RAW only) and Gluster (QCOW2).
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  c986855 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
  9cf6a90 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
  290c5a9 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
  1c37607 
 
 Diff: https://reviews.apache.org/r/18412/diff/
 
 
 Testing
 ---
 
 Test results described with this setup: 
 http://blog.nixpanic.net/2014_02_23_archive.html
 
 
 Thanks,
 
 Niels de Vos
 




Re: Review Request 18412: Gluster should store disk images in qcow2 format

2014-02-25 Thread Wido den Hollander

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18412/#review35381
---

Ship it!


Ship It!

- Wido den Hollander


On Feb. 23, 2014, 7:20 p.m., Niels de Vos wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18412/
 ---
 
 (Updated Feb. 23, 2014, 7:20 p.m.)
 
 
 Review request for cloudstack and Wido den Hollander.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 By default all network disks are in RAW format. Gluster works fine with
 QCOW2 which has some advantages.
 
 Disks are by default in QCOW2 format. It is possible to run into
 a mismatch, where the disk is in QCOW2 format, but QEMU gets started
 with format=raw. This causes the virtual machines to lockup on boot.
 
 Failures to start a virtual machine can be verified by checking the log
 of the virtual machine, and compare the output of 'qemu-img info'.
 
 In /var/log/libvirt/qemu/VM.log find the URL for the drive:
 
 -drive file=gluster+tcp://...,format=raw,..
 
 Compare this with the 'qemu-img info' output of the same file, mounted
 under /mnt/pool-uuid/img-uuid:
 
 # qemu-img info /mnt/pool-uuid/img-uuid
 ...
 file format: qcow2
 ...
 
 This change makes passes the format when creating a disk located on RBD
 (RAW only) and Gluster (QCOW2).
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  c986855 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
  9cf6a90 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
  290c5a9 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
  1c37607 
 
 Diff: https://reviews.apache.org/r/18412/diff/
 
 
 Testing
 ---
 
 Test results described with this setup: 
 http://blog.nixpanic.net/2014_02_23_archive.html
 
 
 Thanks,
 
 Niels de Vos
 




Review Request 18412: Gluster should store disk images in qcow2 format

2014-02-23 Thread Niels de Vos

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18412/
---

Review request for cloudstack and Wido den Hollander.


Repository: cloudstack-git


Description
---

By default all network disks are in RAW format. Gluster works fine with
QCOW2 which has some advantages.

Disks are by default in QCOW2 format. It is possible to run into
a mismatch, where the disk is in QCOW2 format, but QEMU gets started
with format=raw. This causes the virtual machines to lockup on boot.

Failures to start a virtual machine can be verified by checking the log
of the virtual machine, and compare the output of 'qemu-img info'.

In /var/log/libvirt/qemu/VM.log find the URL for the drive:

-drive file=gluster+tcp://...,format=raw,..

Compare this with the 'qemu-img info' output of the same file, mounted
under /mnt/pool-uuid/img-uuid:

# qemu-img info /mnt/pool-uuid/img-uuid
...
file format: qcow2
...

This change makes passes the format when creating a disk located on RBD
(RAW only) and Gluster (QCOW2).


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 c986855 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 9cf6a90 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
290c5a9 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 1c37607 

Diff: https://reviews.apache.org/r/18412/diff/


Testing
---


Thanks,

Niels de Vos



Re: Review Request 18412: Gluster should store disk images in qcow2 format

2014-02-23 Thread Niels de Vos

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18412/
---

(Updated Feb. 23, 2014, 8:20 p.m.)


Review request for cloudstack and Wido den Hollander.


Repository: cloudstack-git


Description
---

By default all network disks are in RAW format. Gluster works fine with
QCOW2 which has some advantages.

Disks are by default in QCOW2 format. It is possible to run into
a mismatch, where the disk is in QCOW2 format, but QEMU gets started
with format=raw. This causes the virtual machines to lockup on boot.

Failures to start a virtual machine can be verified by checking the log
of the virtual machine, and compare the output of 'qemu-img info'.

In /var/log/libvirt/qemu/VM.log find the URL for the drive:

-drive file=gluster+tcp://...,format=raw,..

Compare this with the 'qemu-img info' output of the same file, mounted
under /mnt/pool-uuid/img-uuid:

# qemu-img info /mnt/pool-uuid/img-uuid
...
file format: qcow2
...

This change makes passes the format when creating a disk located on RBD
(RAW only) and Gluster (QCOW2).


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 c986855 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 9cf6a90 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
290c5a9 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 1c37607 

Diff: https://reviews.apache.org/r/18412/diff/


Testing (updated)
---

Test results described with this setup: 
http://blog.nixpanic.net/2014_02_23_archive.html


Thanks,

Niels de Vos