Review Request 28700: Attach volume events are not correctly shown in events.

2014-12-04 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28700/
---

Review request for cloudstack and Koushik Das.


Repository: cloudstack-git


Description
---

When we call AttachVolume API, Cloudstack is not recording all events into 
event table.

It should generate Scheduled, Started and Completed evetns. But it was 
generating only Schduled one.


Diffs
-

  server/src/com/cloud/storage/VolumeApiServiceImpl.java 785a95e 

Diff: https://reviews.apache.org/r/28700/diff/


Testing
---

Tested by attaching volume to a VM


Thanks,

Damodar Reddy Talakanti



Re: Review Request 28700: Attach volume events are not correctly shown in events.

2014-12-04 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28700/#review63844
---

Ship it!


master - 7b8fe0c8cd9716f85108856bedfe24d0235506b5
4.5 - 7ef0f5507d3b0debe4cfc7fb3bcada39c069e33f

- Koushik Das


On Dec. 4, 2014, 10:02 a.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28700/
 ---
 
 (Updated Dec. 4, 2014, 10:02 a.m.)
 
 
 Review request for cloudstack and Koushik Das.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 When we call AttachVolume API, Cloudstack is not recording all events into 
 event table.
 
 It should generate Scheduled, Started and Completed evetns. But it was 
 generating only Schduled one.
 
 
 Diffs
 -
 
   server/src/com/cloud/storage/VolumeApiServiceImpl.java 785a95e 
 
 Diff: https://reviews.apache.org/r/28700/diff/
 
 
 Testing
 ---
 
 Tested by attaching volume to a VM
 
 
 Thanks,
 
 Damodar Reddy Talakanti