[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rashmidixit
Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
@rhtyd On the contrary, I think you adding metrics as pluggable API is a 
good idea. However, to seriously make the feature pluggable the UI component 
should also load based on a plugin based flag.

For example (I am not sure if the current design makes this possible), the 
plugin should return a flag in the listCapabilities API which tells the UI that 
metrics is enabled. If this flag is present, the metrics button should appear, 
else not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry
Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@rhtyd Sure, no problem.  How would you like to handle the back porting?  
Do you want me to open PRs against 4.8 and 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1927: ipv6: Set IPv6 CIDR and Gateway in 'nic' profile

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1927
  
merging this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
@borisstoyanov can you see the failure in Travis with 
test_list_infrastructure_metrics test case?
Thanks @rashmidixit you're right I added this as a plugin to keep it 
separate from the core APIs. If this is a major concern, I can move these APIs 
to server/api modules.

From the UI, to remove this service they can modify the core metrics widget 
to do no-operation (in ui/scripts/ui-custom/metricsView.js) and the rendered 
button can be modified to be hidden, alternatively metricsView section can be 
removed across the resources (zones, cluster, host, vms, volumes and storage 
pool).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-27 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1886
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 398
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failing since 2 runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1972
  
@niteshsarda I don't see any change in file createNetworkOffering.xml, but 
still there are many lines being removed and added. As there is not change in 
this file, please revert.

Also the marvin test case seems as the complete file was edited, even the 
license header. Please add only the changes that are relevant.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-27 Thread niteshsarda
Github user niteshsarda commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1972#discussion_r103190716
  
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java ---
@@ -29,4 +30,6 @@
 
 List listInTransitionStateByNetworkIdAndScheme(long 
networkId, Scheme scheme);
 
+boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, String 
instanceIp, long networkId, FirewallRule.Purpose purpose);
--- End diff --

@SudharmaJain : As per suggestion, removed Purpose parameter from method 
signature and added directly in the SearchBuilder. 

Please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1927: ipv6: Set IPv6 CIDR and Gateway in 'nic' prof...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1927


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Wido den Hollander

> Op 27 februari 2017 om 7:17 schreef Raja Pullela 
> :
> 
> 
> Hi will, 
> 
> I believe, we didn’t get to close ‘getting a mirror on Apache’ because we 
> needed someone on the Apache Infra side to close this. BTW, 
> cloudstack-apt.get.eu (I think Nux manages this?) has all/most of the 
> content.  Once we can close on the Apache mirror for hosting the content, I 
> can help assist getting the content there.
> 

cloudstack.apt-get.eu is managed by me.

> For now, we have replicated the download.cloud.com content to 
> ‘s3.download.accelerite.com’.
> Also, we are working on a set of steps/procedure to help with this change.  I 
> will update everyone in about a week’s time on the details.
> 

Thanks! Although we should probably refrain for using a non-generic domain name 
in any of the source.

Wido

> Best,
> Raja Pullela
> Engineering Team,
> Accelerite, 2055 Laurelwood Road,
> Santa Clara, CA, 95054
> 
> On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will Stevens" 
>  wrote:
> 
> unfortunately the template mirror conversation got caught up in details and
> nobody took the lead on implementing a solution.
> 
> citrix has been pinging me every couple months to say 'dude, we need to
> remove the dependency on download.citrix.com', but i have not had the
> cycles to get in and solve the problem.  the shutdown of that is imminent
> right now, so we need to solve it asap.
> 
> 
> 
> *Will STEVENS*
> Lead Developer
> 
> 
> 
> On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus 
> wrote:
> 
> > Hi Nathan,
> >
> > Ideally, if you put the template location in (or use a template defined
> > in)  test_data.py then the actual location can be overridden by anyone
> > testing.
> >
> > For Trillian, we've copied all of the templates that people have define to
> > a local repo and then replace the URLs in test_data.py to reduce bandwidth
> > use and download times.
> >
> > Ie:
> >
> > "bootableIso":
> > {
> > "displaytext": "Test Bootable ISO",
> > "name": "testISO",
> > "bootable": True,
> > "ispublic": False,
> > "url": "{{ marvin_images_location
> > }}/TinyCore-current.iso",
> > "ostype": 'Other Linux (64-bit)',
> > "mode": 'HTTP_DOWNLOAD'
> > },
> >
> >
> >
> > I thought that we had come up with a solution for download.cloud.com, by
> > having a mirrorlist hosted in Community Apache 'space' with anyone able to
> > out themselves forward as a mirror.
> > But I must admit I lost track of whether anyone made the requisite changes
> > in code
> >
> >
> >
> >
> > Kind regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
> > -Original Message-
> > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > Behalf Of Will Stevens
> > Sent: 24 February 2017 16:30
> > To: dev@cloudstack.apache.org
> > Subject: Re: Modern template hosting
> >
> > this is a hard questions.  in general, we should be setting up a mirror on
> > some cloudstack/apache domain and then mirror to other provided templates.
> >
> > we MUST come up with a solution to deprecate 'download.cloud.com', that
> > is going to be going away any day now.
> >
> > i don't know the right way to solve this to be honest, but if you have
> > ideas, i am willing to help.
> >
> >
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Fri, Feb 24, 2017 at 11:25 AM, Nathan Johnson  wrote:
> >
> > > So not to re-open a can of worms, but I’m in a situation where I need
> > > to come up with a Marvin component test that depends on a template
> > > based on a kernel that’s relatively new, i.e., newer than Centos 5.3 /
> > Ubuntu 10.04 .
> > > I see openvm.eu has a suitable template (Ubuntu 16.0.4 for KVM), but
> > > from looking at the thread "Migrating CloudStack content from
> > > download.cloud.com” it looks like there is resistance to using this at
> > > least for hosting system vm templates over concerns of neutrality.
> > > Would this be suitable for a component test?  If not, what is a “blessed”
> > > template location?
> > >
> > > Thanks in advance!
> > >
> > > Nathan Johnson
> > > R Engineer
> > >
> > >
> > >
> > > 618 Grassmere Park Drive, Suite 12
> > > Nashville, TN 37211
> > > General Office: 615-312-6000
> > >
> > > website | blog | support
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> 
> 
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the 
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the use of the individual or entity to which it is addressed. If you 

Re: Modern template hosting

2017-02-27 Thread Raja Pullela
sorry Wido… forgot… thank you for correcting!

On 2/27/17, 4:50 PM, "Wido den Hollander"  wrote:
> Op 27 februari 2017 om 7:17 schreef Raja Pullela 
> :
> 
> 
> Hi will, 
> 
> I believe, we didn’t get to close ‘getting a mirror on Apache’ because we 
> needed someone on the Apache Infra side to close this. BTW, 
> cloudstack-apt.get.eu (I think Nux manages this?) has all/most of the 
> content.  Once we can close on the Apache mirror for hosting the content, I 
> can help assist getting the content there.
> 

cloudstack.apt-get.eu is managed by me.

> For now, we have replicated the download.cloud.com content to 
> ‘s3.download.accelerite.com’.
> Also, we are working on a set of steps/procedure to help with this change.  I 
> will update everyone in about a week’s time on the details.
> 

Thanks! Although we should probably refrain for using a non-generic domain name 
in any of the source.

Wido

> Best,
> Raja Pullela
> Engineering Team,
> Accelerite, 2055 Laurelwood Road,
> Santa Clara, CA, 95054
> 
> On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will Stevens" 
>  wrote:
> 
> unfortunately the template mirror conversation got caught up in details and
> nobody took the lead on implementing a solution.
> 
> citrix has been pinging me every couple months to say 'dude, we need to
> remove the dependency on download.citrix.com', but i have not had the
> cycles to get in and solve the problem.  the shutdown of that is imminent
> right now, so we need to solve it asap.
> 
> 
> 
> *Will STEVENS*
> Lead Developer
> 
> 
> 
> On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus 
> wrote:
> 
> > Hi Nathan,
> >
> > Ideally, if you put the template location in (or use a template defined
> > in)  test_data.py then the actual location can be overridden by anyone
> > testing.
> >
> > For Trillian, we've copied all of the templates that people have define to
> > a local repo and then replace the URLs in test_data.py to reduce bandwidth
> > use and download times.
> >
> > Ie:
> >
> > "bootableIso":
> > {
> > "displaytext": "Test Bootable ISO",
> > "name": "testISO",
> > "bootable": True,
> > "ispublic": False,
> > "url": "{{ marvin_images_location
> > }}/TinyCore-current.iso",
> > "ostype": 'Other Linux (64-bit)',
> > "mode": 'HTTP_DOWNLOAD'
> > },
> >
> >
> >
> > I thought that we had come up with a solution for download.cloud.com, by
> > having a mirrorlist hosted in Community Apache 'space' with anyone able to
> > out themselves forward as a mirror.
> > But I must admit I lost track of whether anyone made the requisite changes
> > in code
> >
> >
> >
> >
> > Kind regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
> > -Original Message-
> > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > Behalf Of Will Stevens
> > Sent: 24 February 2017 16:30
> > To: dev@cloudstack.apache.org
> > Subject: Re: Modern template hosting
> >
> > this is a hard questions.  in general, we should be setting up a mirror on
> > some cloudstack/apache domain and then mirror to other provided templates.
> >
> > we MUST come up with a solution to deprecate 'download.cloud.com', that
> > is going to be going away any day now.
> >
> > i don't know the right way to solve this to be honest, but if you have
> > ideas, i am willing to help.
> >
> >
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Fri, Feb 24, 2017 at 11:25 AM, Nathan Johnson  wrote:
> >
> > > So not to re-open a can of worms, but I’m in a situation where I need
> > > to come up with a Marvin component test that depends on a template
> > > based on a kernel that’s relatively new, i.e., newer than Centos 5.3 /
> > Ubuntu 10.04 .
> > > I see openvm.eu has a suitable template (Ubuntu 16.0.4 for KVM), but
> > > from looking at the thread "Migrating CloudStack content from
> > > download.cloud.com” it looks like there is resistance to using this at
> > > least for hosting system vm templates over concerns of neutrality.
> > > Would this be suitable for a component test?  If not, what is a “blessed”
> > > template location?
> > >
> > > Thanks in advance!
> > >
> > > Nathan Johnson
> > > R Engineer
> > >
> > >
> > >
> > > 618 Grassmere Park Drive, Suite 12
> > > Nashville, TN 37211
> > > General Office: 615-312-6000
> > >
> > > website | blog | support
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> 
> 
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the 
> property of Accelerite, a Persistent 

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103212914
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/ha/EnableHAForClusterCmd.java 
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.ha;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.org.Cluster;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ClusterResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.ha.HAConfigManager;
+
+import javax.inject.Inject;
+
+@APICommand(name = EnableHAForClusterCmd.APINAME, description = "Enables 
HA cluster-wide",
+responseObject = SuccessResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+since = "4.11", authorized = {RoleType.Admin})
+public final class EnableHAForClusterCmd extends BaseAsyncCmd {
--- End diff --

naming: see disable cmd


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@marcaurele can we have a unit test to confirm that this does not break 
upgrade for older systems, also by changing the order for all older versions, 
the way someone would upgrade from say 4.3 to 4.10, will be different from 
someone who upgraded from 4.3->4.9->4.10 -- this may have side effects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@DaanHoogland Can you post test results?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-27 Thread prashanthvarma
Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack-docs/pull/19
  
@rhtyd @karuturi Please do review this cloudstack-docs PR, which includes 
changes to the Nuage VSP Plugin documentation for ACS 4.10 release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Save The Date: Spring Meetup Of Cloudstack European User Group

2017-02-27 Thread Steve Roles
Hi guys,

The next meetup is Wednesday, April 12, hosted by Interoute Prague. As always, 
there will be some great speakers, the chance to meet and collaborate with 
other CloudStack users, and an informal gathering afterwards over a drink!

Agenda and speakers: TBC; Venue: Interoute Czech s.r.o. Siemensova Street 
2717/4, Prague 5, 155 00, Czech Republic

More information including how to register 
here.

Hope to see you there!

Best regards,


steve.ro...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103210828
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java 
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.ha;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.org.Cluster;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ClusterResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.ha.HAConfigManager;
+
+import javax.inject.Inject;
+
+@APICommand(name = DisableHAForClusterCmd.APINAME, description = "Disables 
HA cluster-wide",
--- End diff --

naming: looking at the code below this actually is 
DisableHAForHostsInClusterCmd. I don't think it is a biggy but might lead to 
conflicts at some point


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103207344
  
--- Diff: .travis.yml ---
@@ -42,13 +42,18 @@ env:
  smoke/test_dynamicroles
  smoke/test_global_settings
  smoke/test_guest_vlan_range
+ smoke/test_ha_for_host
--- End diff --

:+1: :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103212736
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForZoneCmd.java ---
@@ -0,0 +1,115 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.ha;
+
+import com.cloud.dc.DataCenter;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.ha.HAConfigManager;
+
+import javax.inject.Inject;
+
+@APICommand(name = DisableHAForZoneCmd.APINAME, description = "Disables HA 
for a zone",
--- End diff --

naming: see disable cluster cmd


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1954: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1954


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-27 Thread prashanthvarma
Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack-docs/pull/19
  
These changes in the documentation are in accordance with our merged 
feature support (including bug fix) PRs. Here are some of our merged feature 
support PRs:

https://github.com/apache/cloudstack/pull/1578
https://github.com/apache/cloudstack/pull/1579
https://github.com/apache/cloudstack/pull/1580
https://github.com/apache/cloudstack/pull/1452

Moreover, we have restructured and extended the documentation with some 
screen-shots.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread marcaurele
Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@rhtyd I don't see how I could write such a test case. My point is exactly 
what you're saying, the upgrade would be different today for anyone who comes 
from an older version, which I don't think you're currently testing. I want to 
avoid such situation, therefore I'm pushing this PR to stop having different 
upgrade paths.
Can you be more explicit in what you think can become a problem compared to 
the current situation we're in today?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #:

2017-02-27 Thread nitin-maharana
Github user nitin-maharana commented on the pull request:


https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082376
  
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java on line 295:
Build is failing due to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rashmidixit
Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
@rhtyd I guess this is fine for now. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1975: Fix build failure on master

2017-02-27 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1975
  
ping @karuturi


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1975: Fix build failure on master

2017-02-27 Thread koushik-das
GitHub user koushik-das opened a pull request:

https://github.com/apache/cloudstack/pull/1975

Fix build failure on master



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack build-failure

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1975


commit f843fcb969780e1368a060e26fe229f08a4ec92c
Author: Koushik Das 
Date:   2017-02-28T05:52:30Z

Fix build failure on master




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1824: CLOUDSTACK-9657: Fixed security group ipset issues w...

2017-02-27 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1824
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
The cloud templates provided by Ubuntu and CentOS (Debian doesn't provide
one) can work out of the box if we support http://1692.254.169.254/ as a
metadata URL. I believe this is as simple as adding this IP to the VR (+ a
DNAT rule in the VR?) for advanced zone. For Basic Zone the default router
is not the VR, so additional DNAT rule will have to be added on the xenbr0
bridge.

On Mon, Feb 27, 2017 at 5:40 PM, Pierre-Luc Dion 
wrote:

> hi!
>
> I think we should work with distro provider to have their cloud builds work
> with cloudstack. Good example is CoreOS, it work out of the box from their
> channel builds.
> it shouldn't be too complicated to have centos, ubuntu and debian, unless
> ...
>
> For our systemvm templates, can we just change the URL for somthing like
> cloudstack.apache.org/systemvm/... ?
> and for old systemvm that are depricated but that we might want to keep,
> could we archive them into a github repo in
> https://github.com/apachecloudstack ?
>
>
>
>
> On Mon, Feb 27, 2017 at 6:28 PM, Chiradeep Vittal 
> wrote:
>
> > My stance is that the current workflow does a disservice to the user
> > community by letting them install / use outdated and insecure templates.
> > Now, let's assume download.cloud.com is gone forever. What do we tell
> ACS
> > users pre-4.11 as far as *built-in templates* go?
> > 1. Direct them to update templates.sql with some new URL, but with the
> same
> > dirty old templates
> > 2. Direct them to update templates.sql with some new URL, but with nice
> > templates (e.g., open.vm.eu)
> > 3. Same as (2), but document more choices.
> >
> > Now, why should things be different for 4.11 and later? Documenting the
> > steps to install templates offline is trivial (and can be scripted to a
> > large part, like cloud-install-sys-tmplt)
> >
> > For pre-4.11 users, for *systemvms*, anyway we tell them to use
> > http://cloudstack.apt-get.eu which is not controlled by ACS.
> >
> >
> > On Mon, Feb 27, 2017 at 2:50 PM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com> wrote:
> >
> > > Agree with you.
> > > We need to support the current working flow. And then, define the first
> > > version that will start using the new approach.
> > >
> > > On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens 
> > > wrote:
> > >
> > > > I think we almost need a two pronged approach.
> > > >
> > > > 1) Get a solution in place which will enable us to document and serve
> > > > templates for legacy systems.  I will work on this.
> > > > 2) Discuss and understand how we SHOULD be handling this problem in
> the
> > > > future and in what release we can expect it.
> > > >
> > > > I think we need to do both.  I think we should start to try to really
> > > > understand what we want to deliver in (2) going forward.
> > > >
> > > > *Will STEVENS*
> > > > Lead Developer
> > > >
> > > > 
> > > >
> > > > On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> > > > rafaelweingart...@gmail.com> wrote:
> > > >
> > > > > My worry is exactly with system VMs templates.
> > > > >
> > > > > Currently, we indicate administrators to download them from
> > > > > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> > > > installation
> > > > > docs do not mention the expected hashes for the file that is going
> to
> > > be
> > > > > downloaded.
> > > > > Also, I do not know the code that downloads system VMs templates
> > (when
> > > > > upgrading), but if the hash being checked is taken from the mirror
> > used
> > > > to
> > > > > download the file; the only thing it checks is that if the download
> > > > > finished successfully (no transmission errors). If we want to check
> > > > > integrity, check that the template we created is untampered; we
> need
> > to
> > > > > host and serve the hash in a secure manner.
> > > > >
> > > > > [1]
> > > > > http://docs.cloudstack.apache.org/projects/cloudstack-
> > > > installation/en/4.9/
> > > > > management-server/index.html#prepare-the-system-vm-template
> > > > >
> > > > >
> > > > > On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal <
> > > chirade...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hashes are checked (md5 IIRC) today.
> > > > > > But given the issues, I think the project should steer away from
> > > > hosting
> > > > > > templates except the systemvm template.
> > > > > >
> > > > > > On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
> > > > > > rafaelweingart...@gmail.com> wrote:
> > > > > >
> > > > > > > Will, I think we could support different path structures. This
> > can
> > > > > > > facilitate different deployment of mirrors based on the
> structure
> > > the
> > > > > > host
> > > > > > > has.
> > > > > > >
> > > > > > > Could I add something else to the discussion? Have we discussed
> > the
> > > > > > > security impacts of setting up this mirrors approach?
> > > > > > > I mean, if any of the mirrors gets corrupted (let`s say by a
> > > hacker),
> 

[GitHub] cloudstack pull request #:

2017-02-27 Thread pdion891
Github user pdion891 commented on the pull request:


https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21080945
  
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java on line 295:
@karuturi this seams to break master. the line 294 `{` does not seams to be 
close.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r103382438
  
--- Diff: debian/control ---
@@ -16,14 +16,15 @@ Description: A common package which contains files 
which are shared by several C
 Package: cloudstack-management
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends}, openjdk-8-jre-headless | 
java8-runtime-headless | java8-runtime, cloudstack-common (= 
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector, 
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool, lsb-release
+Recommends: init-system-helpers (>= 1.14)
--- End diff --

@ustcweizhou can you move init-system-helpers (>= 1.14) to Depends, or 
remove it if it's not necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Pierre-Luc Dion
hi!

I think we should work with distro provider to have their cloud builds work
with cloudstack. Good example is CoreOS, it work out of the box from their
channel builds.
it shouldn't be too complicated to have centos, ubuntu and debian, unless
...

For our systemvm templates, can we just change the URL for somthing like
cloudstack.apache.org/systemvm/... ?
and for old systemvm that are depricated but that we might want to keep,
could we archive them into a github repo in
https://github.com/apachecloudstack ?




On Mon, Feb 27, 2017 at 6:28 PM, Chiradeep Vittal 
wrote:

> My stance is that the current workflow does a disservice to the user
> community by letting them install / use outdated and insecure templates.
> Now, let's assume download.cloud.com is gone forever. What do we tell ACS
> users pre-4.11 as far as *built-in templates* go?
> 1. Direct them to update templates.sql with some new URL, but with the same
> dirty old templates
> 2. Direct them to update templates.sql with some new URL, but with nice
> templates (e.g., open.vm.eu)
> 3. Same as (2), but document more choices.
>
> Now, why should things be different for 4.11 and later? Documenting the
> steps to install templates offline is trivial (and can be scripted to a
> large part, like cloud-install-sys-tmplt)
>
> For pre-4.11 users, for *systemvms*, anyway we tell them to use
> http://cloudstack.apt-get.eu which is not controlled by ACS.
>
>
> On Mon, Feb 27, 2017 at 2:50 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > Agree with you.
> > We need to support the current working flow. And then, define the first
> > version that will start using the new approach.
> >
> > On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens 
> > wrote:
> >
> > > I think we almost need a two pronged approach.
> > >
> > > 1) Get a solution in place which will enable us to document and serve
> > > templates for legacy systems.  I will work on this.
> > > 2) Discuss and understand how we SHOULD be handling this problem in the
> > > future and in what release we can expect it.
> > >
> > > I think we need to do both.  I think we should start to try to really
> > > understand what we want to deliver in (2) going forward.
> > >
> > > *Will STEVENS*
> > > Lead Developer
> > >
> > > 
> > >
> > > On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> > > rafaelweingart...@gmail.com> wrote:
> > >
> > > > My worry is exactly with system VMs templates.
> > > >
> > > > Currently, we indicate administrators to download them from
> > > > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> > > installation
> > > > docs do not mention the expected hashes for the file that is going to
> > be
> > > > downloaded.
> > > > Also, I do not know the code that downloads system VMs templates
> (when
> > > > upgrading), but if the hash being checked is taken from the mirror
> used
> > > to
> > > > download the file; the only thing it checks is that if the download
> > > > finished successfully (no transmission errors). If we want to check
> > > > integrity, check that the template we created is untampered; we need
> to
> > > > host and serve the hash in a secure manner.
> > > >
> > > > [1]
> > > > http://docs.cloudstack.apache.org/projects/cloudstack-
> > > installation/en/4.9/
> > > > management-server/index.html#prepare-the-system-vm-template
> > > >
> > > >
> > > > On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal <
> > chirade...@gmail.com>
> > > > wrote:
> > > >
> > > > > Hashes are checked (md5 IIRC) today.
> > > > > But given the issues, I think the project should steer away from
> > > hosting
> > > > > templates except the systemvm template.
> > > > >
> > > > > On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
> > > > > rafaelweingart...@gmail.com> wrote:
> > > > >
> > > > > > Will, I think we could support different path structures. This
> can
> > > > > > facilitate different deployment of mirrors based on the structure
> > the
> > > > > host
> > > > > > has.
> > > > > >
> > > > > > Could I add something else to the discussion? Have we discussed
> the
> > > > > > security impacts of setting up this mirrors approach?
> > > > > > I mean, if any of the mirrors gets corrupted (let`s say by a
> > hacker),
> > > > and
> > > > > > the templates are injected with malicious code, an attacker could
> > > > > > potentially get un-monitored and unlimited access to a cloud
> > > > environment.
> > > > > >
> > > > > > If we assume that the mirror may get malicious (it is not that I
> do
> > > not
> > > > > > trust you guys, but bad things happen), we cannot host hashes
> > there.
> > > > > Where
> > > > > > do you think we could store Sha512 or another hash type for these
> > > > > > templates? Could we host in the newly proposed Github repo or
> maybe
> > > > some
> > > > > > place in the ACS website?
> > > > > >
> > > > > > This would have an impact on clients (needing clear
> documentation)
> > 

[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...

2017-02-27 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1919
  
This is usefull when using VPC.

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...

2017-02-27 Thread ramkatru
Github user ramkatru commented on the issue:

https://github.com/apache/cloudstack/pull/847
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-27 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
>can you run internal CI and post @cloudmonger test results?

@karuturi running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
@rashmidixit the current UI does not support support pluggability of 
components within UI like the backend does. We can have a separate tab but not 
the implementation that the current metrics view UI has i.e. embedded across 
resource views. It's a general purpose feature that works for all 
deployments/environments and I think most users would want to keep it so we 
never implemented a way to disable it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1944

CLOUDSTACK-9783: Improve metrics view performance

This improves the metrics view feature by improving the rendering 
performance
of metrics view tables, by re-implementing the logic at the backend and data
served via APIs. In large environments, the older implementation would
make several API calls that increases both network and database load.

List of APIs introduced for improving the performance that re-implement the 
frontend logic at backend:

listClustersMetrics
listHostsMetrics
listInfrastructure
listStoragePoolsMetrics
listVMsMetrics
listVolumesMetrics
listZonesMetrics

Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov 
@karuturi @rashmidixit 

Marvin test results:

=== TestName: test_list_clusters_metrics | Status : SUCCESS ===

=== TestName: test_list_hosts_metrics | Status : SUCCESS ===

=== TestName: test_list_infrastructure_metrics | Status : SUCCESS ===

=== TestName: test_list_pstorage_metrics | Status : SUCCESS ===

=== TestName: test_list_vms_metrics | Status : SUCCESS ===

=== TestName: test_list_volumes_metrics | Status : SUCCESS ===

=== TestName: test_list_zones_metrics | Status : SUCCESS ===

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-metrics-enhancement

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1944


commit 3881d249d07f16bde77c20450c5f39425a135e42
Author: Rohit Yadav 
Date:   2017-02-16T08:15:15Z

CLOUDSTACK-9783: Improve metrics view performance

This improves the metrics view feature by improving the rendering 
performance
of metrics view tables, by reimplementing the logic at the backend and data
served via APIs. In large environments, the older implementation would
make several API calls that increases both network and database load.

List of APIs introduced for improving the performance:

listClustersMetrics
listHostsMetrics
listInfrastructure
listStoragePoolsMetrics
listVMsMetrics
listVolumesMetrics
listZonesMetrics

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1944


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #:

2017-02-27 Thread koushik-das
Github user koushik-das commented on the pull request:


https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082422
  
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java on line 295:
Thats correct, already submitted #1975 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
Actually, BVT is not going to verify this as this is db upgrade related and 
travis would have tested it. 
I am merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-27 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1976: Revert "Merge pull request #1829 from syed/hv...

2017-02-27 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/1976

Revert "Merge pull request #1829 from syed/hvm-volume-attach-restart-fix"


This reverts commit d9bd01266ffb23f591283c058beff6e65d1cc4aa, reversing
changes made to ea7c48cf6127aeb73c1d25d7bcee52120ab85204.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack revert-1829

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1976.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1976


commit 0a18d19e8cb30ecfd546d34afb0b0bfaa05c9c80
Author: Rajani Karuturi 
Date:   2017-02-28T06:21:46Z

Revert "Merge pull request #1829 from syed/hvm-volume-attach-restart-fix"

This reverts commit d9bd01266ffb23f591283c058beff6e65d1cc4aa, reversing
changes made to ea7c48cf6127aeb73c1d25d7bcee52120ab85204.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
Thanks @rashmidixit 

@karuturi this is ready for merge, as soon as Travis passes. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1976: Revert "Merge pull request #1829 from syed/hv...

2017-02-27 Thread karuturi
Github user karuturi closed the pull request at:

https://github.com/apache/cloudstack/pull/1976


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1976: Revert "Merge pull request #1829 from syed/hvm-volum...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1976
  
This is not going to fix the build issue. The issue is different. I will 
open a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
Both #1829 and #1941 are merged and is causing build failures. I am 
creating new PR with the revert.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1975: Fix build failure on master

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1975
  
LGTM, found the build failure locally today. Introduced in `a2428508`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi closed the pull request at:

https://github.com/apache/cloudstack/pull/1977


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1977
  
PR #1975 has the same fix. closing this in favour of #1975 as jenkins 
already passed there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1975: Fix build failure on master

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1975


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@rhtyd I don't see how your concern is more true for the new code by 
@marcaurele then it is true for old code. cleanup is still going to be executed 
after the scripts, is it? only directly after instead of waiting for unrelated 
upgrade scripts to complete as well. We never have and never can have full 
coverage of upgrades as every cloud is a different snowflake. So we'll need to 
fix problems after intitial release most of the time. That is no worse or 
better with this code it is just a little more predictable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1977
  
LGTM. This change occurs due to code around that are gets diverged in 
master and 4.9 with merge of PR #1727.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1977
  
Thanks for the review anshul.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  

[1768.network.results.txt](https://github.com/apache/cloudstack/files/805988/1768.network.results.txt)

[1768.vpc_routers.results.txt](https://github.com/apache/cloudstack/files/805989/1768.vpc_routers.results.txt)

just for form @karuturi . I see failures in network but can not relate 
these to the upgrades


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@marcaurele I appreciate the cleanup, it should have been like this from 
the beginning but since we've the workflow to execute all the upgrades first 
and then the cleanup. In 
`https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-481to490-cleanup.sql`
 the views are executed at the end because certain columns are added by the 
java based upgrade path and views can only access them after the 
script/java-based-upgrade is complete. I think with this change future db 
upgrade paths need to written carefully.

I've no objections with the overall goal to cleanup the sequence logic, 
though I have a concern that this might cause upgrade regressions in some 
environments as writing upgrade validation tests may not be possible. /cc 
@DaanHoogland @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


master is broken

2017-02-27 Thread Rajani Karuturi
FYI,

master is broken due to a merge conflict.

I created PR https://github.com/apache/cloudstack/pull/1977 to
fix the same.

Will merge it ASAP.

~ Rajani

http://cloudplatform.accelerite.com/

[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-27 Thread marcaurele
Github user marcaurele commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1768#discussion_r103394277
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion, 
CloudStackVersion currentVer
 }
 
 upgrade.performDataMigration(conn);
-boolean upgradeVersion = true;
-
-if (upgrade.getUpgradedVersion().equals("2.1.8")) {
--- End diff --

I thought that anything older than 4.x should be removed. The simulator and 
DB schema create a structure based on 4.0.0 or 4.1.0 if I recall correctly.
I initially added another commit (removed now) which was only leaving 
upgrade paths from version 4.0.0. That can be done later, and I think it would 
be a good cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-27 Thread srinivas-gandikota
Github user srinivas-gandikota commented on the issue:

https://github.com/apache/cloudstack/pull/1883
  
LGTM

Reviewed code -- looks good
I see even the BVTs have passed without any failures


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/1977

fixed the merge conflict on merging #1941



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack build-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1977.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1977


commit 8402ee635c089a07230cfbe7f971451f959d46ba
Author: Rajani Karuturi 
Date:   2017-02-28T07:03:47Z

fixed an issue due to the merge conflict on merging #1941




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1768#discussion_r103388263
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion, 
CloudStackVersion currentVer
 }
 
 upgrade.performDataMigration(conn);
-boolean upgradeVersion = true;
-
-if (upgrade.getUpgradedVersion().equals("2.1.8")) {
--- End diff --

I'm not sure about the implications, but since 2.x is a very old version -- 
we need to put in our release notes that we won't support upgrades from very 
old 2.x releases. We can in that case even remove all 2.x upgrade paths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-27 Thread syed
Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
Thanks @rhtyd for confirming. LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-27 Thread syed
Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1962


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-27 Thread syed
Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1962
  
@mike-tutkowski If you already have incorporated these changes, I'll close 
this one. If possible, please add me as reviewer when you open the other PR 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Nathan Johnson
Paul Angus  wrote:

> Hi Nathan,
>
> Ideally, if you put the template location in (or use a template defined  
> in)  test_data.py then the actual location can be overridden by anyone  
> testing.
>
> For Trillian, we've copied all of the templates that people have define  
> to a local repo and then replace the URLs in test_data.py to reduce  
> bandwidth use and download times.
>
> Ie:
>
> "bootableIso":
> {
> "displaytext": "Test Bootable ISO",
> "name": "testISO",
> "bootable": True,
> "ispublic": False,
> "url": "{{ marvin_images_location 
> }}/TinyCore-current.iso",
> "ostype": 'Other Linux (64-bit)',
> "mode": 'HTTP_DOWNLOAD'
> },
>


Thanks for the tip, this could work pretty well for us I think.



Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
What steps are needed to set up a mirror? What does Infra need to do? Has
anybody filed a ticket with Infra?

On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela 
wrote:

> Hi will,
>
> I believe, we didn’t get to close ‘getting a mirror on Apache’ because we
> needed someone on the Apache Infra side to close this. BTW,
> cloudstack-apt.get.eu (I think Nux manages this?) has all/most of the
> content.  Once we can close on the Apache mirror for hosting the content, I
> can help assist getting the content there.
>
> For now, we have replicated the download.cloud.com content to ‘
> s3.download.accelerite.com’.
> Also, we are working on a set of steps/procedure to help with this
> change.  I will update everyone in about a week’s time on the details.
>
> Best,
> Raja Pullela
> Engineering Team,
> Accelerite, 2055 Laurelwood Road,
> Santa Clara, CA, 95054
>
> On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will
> Stevens" 
> wrote:
>
> unfortunately the template mirror conversation got caught up in details and
> nobody took the lead on implementing a solution.
>
> citrix has been pinging me every couple months to say 'dude, we need to
> remove the dependency on download.citrix.com', but i have not had the
> cycles to get in and solve the problem.  the shutdown of that is imminent
> right now, so we need to solve it asap.
>
>
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus 
> wrote:
>
> > Hi Nathan,
> >
> > Ideally, if you put the template location in (or use a template defined
> > in)  test_data.py then the actual location can be overridden by anyone
> > testing.
> >
> > For Trillian, we've copied all of the templates that people have define
> to
> > a local repo and then replace the URLs in test_data.py to reduce
> bandwidth
> > use and download times.
> >
> > Ie:
> >
> > "bootableIso":
> > {
> > "displaytext": "Test Bootable ISO",
> > "name": "testISO",
> > "bootable": True,
> > "ispublic": False,
> > "url": "{{ marvin_images_location
> > }}/TinyCore-current.iso",
> > "ostype": 'Other Linux (64-bit)',
> > "mode": 'HTTP_DOWNLOAD'
> > },
> >
> >
> >
> > I thought that we had come up with a solution for download.cloud.com, by
> > having a mirrorlist hosted in Community Apache 'space' with anyone able
> to
> > out themselves forward as a mirror.
> > But I must admit I lost track of whether anyone made the requisite
> changes
> > in code
> >
> >
> >
> >
> > Kind regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
> > -Original Message-
> > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > Behalf Of Will Stevens
> > Sent: 24 February 2017 16:30
> > To: dev@cloudstack.apache.org
> > Subject: Re: Modern template hosting
> >
> > this is a hard questions.  in general, we should be setting up a mirror
> on
> > some cloudstack/apache domain and then mirror to other provided
> templates.
> >
> > we MUST come up with a solution to deprecate 'download.cloud.com', that
> > is going to be going away any day now.
> >
> > i don't know the right way to solve this to be honest, but if you have
> > ideas, i am willing to help.
> >
> >
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Fri, Feb 24, 2017 at 11:25 AM, Nathan Johnson 
> wrote:
> >
> > > So not to re-open a can of worms, but I’m in a situation where I need
> > > to come up with a Marvin component test that depends on a template
> > > based on a kernel that’s relatively new, i.e., newer than Centos 5.3 /
> > Ubuntu 10.04 .
> > > I see openvm.eu has a suitable template (Ubuntu 16.0.4 for KVM), but
> > > from looking at the thread "Migrating CloudStack content from
> > > download.cloud.com” it looks like there is resistance to using this at
> > > least for hosting system vm templates over concerns of neutrality.
> > > Would this be suitable for a component test?  If not, what is a
> “blessed”
> > > template location?
> > >
> > > Thanks in advance!
> > >
> > > Nathan Johnson
> > > R Engineer
> > >
> > >
> > >
> > > 618 Grassmere Park Drive, Suite 12
> > > Nashville, TN 37211
> > > General Office: 615-312-6000
> > >
> > > website | blog | support
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
>
>
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to 

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-27 Thread kiwiflyer
Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Will Stevens
We haven't opened a ticket yet because we don't have a strategy yet.

What do you guys think of this:
- We setup a new github repo in the 'apache' org which consists of a single
file with a list of active/supported mirrors.
- I write a small web server, distributed as a binary, which can be hosted
by ASF Infra.  This web server will query the current list of mirrors and
will select one and then do a 302 redirect to that mirror.

The act of 'choosing' a mirror could be done in a number of ways.
- If we want to define an order, then it could just try from the top of the
list and work its way down.  It would curl the target to make sure it gets
a 200 and if it does, it would do a 302 redirect.
- Or, if we want to distribute the load across the mirrors, we could pick
from the list randomly.  Again, doing a curl to verify the mirror is up and
then doing a redirect.
- If we want to get fancy, we could do a reverse IP lookup and try to match
the requester with their closest geographical mirror.

Thoughts?

*Will STEVENS*
Lead Developer



On Mon, Feb 27, 2017 at 12:46 PM, Chiradeep Vittal 
wrote:

> What steps are needed to set up a mirror? What does Infra need to do? Has
> anybody filed a ticket with Infra?
>
> On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela <
> raja.pull...@accelerite.com>
> wrote:
>
> > Hi will,
> >
> > I believe, we didn’t get to close ‘getting a mirror on Apache’ because we
> > needed someone on the Apache Infra side to close this. BTW,
> > cloudstack-apt.get.eu (I think Nux manages this?) has all/most of the
> > content.  Once we can close on the Apache mirror for hosting the
> content, I
> > can help assist getting the content there.
> >
> > For now, we have replicated the download.cloud.com content to ‘
> > s3.download.accelerite.com’.
> > Also, we are working on a set of steps/procedure to help with this
> > change.  I will update everyone in about a week’s time on the details.
> >
> > Best,
> > Raja Pullela
> > Engineering Team,
> > Accelerite, 2055 Laurelwood Road,
> > Santa Clara, CA, 95054
> >
> > On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will
> > Stevens" 
> > wrote:
> >
> > unfortunately the template mirror conversation got caught up in details
> and
> > nobody took the lead on implementing a solution.
> >
> > citrix has been pinging me every couple months to say 'dude, we need to
> > remove the dependency on download.citrix.com', but i have not had the
> > cycles to get in and solve the problem.  the shutdown of that is imminent
> > right now, so we need to solve it asap.
> >
> >
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus 
> > wrote:
> >
> > > Hi Nathan,
> > >
> > > Ideally, if you put the template location in (or use a template defined
> > > in)  test_data.py then the actual location can be overridden by anyone
> > > testing.
> > >
> > > For Trillian, we've copied all of the templates that people have define
> > to
> > > a local repo and then replace the URLs in test_data.py to reduce
> > bandwidth
> > > use and download times.
> > >
> > > Ie:
> > >
> > > "bootableIso":
> > > {
> > > "displaytext": "Test Bootable ISO",
> > > "name": "testISO",
> > > "bootable": True,
> > > "ispublic": False,
> > > "url": "{{ marvin_images_location
> > > }}/TinyCore-current.iso",
> > > "ostype": 'Other Linux (64-bit)',
> > > "mode": 'HTTP_DOWNLOAD'
> > > },
> > >
> > >
> > >
> > > I thought that we had come up with a solution for download.cloud.com,
> by
> > > having a mirrorlist hosted in Community Apache 'space' with anyone able
> > to
> > > out themselves forward as a mirror.
> > > But I must admit I lost track of whether anyone made the requisite
> > changes
> > > in code
> > >
> > >
> > >
> > >
> > > Kind regards,
> > >
> > > Paul Angus
> > >
> > > paul.an...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > >
> > >
> > > -Original Message-
> > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > > Behalf Of Will Stevens
> > > Sent: 24 February 2017 16:30
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Modern template hosting
> > >
> > > this is a hard questions.  in general, we should be setting up a mirror
> > on
> > > some cloudstack/apache domain and then mirror to other provided
> > templates.
> > >
> > > we MUST come up with a solution to deprecate 'download.cloud.com',
> that
> > > is going to be going away any day now.
> > >
> > > i don't know the right way to solve this to be honest, but if you have
> > > ideas, i am willing to help.
> > >
> > >
> > >
> > > *Will 

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-27 Thread syed
Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
@rhtyd @anshul1886 I suggest merging this first as the changes here are 
very limited and tested. We can refactor the change out from #1941 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
Sounds workable. The downloader code in the SSVM won't follow redirects I
think.
https://github.com/apache/cloudstack/blob/5511065fc20787619d9cd0444a65a3155fc9c921/core/src/com/cloud/storage/template/HttpTemplateDownloader.java#L93
https://goo.gl/dSi0r5
 Might need to add
client.setRedirectStrategy(new LaxRedirectStrategy());

On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens  wrote:

> We haven't opened a ticket yet because we don't have a strategy yet.
>
> What do you guys think of this:
> - We setup a new github repo in the 'apache' org which consists of a single
> file with a list of active/supported mirrors.
> - I write a small web server, distributed as a binary, which can be hosted
> by ASF Infra.  This web server will query the current list of mirrors and
> will select one and then do a 302 redirect to that mirror.
>
> The act of 'choosing' a mirror could be done in a number of ways.
> - If we want to define an order, then it could just try from the top of the
> list and work its way down.  It would curl the target to make sure it gets
> a 200 and if it does, it would do a 302 redirect.
> - Or, if we want to distribute the load across the mirrors, we could pick
> from the list randomly.  Again, doing a curl to verify the mirror is up and
> then doing a redirect.
> - If we want to get fancy, we could do a reverse IP lookup and try to match
> the requester with their closest geographical mirror.
>
> Thoughts?
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 27, 2017 at 12:46 PM, Chiradeep Vittal 
> wrote:
>
> > What steps are needed to set up a mirror? What does Infra need to do? Has
> > anybody filed a ticket with Infra?
> >
> > On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela <
> > raja.pull...@accelerite.com>
> > wrote:
> >
> > > Hi will,
> > >
> > > I believe, we didn’t get to close ‘getting a mirror on Apache’ because
> we
> > > needed someone on the Apache Infra side to close this. BTW,
> > > cloudstack-apt.get.eu (I think Nux manages this?) has all/most of the
> > > content.  Once we can close on the Apache mirror for hosting the
> > content, I
> > > can help assist getting the content there.
> > >
> > > For now, we have replicated the download.cloud.com content to ‘
> > > s3.download.accelerite.com’.
> > > Also, we are working on a set of steps/procedure to help with this
> > > change.  I will update everyone in about a week’s time on the details.
> > >
> > > Best,
> > > Raja Pullela
> > > Engineering Team,
> > > Accelerite, 2055 Laurelwood Road,
> > > Santa Clara, CA, 95054
> > >
> > > On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will
> > > Stevens" 
> > > wrote:
> > >
> > > unfortunately the template mirror conversation got caught up in details
> > and
> > > nobody took the lead on implementing a solution.
> > >
> > > citrix has been pinging me every couple months to say 'dude, we need to
> > > remove the dependency on download.citrix.com', but i have not had the
> > > cycles to get in and solve the problem.  the shutdown of that is
> imminent
> > > right now, so we need to solve it asap.
> > >
> > >
> > >
> > > *Will STEVENS*
> > > Lead Developer
> > >
> > > 
> > >
> > > On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus  >
> > > wrote:
> > >
> > > > Hi Nathan,
> > > >
> > > > Ideally, if you put the template location in (or use a template
> defined
> > > > in)  test_data.py then the actual location can be overridden by
> anyone
> > > > testing.
> > > >
> > > > For Trillian, we've copied all of the templates that people have
> define
> > > to
> > > > a local repo and then replace the URLs in test_data.py to reduce
> > > bandwidth
> > > > use and download times.
> > > >
> > > > Ie:
> > > >
> > > > "bootableIso":
> > > > {
> > > > "displaytext": "Test Bootable ISO",
> > > > "name": "testISO",
> > > > "bootable": True,
> > > > "ispublic": False,
> > > > "url": "{{ marvin_images_location
> > > > }}/TinyCore-current.iso",
> > > > "ostype": 'Other Linux (64-bit)',
> > > > "mode": 'HTTP_DOWNLOAD'
> > > > },
> > > >
> > > >
> > > >
> > > > I thought that we had come up with a solution for download.cloud.com
> ,
> > by
> > > > having a mirrorlist hosted in Community Apache 'space' with anyone
> able
> > > to
> > > > out themselves forward as a mirror.
> > > > But I must admit I lost track of whether anyone made the requisite
> > > changes
> > > > in code
> > > >
> > > >
> > > >
> > > >
> > > > Kind regards,
> > > >
> > > > Paul Angus
> > > >
> > > > paul.an...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > >
> > > > -Original 

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
The alternative foolproof way is to simply not provide the automatic
download.

Just document the mirror list URL where the templates can be found. I don't
know why people reject this option.

https://shankerbalan.net/blog/seed-cloudstack-templates-offline/

On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens 
wrote:

> OK. Thanks for the heads up.
>
> On Feb 27, 2017 1:08 PM, "Chiradeep Vittal"  wrote:
>
> > Sounds workable. The downloader code in the SSVM won't follow redirects I
> > think.
> > https://github.com/apache/cloudstack/blob/5511065fc20787619d9cd0444a65a3
> > 155fc9c921/core/src/com/cloud/storage/template/
> > HttpTemplateDownloader.java#L93
> > https://goo.gl/dSi0r5
> >  Might need to add
> > client.setRedirectStrategy(new LaxRedirectStrategy());
> >
> > On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens 
> > wrote:
> >
> > > We haven't opened a ticket yet because we don't have a strategy yet.
> > >
> > > What do you guys think of this:
> > > - We setup a new github repo in the 'apache' org which consists of a
> > single
> > > file with a list of active/supported mirrors.
> > > - I write a small web server, distributed as a binary, which can be
> > hosted
> > > by ASF Infra.  This web server will query the current list of mirrors
> and
> > > will select one and then do a 302 redirect to that mirror.
> > >
> > > The act of 'choosing' a mirror could be done in a number of ways.
> > > - If we want to define an order, then it could just try from the top of
> > the
> > > list and work its way down.  It would curl the target to make sure it
> > gets
> > > a 200 and if it does, it would do a 302 redirect.
> > > - Or, if we want to distribute the load across the mirrors, we could
> pick
> > > from the list randomly.  Again, doing a curl to verify the mirror is up
> > and
> > > then doing a redirect.
> > > - If we want to get fancy, we could do a reverse IP lookup and try to
> > match
> > > the requester with their closest geographical mirror.
> > >
> > > Thoughts?
> > >
> > > *Will STEVENS*
> > > Lead Developer
> > >
> > > 
> > >
> > > On Mon, Feb 27, 2017 at 12:46 PM, Chiradeep Vittal <
> chirade...@gmail.com
> > >
> > > wrote:
> > >
> > > > What steps are needed to set up a mirror? What does Infra need to do?
> > Has
> > > > anybody filed a ticket with Infra?
> > > >
> > > > On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela <
> > > > raja.pull...@accelerite.com>
> > > > wrote:
> > > >
> > > > > Hi will,
> > > > >
> > > > > I believe, we didn’t get to close ‘getting a mirror on Apache’
> > because
> > > we
> > > > > needed someone on the Apache Infra side to close this. BTW,
> > > > > cloudstack-apt.get.eu (I think Nux manages this?) has all/most of
> > the
> > > > > content.  Once we can close on the Apache mirror for hosting the
> > > > content, I
> > > > > can help assist getting the content there.
> > > > >
> > > > > For now, we have replicated the download.cloud.com content to ‘
> > > > > s3.download.accelerite.com’.
> > > > > Also, we are working on a set of steps/procedure to help with this
> > > > > change.  I will update everyone in about a week’s time on the
> > details.
> > > > >
> > > > > Best,
> > > > > Raja Pullela
> > > > > Engineering Team,
> > > > > Accelerite, 2055 Laurelwood Road,
> > > > > Santa Clara, CA, 95054
> > > > >
> > > > > On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will
> > > > > Stevens"  > wstev...@cloudops.com>
> > > > > wrote:
> > > > >
> > > > > unfortunately the template mirror conversation got caught up in
> > details
> > > > and
> > > > > nobody took the lead on implementing a solution.
> > > > >
> > > > > citrix has been pinging me every couple months to say 'dude, we
> need
> > to
> > > > > remove the dependency on download.citrix.com', but i have not had
> > the
> > > > > cycles to get in and solve the problem.  the shutdown of that is
> > > imminent
> > > > > right now, so we need to solve it asap.
> > > > >
> > > > >
> > > > >
> > > > > *Will STEVENS*
> > > > > Lead Developer
> > > > >
> > > > > 
> > > > >
> > > > > On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus <
> > paul.an...@shapeblue.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Nathan,
> > > > > >
> > > > > > Ideally, if you put the template location in (or use a template
> > > defined
> > > > > > in)  test_data.py then the actual location can be overridden by
> > > anyone
> > > > > > testing.
> > > > > >
> > > > > > For Trillian, we've copied all of the templates that people have
> > > define
> > > > > to
> > > > > > a local repo and then replace the URLs in test_data.py to reduce
> > > > > bandwidth
> > > > > > use and download times.
> > > > > >
> > > > > > Ie:
> > > > > >
> > > > > > "bootableIso":
> > > > > > {
> > > > > > "displaytext": "Test Bootable ISO",
> > > > > >

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
My bad. A few lines down, this has been added recently:

this.request.setFollowRedirects(true);

On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens 
wrote:

> OK. Thanks for the heads up.
>
> On Feb 27, 2017 1:08 PM, "Chiradeep Vittal"  wrote:
>
> > Sounds workable. The downloader code in the SSVM won't follow redirects I
> > think.
> > https://github.com/apache/cloudstack/blob/5511065fc20787619d9cd0444a65a3
> > 155fc9c921/core/src/com/cloud/storage/template/
> > HttpTemplateDownloader.java#L93
> > https://goo.gl/dSi0r5
> >  Might need to add
> > client.setRedirectStrategy(new LaxRedirectStrategy());
> >
> > On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens 
> > wrote:
> >
> > > We haven't opened a ticket yet because we don't have a strategy yet.
> > >
> > > What do you guys think of this:
> > > - We setup a new github repo in the 'apache' org which consists of a
> > single
> > > file with a list of active/supported mirrors.
> > > - I write a small web server, distributed as a binary, which can be
> > hosted
> > > by ASF Infra.  This web server will query the current list of mirrors
> and
> > > will select one and then do a 302 redirect to that mirror.
> > >
> > > The act of 'choosing' a mirror could be done in a number of ways.
> > > - If we want to define an order, then it could just try from the top of
> > the
> > > list and work its way down.  It would curl the target to make sure it
> > gets
> > > a 200 and if it does, it would do a 302 redirect.
> > > - Or, if we want to distribute the load across the mirrors, we could
> pick
> > > from the list randomly.  Again, doing a curl to verify the mirror is up
> > and
> > > then doing a redirect.
> > > - If we want to get fancy, we could do a reverse IP lookup and try to
> > match
> > > the requester with their closest geographical mirror.
> > >
> > > Thoughts?
> > >
> > > *Will STEVENS*
> > > Lead Developer
> > >
> > > 
> > >
> > > On Mon, Feb 27, 2017 at 12:46 PM, Chiradeep Vittal <
> chirade...@gmail.com
> > >
> > > wrote:
> > >
> > > > What steps are needed to set up a mirror? What does Infra need to do?
> > Has
> > > > anybody filed a ticket with Infra?
> > > >
> > > > On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela <
> > > > raja.pull...@accelerite.com>
> > > > wrote:
> > > >
> > > > > Hi will,
> > > > >
> > > > > I believe, we didn’t get to close ‘getting a mirror on Apache’
> > because
> > > we
> > > > > needed someone on the Apache Infra side to close this. BTW,
> > > > > cloudstack-apt.get.eu (I think Nux manages this?) has all/most of
> > the
> > > > > content.  Once we can close on the Apache mirror for hosting the
> > > > content, I
> > > > > can help assist getting the content there.
> > > > >
> > > > > For now, we have replicated the download.cloud.com content to ‘
> > > > > s3.download.accelerite.com’.
> > > > > Also, we are working on a set of steps/procedure to help with this
> > > > > change.  I will update everyone in about a week’s time on the
> > details.
> > > > >
> > > > > Best,
> > > > > Raja Pullela
> > > > > Engineering Team,
> > > > > Accelerite, 2055 Laurelwood Road,
> > > > > Santa Clara, CA, 95054
> > > > >
> > > > > On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will
> > > > > Stevens"  > wstev...@cloudops.com>
> > > > > wrote:
> > > > >
> > > > > unfortunately the template mirror conversation got caught up in
> > details
> > > > and
> > > > > nobody took the lead on implementing a solution.
> > > > >
> > > > > citrix has been pinging me every couple months to say 'dude, we
> need
> > to
> > > > > remove the dependency on download.citrix.com', but i have not had
> > the
> > > > > cycles to get in and solve the problem.  the shutdown of that is
> > > imminent
> > > > > right now, so we need to solve it asap.
> > > > >
> > > > >
> > > > >
> > > > > *Will STEVENS*
> > > > > Lead Developer
> > > > >
> > > > > 
> > > > >
> > > > > On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus <
> > paul.an...@shapeblue.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Nathan,
> > > > > >
> > > > > > Ideally, if you put the template location in (or use a template
> > > defined
> > > > > > in)  test_data.py then the actual location can be overridden by
> > > anyone
> > > > > > testing.
> > > > > >
> > > > > > For Trillian, we've copied all of the templates that people have
> > > define
> > > > > to
> > > > > > a local repo and then replace the URLs in test_data.py to reduce
> > > > > bandwidth
> > > > > > use and download times.
> > > > > >
> > > > > > Ie:
> > > > > >
> > > > > > "bootableIso":
> > > > > > {
> > > > > > "displaytext": "Test Bootable ISO",
> > > > > > "name": "testISO",
> > > > > > "bootable": True,
> > > > > > "ispublic": False,
> > > > > > 

[GitHub] cloudstack issue #1940: CLOUDSTACK-9781:ACS records ID in events tables inst...

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1940
  
Trillian test result (tid-901)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30078 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1940-t901-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 321.08 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 155.29 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.18 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 220.72 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 264.86 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 518.17 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 500.68 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1392.41 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 533.72 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 741.20 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1285.68 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.48 | test_volumes.py
test_08_resize_volume | Success | 156.57 | test_volumes.py
test_07_resize_fail | Success | 161.57 | test_volumes.py
test_06_download_detached_volume | Success | 156.72 | test_volumes.py
test_05_detach_volume | Success | 145.88 | test_volumes.py
test_04_delete_attached_volume | Success | 151.23 | test_volumes.py
test_03_download_attached_volume | Success | 156.32 | test_volumes.py
test_02_attach_volume | Success | 89.25 | test_volumes.py
test_01_create_volume | Success | 620.97 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.14 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.55 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.66 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.76 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.52 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 56.05 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 126.00 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.89 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 45.48 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.13 | test_templates.py
test_02_edit_template | Success | 90.20 | test_templates.py
test_01_create_template | Success | 35.39 | test_templates.py
test_10_destroy_cpvm | Success | 161.51 | test_ssvm.py
test_09_destroy_ssvm | Success | 133.28 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.37 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.22 | test_ssvm.py
test_06_stop_cpvm | Success | 131.62 | test_ssvm.py
test_05_stop_ssvm | Success | 133.25 | test_ssvm.py
test_04_cpvm_internals | Success | 0.96 | test_ssvm.py
test_03_ssvm_internals | Success | 2.94 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.15 | test_snapshots.py
test_04_change_offering_small | Success | 239.56 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 

Re: Modern template hosting

2017-02-27 Thread Will Stevens
OK. Thanks for the heads up.

On Feb 27, 2017 1:08 PM, "Chiradeep Vittal"  wrote:

> Sounds workable. The downloader code in the SSVM won't follow redirects I
> think.
> https://github.com/apache/cloudstack/blob/5511065fc20787619d9cd0444a65a3
> 155fc9c921/core/src/com/cloud/storage/template/
> HttpTemplateDownloader.java#L93
> https://goo.gl/dSi0r5
>  Might need to add
> client.setRedirectStrategy(new LaxRedirectStrategy());
>
> On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens 
> wrote:
>
> > We haven't opened a ticket yet because we don't have a strategy yet.
> >
> > What do you guys think of this:
> > - We setup a new github repo in the 'apache' org which consists of a
> single
> > file with a list of active/supported mirrors.
> > - I write a small web server, distributed as a binary, which can be
> hosted
> > by ASF Infra.  This web server will query the current list of mirrors and
> > will select one and then do a 302 redirect to that mirror.
> >
> > The act of 'choosing' a mirror could be done in a number of ways.
> > - If we want to define an order, then it could just try from the top of
> the
> > list and work its way down.  It would curl the target to make sure it
> gets
> > a 200 and if it does, it would do a 302 redirect.
> > - Or, if we want to distribute the load across the mirrors, we could pick
> > from the list randomly.  Again, doing a curl to verify the mirror is up
> and
> > then doing a redirect.
> > - If we want to get fancy, we could do a reverse IP lookup and try to
> match
> > the requester with their closest geographical mirror.
> >
> > Thoughts?
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Mon, Feb 27, 2017 at 12:46 PM, Chiradeep Vittal  >
> > wrote:
> >
> > > What steps are needed to set up a mirror? What does Infra need to do?
> Has
> > > anybody filed a ticket with Infra?
> > >
> > > On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela <
> > > raja.pull...@accelerite.com>
> > > wrote:
> > >
> > > > Hi will,
> > > >
> > > > I believe, we didn’t get to close ‘getting a mirror on Apache’
> because
> > we
> > > > needed someone on the Apache Infra side to close this. BTW,
> > > > cloudstack-apt.get.eu (I think Nux manages this?) has all/most of
> the
> > > > content.  Once we can close on the Apache mirror for hosting the
> > > content, I
> > > > can help assist getting the content there.
> > > >
> > > > For now, we have replicated the download.cloud.com content to ‘
> > > > s3.download.accelerite.com’.
> > > > Also, we are working on a set of steps/procedure to help with this
> > > > change.  I will update everyone in about a week’s time on the
> details.
> > > >
> > > > Best,
> > > > Raja Pullela
> > > > Engineering Team,
> > > > Accelerite, 2055 Laurelwood Road,
> > > > Santa Clara, CA, 95054
> > > >
> > > > On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will
> > > > Stevens"  wstev...@cloudops.com>
> > > > wrote:
> > > >
> > > > unfortunately the template mirror conversation got caught up in
> details
> > > and
> > > > nobody took the lead on implementing a solution.
> > > >
> > > > citrix has been pinging me every couple months to say 'dude, we need
> to
> > > > remove the dependency on download.citrix.com', but i have not had
> the
> > > > cycles to get in and solve the problem.  the shutdown of that is
> > imminent
> > > > right now, so we need to solve it asap.
> > > >
> > > >
> > > >
> > > > *Will STEVENS*
> > > > Lead Developer
> > > >
> > > > 
> > > >
> > > > On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus <
> paul.an...@shapeblue.com
> > >
> > > > wrote:
> > > >
> > > > > Hi Nathan,
> > > > >
> > > > > Ideally, if you put the template location in (or use a template
> > defined
> > > > > in)  test_data.py then the actual location can be overridden by
> > anyone
> > > > > testing.
> > > > >
> > > > > For Trillian, we've copied all of the templates that people have
> > define
> > > > to
> > > > > a local repo and then replace the URLs in test_data.py to reduce
> > > > bandwidth
> > > > > use and download times.
> > > > >
> > > > > Ie:
> > > > >
> > > > > "bootableIso":
> > > > > {
> > > > > "displaytext": "Test Bootable ISO",
> > > > > "name": "testISO",
> > > > > "bootable": True,
> > > > > "ispublic": False,
> > > > > "url": "{{ marvin_images_location
> > > > > }}/TinyCore-current.iso",
> > > > > "ostype": 'Other Linux (64-bit)',
> > > > > "mode": 'HTTP_DOWNLOAD'
> > > > > },
> > > > >
> > > > >
> > > > >
> > > > > I thought that we had come up with a solution for
> download.cloud.com
> > ,
> > > by
> > > > > having a mirrorlist hosted in Community Apache 'space' with anyone
> > able
> > > > to
> > > > > out themselves forward 

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
@karuturi This seems to be ready for merge.
It has 2 LGTMs and tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1725
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1949
  
@shwetaag I see some new failures in Travis around component tests, can you 
close and reopen this PR to rekick Travis tests? If Travis fails again, please 
see the failed tests and fix them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@serg38 okay, we can add this to test_data /cc @PaulAngus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1960

[4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

Host-HA offers investigation, fencing and recovery mechanisms for host that 
for
any reason are malfunctioning. It uses Activity and Health checks to 
determine
current host state based on which it may degrade a host or try to recover 
it. On
failing to recover it, it may try to fence the host.

The core feature is implemented in a hypervisor agnostic way, with two 
separate
implementations of the driver/provider for Simulator and KVM hypervisors. 
The
framework also allows for implementation of other hypervisor specific 
provider
implementation in future.

The Host-HA provider implementation for KVM hypervisor uses the out-of-band
management sub-system to issue IPMI calls to reset (recover) or poweroff 
(fence)
a host.

The Host-HA provider implementation for Simulator provides a means of 
testing 
and validating the core framework implementation.

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Host+HA

Signed-off-by: Abhinandan Prateek 
Signed-off-by: Rohit Yadav 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack host-ha-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1960


commit 24ec0dd70a97be738e18cc66a6ec0401edd7f32f
Author: Rohit Yadav 
Date:   2017-02-15T12:06:18Z

CLOUDSTACK-9782: Host HA and KVM HA provider

Host-HA offers investigation, fencing and recovery mechanisms for host that 
for
any reason are malfunctioning. It uses Activity and Health checks to 
determine
current host state based on which it may degrade a host or try to recover 
it. On
failing to recover it, it may try to fence the host.

The core feature is implemented in a hypervisor agnostic way, with two 
separate
implementations of the driver/provider for Simulator and KVM hypervisors. 
The
framework also allows for implementation of other hypervisor specific 
provider
implementation in future.

The Host-HA provider implementation for KVM hypervisor uses the out-of-band
management sub-system to issue IPMI calls to reset (recover) or poweroff 
(fence)
a host.

The Host-HA provider implementation for Simulator provides a means of 
testing
and validating the core framework implementation.

Signed-off-by: Abhinandan Prateek 
Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1960


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
LGTM, @karuturi can this be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1810: CLOUDSTACK-9647: NIC adapter type becomes e1000 , ev...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1810
  
LGTM for code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-538


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-27 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r103154553
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus 
status) throws InsufficientCap
 }
 rootDiskSize = 
Long.parseLong(customParameters.get("rootdisksize"));
 
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
-throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support rootdisksize override");
+// only KVM, XenServer and VMware  supports 
rootdisksize override
+if (!(hypervisorType == HypervisorType.KVM || 
hypervisorType == HypervisorType.XenServer || hypervisorType == 
HypervisorType.VMware)) {
+throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support  rootdisksize override");
--- End diff --

@sureshanaparti both are serving different purpose. Yes, It is intentional. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-27 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov as far as i can see test failures are not happening because 
of this change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-27 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 400
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Will Stevens
so this is what I am looking to do.  Please let me know if you have
suggestions for me or think I should be solving the problem a different way.

- We request a new Github repository from the ASF at:
'apache/cloudstack-mirror-list'
- In this repository we track a text file in the 'gh-pages' branch with a
list of valid download mirrors.
- I build a binary to be hosted by the ASF (or at least with the ASF
pointing a domain at the binary and I could potentially host it).  We will
see how they want to handle the hosting of the binary.

The binary would expose a web server which would behave as follows:
- When the 'client' requests a download url the following flow is kicked
off:
-- The mirror list is queried from github (or from a static site hosted on
asf, as we see fit).
-- The Lat/Lon of the 'client' is determined based on their IP.
-- The Lat/Lon for each of the 'mirror's is determined based on an IP
lookup of the hostname.
-- The closest geographical mirror is determined, the target is validated
to be available and the user is redirected.

Some questions I have right now:
- Will every mirror have the same path structure to access the equivalent
resources?
- Should we support adding a path to the mirror url to specify the path to
the base common path?
-- Example: lets say the binary is hosted on 'dl.acs.com' and there are
three mirrors 'abc.com', 'pqr.com/files' and 'xyx.com/downloads'.
-- If the path being requested is '
dl.acs.com/templates/systemvm-4.6.xen.vhd.bz2', it would result in the
following potential paths for the mirrors:
-- 'abc.com/templates/systemvm-4.6.xen.vhd.bz2'
-- 'pqr.com/files/templates/systemvm-4.6.xen.vhd.bz2'
-- 'xyz.com/downloads/templates/systemvm-4.6.xen.vhd.bz2'

Does this all make sense?

*Will STEVENS*
Lead Developer



On Mon, Feb 27, 2017 at 1:31 PM, Chiradeep Vittal 
wrote:

> My bad. A few lines down, this has been added recently:
>
> this.request.setFollowRedirects(true);
>
> On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens 
> wrote:
>
> > OK. Thanks for the heads up.
> >
> > On Feb 27, 2017 1:08 PM, "Chiradeep Vittal" 
> wrote:
> >
> > > Sounds workable. The downloader code in the SSVM won't follow
> redirects I
> > > think.
> > > https://github.com/apache/cloudstack/blob/
> 5511065fc20787619d9cd0444a65a3
> > > 155fc9c921/core/src/com/cloud/storage/template/
> > > HttpTemplateDownloader.java#L93
> > > https://goo.gl/dSi0r5
> > >  Might need to add
> > > client.setRedirectStrategy(new LaxRedirectStrategy());
> > >
> > > On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens 
> > > wrote:
> > >
> > > > We haven't opened a ticket yet because we don't have a strategy yet.
> > > >
> > > > What do you guys think of this:
> > > > - We setup a new github repo in the 'apache' org which consists of a
> > > single
> > > > file with a list of active/supported mirrors.
> > > > - I write a small web server, distributed as a binary, which can be
> > > hosted
> > > > by ASF Infra.  This web server will query the current list of mirrors
> > and
> > > > will select one and then do a 302 redirect to that mirror.
> > > >
> > > > The act of 'choosing' a mirror could be done in a number of ways.
> > > > - If we want to define an order, then it could just try from the top
> of
> > > the
> > > > list and work its way down.  It would curl the target to make sure it
> > > gets
> > > > a 200 and if it does, it would do a 302 redirect.
> > > > - Or, if we want to distribute the load across the mirrors, we could
> > pick
> > > > from the list randomly.  Again, doing a curl to verify the mirror is
> up
> > > and
> > > > then doing a redirect.
> > > > - If we want to get fancy, we could do a reverse IP lookup and try to
> > > match
> > > > the requester with their closest geographical mirror.
> > > >
> > > > Thoughts?
> > > >
> > > > *Will STEVENS*
> > > > Lead Developer
> > > >
> > > > 
> > > >
> > > > On Mon, Feb 27, 2017 at 12:46 PM, Chiradeep Vittal <
> > chirade...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > What steps are needed to set up a mirror? What does Infra need to
> do?
> > > Has
> > > > > anybody filed a ticket with Infra?
> > > > >
> > > > > On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela <
> > > > > raja.pull...@accelerite.com>
> > > > > wrote:
> > > > >
> > > > > > Hi will,
> > > > > >
> > > > > > I believe, we didn’t get to close ‘getting a mirror on Apache’
> > > because
> > > > we
> > > > > > needed someone on the Apache Infra side to close this. BTW,
> > > > > > cloudstack-apt.get.eu (I think Nux manages this?) has all/most
> of
> > > the
> > > > > > content.  Once we can close on the Apache mirror for hosting the
> > > > > content, I
> > > > > > can help assist getting the content there.
> > > > > >
> > > > > > For now, we have replicated the download.cloud.com content to ‘
> > > > > > s3.download.accelerite.com’.
> > > > > > Also, we are 

[GitHub] cloudstack pull request #1974: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-27 Thread dmabry
GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1974

CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for 
vpcrouter

[BACKPORT PR1954]

moved logrotate from cron.daily to cron.hourly for vpcrouter in 
cloud-early-config. This brings 'vpcrouter' inline with 'router'. We are having 
issues with cloud.log not rotating fast enough, which filled up /var/log and 
ultimately caused the VR to stop functioning in such a way that it prevented 
new VMs from being deployed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack bug/4.9-vpc-vr-logrotate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1974


commit f1ae0d3bdde3317f6be34f09a656b7c50779e3be
Author: David Mabry 
Date:   2017-02-27T20:53:33Z

Backport of PR 1954 [CLOUDSTACK-9795]




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry
Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@rhtyd I have created PRs for 4.8 and 4.9.  They are PR #1973 and PR #1974 
respectively.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1974
  
@dmabry  what about using `git cherry-pick` to introduce the changes that 
were already merged into master in 4.9? Then, we can maintain the same commit 
hash. This would facilitate tracking quite a lot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: GSoC projects

2017-02-27 Thread Syed Ahmed
I've added another project to the list.

CLOUDSTACK-9804 :  Add Cinder as a storage driver to Cloudstack

The idea is to add cinder support for managed storage. Cinder is *The*
platform for doing Software defined storage. Every vendor has plugged in
their device to Cinder. We can run Cinder standalone [1] . This would mean
that once we integrate Cinder, we get all the other storage vendor support
for free, NetApp, HP ... the list is huge [2]

[1] https://gorka.eguileor.com/standalone-cinder/
[2] https://wiki.openstack.org/wiki/CinderSupportMatrix

On Thu, Feb 9, 2017 at 1:38 AM, Rajani Karuturi  wrote:

> I added two:
>
> CLOUDSTACK-8310 - commit to commit db upgrades and db version
> control
>
> CLOUDSTACK-9777 - decouple cloudstack UI
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On February 9, 2017 at 9:12 AM, Rafael Weingärtner
> (rafaelweingart...@gmail.com) wrote:
>
> Hi guys,
> Do you find interesting integrating ACS with OpenID Connect
> identity
> providers?
>
> Today ACS supports SAML; therefore, it can be used in federated
> systems
> that are created using Shibboleth or OpenAM. OpenID Connect is
> an
> alternative to SAML to create federations. Would you like to see
> ACS
> supporting OpenID Connect protocol?
>
> I have been helping two students with their undergraduate
> thesis. They are
> creating an integration between ACS and OpenID Connect protocol
> (it is an
> authentication plugin, like the one created for SAML). It seems
> that this
> could be an interesting opportunity to push this integration
> further and to
> add another competitive advantage to ACS (BTW: OpenStack already
> supports
> OpenId Connect).
>
> I could speak with them and work out their application with this
> proposal.
>
> On Wed, Feb 8, 2017 at 9:57 AM, Rene Moser 
> wrote:
>
> On 02/08/2017 02:46 PM, Syed Ahmed wrote:
>
> I want to propose another topic to relplace our old and crummy
> console
>
> with
>
> a NoVNC console. Long time ago I developed a prototype and the
> results
>
> were
>
> very promising [2]. I have opened a JIRA ticket for this as well
> [1]
>
> That would be AWESOME!
>
> --
> Rafael Weingärtner
>


Re: Modern template hosting

2017-02-27 Thread Will Stevens
@rafael: Yes, I think it makes sense to support sub-paths.  It will make
things a lot easier to work with.  The security question is an interesting
one.  I am not sure I would be the best person to answer that.  I would say
that we would want to have the MD5s hosted in the same repo as the mirror
list urls.

I do like the idea of running a web server on the management server for
hosting the system vms though.  It could be used to populate secondary
storage and could potentially give operators an easier (more efficient?)
workflow for introducing new templates.  That area could use some work...

*Will STEVENS*
Lead Developer



On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal 
wrote:

> Hashes are checked (md5 IIRC) today.
> But given the issues, I think the project should steer away from hosting
> templates except the systemvm template.
>
> On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > Will, I think we could support different path structures. This can
> > facilitate different deployment of mirrors based on the structure the
> host
> > has.
> >
> > Could I add something else to the discussion? Have we discussed the
> > security impacts of setting up this mirrors approach?
> > I mean, if any of the mirrors gets corrupted (let`s say by a hacker), and
> > the templates are injected with malicious code, an attacker could
> > potentially get un-monitored and unlimited access to a cloud environment.
> >
> > If we assume that the mirror may get malicious (it is not that I do not
> > trust you guys, but bad things happen), we cannot host hashes there.
> Where
> > do you think we could store Sha512 or another hash type for these
> > templates? Could we host in the newly proposed Github repo or maybe some
> > place in the ACS website?
> >
> > This would have an impact on clients (needing clear documentation) and
> our
> > code that automatically downloads System VM templates (does it check
> hashes
> > when automatically installing templates today? It may require
> > implementation changes).
> >
> > On Mon, Feb 27, 2017 at 3:48 PM, Will Stevens 
> > wrote:
> >
> > > so this is what I am looking to do.  Please let me know if you have
> > > suggestions for me or think I should be solving the problem a different
> > > way.
> > >
> > > - We request a new Github repository from the ASF at:
> > > 'apache/cloudstack-mirror-list'
> > > - In this repository we track a text file in the 'gh-pages' branch
> with a
> > > list of valid download mirrors.
> > > - I build a binary to be hosted by the ASF (or at least with the ASF
> > > pointing a domain at the binary and I could potentially host it).  We
> > will
> > > see how they want to handle the hosting of the binary.
> > >
> > > The binary would expose a web server which would behave as follows:
> > > - When the 'client' requests a download url the following flow is
> kicked
> > > off:
> > > -- The mirror list is queried from github (or from a static site hosted
> > on
> > > asf, as we see fit).
> > > -- The Lat/Lon of the 'client' is determined based on their IP.
> > > -- The Lat/Lon for each of the 'mirror's is determined based on an IP
> > > lookup of the hostname.
> > > -- The closest geographical mirror is determined, the target is
> validated
> > > to be available and the user is redirected.
> > >
> > > Some questions I have right now:
> > > - Will every mirror have the same path structure to access the
> equivalent
> > > resources?
> > > - Should we support adding a path to the mirror url to specify the path
> > to
> > > the base common path?
> > > -- Example: lets say the binary is hosted on 'dl.acs.com' and there
> are
> > > three mirrors 'abc.com', 'pqr.com/files' and 'xyx.com/downloads'.
> > > -- If the path being requested is '
> > > dl.acs.com/templates/systemvm-4.6.xen.vhd.bz2', it would result in the
> > > following potential paths for the mirrors:
> > > -- 'abc.com/templates/systemvm-4.6.xen.vhd.bz2'
> > > -- 'pqr.com/files/templates/systemvm-4.6.xen.vhd.bz2'
> > > -- 'xyz.com/downloads/templates/systemvm-4.6.xen.vhd.bz2'
> > >
> > > Does this all make sense?
> > >
> > > *Will STEVENS*
> > > Lead Developer
> > >
> > > 
> > >
> > > On Mon, Feb 27, 2017 at 1:31 PM, Chiradeep Vittal <
> chirade...@gmail.com>
> > > wrote:
> > >
> > > > My bad. A few lines down, this has been added recently:
> > > >
> > > > this.request.setFollowRedirects(true);
> > > >
> > > > On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens <
> > williamstev...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > OK. Thanks for the heads up.
> > > > >
> > > > > On Feb 27, 2017 1:08 PM, "Chiradeep Vittal" 
> > > > wrote:
> > > > >
> > > > > > Sounds workable. The downloader code in the SSVM won't follow
> > > > redirects I
> > > > > > think.
> > > > > > https://github.com/apache/cloudstack/blob/
> > > > 5511065fc20787619d9cd0444a65a3
> > > 

Re: Modern template hosting

2017-02-27 Thread Will Stevens
I think we almost need a two pronged approach.

1) Get a solution in place which will enable us to document and serve
templates for legacy systems.  I will work on this.
2) Discuss and understand how we SHOULD be handling this problem in the
future and in what release we can expect it.

I think we need to do both.  I think we should start to try to really
understand what we want to deliver in (2) going forward.

*Will STEVENS*
Lead Developer



On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> My worry is exactly with system VMs templates.
>
> Currently, we indicate administrators to download them from
> http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the installation
> docs do not mention the expected hashes for the file that is going to be
> downloaded.
> Also, I do not know the code that downloads system VMs templates (when
> upgrading), but if the hash being checked is taken from the mirror used to
> download the file; the only thing it checks is that if the download
> finished successfully (no transmission errors). If we want to check
> integrity, check that the template we created is untampered; we need to
> host and serve the hash in a secure manner.
>
> [1]
> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.9/
> management-server/index.html#prepare-the-system-vm-template
>
>
> On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal 
> wrote:
>
> > Hashes are checked (md5 IIRC) today.
> > But given the issues, I think the project should steer away from hosting
> > templates except the systemvm template.
> >
> > On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com> wrote:
> >
> > > Will, I think we could support different path structures. This can
> > > facilitate different deployment of mirrors based on the structure the
> > host
> > > has.
> > >
> > > Could I add something else to the discussion? Have we discussed the
> > > security impacts of setting up this mirrors approach?
> > > I mean, if any of the mirrors gets corrupted (let`s say by a hacker),
> and
> > > the templates are injected with malicious code, an attacker could
> > > potentially get un-monitored and unlimited access to a cloud
> environment.
> > >
> > > If we assume that the mirror may get malicious (it is not that I do not
> > > trust you guys, but bad things happen), we cannot host hashes there.
> > Where
> > > do you think we could store Sha512 or another hash type for these
> > > templates? Could we host in the newly proposed Github repo or maybe
> some
> > > place in the ACS website?
> > >
> > > This would have an impact on clients (needing clear documentation) and
> > our
> > > code that automatically downloads System VM templates (does it check
> > hashes
> > > when automatically installing templates today? It may require
> > > implementation changes).
> > >
> > > On Mon, Feb 27, 2017 at 3:48 PM, Will Stevens 
> > > wrote:
> > >
> > > > so this is what I am looking to do.  Please let me know if you have
> > > > suggestions for me or think I should be solving the problem a
> different
> > > > way.
> > > >
> > > > - We request a new Github repository from the ASF at:
> > > > 'apache/cloudstack-mirror-list'
> > > > - In this repository we track a text file in the 'gh-pages' branch
> > with a
> > > > list of valid download mirrors.
> > > > - I build a binary to be hosted by the ASF (or at least with the ASF
> > > > pointing a domain at the binary and I could potentially host it).  We
> > > will
> > > > see how they want to handle the hosting of the binary.
> > > >
> > > > The binary would expose a web server which would behave as follows:
> > > > - When the 'client' requests a download url the following flow is
> > kicked
> > > > off:
> > > > -- The mirror list is queried from github (or from a static site
> hosted
> > > on
> > > > asf, as we see fit).
> > > > -- The Lat/Lon of the 'client' is determined based on their IP.
> > > > -- The Lat/Lon for each of the 'mirror's is determined based on an IP
> > > > lookup of the hostname.
> > > > -- The closest geographical mirror is determined, the target is
> > validated
> > > > to be available and the user is redirected.
> > > >
> > > > Some questions I have right now:
> > > > - Will every mirror have the same path structure to access the
> > equivalent
> > > > resources?
> > > > - Should we support adding a path to the mirror url to specify the
> path
> > > to
> > > > the base common path?
> > > > -- Example: lets say the binary is hosted on 'dl.acs.com' and there
> > are
> > > > three mirrors 'abc.com', 'pqr.com/files' and 'xyx.com/downloads'.
> > > > -- If the path being requested is '
> > > > dl.acs.com/templates/systemvm-4.6.xen.vhd.bz2', it would result in
> the
> > > > following potential paths for the mirrors:
> > > > -- 'abc.com/templates/systemvm-4.6.xen.vhd.bz2'
> > > > -- 

Re: Modern template hosting

2017-02-27 Thread Rafael Weingärtner
Agree with you.
We need to support the current working flow. And then, define the first
version that will start using the new approach.

On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens  wrote:

> I think we almost need a two pronged approach.
>
> 1) Get a solution in place which will enable us to document and serve
> templates for legacy systems.  I will work on this.
> 2) Discuss and understand how we SHOULD be handling this problem in the
> future and in what release we can expect it.
>
> I think we need to do both.  I think we should start to try to really
> understand what we want to deliver in (2) going forward.
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > My worry is exactly with system VMs templates.
> >
> > Currently, we indicate administrators to download them from
> > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> installation
> > docs do not mention the expected hashes for the file that is going to be
> > downloaded.
> > Also, I do not know the code that downloads system VMs templates (when
> > upgrading), but if the hash being checked is taken from the mirror used
> to
> > download the file; the only thing it checks is that if the download
> > finished successfully (no transmission errors). If we want to check
> > integrity, check that the template we created is untampered; we need to
> > host and serve the hash in a secure manner.
> >
> > [1]
> > http://docs.cloudstack.apache.org/projects/cloudstack-
> installation/en/4.9/
> > management-server/index.html#prepare-the-system-vm-template
> >
> >
> > On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal 
> > wrote:
> >
> > > Hashes are checked (md5 IIRC) today.
> > > But given the issues, I think the project should steer away from
> hosting
> > > templates except the systemvm template.
> > >
> > > On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
> > > rafaelweingart...@gmail.com> wrote:
> > >
> > > > Will, I think we could support different path structures. This can
> > > > facilitate different deployment of mirrors based on the structure the
> > > host
> > > > has.
> > > >
> > > > Could I add something else to the discussion? Have we discussed the
> > > > security impacts of setting up this mirrors approach?
> > > > I mean, if any of the mirrors gets corrupted (let`s say by a hacker),
> > and
> > > > the templates are injected with malicious code, an attacker could
> > > > potentially get un-monitored and unlimited access to a cloud
> > environment.
> > > >
> > > > If we assume that the mirror may get malicious (it is not that I do
> not
> > > > trust you guys, but bad things happen), we cannot host hashes there.
> > > Where
> > > > do you think we could store Sha512 or another hash type for these
> > > > templates? Could we host in the newly proposed Github repo or maybe
> > some
> > > > place in the ACS website?
> > > >
> > > > This would have an impact on clients (needing clear documentation)
> and
> > > our
> > > > code that automatically downloads System VM templates (does it check
> > > hashes
> > > > when automatically installing templates today? It may require
> > > > implementation changes).
> > > >
> > > > On Mon, Feb 27, 2017 at 3:48 PM, Will Stevens  >
> > > > wrote:
> > > >
> > > > > so this is what I am looking to do.  Please let me know if you have
> > > > > suggestions for me or think I should be solving the problem a
> > different
> > > > > way.
> > > > >
> > > > > - We request a new Github repository from the ASF at:
> > > > > 'apache/cloudstack-mirror-list'
> > > > > - In this repository we track a text file in the 'gh-pages' branch
> > > with a
> > > > > list of valid download mirrors.
> > > > > - I build a binary to be hosted by the ASF (or at least with the
> ASF
> > > > > pointing a domain at the binary and I could potentially host it).
> We
> > > > will
> > > > > see how they want to handle the hosting of the binary.
> > > > >
> > > > > The binary would expose a web server which would behave as follows:
> > > > > - When the 'client' requests a download url the following flow is
> > > kicked
> > > > > off:
> > > > > -- The mirror list is queried from github (or from a static site
> > hosted
> > > > on
> > > > > asf, as we see fit).
> > > > > -- The Lat/Lon of the 'client' is determined based on their IP.
> > > > > -- The Lat/Lon for each of the 'mirror's is determined based on an
> IP
> > > > > lookup of the hostname.
> > > > > -- The closest geographical mirror is determined, the target is
> > > validated
> > > > > to be available and the user is redirected.
> > > > >
> > > > > Some questions I have right now:
> > > > > - Will every mirror have the same path structure to access the
> > > equivalent
> > > > > resources?
> > > > > - Should we support adding a path to the mirror url to specify the
> > path
> > > > to
> > > 

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-27 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1962
  
@syed Yes, I can include you as a reviewer for the relevant PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-27 Thread Rafael Weingärtner
Will, I think we could support different path structures. This can
facilitate different deployment of mirrors based on the structure the host
has.

Could I add something else to the discussion? Have we discussed the
security impacts of setting up this mirrors approach?
I mean, if any of the mirrors gets corrupted (let`s say by a hacker), and
the templates are injected with malicious code, an attacker could
potentially get un-monitored and unlimited access to a cloud environment.

If we assume that the mirror may get malicious (it is not that I do not
trust you guys, but bad things happen), we cannot host hashes there. Where
do you think we could store Sha512 or another hash type for these
templates? Could we host in the newly proposed Github repo or maybe some
place in the ACS website?

This would have an impact on clients (needing clear documentation) and our
code that automatically downloads System VM templates (does it check hashes
when automatically installing templates today? It may require
implementation changes).

On Mon, Feb 27, 2017 at 3:48 PM, Will Stevens  wrote:

> so this is what I am looking to do.  Please let me know if you have
> suggestions for me or think I should be solving the problem a different
> way.
>
> - We request a new Github repository from the ASF at:
> 'apache/cloudstack-mirror-list'
> - In this repository we track a text file in the 'gh-pages' branch with a
> list of valid download mirrors.
> - I build a binary to be hosted by the ASF (or at least with the ASF
> pointing a domain at the binary and I could potentially host it).  We will
> see how they want to handle the hosting of the binary.
>
> The binary would expose a web server which would behave as follows:
> - When the 'client' requests a download url the following flow is kicked
> off:
> -- The mirror list is queried from github (or from a static site hosted on
> asf, as we see fit).
> -- The Lat/Lon of the 'client' is determined based on their IP.
> -- The Lat/Lon for each of the 'mirror's is determined based on an IP
> lookup of the hostname.
> -- The closest geographical mirror is determined, the target is validated
> to be available and the user is redirected.
>
> Some questions I have right now:
> - Will every mirror have the same path structure to access the equivalent
> resources?
> - Should we support adding a path to the mirror url to specify the path to
> the base common path?
> -- Example: lets say the binary is hosted on 'dl.acs.com' and there are
> three mirrors 'abc.com', 'pqr.com/files' and 'xyx.com/downloads'.
> -- If the path being requested is '
> dl.acs.com/templates/systemvm-4.6.xen.vhd.bz2', it would result in the
> following potential paths for the mirrors:
> -- 'abc.com/templates/systemvm-4.6.xen.vhd.bz2'
> -- 'pqr.com/files/templates/systemvm-4.6.xen.vhd.bz2'
> -- 'xyz.com/downloads/templates/systemvm-4.6.xen.vhd.bz2'
>
> Does this all make sense?
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 27, 2017 at 1:31 PM, Chiradeep Vittal 
> wrote:
>
> > My bad. A few lines down, this has been added recently:
> >
> > this.request.setFollowRedirects(true);
> >
> > On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens  >
> > wrote:
> >
> > > OK. Thanks for the heads up.
> > >
> > > On Feb 27, 2017 1:08 PM, "Chiradeep Vittal" 
> > wrote:
> > >
> > > > Sounds workable. The downloader code in the SSVM won't follow
> > redirects I
> > > > think.
> > > > https://github.com/apache/cloudstack/blob/
> > 5511065fc20787619d9cd0444a65a3
> > > > 155fc9c921/core/src/com/cloud/storage/template/
> > > > HttpTemplateDownloader.java#L93
> > > > https://goo.gl/dSi0r5
> > > >  Might need to add
> > > > client.setRedirectStrategy(new LaxRedirectStrategy());
> > > >
> > > > On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens  >
> > > > wrote:
> > > >
> > > > > We haven't opened a ticket yet because we don't have a strategy
> yet.
> > > > >
> > > > > What do you guys think of this:
> > > > > - We setup a new github repo in the 'apache' org which consists of
> a
> > > > single
> > > > > file with a list of active/supported mirrors.
> > > > > - I write a small web server, distributed as a binary, which can be
> > > > hosted
> > > > > by ASF Infra.  This web server will query the current list of
> mirrors
> > > and
> > > > > will select one and then do a 302 redirect to that mirror.
> > > > >
> > > > > The act of 'choosing' a mirror could be done in a number of ways.
> > > > > - If we want to define an order, then it could just try from the
> top
> > of
> > > > the
> > > > > list and work its way down.  It would curl the target to make sure
> it
> > > > gets
> > > > > a 200 and if it does, it would do a 302 redirect.
> > > > > - Or, if we want to distribute the load across the mirrors, we
> could
> > > pick
> > > > > from the list randomly.  Again, doing a curl to verify the mirror
> is
> > up

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
Hashes are checked (md5 IIRC) today.
But given the issues, I think the project should steer away from hosting
templates except the systemvm template.

On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Will, I think we could support different path structures. This can
> facilitate different deployment of mirrors based on the structure the host
> has.
>
> Could I add something else to the discussion? Have we discussed the
> security impacts of setting up this mirrors approach?
> I mean, if any of the mirrors gets corrupted (let`s say by a hacker), and
> the templates are injected with malicious code, an attacker could
> potentially get un-monitored and unlimited access to a cloud environment.
>
> If we assume that the mirror may get malicious (it is not that I do not
> trust you guys, but bad things happen), we cannot host hashes there. Where
> do you think we could store Sha512 or another hash type for these
> templates? Could we host in the newly proposed Github repo or maybe some
> place in the ACS website?
>
> This would have an impact on clients (needing clear documentation) and our
> code that automatically downloads System VM templates (does it check hashes
> when automatically installing templates today? It may require
> implementation changes).
>
> On Mon, Feb 27, 2017 at 3:48 PM, Will Stevens 
> wrote:
>
> > so this is what I am looking to do.  Please let me know if you have
> > suggestions for me or think I should be solving the problem a different
> > way.
> >
> > - We request a new Github repository from the ASF at:
> > 'apache/cloudstack-mirror-list'
> > - In this repository we track a text file in the 'gh-pages' branch with a
> > list of valid download mirrors.
> > - I build a binary to be hosted by the ASF (or at least with the ASF
> > pointing a domain at the binary and I could potentially host it).  We
> will
> > see how they want to handle the hosting of the binary.
> >
> > The binary would expose a web server which would behave as follows:
> > - When the 'client' requests a download url the following flow is kicked
> > off:
> > -- The mirror list is queried from github (or from a static site hosted
> on
> > asf, as we see fit).
> > -- The Lat/Lon of the 'client' is determined based on their IP.
> > -- The Lat/Lon for each of the 'mirror's is determined based on an IP
> > lookup of the hostname.
> > -- The closest geographical mirror is determined, the target is validated
> > to be available and the user is redirected.
> >
> > Some questions I have right now:
> > - Will every mirror have the same path structure to access the equivalent
> > resources?
> > - Should we support adding a path to the mirror url to specify the path
> to
> > the base common path?
> > -- Example: lets say the binary is hosted on 'dl.acs.com' and there are
> > three mirrors 'abc.com', 'pqr.com/files' and 'xyx.com/downloads'.
> > -- If the path being requested is '
> > dl.acs.com/templates/systemvm-4.6.xen.vhd.bz2', it would result in the
> > following potential paths for the mirrors:
> > -- 'abc.com/templates/systemvm-4.6.xen.vhd.bz2'
> > -- 'pqr.com/files/templates/systemvm-4.6.xen.vhd.bz2'
> > -- 'xyz.com/downloads/templates/systemvm-4.6.xen.vhd.bz2'
> >
> > Does this all make sense?
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Mon, Feb 27, 2017 at 1:31 PM, Chiradeep Vittal 
> > wrote:
> >
> > > My bad. A few lines down, this has been added recently:
> > >
> > > this.request.setFollowRedirects(true);
> > >
> > > On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens <
> williamstev...@gmail.com
> > >
> > > wrote:
> > >
> > > > OK. Thanks for the heads up.
> > > >
> > > > On Feb 27, 2017 1:08 PM, "Chiradeep Vittal" 
> > > wrote:
> > > >
> > > > > Sounds workable. The downloader code in the SSVM won't follow
> > > redirects I
> > > > > think.
> > > > > https://github.com/apache/cloudstack/blob/
> > > 5511065fc20787619d9cd0444a65a3
> > > > > 155fc9c921/core/src/com/cloud/storage/template/
> > > > > HttpTemplateDownloader.java#L93
> > > > > https://goo.gl/dSi0r5
> > > > >  Might need to add
> > > > > client.setRedirectStrategy(new LaxRedirectStrategy());
> > > > >
> > > > > On Mon, Feb 27, 2017 at 9:57 AM, Will Stevens <
> wstev...@cloudops.com
> > >
> > > > > wrote:
> > > > >
> > > > > > We haven't opened a ticket yet because we don't have a strategy
> > yet.
> > > > > >
> > > > > > What do you guys think of this:
> > > > > > - We setup a new github repo in the 'apache' org which consists
> of
> > a
> > > > > single
> > > > > > file with a list of active/supported mirrors.
> > > > > > - I write a small web server, distributed as a binary, which can
> be
> > > > > hosted
> > > > > > by ASF Infra.  This web server will query the current list of
> > mirrors
> > > > and
> > > > > > will select one and then do a 302 redirect to that mirror.
> > > > > >
> > > > > > The act of 

[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1973
  
@dmabry as I posted on the other PR, I only suggested `git cherry-pick` 
because I thought it would preserve the commit hash. It was a misunderstanding 
from me. The git hash is generated based on parent commit as well as other bits 
of information. Therefore, even when using `git cherry-pick` the hash of 
commits between branches will always be different (unless a hash collision 
happens). 

The `git cherry-pick` is quite useful when you have to apply a bunch of 
changes, but in your case, I do not think you need it. The way you did before 
was ok.

BTW: I think a single commit to introduce these changes is enough ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   >