Re: [PR] Improves service offering resource [cloudstack-terraform-provider]
vishesh92 merged PR #64: URL: https://github.com/apache/cloudstack-terraform-provider/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup acceptance tests [cloudstack-terraform-provider]
vishesh92 commented on PR #96: URL: https://github.com/apache/cloudstack-terraform-provider/pull/96#issuecomment-1980998466 > ``` > === RUN TestAccCloudStackKubernetesVersion_basic > testing.go:568: Step 0 error: errors during apply: > > Error: CloudStack API error 401 (CSExceptionErrorCode: 0): unable to verify user credentials and/or request signature > > on /tmp/tf-test3270280120/main.tf line 2: > (source code not available) > > > --- FAIL: TestAccCloudStackKubernetesVersion_basic (0.02s) > === RUN TestAccCloudStackKubernetesVersion_update > testing.go:568: Step 0 error: errors during apply: > > Error: CloudStack API error 401 (CSExceptionErrorCode: 0): unable to verify user credentials and/or request signature > > on /tmp/tf-test3546500911/main.tf line 2: > (source code not available) > > > --- FAIL: TestAccCloudStackKubernetesVersion_update (0.02s) > ``` This is failing because CKS is disabled by default on older versions. It should work for 4.19. Other runs shouldn't have got canceled. Let me fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/go-ini/ini from 1.40.0 to 1.67.0 [cloudstack-terraform-provider]
rohityadavcloud commented on PR #94: URL: https://github.com/apache/cloudstack-terraform-provider/pull/94#issuecomment-1980984848 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
rohityadavcloud merged PR #83: URL: https://github.com/apache/cloudstack-terraform-provider/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 [cloudstack-terraform-provider]
rohityadavcloud closed pull request #93: Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 URL: https://github.com/apache/cloudstack-terraform-provider/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 [cloudstack-terraform-provider]
dependabot[bot] commented on PR #93: URL: https://github.com/apache/cloudstack-terraform-provider/pull/93#issuecomment-1980984141 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/go-ini/ini from 1.40.0 to 1.67.0 [cloudstack-terraform-provider]
dependabot[bot] commented on PR #94: URL: https://github.com/apache/cloudstack-terraform-provider/pull/94#issuecomment-1980984984 Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup acceptance tests [cloudstack-terraform-provider]
rohityadavcloud commented on PR #96: URL: https://github.com/apache/cloudstack-terraform-provider/pull/96#issuecomment-1980982689 ``` === RUN TestAccCloudStackKubernetesVersion_basic testing.go:568: Step 0 error: errors during apply: Error: CloudStack API error 401 (CSExceptionErrorCode: 0): unable to verify user credentials and/or request signature on /tmp/tf-test3270280120/main.tf line 2: (source code not available) --- FAIL: TestAccCloudStackKubernetesVersion_basic (0.02s) === RUN TestAccCloudStackKubernetesVersion_update testing.go:568: Step 0 error: errors during apply: Error: CloudStack API error 401 (CSExceptionErrorCode: 0): unable to verify user credentials and/or request signature on /tmp/tf-test3546500911/main.tf line 2: (source code not available) --- FAIL: TestAccCloudStackKubernetesVersion_update (0.02s) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/hashicorp/go-multierror from 1.0.0 to 1.1.1 [cloudstack-terraform-provider]
rohityadavcloud merged PR #95: URL: https://github.com/apache/cloudstack-terraform-provider/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow connecting network ACL to a (VPC) network according API specs [cloudstack-terraform-provider]
vishesh92 commented on issue #28: URL: https://github.com/apache/cloudstack-terraform-provider/issues/28#issuecomment-1982725696 @synergiator `resource_cloudstack_network_acl` is actually a network ACL list. And resource_cloudstack_network_acl_rule is the network ACL. Network ACL requires a aclid (ACL List's uuid). If you don't pass aclid and pass network id, cloudstack will check if the network has a VPC and checks for existing acl id. If it doesn't find one, it creates a new ACL list and use that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] next version 20 instead of 4.20
I think we will (and have) changed APIs and dropped plugin support in major versions with at least a deprecation period. this is exactly the reason I now (finally) proposed we should drop the 4 and proceed with regarding the second number as the primary version. Semantic versioning is well defined as a three number scheme that we follow otherwise. this is also how https://semver.org/ defines it. Our only difference with that is that we do not allow backwards compatible feature added in major versions, which we could decide to do or don't independent of whether we drop the 4 or not. I agree that we could codify our protocol first. On Wed, Mar 6, 2024 at 5:54 AM Rohit Yadav wrote: > > Daniel, Daan, others, > > Could you explain why you’d break CloudStack’s rest-like APIs? Isn’t the > intention of dropping the 4. as we may never see a 5.x that involves major > changes involving API incompatibility? > > Regards. > > > > > From: Guto Veronezi > Sent: Wednesday, March 6, 2024 4:00:30 AM > To: dev@cloudstack.apache.org > Subject: Re: [VOTE] next version 20 instead of 4.20 > > > By agreeing to drop the "4" I think we're effectively voting and agreeing > > that we'll not be breaking APIs. > That is not what was discussed in the thread [1]. If we agree that we > will not break APIs, I am -1 on dropping the "4". We need to create a > protocol along with the proposal, otherwise, we will be subjective about > the topic and will be agreeing on something for different reasons. > > [1] https://lists.apache.org/thread/yxxjzov5dqrfsogth6kcq2r0wn8rzljv > > On 3/5/24 15:10, Paul Angus wrote: > > Hi Rohit, thank you > > > > So to recap; > > > > Semantic versioning goes (in our use): > > . . . > > > > > > And as I understand it you're looking to go > > > > . . > > Starting from 20 > > > > I'd ask the question - are there any big/disruptive changes people would > > want to bundle together to keep the semantic versioning and move to 5.x.y.z > > > > I'm assuming not, so the move proposed is to drop semantic versioning and > > continue from 20, understanding that we would lose the mechanism to warn of > > very disruptive changes (for what it's worth). > > > > I've no objection to it. The issue was, that reading the thread, people > > had different takes on what the change was, what would it do and what it > > meant. And also incorrect understandings of semantic versioning. > > > > So, to be pedantic, and have a clearly defined vote, I'd change the vote to > > something like "Drop semantic versioning and continue from 20". And > > include your explanation about moving to > > . . > > > > I would be ok to +1 that ^^^ > > > > -paul > > > > -Original Message- > > From: Rohit Yadav > > Sent: Tuesday, March 5, 2024 4:02 PM > > To: dev@cloudstack.apache.org; us...@cloudstack.apache.org > > Subject: Re: [VOTE] next version 20 instead of 4.20 > > > > As I understand Daan's vote proposal and from the previous discussion > > thread, the current scheme that results in a release like 4.20.x.y would > > simply become 20.a.b, wherein "a" is for maintenance release (counter, > > starting with 0) and "b" is only used for security releases (counter, > > starting with 0). > > > > The voting thread is about "deciding to drop the 4 from our versioning > > scheme", wherein the next CloudStack version would become "20" instead of > > "4.20". By agreeing to drop the "4" I think we're effectively voting and > > agreeing that we'll not be breaking APIs. Some other opensource projects > > have done something similar too. Of course, this needs to be properly > > explained and documented both by a blog article and on the project wiki. > > > > Paul - are you satisfied with the explanations and discussions, are you > > still blocking this vote thead or do you want to reconsider your vote? > > > > > > Regards. > > > > > > > > > > > > From: Paul Angus > > Sent: Tuesday, February 20, 2024 15:55 > > To: dev@cloudstack.apache.org > > Cc: us...@cloudstack.apache.org > > Subject: RE: [VOTE] next version 20 instead of 4.20 > > > > Hi Daan, > > > > > > From our wiki page: > > > > -- Quote > > For those that may not be familiar with Semantic Versioning, the number > > format is: X.Y.Z, where X is the major version, Y is the minor version, Z > > is the patch number. The community strives to ensure backward API > > compatibility within each major version (i.e.: code written against the > > CloudStack 4.0.0-incubating API should work with all future 4.y.z > > versions). The community may decide to increment the major version number > > in situations where underlying implementation details require a cloud > > operator to face significant challenges in upgrading from one version to > > the next. This should be rare situation. > > > > In practice, feature releases will normally be an increment of the minor > > version number of the project. Feature
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
vishesh92 commented on code in PR #83:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/83#discussion_r1514083157
##
cloudstack/resource_cloudstack_instance.go:
##
@@ -277,6 +283,11 @@ func resourceCloudStackInstanceCreate(d
*schema.ResourceData, meta interface{})
p.SetRootdisksize(int64(rootdisksize.(int)))
}
+ if d.Get("uefi").(bool) {
+ p.SetBoottype("UEFI")
+ p.SetBootmode("Legacy")
Review Comment:
@rohityadavcloud Is this fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Adds dependabot [cloudstack-terraform-provider]
rohityadavcloud merged PR #70: URL: https://github.com/apache/cloudstack-terraform-provider/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add Override root disk offering and Disk Offerings to cloudstack_instance Resource [cloudstack-terraform-provider]
vishesh92 commented on issue #68: URL: https://github.com/apache/cloudstack-terraform-provider/issues/68#issuecomment-1980423213 Had a discussion with @kiranchavala. This requires go SDK to be upgraded. Changed the milestone to v0.6.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 [cloudstack-terraform-provider]
dependabot[bot] opened a new pull request, #93:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/93
Bumps
[github.com/apache/cloudstack-go/v2](https://github.com/apache/cloudstack-go)
from 2.13.2 to 2.15.0.
Release notes
Sourced from https://github.com/apache/cloudstack-go/releases;>github.com/apache/cloudstack-go/v2's
releases.
v2.15.0
Support for Apache Cloudstack 4.18
Full changelog: https://github.com/apache/cloudstack-go/compare/v2.14.0...v2.15.0;>https://github.com/apache/cloudstack-go/compare/v2.14.0...v2.15.0
v2.14.0
Support for Apache Cloudstack 4.17
Fixes around APIs support, value encoding, and generate
Full changelog: https://github.com/apache/cloudstack-go/compare/v2.13.2...v2.14.0;>https://github.com/apache/cloudstack-go/compare/v2.13.2...v2.14.0
Commits
https://github.com/apache/cloudstack-go/commit/3995b5eee381ddcce7a8be7ca9b491f7b9ca0c12;>3995b5e
4.18 support changes (https://redirect.github.com/apache/cloudstack-go/issues/53;>#53)
https://github.com/apache/cloudstack-go/commit/f4cfaae2c11c510f4871ffe20a4b96b14633963d;>f4cfaae
Add ACS 4.17 support (https://redirect.github.com/apache/cloudstack-go/issues/38;>#38)
https://github.com/apache/cloudstack-go/commit/00518763325b6594ce198ae034f172d444cec21d;>0051876
Implement resourceiconresponse as interface{} (https://redirect.github.com/apache/cloudstack-go/issues/45;>#45)
https://github.com/apache/cloudstack-go/commit/5b49469f93181c5de579856b4eae087a7961c9a3;>5b49469
Do value encoding in EncodeValues, add tests (https://redirect.github.com/apache/cloudstack-go/issues/52;>#52)
https://github.com/apache/cloudstack-go/commit/275fbdc62a98398c09f95e1cc5141ea5a3bac666;>275fbdc
Merge pull request https://redirect.github.com/apache/cloudstack-go/issues/47;>#47 from
mp-forks/resetconfiguration
https://github.com/apache/cloudstack-go/commit/0106fc79c6b1031ad6d7c89a157ba8a77f6c8afe;>0106fc7
generate: fix error when goimports not found (https://redirect.github.com/apache/cloudstack-go/issues/50;>#50)
https://github.com/apache/cloudstack-go/commit/1cd3965ca40dc316dc73c04f0f60752863324502;>1cd3965
Generate account details correctly (accountdetails[0].somekey=someval) (https://redirect.github.com/apache/cloudstack-go/issues/46;>#46)
https://github.com/apache/cloudstack-go/commit/9bf003bf8fb50be38fe2250e7124fdd4cd893786;>9bf003b
added resetconfigurationresponse
https://github.com/apache/cloudstack-go/commit/a5f7e1afa6ee5abb21d67388c52eb2437aff80bb;>a5f7e1a
Adding resetconfiguration api support
https://github.com/apache/cloudstack-go/commit/020871fc7e60a602f2ad7f9687be4ee9aeebe29d;>020871f
Fix registerTemplate/updateTemplate details map (https://redirect.github.com/apache/cloudstack-go/issues/44;>#44)
Additional commits viewable in https://github.com/apache/cloudstack-go/compare/v2.13.2...v2.15.0;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it.
You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of
the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the PR or
upgrade to it yourself)
--
This is an automated message from the Apache Git Service.
To respond to the
[PR] Bump github.com/go-ini/ini from 1.40.0 to 1.67.0 [cloudstack-terraform-provider]
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/cloudstack-terraform-provider/pull/94 Bumps [github.com/go-ini/ini](https://github.com/go-ini/ini) from 1.40.0 to 1.67.0. Release notes Sourced from https://github.com/go-ini/ini/releases;>github.com/go-ini/ini's releases. 1.67.0 What's Changed ini: allow changing the default section name by https://github.com/jade-clarke;>@jade-clarke in https://redirect.github.com/go-ini/ini/pull/319;>go-ini/ini#319 New Contributors https://github.com/jade-clarke;>@jade-clarke made their first contribution in https://redirect.github.com/go-ini/ini/pull/319;>go-ini/ini#319 Full Changelog: https://github.com/go-ini/ini/compare/v1.66.6...v1.67.0;>https://github.com/go-ini/ini/compare/v1.66.6...v1.67.0 1.66.6 What's Changed parser: fix line skipping when key is empty by https://github.com/gandarez;>@gandarez in https://redirect.github.com/go-ini/ini/pull/323;>go-ini/ini#323 Full Changelog: https://github.com/go-ini/ini/compare/v1.66.5...v1.66.6;>https://github.com/go-ini/ini/compare/v1.66.5...v1.66.6 1.66.5 What's Changed write: pretty print section only if it is not the last one by https://github.com/danilo-gemoli;>@danilo-gemoli in https://redirect.github.com/go-ini/ini/pull/321;>go-ini/ini#321 New Contributors https://github.com/danilo-gemoli;>@danilo-gemoli made their first contribution in https://redirect.github.com/go-ini/ini/pull/321;>go-ini/ini#321 Full Changelog: https://github.com/go-ini/ini/compare/v1.66.4...v1.66.5;>https://github.com/go-ini/ini/compare/v1.66.4...v1.66.5 1.66.4 What's Changed key: ignore empty values in ValueWithShadows by https://github.com/unknwon;>@unknwon in https://redirect.github.com/go-ini/ini/pull/316;>go-ini/ini#316 Full Changelog: https://github.com/go-ini/ini/compare/v1.66.3...v1.66.4;>https://github.com/go-ini/ini/compare/v1.66.3...v1.66.4 1.66.3 What's Changed Return an empty array from ValueWithShadows if there is none by https://github.com/NDagestad;>@NDagestad in https://redirect.github.com/go-ini/ini/pull/313;>go-ini/ini#313 New Contributors https://github.com/NDagestad;>@NDagestad made their first contribution in https://redirect.github.com/go-ini/ini/pull/313;>go-ini/ini#313 Full Changelog: https://github.com/go-ini/ini/compare/v1.66.2...v1.66.3;>https://github.com/go-ini/ini/compare/v1.66.2...v1.66.3 1.66.2 What's Changed Fix nested values can span sections by https://github.com/ravron;>@ravron in https://redirect.github.com/go-ini/ini/pull/306;>go-ini/ini#306 New Contributors https://github.com/ravron;>@ravron made their first contribution in https://redirect.github.com/go-ini/ini/pull/306;>go-ini/ini#306 Full Changelog: https://github.com/go-ini/ini/compare/v1.66.1...v1.66.2;>https://github.com/go-ini/ini/compare/v1.66.1...v1.66.2 ... (truncated) Commits https://github.com/go-ini/ini/commit/b2f570e5b5b844226bbefe6fb521d891f529a951;>b2f570e ini: allow changing the default section name (https://redirect.github.com/go-ini/ini/issues/319;>#319) https://github.com/go-ini/ini/commit/6098d4257e883d8cf846e9012bdd5b03811af4ce;>6098d42 parser: fix line skipping when key is empty (https://redirect.github.com/go-ini/ini/issues/323;>#323) https://github.com/go-ini/ini/commit/7c569cc85f52695ad982c2d237fae259d06b85c4;>7c569cc chore: various config updates to CI (https://redirect.github.com/go-ini/ini/issues/322;>#322) https://github.com/go-ini/ini/commit/842b9a946dd3bb45b95001ce6d9ae86f3b3ce921;>842b9a9 write: pretty print section only if it is not the last one (https://redirect.github.com/go-ini/ini/issues/321;>#321) https://github.com/go-ini/ini/commit/386cf3065553288870de976e7de63e041236c329;>386cf30 lsif: update upload endpoint (https://redirect.github.com/go-ini/ini/issues/317;>#317) https://github.com/go-ini/ini/commit/6d3eeb0dc855cb516eabc3fe40e76ad83a8360e4;>6d3eeb0 README: use branch check status instead of workflow https://github.com/go-ini/ini/commit/39f9e49bca3bbb9e67f361e9dd883912bb09a1b0;>39f9e49 key: ignore empty values in ValueWithShadows (https://redirect.github.com/go-ini/ini/issues/316;>#316) https://github.com/go-ini/ini/commit/fcd6cc399e588727c1231f4ea187d1b963536bcc;>fcd6cc3 Return an empty array from ValueWithShadows if there is none (https://redirect.github.com/go-ini/ini/issues/313;>#313) https://github.com/go-ini/ini/commit/d26f092124b3ad090fe6cd2de7458f6971565471;>d26f092 github: refurbish issue forms and pull request templates (https://redirect.github.com/go-ini/ini/issues/312;>#312) https://github.com/go-ini/ini/commit/c71eccd557feacd4fcd29f322a99e98870f908b7;>c71eccd Fix nested values can span sections (https://redirect.github.com/go-ini/ini/issues/306;>#306) Additional commits viewable in
[PR] Bump github.com/hashicorp/go-multierror from 1.0.0 to 1.1.1 [cloudstack-terraform-provider]
dependabot[bot] opened a new pull request, #95: URL: https://github.com/apache/cloudstack-terraform-provider/pull/95 Bumps [github.com/hashicorp/go-multierror](https://github.com/hashicorp/go-multierror) from 1.0.0 to 1.1.1. Commits https://github.com/hashicorp/go-multierror/commit/9974e9ec57696378079ecc3accd3d6f29401b3a0;>9974e9e Merge pull request https://redirect.github.com/hashicorp/go-multierror/issues/50;>#50 from sethvargo/sethvargo/npe https://github.com/hashicorp/go-multierror/commit/0023bb0ab1225a10509dca08627b42bed25d74a5;>0023bb0 Check if multierror is nil in WrappedErrors https://github.com/hashicorp/go-multierror/commit/ab6846acb1cf402787cde041fcff5f01c0b8e362;>ab6846a we require go 1.13 https://github.com/hashicorp/go-multierror/commit/cb869d97a564fb27eb864d7053ca42585ee29f2f;>cb869d9 Merge pull request https://redirect.github.com/hashicorp/go-multierror/issues/49;>#49 from hashicorp/fix-ci-config https://github.com/hashicorp/go-multierror/commit/af59c663db3f8243edf5eda89a73ba6ef19c7346;>af59c66 Upgrade gotestsum version https://github.com/hashicorp/go-multierror/commit/eabd672ee8f2389db69282b7b530acce8f5c4a1a;>eabd672 Fix CI config https://github.com/hashicorp/go-multierror/commit/7795f06f94b03e0fb27702faed3d1e4555a2c74b;>7795f06 Merge pull request https://redirect.github.com/hashicorp/go-multierror/issues/47;>#47 from hashicorp/mwhooker-patch-1 https://github.com/hashicorp/go-multierror/commit/e27d23170e2b792ee617968384b794d2930b4924;>e27d231 update badges to use circle https://github.com/hashicorp/go-multierror/commit/78708dbe0f6f1383078ba6c47f7e19cc8f810488;>78708db Carry over some changes from https://redirect.github.com/hashicorp/go-multierror/issues/26;>#26 https://github.com/hashicorp/go-multierror/commit/c7dd669f3467df8743c3e88bcaa430467e074c08;>c7dd669 Merge pull request https://redirect.github.com/hashicorp/go-multierror/issues/27;>#27 from mdeggies/add-circleci Additional commits viewable in https://github.com/hashicorp/go-multierror/compare/v1.0.0...v1.1.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] next version 20 instead of 4.20
That logic doesn't hold with what's proposed Taking your interpretation, after moving to 20.x.y we would then have to stay on 20.x.y until "incompatible API changes" happen. New features and updates would go into 20 . x+1 . y which only achieves removing the security fix dot releases nomenclature. MAJOR version when you make incompatible API changes MINOR version when you add functionality in a backward compatible manner PATCH version when you make backward compatible bug fixes -Original Message- From: Daan Hoogland Sent: Wednesday, March 6, 2024 8:57 AM To: dev@cloudstack.apache.org Subject: Re: [VOTE] next version 20 instead of 4.20 I think we will (and have) changed APIs and dropped plugin support in major versions with at least a deprecation period. this is exactly the reason I now (finally) proposed we should drop the 4 and proceed with regarding the second number as the primary version. Semantic versioning is well defined as a three number scheme that we follow otherwise. this is also how https://semver.org/ defines it. Our only difference with that is that we do not allow backwards compatible feature added in major versions, which we could decide to do or don't independent of whether we drop the 4 or not. I agree that we could codify our protocol first. On Wed, Mar 6, 2024 at 5:54 AM Rohit Yadav wrote: > > Daniel, Daan, others, > > Could you explain why you’d break CloudStack’s rest-like APIs? Isn’t the > intention of dropping the 4. as we may never see a 5.x that involves major > changes involving API incompatibility? > > Regards. > > > > > From: Guto Veronezi > Sent: Wednesday, March 6, 2024 4:00:30 AM > To: dev@cloudstack.apache.org > Subject: Re: [VOTE] next version 20 instead of 4.20 > > > By agreeing to drop the "4" I think we're effectively voting and agreeing > > that we'll not be breaking APIs. > That is not what was discussed in the thread [1]. If we agree that we > will not break APIs, I am -1 on dropping the "4". We need to create a > protocol along with the proposal, otherwise, we will be subjective > about the topic and will be agreeing on something for different reasons. > > [1] https://lists.apache.org/thread/yxxjzov5dqrfsogth6kcq2r0wn8rzljv > > On 3/5/24 15:10, Paul Angus wrote: > > Hi Rohit, thank you > > > > So to recap; > > > > Semantic versioning goes (in our use): > > . . > > . > > > > And as I understand it you're looking to go > > > > . . Starting > > from 20 > > > > I'd ask the question - are there any big/disruptive changes people > > would want to bundle together to keep the semantic versioning and > > move to 5.x.y.z > > > > I'm assuming not, so the move proposed is to drop semantic versioning and > > continue from 20, understanding that we would lose the mechanism to warn of > > very disruptive changes (for what it's worth). > > > > I've no objection to it. The issue was, that reading the thread, people > > had different takes on what the change was, what would it do and what it > > meant. And also incorrect understandings of semantic versioning. > > > > So, to be pedantic, and have a clearly defined vote, I'd change the > > vote to something like "Drop semantic versioning and continue from > > 20". And include your explanation about moving to > > . . > > > > I would be ok to +1 that ^^^ > > > > -paul > > > > -Original Message- > > From: Rohit Yadav > > Sent: Tuesday, March 5, 2024 4:02 PM > > To: dev@cloudstack.apache.org; us...@cloudstack.apache.org > > Subject: Re: [VOTE] next version 20 instead of 4.20 > > > > As I understand Daan's vote proposal and from the previous discussion > > thread, the current scheme that results in a release like 4.20.x.y would > > simply become 20.a.b, wherein "a" is for maintenance release (counter, > > starting with 0) and "b" is only used for security releases (counter, > > starting with 0). > > > > The voting thread is about "deciding to drop the 4 from our versioning > > scheme", wherein the next CloudStack version would become "20" instead of > > "4.20". By agreeing to drop the "4" I think we're effectively voting and > > agreeing that we'll not be breaking APIs. Some other opensource projects > > have done something similar too. Of course, this needs to be properly > > explained and documented both by a blog article and on the project wiki. > > > > Paul - are you satisfied with the explanations and discussions, are you > > still blocking this vote thead or do you want to reconsider your vote? > > > > > > Regards. > > > > > > > > > > > > From: Paul Angus > > Sent: Tuesday, February 20, 2024 15:55 > > To: dev@cloudstack.apache.org > > Cc: us...@cloudstack.apache.org > > Subject: RE: [VOTE] next version 20 instead of 4.20 > > > > Hi Daan, > > > > > > From our wiki page: > > > > -- Quote > > For those that may not be familiar with Semantic Versioning, the number > > format is: X.Y.Z,
RE: [VOTE] next version 20 instead of 4.20
IMO - they are two different subjects. Everybody hopes that we'd never break API compatibility, but there may be a situation at some point in the future where it may be required and we fundamentally cant take a decision now that limits what the community may want to do in 10 years time. Irrespective of what numbering scheme is being used, that would still be a massive decision to make *at the time* and I'd expect a vibrant debate on doing so Yes, semantic is a well know agreed standard: giving consistency across lots of different software - but there is absolutely nothing to say that CloudStack HAS to stick to that convention (arguably, by removing the "4." , we're coming away from that standard anyway) Lots of software doesn’t use semantic release versioning at all. As long as we have a consistent versioning scheme and are clear about it - it doesn’t matter what scheme we use IMO As Paul says the "X" in X.Y.Z is usually used as a simple way to warn of API disruptive changes - but that warning can be given in other ways (in documentation , a compatibility matrix, etc) *If* it ever happened, we would be using the first number for bothand Kind Regards Giles -Original Message- From: Rohit Yadav Sent: Wednesday, March 6, 2024 4:54 AM To: dev@cloudstack.apache.org Subject: Re: [VOTE] next version 20 instead of 4.20 Daniel, Daan, others, Could you explain why you’d break CloudStack’s rest-like APIs? Isn’t the intention of dropping the 4. as we may never see a 5.x that involves major changes involving API incompatibility? Regards. From: Guto Veronezi Sent: Wednesday, March 6, 2024 4:00:30 AM To: dev@cloudstack.apache.org Subject: Re: [VOTE] next version 20 instead of 4.20 > By agreeing to drop the "4" I think we're effectively voting and agreeing > that we'll not be breaking APIs. That is not what was discussed in the thread [1]. If we agree that we will not break APIs, I am -1 on dropping the "4". We need to create a protocol along with the proposal, otherwise, we will be subjective about the topic and will be agreeing on something for different reasons. [1] https://lists.apache.org/thread/yxxjzov5dqrfsogth6kcq2r0wn8rzljv On 3/5/24 15:10, Paul Angus wrote: > Hi Rohit, thank you > > So to recap; > > Semantic versioning goes (in our use): > . . > . > > And as I understand it you're looking to go > > . . Starting from > 20 > > I'd ask the question - are there any big/disruptive changes people > would want to bundle together to keep the semantic versioning and move > to 5.x.y.z > > I'm assuming not, so the move proposed is to drop semantic versioning and > continue from 20, understanding that we would lose the mechanism to warn of > very disruptive changes (for what it's worth). > > I've no objection to it. The issue was, that reading the thread, people had > different takes on what the change was, what would it do and what it meant. > And also incorrect understandings of semantic versioning. > > So, to be pedantic, and have a clearly defined vote, I'd change the > vote to something like "Drop semantic versioning and continue from > 20". And include your explanation about moving to > . . > > I would be ok to +1 that ^^^ > > -paul > > -Original Message- > From: Rohit Yadav > Sent: Tuesday, March 5, 2024 4:02 PM > To: dev@cloudstack.apache.org; us...@cloudstack.apache.org > Subject: Re: [VOTE] next version 20 instead of 4.20 > > As I understand Daan's vote proposal and from the previous discussion thread, > the current scheme that results in a release like 4.20.x.y would simply > become 20.a.b, wherein "a" is for maintenance release (counter, starting with > 0) and "b" is only used for security releases (counter, starting with 0). > > The voting thread is about "deciding to drop the 4 from our versioning > scheme", wherein the next CloudStack version would become "20" instead of > "4.20". By agreeing to drop the "4" I think we're effectively voting and > agreeing that we'll not be breaking APIs. Some other opensource projects have > done something similar too. Of course, this needs to be properly explained > and documented both by a blog article and on the project wiki. > > Paul - are you satisfied with the explanations and discussions, are you still > blocking this vote thead or do you want to reconsider your vote? > > > Regards. > > > > > > From: Paul Angus > Sent: Tuesday, February 20, 2024 15:55 > To: dev@cloudstack.apache.org > Cc: us...@cloudstack.apache.org > Subject: RE: [VOTE] next version 20 instead of 4.20 > > Hi Daan, > > > From our wiki page: > > -- Quote > For those that may not be familiar with Semantic Versioning, the number > format is: X.Y.Z, where X is the major version, Y is the minor version, Z is > the patch number. The community strives to ensure backward API compatibility > within each major version (i.e.: code
