Final 2.2 release?

2008-01-29 Thread Carsten Ziegeler

Hi,

did you know that I bought one of those Grumpy shirts last time I 
visited WDW? So, I *have* to ask what the current plans for the long 
awaited final release of 2.2 is?


Thanks
Carsten
--
Carsten Ziegeler
[EMAIL PROTECTED]


Re: Final 2.2 release?

2008-01-29 Thread Grzegorz Kossakowski
Carsten Ziegeler pisze:
 Hi,
 
 did you know that I bought one of those Grumpy shirts last time I
 visited WDW? So, I *have* to ask what the current plans for the long
 awaited final release of 2.2 is?

Hi Carsten,

I think that 2.2 is ready for a final release. JIRA does not report any 
outstanding serious issues
apart from this one: https://issues.apache.org/jira/browse/COCOON-2108 which 
seems to be fixed by
Ralph in r609282[1]. It would be good if Ralph who reopened that issue could 
confirm his fix and
close it.

Apart from JIRA issues there was one very serious problem: lack of any 
documentation on Servlet
Service Framework. I was working on writing docs some time ago and I will 
continue to do so in
upcomming days so you can expect something complete really soon.

To sum up, it's certainly right time to start preparing the release.

[1] http://svn.apache.org/viewvc?rev=609282view=rev

-- 
Grzegorz Kossakowski
Committer and PMC Member of Apache Cocoon
http://reflectingonthevicissitudes.wordpress.com/


[jira] Closed: (COCOON-2150) Error on resetting response

2008-01-29 Thread Grzegorz Kossakowski (JIRA)

 [ 
https://issues.apache.org/jira/browse/COCOON-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Grzegorz Kossakowski closed COCOON-2150.


Resolution: Fixed

 Error on resetting response
 ---

 Key: COCOON-2150
 URL: https://issues.apache.org/jira/browse/COCOON-2150
 Project: Cocoon
  Issue Type: Bug
  Components: - Servlet service framework
Affects Versions: 2.2-dev (Current SVN)
Reporter: Jörg Heinicke
Assignee: Grzegorz Kossakowski
Priority: Minor
 Fix For: 2.2-dev (Current SVN)


 This is the exception shown on the console:
 java.lang.IllegalStateException: Committed
 at org.mortbay.jetty.Response.resetBuffer(Response.java:855)
 at org.mortbay.jetty.Response.reset(Response.java:834)
 at 
 javax.servlet.ServletResponseWrapper.reset(ServletResponseWrapper.java:182)
 at 
 org.apache.cocoon.servletservice.ServletServiceContext$PathDispatcher.forward(ServletServiceContext.java:576)
 at 
 org.apache.cocoon.servletservice.ServletServiceContext$PathDispatcher.forward(ServletServiceContext.java:545)
 at 
 org.apache.cocoon.servletservice.spring.ServletFactoryBean$ServiceInterceptor.invoke(ServletFactoryBean.java:230)
 at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
 at 
 org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
 at $Proxy2.service(Unknown Source)
 at 
 org.apache.cocoon.servletservice.DispatcherServlet.service(DispatcherServlet.java:102)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
 at 
 org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:459)
 It seems to be thrown whenever the response object is reseted after the 
 actual response has been sent by the sitemap error handler. In this case 
 reset is no longer possible since the response has already been committed as 
 stated in the error message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Final 2.2 release?

2008-01-29 Thread Reinhard Poetz

Carsten Ziegeler wrote:

Hi,

did you know that I bought one of those Grumpy shirts last time I 
visited WDW? So, I *have* to ask what the current plans for the long 
awaited final release of 2.2 is?


:-)

On my personal todo list only the creation of non-Maven-2-artifacts is missing. 
I will also finish the integration test suite for Cocoon sitemaps next week 
(since I need it for Micro-Cocoon).


So far I found two bugs:

 o pipeline-specific error handlers don't work
 o if you send a response code other than 200, the *first* response will
   return 200 nevertheless

IMHO these are not blockers, but it would be nice if somebody could have a look 
at it.


Anything else?

--
Reinhard PötzManaging Director, {Indoqa} GmbH
  http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair[EMAIL PROTECTED]
_



Re: Final 2.2 release?

2008-01-29 Thread Grzegorz Kossakowski
Reinhard Poetz pisze:
 Carsten Ziegeler wrote:
 Hi,

 did you know that I bought one of those Grumpy shirts last time I
 visited WDW? So, I *have* to ask what the current plans for the long
 awaited final release of 2.2 is?
 
 :-)

It's right time for someone to explain what the hell WDW is? :-)

 On my personal todo list only the creation of non-Maven-2-artifacts is
 missing. I will also finish the integration test suite for Cocoon
 sitemaps next week (since I need it for Micro-Cocoon).
 
 So far I found two bugs:
 
  o pipeline-specific error handlers don't work
  o if you send a response code other than 200, the *first* response will
return 200 nevertheless
 
 IMHO these are not blockers, but it would be nice if somebody could have
 a look at it.

Ehkm, I would like to point out (remind?) that we have everything needed for 
independent release
cycle of blocks and Cocoon's core so if issue is not really critical or a fix 
is already known it
should never block a release. If someone comes with fix to issues above we will 
(hopefully) be able
to easily cut a new release.

-- 
Grzegorz Kossakowski
Committer and PMC Member of Apache Cocoon
http://reflectingonthevicissitudes.wordpress.com/


Re: Final 2.2 release?

2008-01-29 Thread Reinhard Poetz

Vadim Gritsenko wrote:

On Jan 29, 2008, at 11:17 AM, Reinhard Poetz wrote:


o pipeline-specific error handlers don't work


Can you elaborate? As far as I can see all tests are passing fine

http://cocoon.zones.apache.org/demos/trunk/samples/core/errorhandling/
http://cocoon.zones.apache.org/demos/trunk/samples/core/errorhandling/exception/application?code=1 



I tried this (see the comment inline):

map:pipelines

  !--  error handling ~~~ --
  map:pipeline
map:match pattern=error-handling/custom-error
  map:act type=error-throwing/
  map:generate src=sax-pipeline/simple.xml/
  map:serialize type=xml/
/map:match
  /map:pipeline
  !-- doesn't work: when this per pipeline error handler is active,
   it catches ALL errors and the per-sitemap error handler will never
   be reached. --
  map:pipeline
map:match
 pattern=error-handling/custom-error-per-pipeline-error-handling
  map:act type=error-throwing/
  map:generate src=sax-pipeline/simple.xml/
  map:serialize type=xml/
/map:match
map:handle-errors
  map:generate src=error-handling/501.xml/
  map:serialize type=xhtml status-code=501/
/map:handle-errors
  /map:pipeline

  map:handle-errors
map:select type=custom-exception
  map:when test=not-found
map:generate src=error-handling/404.xml/
map:serialize type=xhtml status-code=404/
  /map:when
  map:when test=custom-exception
map:generate src=error-handling/500.xml/
map:serialize type=xhtml status-code=500/
  /map:when
  map:otherwise
map:generate src=error-handling/503.xml/
map:serialize type=xhtml status-code=503/
  /map:otherwise
/map:select
  /map:handle-errors

/map:pipelines


--
Reinhard PötzManaging Director, {Indoqa} GmbH
  http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair[EMAIL PROTECTED]
_


Re: Final 2.2 release?

2008-01-29 Thread Vadim Gritsenko

On Jan 29, 2008, at 11:17 AM, Reinhard Poetz wrote:


o pipeline-specific error handlers don't work


Can you elaborate? As far as I can see all tests are passing fine

http://cocoon.zones.apache.org/demos/trunk/samples/core/errorhandling/
http://cocoon.zones.apache.org/demos/trunk/samples/core/errorhandling/exception/application?code=1


Vadim


Re: svn commit: r616536 - in /cocoon/whiteboard/micro/misc: cocoon-micro-it-block/src/main/java/org/apache/cocoon/micro/it/ cocoon-micro-it-block/src/main/resources/COB-INF/ cocoon-micro-it-block/src/

2008-01-29 Thread Reinhard Poetz

Grzegorz Kossakowski wrote:

[EMAIL PROTECTED] pisze:

Author: reinhard Date: Tue Jan 29 14:07:32 2008 New Revision: 616536

URL: http://svn.apache.org/viewvc?rev=616536view=rev Log: add test for
accessing the object model from within a generator and redirection
(redirecting to a servlet source doesn't work ATM)


Which object model you want to test here?


TBH, from an integration test perspective, I don't care which one. I want to 
test if the object model can be accessed at all from within a generator. I want 
to make sure that the OM is still available after doing refactorings, because I 
guess that the old one will be removed sooner or later.




+ +public class RequestParametersGenerator extends AbstractGenerator { + +
public void generate() throws IOException, SAXException,
ProcessingException { +Request request =
ObjectModelHelper.getRequest(this.objectModel); +


Modern way to access request object is PipelineInfoProvider bean.


ok

--
Reinhard PötzManaging Director, {Indoqa} GmbH
  http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair[EMAIL PROTECTED]
_


Re: svn commit: r616536 - in /cocoon/whiteboard/micro/misc: cocoon-micro-it-block/src/main/java/org/apache/cocoon/micro/it/ cocoon-micro-it-block/src/main/resources/COB-INF/ cocoon-micro-it-block/src/

2008-01-29 Thread Grzegorz Kossakowski
[EMAIL PROTECTED] pisze:
 Author: reinhard
 Date: Tue Jan 29 14:07:32 2008
 New Revision: 616536
 
 URL: http://svn.apache.org/viewvc?rev=616536view=rev
 Log:
 add test for accessing the object model from within a generator and 
 redirection (redirecting to a servlet source doesn't work ATM)

Which object model you want to test here?

 +
 +public class RequestParametersGenerator extends AbstractGenerator {
 +
 +public void generate() throws IOException, SAXException, 
 ProcessingException {
 +Request request = ObjectModelHelper.getRequest(this.objectModel);
 +

Modern way to access request object is PipelineInfoProvider bean.

-- 
Grzegorz Kossakowski
Committer and PMC Member of Apache Cocoon
http://reflectingonthevicissitudes.wordpress.com/


Re: Final 2.2 release?

2008-01-29 Thread Ralph Goers
Yes, I fixed 2108. If you are happy that the fix hasn't caused any other 
problems then I will close it.


Grzegorz Kossakowski wrote:

Carsten Ziegeler pisze:
  

Hi,

did you know that I bought one of those Grumpy shirts last time I
visited WDW? So, I *have* to ask what the current plans for the long
awaited final release of 2.2 is?



Hi Carsten,

I think that 2.2 is ready for a final release. JIRA does not report any 
outstanding serious issues
apart from this one: https://issues.apache.org/jira/browse/COCOON-2108 which 
seems to be fixed by
Ralph in r609282[1]. It would be good if Ralph who reopened that issue could 
confirm his fix and
close it.

Apart from JIRA issues there was one very serious problem: lack of any 
documentation on Servlet
Service Framework. I was working on writing docs some time ago and I will 
continue to do so in
upcomming days so you can expect something complete really soon.

To sum up, it's certainly right time to start preparing the release.

[1] http://svn.apache.org/viewvc?rev=609282view=rev

  


Re: Final 2.2 release?

2008-01-29 Thread Carsten Ziegeler

Grzegorz Kossakowski wrote:

Reinhard Poetz pisze:

Carsten Ziegeler wrote:

Hi,

did you know that I bought one of those Grumpy shirts last time I
visited WDW? So, I *have* to ask what the current plans for the long
awaited final release of 2.2 is?

:-)


It's right time for someone to explain what the hell WDW is? :-)


:) Just try your favorite search engine - but as a hint, it's located in
Florida...


Carsten

--
Carsten Ziegeler
[EMAIL PROTECTED]


Re: Final 2.2 release?

2008-01-29 Thread Carsten Ziegeler

Thanks for all the answers!

So, lets just release now!

Carsten


--
Carsten Ziegeler
[EMAIL PROTECTED]


Re: Final 2.2 release?

2008-01-29 Thread Reinhard Poetz

Carsten Ziegeler wrote:

Thanks for all the answers!

So, lets just release now!


As it looks today, the chances are high that I will be able to start the release 
process on Feb. 11th. If somebody else can do it earlier, please go ahead.


--
Reinhard PötzManaging Director, {Indoqa} GmbH
  http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair[EMAIL PROTECTED]
_