Re: Run latest from trunk
Grzegorz Kossakowski pisze: Grzegorz Kossakowski pisze: Felix Knecht pisze: I can confirm now that I see this problem locally. By mistake, I was testing a copy without this bug fix before committing so I didn't spot it. I'm just having a look at this. Sorry for breaking your work at the end of the week! :-( I have looked at this and found the cause for this bug. Class StatusRetrievableBufferedWrappedResponse passes Content-Length setting to the wrapped response _before_ final settlement of this value which leads to situation where Content-Length is set to 0. I tried to fix this but whole issue looks to be more troublesome that I previously thought and I need to rethink whole approach. Basically, I opt to writing our own, full-blown implementation of HttpServletResponse that will buffer *everything* until we can be 100% sure that everything is established in final shape. This looks like quite a lot of work to implement meaningful implementation of HttpServletResponse that can copy to another one and will certainly increase complexity of SSF. If you have any thoughts on this I'm willing to hear. I regret to say that I probably won't be able to fix this until final release of SSF. I reverted commit blowing up SSF but this does not solves the whole issue, of course. The original bug is still there and it will bite people even in more obscure way because its real consequences can be seen in complicated setups with servlet inheritance only. Nevertheless, it's still better than completely broken SSF. -- Grzegorz Kossakowski Committer and PMC Member of Apache Cocoon http://reflectingonthevicissitudes.wordpress.com/
[jira] Updated: (COCOON-2150) Error on resetting response
[ https://issues.apache.org/jira/browse/COCOON-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kossakowski updated COCOON-2150: - Fix version (Component): Parent values: Servlet Service Framework(10247). (was: Parent values: Servlet Service Framework(10247). Level 1 values: 1.0.0-RC2-dev(10316). ) Priority: Major (was: Critical) I confirmed that my fix was wrong in this thread: http://article.gmane.org/gmane.text.xml.cocoon.devel/76831 Switching back to Major priority because, with reverted commit, this issue no longer breaks people's applications. At least, in general. Error on resetting response --- Key: COCOON-2150 URL: https://issues.apache.org/jira/browse/COCOON-2150 Project: Cocoon Issue Type: Bug Components: - Servlet service framework Affects Versions: 2.2-dev (Current SVN) Reporter: Jörg Heinicke Assignee: Grzegorz Kossakowski Fix For: 2.2-dev (Current SVN) This is the exception shown on the console: java.lang.IllegalStateException: Committed at org.mortbay.jetty.Response.resetBuffer(Response.java:855) at org.mortbay.jetty.Response.reset(Response.java:834) at javax.servlet.ServletResponseWrapper.reset(ServletResponseWrapper.java:182) at org.apache.cocoon.servletservice.ServletServiceContext$PathDispatcher.forward(ServletServiceContext.java:576) at org.apache.cocoon.servletservice.ServletServiceContext$PathDispatcher.forward(ServletServiceContext.java:545) at org.apache.cocoon.servletservice.spring.ServletFactoryBean$ServiceInterceptor.invoke(ServletFactoryBean.java:230) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy2.service(Unknown Source) at org.apache.cocoon.servletservice.DispatcherServlet.service(DispatcherServlet.java:102) at javax.servlet.http.HttpServlet.service(HttpServlet.java:802) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:459) It seems to be thrown whenever the response object is reseted after the actual response has been sent by the sitemap error handler. In this case reset is no longer possible since the response has already been committed as stated in the error message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r617586 - /cocoon/trunk/blocks/cocoon-validation/cocoon-validation-impl/src/main/java/org/apache/cocoon/components/validation/jaxp/JaxpResolver.java
Grzegorz Kossakowski wrote: [EMAIL PROTECTED] pisze: Author: cziegeler Date: Fri Feb 1 10:16:27 2008 New Revision: 617586 URL: http://svn.apache.org/viewvc?rev=617586view=rev Log: SOLVED - issue COCOON-2164: Bug in JaxpResolver in validation block https://issues.apache.org/jira/browse/COCOON-2164 Modified: cocoon/trunk/blocks/cocoon-validation/cocoon-validation-impl/src/main/java/org/apache/cocoon/components/validation/jaxp/JaxpResolver.java Hi Carsten, What about mentioning this in changes file in trunk? Hmm, not sure - so far I only mentioned changes there if these were changes compared to the 2.1.x branch. I added this change to the status.xml in 2.1.x. Not sure if this is the best approach? Carsten -- Carsten Ziegeler [EMAIL PROTECTED]
