Re: svn commit: r666946 - in /cocoon/branches/BRANCH_2_1_X/tools/targets: compile-build.xml init-build.xml

2008-06-12 Thread Ralph Goers

Until we need to take advantage of some Java 1.5 feature  ;-)

[EMAIL PROTECTED] wrote:

URL: http://svn.apache.org/viewvc?rev=666946view=rev
Log:
With minimum Java raised to 1.4.2 it is no longer necessary to have 
JDK-specific source directories.
  


Re: [2.1.x] Build failed after jdk1.* directories were removed

2008-06-12 Thread Andreas Hartmann

Hi Jörg,

Joerg Heinicke schrieb:

On 11.06.2008 09:17, Andreas Hartmann wrote:


Removed:
cocoon/branches/BRANCH_2_1_X/src/jdk1.3/
cocoon/branches/BRANCH_2_1_X/src/jdk1.4/


now the build fails for me due to the missing directories 
(compile-build.xml):


  !-- compiles the core --
  target name=compile-core depends=compile-mocks, clover.on
cocoon.compile srcdir=${java}
destdir=${build.dest}/
echoCompiling jdk ${used.vm} core classes/echo
cocoon.compile srcdir=${jdk.java}
destdir=${build.dest}/
  /target


Does it work for you?


Hmm, on the one hand it does not really surprise me that it fails on 
missing directories, on the other hand that's exactly why I tried a 
build clean on my machine (Mac OS X though) before committing it. I 


strange, I'm also using Mac OS X …
But I'm building through Lenya, maybe it uses a different Ant version.

will just take this compile statement out, but can not really test it 
obviously. Please report back if there are still problems.


The build process is working again. Thanks a lot!

-- Andreas


--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01



Re: Objects inherited in subrequests

2008-06-12 Thread Christoph Gaffga (triplemind.com)


Grzegorz Kossakowski wrote:
Therefore I would like to propose introduction of a new scope called 
request-inheritable which would allow beans (like ObjectModel) to be 
inherited but by cloning.


What do you think?


hmm, just tried to solve that problem and found that in 
IncludeTransformer it works with threading and parallel processing. Only 
for the DefaultIncludeCacheManager we are using in our replacement for 
the aggregator to do parallel aggregation it is broken since version 2.2.


So I decided to patch the DefaultIncludeCacheManager to work in the same 
way as the IncludeTransformer does, by setting up the child threads with 
the same context/environment:


  // Setup this thread's environment
  RequestContextHolder.setRequestAttributes(
this.session.getRequestAttributes());
  EnvironmentHelper.enterProcessor(this.session.getProcessor(),
this.session.getEnvironment());

I'll test this out, and if it work's I send in the patch.

Christoph



Re: svn commit: r666946 - in /cocoon/branches/BRANCH_2_1_X/tools/targets: compile-build.xml init-build.xml

2008-06-12 Thread Joerg Heinicke
That's why I just wrapped the stuff in comments rather than taking it 
out completely :)


Joerg

On 12.06.2008 02:51, Ralph Goers wrote:

Until we need to take advantage of some Java 1.5 feature  ;-)

[EMAIL PROTECTED] wrote:

URL: http://svn.apache.org/viewvc?rev=666946view=rev
Log:
With minimum Java raised to 1.4.2 it is no longer necessary to have 
JDK-specific source directories.