Re: closeLoudly()
OK, I attached the patch to the issue. I guess that is the right way. Thanks for mentioning. Jos
[jira] Updated: (COCOON3-46) URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null
[ https://issues.apache.org/jira/browse/COCOON3-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jos Snellings updated COCOON3-46: - Attachment: closeQuietly-fix.patch > URLConnectionUtils.closeQuietly() complains loudly if servletConnection == > null > --- > > Key: COCOON3-46 > URL: https://issues.apache.org/jira/browse/COCOON3-46 > Project: Cocoon 3 > Issue Type: Improvement > Components: cocoon-pipeline >Affects Versions: 3.0.0-alpha-2 >Reporter: Jos Snellings >Assignee: Cocoon Developers Team >Priority: Minor > Fix For: 3.0.0-alpha-3 > > Attachments: closeQuietly-fix.patch > > > finally clause in URLResponse method execute() > contains call to URLConnectionUtils.closeQuietly. > If servletConnection = this.url.openConnection(); fails, servletConnection > is null. > In that case closeQuietly causes a stacktrace to be output. > Solution is if (servletConnection != null) > URLConnectionUtils.closeQuietly(servletConnection);, guard the call with a > test, > or even better, take into account in closeQuietly that the input parameter > may be null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: closeLoudly()
Jos Snellings wrote: > I attached the patch. Is this the proper way to submit? > Thanks, and please excuse me my ignorance. It is the first time. > (first times can be traumatic, so far I am feeling well). Thanks for your help. As Simone suggested below, the issue tracker is way better for many reasons. Ideally then also follow up here by mentioning the issue number. http://issues.apache.org/jira/browse/COCOON3 http://issues.apache.org/jira/browse/COCOON > Jos Snellings wrote: > > Thank you, Simone. I will do that. > > > > Simone Tripodi wrote: > > > Hi Jos, > > > nice to meet you :) Usually suggestions of this kind have to be > > > submitted by the issue tracker: > > > > > > http://issues.apache.org/jira/browse/COCOON3 > > > > > > Make your own patch through the command line: > > > > > > svn diff -x -u Main.java > arg-fix.patch > > > > > > giving your patch file meaningful name. > > > Goof job! > > > Simo
[jira] Created: (COCOON-2273) Download page does not have link to KEYS file; hashes/sigs must point to main ASF site
Download page does not have link to KEYS file; hashes/sigs must point to main ASF site -- Key: COCOON-2273 URL: https://issues.apache.org/jira/browse/COCOON-2273 Project: Cocoon Issue Type: Bug Components: * Cocoon Core Reporter: Sebb Priority: Critical The download page http://cocoon.apache.org/1284_1_1.html has links to sigs and hashes. However these links point to the mirrors, but they should point to the main Apache server, i.e instead of http://www.apache.org/dyn/closer.cgi/cocoon/2.2/cocoon-2.2.0.zip.asc the link should be http://www.apache.org/dist/cocoon/2.2/cocoon-2.2.0.zip.asc Also, the download page must have a link to the KEYS file, i.e. http://www.apache.org/dist/cocoon/KEYS (otherwise the pgp - .asc - links aren't much use) The .md5.asc and .sha1.asc files are redundant and should be deleted from the dist/ directory tree. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
