[jira] [Commented] (COCOON3-98) RegexpLinkRewriterTransformer doesn't guarantees rules order
[ https://issues.apache.org/jira/browse/COCOON3-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252993#comment-13252993 ] Thorsten Scherler commented on COCOON3-98: -- I understand the underlying issue, so I wonder if a linkedList would get rid of the position. Otherwise looks nice. RegexpLinkRewriterTransformer doesn't guarantees rules order Key: COCOON3-98 URL: https://issues.apache.org/jira/browse/COCOON3-98 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sax Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: LinkRewriterTransformer-COCOON-98.diff RegexpLinkRewriterTransformer apply all the defined rules iterating over a Set. I think that makes sense to implement some kind of priority because you may have rules that depends on other rules. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245471#comment-13245471 ] Thorsten Scherler commented on COCOON3-95: -- Committed revision 1309027. cocoon3-95.txt Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: SitemapBuilder-COCOON-95.diff, cocoon3-95.txt, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-93) Concurrency issues with ComponentProvider
[ https://issues.apache.org/jira/browse/COCOON3-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230079#comment-13230079 ] Thorsten Scherler commented on COCOON3-93: -- I applied the patch in revision 1300923 even if we still discuss it since it fixes the concurrency problem in our customer app. Concurrency issues with ComponentProvider - Key: COCOON3-93 URL: https://issues.apache.org/jira/browse/COCOON3-93 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Labels: patch Attachments: SpringComponentProvider.diff, concurrency.tar.gz http://cocoon.markmail.org/thread/3kgfye55zxavikwo we are working in a project based on C3 and we found a strange behaviour when loading the static resources. We are developing a Web 2.0 application and therefore we have a lot of resources (js, images and css). The weird thing is that sometimes the system is returning the wrong resources, returning a js instead of a css or switching images... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer
[
https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177216#comment-13177216
]
Thorsten Scherler commented on COCOON3-85:
--
I am At revision 1225548.
uname -rios
Linux 3.0.0-14-generic x86_64 GNU/Linux
java -version
java version 1.6.0_25
Java(TM) SE Runtime Environment (build 1.6.0_25-b06)
Java HotSpot(TM) 64-Bit Server VM (build 20.0-b11, mixed mode)
c3/cocoon-sample$ mvn clean install jetty:run
now works, weird seems the clean did the trick, sorry for the noise and
thanks for testing.
cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's
static optimizer
Key: COCOON3-85
URL: https://issues.apache.org/jira/browse/COCOON3-85
Project: Cocoon 3
Issue Type: Bug
Components: cocoon-servlet
Affects Versions: 3.0.0-alpha-1, 3.0.0-alpha-2, 3.0.0-alpha-3, 3.0.0-beta-1
Reporter: Igor Malinin
Fix For: 3.0.0-beta-1
Attachments: java.patch
As reported at first in mailing list [1], AspectJ's static optimizer was
reviewed starting from 1.6.7 onward.
A temporary workaround for this is to force usage of version 1.6.6 of AspectJ
(quite ancient right now).
At the moment Cocoon 3 is using latest Spring (3.1) and AspectJ (1.6.12)
versions.
With Spring 3.1, this workaround is not enough any more.
One issue I reported already in mailing list when Jetty7 + recent AspectJ was
failing, not the same issue is deeper and ServletContextFactoryBean doesn't
work at all with Spring 3.1.
Note that ServletContext is already in the Spring web-app context, although
with another name ('servletContext'). This is available starting from Spring
3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext'
solves problem partially, but still fails on XMLSitemapServlet initialization
(as it uses static field in ServletContextFactoryBean).
I will attach a patch (a little bit dirty, but not more than the current
implementation). But it assumes at least Spring 3.0.
As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have
as a dependency at leas 3.0 version of Spring Framework (for Java5 generics
etc.)
[1]
http://old.nabble.com/Jetty-7---%22can%27t-determine-modifiers-of-missing-type-org.eclipse.jetty.webapp.WebAppContext$Context%22-error-td32314839.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer
[
https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177189#comment-13177189
]
Thorsten Scherler commented on COCOON3-85:
--
Actually @Francesco r1224754 broke the Stringtemplate example, meaning it
seems that everything is fine but in runtime that is not like that any more. It
seems as Igor described a problem of the class loader. Not sure though whether
it is fault of the RCL or the configurator, but I will try now to apply the
patch on my system and look whether that solves the problem.
To reproduce,
* just mvn clean install current Head
* cd cocoon-sample
* mvn jetty:run
* http://localhost:/string-template/generator - BANG!
{{{
2011-12-29 15:08:16.138:INFO:/:Initializing Spring root WebApplicationContext
2011-12-29 15:08:19.347:INFO:/:Apache Cocoon Spring Configurator v2.1.0 is
running in mode 'dev'.
2011-12-29 15:08:23.468:INFO:/:DispatcherServlet: Block dispatcher was
initialized successfully.
2011-12-29 15:08:23.581:INFO::Started SelectChannelConnector@0.0.0.0:
[INFO] Started Jetty Server
2011-12-29 15:08:35.365:INFO:/:Apache Cocoon Spring Configurator v2.1.0 is
running in mode 'dev'.
java.lang.Error: Unresolved compilation problem:
STRenderer cannot be resolved
at
org.apache.cocoon.stringtemplate.StringTemplateGenerator.renderTemplate(StringTemplateGenerator.java:152)
at
org.apache.cocoon.stringtemplate.StringTemplateGenerator.execute(StringTemplateGenerator.java:172)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:318)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at
org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:91)
at
org.apache.cocoon.profiling.aspects.InvocationDispatcher.dispatch(InvocationDispatcher.java:68)
at
org.apache.cocoon.profiling.aspects.PipelineComponentProfilingAspect.handleInvocation(PipelineComponentProfilingAspect.java:41)
at sun.reflect.GeneratedMethodAccessor73.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:621)
at
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:610)
at
org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:65)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:90)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
at $Proxy46.execute(Unknown Source)
at
org.apache.cocoon.pipeline.AbstractPipeline.invokeStarter(AbstractPipeline.java:150)
at
org.apache.cocoon.pipeline.AbstractPipeline.execute(AbstractPipeline.java:80)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:318)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at
org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:80)
at
org.apache.cocoon.servlet.collector.ResponseHeaderCollector.interceptInvoke(ResponseHeaderCollector.java:94)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139376#comment-13139376 ] Thorsten Scherler commented on COCOON3-77: -- Andre can you prepare a svn diff since I am really keen to apply this patch. Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding serializers (such as the EncodingHTMLSerializer). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
