[jira] [Updated] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Miceli updated COCOON3-95: --- Attachment: cocoon3-95.txt for act:src optional attribute Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: SitemapBuilder-COCOON-95.diff, cocoon3-95.txt, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Puerto updated COCOON3-95: - Attachment: SitemapBuilder-COCOON-95.diff Add schema validation to SitemapBuilder Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: SitemapBuilder-COCOON-95.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Puerto updated COCOON3-95: - Attachment: sitemap-schema.diff Update sitemap schema with caching pipeline attributes. Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Puerto updated COCOON3-95: - Attachment: sitemap-validation.tar.gz Sample block. Steps to reproduce: * mvn clean isntall jetty:run * Go to http://localhost:/test1.html (It should work) * Go to http://localhost:/test2.html (returns 200 but empty response, also NPE in logs) Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
