[jira] Commented: (COCOON-2195) Additional components and features.
[ https://issues.apache.org/jira/browse/COCOON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588221#action_12588221 ] Grzegorz Kossakowski commented on COCOON-2195: -- @Steven: Smaller patches make sense only if they are focused on one change (e.g. adding new component) and each one is annotaed with one-two sentences of description. I would love to see your patches applied in similar fasion it was done for COCOON-1993. Then it's easier to review patches because you focus on one thing only at the mmoment. @Reinhard: Sure. I wanted to review this code and the best way is to apply it but if you are want to do this I won't stop you. :-) Additional components and features. --- Key: COCOON-2195 URL: https://issues.apache.org/jira/browse/COCOON-2195 Project: Cocoon Issue Type: Improvement Components: Corona (experimental) Reporter: Steven Dolg Assignee: Grzegorz Kossakowski Attachments: patch.txt Additional components: * XSLT Transformer * first attempt at Controllers Additional features: * JNet integration (not finished, but working) * Mime-Type handling (not finished, but working) * Input parameters provided for all pipeline components * Controller can redirect to the sitemap (somewhat experimental) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2195) Additional components and features.
[ https://issues.apache.org/jira/browse/COCOON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12587771#action_12587771 ] Grzegorz Kossakowski commented on COCOON-2195: -- Thanks Steven for your work! One problem strikes me: it's 113kb of patch. This will be quite hard to review but I hope to have a look at it over the weekend. Could you split your patches into smaller chunks in a future? For this time I'll try to divide it into smaller commits. Additional components and features. --- Key: COCOON-2195 URL: https://issues.apache.org/jira/browse/COCOON-2195 Project: Cocoon Issue Type: Improvement Components: Corona (experimental) Reporter: Steven Dolg Attachments: patch.txt Additional components: * XSLT Transformer * first attempt at Controllers Additional features: * JNet integration (not finished, but working) * Mime-Type handling (not finished, but working) * Input parameters provided for all pipeline components * Controller can redirect to the sitemap (somewhat experimental) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2195) Additional components and features.
[ https://issues.apache.org/jira/browse/COCOON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12587849#action_12587849 ] Steven Dolg commented on COCOON-2195: - Of course I can create smaller patches. I'm sure you know that this will not reduce the actual amount of changes to review. But if you rather have 10 files instead of one, that's fine with me... Additional components and features. --- Key: COCOON-2195 URL: https://issues.apache.org/jira/browse/COCOON-2195 Project: Cocoon Issue Type: Improvement Components: Corona (experimental) Reporter: Steven Dolg Assignee: Grzegorz Kossakowski Attachments: patch.txt Additional components: * XSLT Transformer * first attempt at Controllers Additional features: * JNet integration (not finished, but working) * Mime-Type handling (not finished, but working) * Input parameters provided for all pipeline components * Controller can redirect to the sitemap (somewhat experimental) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2195) Additional components and features.
[ https://issues.apache.org/jira/browse/COCOON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12587850#action_12587850 ] Reinhard Poetz commented on COCOON-2195: Grzegorz, if you don't mind I will take care of this patch on Monday or Tuesday. Additional components and features. --- Key: COCOON-2195 URL: https://issues.apache.org/jira/browse/COCOON-2195 Project: Cocoon Issue Type: Improvement Components: Corona (experimental) Reporter: Steven Dolg Assignee: Grzegorz Kossakowski Attachments: patch.txt Additional components: * XSLT Transformer * first attempt at Controllers Additional features: * JNet integration (not finished, but working) * Mime-Type handling (not finished, but working) * Input parameters provided for all pipeline components * Controller can redirect to the sitemap (somewhat experimental) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
