Patch for NPE in ApplicationUtil (cocoon-auth-api)

2008-09-09 Thread Benjamin Boksa

Hi,

today I ran into a NPE when using ApplicationUtil.isUserInRole(…),  
attached is a patch that allows the User instance passed to  
isUserInRole(…) to be null.


Hope it is OK to submit a patch like that - if there is a better way  
to do it just let me know.


Best regards

Benjamin






Fwd: Patch for NPE in ApplicationUtil (cocoon-auth-api)

2008-09-09 Thread Benjamin Boksa

This time including the patch…



ApplicationUtil.java.patch
Description: Binary data




Anfang der weitergeleiteten E-Mail:


Von: Benjamin Boksa [EMAIL PROTECTED]
Datum: 9. September 2008 12:20:29 MESZ
An: dev@cocoon.apache.org
Betreff: Patch for NPE in ApplicationUtil (cocoon-auth-api)
Antwort an: dev@cocoon.apache.org

Hi,

today I ran into a NPE when using ApplicationUtil.isUserInRole(…),  
attached is a patch that allows the User instance passed to  
isUserInRole(…) to be null.


Hope it is OK to submit a patch like that - if there is a better way  
to do it just let me know.


Best regards

Benjamin








Re: Patch for NPE in ApplicationUtil (cocoon-auth-api)

2008-09-09 Thread Joerg Heinicke
Benjamin Boksa mailinglists at boksa.de writes:

 Hi,
 
 today I ran into a NPE when using ApplicationUtil.isUserInRole(…),  
 attached is a patch that allows the User instance passed to  
 isUserInRole(…) to be null.
 
 Hope it is OK to submit a patch like that - if there is a better way  
 to do it just let me know.

Hi Benjamin,

please file an issue in our bug-tracking system Jira [1]. This is especially for
legal reasons since you have to grant license to ASF to actually allow us to use
your patch in Cocoon. You will find this option I'm talking about when you
attach the patch to the issue.

Thanks,

Joerg

[1] https://issues.apache.org/jira/browse/COCOON



Re: Patch for NPE in ApplicationUtil (cocoon-auth-api)

2008-09-09 Thread Benjamin Boksa


Hi,

today I ran into a NPE when using ApplicationUtil.isUserInRole(…),
attached is a patch that allows the User instance passed to
isUserInRole(…) to be null.

Hope it is OK to submit a patch like that - if there is a better way
to do it just let me know.


Hi Benjamin,

please file an issue in our bug-tracking system Jira [1]. This is  
especially for
legal reasons since you have to grant license to ASF to actually  
allow us to use
your patch in Cocoon. You will find this option I'm talking about  
when you

attach the patch to the issue.

Thanks,

Joerg

[1] https://issues.apache.org/jira/browse/COCOON



Hi Joerg,

thanks - issue is filed [1]. Sorry for the second email.

HTH

Benjamin

[1] https://issues.apache.org/jira/browse/COCOON-2243