date:20160905

Re: Back to contributing to Commons Imaging

2016-09-05 Thread Amedee Van Gasse


Op 03-09-16 om 15:29 schreef sebb:

On 3 September 2016 at 13:14, Benedikt Ritter  wrote:

Hi Damjan,

nice you're back. I think there is only one thing left before 1.0 can ne
released and that is the findbugs violations. They are mainly about
exposure of internal state because the public API accepts byte arrays as
input parameter. An easy way to fix this would be to copy the arrays. But I
think that would be very bad for Performance...


On the other hand, if the existing API is kept, it's not going to be
possible to easily change the design without breaking compatibility.

The more internal state is exposed, the harder it is to change code in
the future.
And the harder it is to fully test the code.

I've not looked at the code recently, but would it be possible to wrap
the byte array in an object, and only provide access via methods?

It would be fairly easy to replace individual entry reads and writes
with getters and setters, but that might be too expensive for some
operations.
Depending on how many other such operations there are it might be
possible to provide other methods for them.


Regards,
Benedikt


As an actual user of Commons Imaging, I'd like to chime in and say: make 
those changes and break compatibility now.


--
Amedee Van Gasse
QA Engineer | iText Software BVBA
amedee.vanga...@itextpdf.com
http://itextpdf.com

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-bcel pull request #10: BCEL-276 LocalVariableTypeTable is not update...

2016-09-05 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-bcel/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build is back to normal : Commons-Compress-Windows » Apache Commons Compress #56

2016-09-05 Thread Apache Jenkins Server

See 



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build is back to normal : Commons-Compress-Windows #56

2016-09-05 Thread Apache Jenkins Server

See 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Build failed in Jenkins: Commons-Compress-Windows #55

2016-09-05 Thread Apache Jenkins Server

See 

Changes:

[ggregory] Use try with resources.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on windows2 (Windows) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/commons-compress.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/commons-compress.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/commons-compress.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse "refs/remotes/origin/master^{commit}" # timeout=10
 > git rev-parse "refs/remotes/origin/origin/master^{commit}" # timeout=10
Checking out Revision 7ee18aa0cc99a429e6ff9e3fe4b5e73f91b99776 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 7ee18aa0cc99a429e6ff9e3fe4b5e73f91b99776
 > git rev-list e71827b5db22d81e0b009f3e205173ce643d2e8e # timeout=10
Setting JDK_1_7_LATEST__HOME=f:\jenkins\tools\java\latest-1.7-64
Parsing POMs
Established TCP socket on 51261
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[Commons-Compress-Windows] $ f:\jenkins\tools\java\latest-1.7-64/bin/java 
-Xmx2g -Xms256m -XX:MaxPermSize=512m -cp 
f:\jenkins\jenkins-slave\maven32-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\jenkins\tools\maven\latest3/conf/logging
 jenkins.maven3.agent.Maven32Main f:\jenkins\tools\maven\latest3 
F:\jenkins\jenkins-slave\slave.jar 
f:\jenkins\jenkins-slave\maven32-interceptor.jar 
f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 51261
ERROR: Failed to parse POMs
java.io.IOException: Cannot run program 
"f:\jenkins\tools\java\latest-1.7-64/bin/java" (in directory 
": CreateProcess 
error=2, The system cannot find the file specified
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:240)
at hudson.Proc$LocalProc.(Proc.java:212)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1148)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1113)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:328)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at hudson.remoting.Engine$1$1.run(Engine.java:63)
at java.lang.Thread.run(Unknown Source)
at ..remote call to windows2(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:781)
at hudson.Launcher$RemoteLauncher.launch(Launcher.java:928)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at 
hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:281)
at hudson.maven.ProcessCache.get(ProcessCache.java:236)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:778)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1741)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:531)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find 
the file specified
at java.lang.ProcessImpl.create(Native Method)
at java.lang.ProcessImpl.(Unknown Source)
at java.lang.ProcessImpl.start(Unknown Source)
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:240)
at hudson.Proc$LocalProc.(Proc.java:212)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1148)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher

Build failed in Jenkins: Commons-Compress-Windows #54

2016-09-05 Thread Apache Jenkins Server

See 

Changes:

[ggregory] Use try with resources.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on windows2 (Windows) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/commons-compress.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/commons-compress.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/commons-compress.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse "refs/remotes/origin/master^{commit}" # timeout=10
 > git rev-parse "refs/remotes/origin/origin/master^{commit}" # timeout=10
Checking out Revision e71827b5db22d81e0b009f3e205173ce643d2e8e 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e71827b5db22d81e0b009f3e205173ce643d2e8e
 > git rev-list 159d9c646d598edde1dbf2e20bb3879abaea7694 # timeout=10
Setting JDK_1_7_LATEST__HOME=f:\jenkins\tools\java\latest-1.7-64
Parsing POMs
Established TCP socket on 51257
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[Commons-Compress-Windows] $ f:\jenkins\tools\java\latest-1.7-64/bin/java 
-Xmx2g -Xms256m -XX:MaxPermSize=512m -cp 
f:\jenkins\jenkins-slave\maven32-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\jenkins\tools\maven\latest3/conf/logging
 jenkins.maven3.agent.Maven32Main f:\jenkins\tools\maven\latest3 
F:\jenkins\jenkins-slave\slave.jar 
f:\jenkins\jenkins-slave\maven32-interceptor.jar 
f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 51257
ERROR: Failed to parse POMs
java.io.IOException: Cannot run program 
"f:\jenkins\tools\java\latest-1.7-64/bin/java" (in directory 
": CreateProcess 
error=2, The system cannot find the file specified
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:240)
at hudson.Proc$LocalProc.(Proc.java:212)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1148)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1113)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:328)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at hudson.remoting.Engine$1$1.run(Engine.java:63)
at java.lang.Thread.run(Unknown Source)
at ..remote call to windows2(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:781)
at hudson.Launcher$RemoteLauncher.launch(Launcher.java:928)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at 
hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:281)
at hudson.maven.ProcessCache.get(ProcessCache.java:236)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:778)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1741)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:531)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find 
the file specified
at java.lang.ProcessImpl.create(Native Method)
at java.lang.ProcessImpl.(Unknown Source)
at java.lang.ProcessImpl.start(Unknown Source)
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:240)
at hudson.Proc$LocalProc.(Proc.java:212)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1148)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher

Re: commons-compress git commit: Avoid unclosed stream warnings

2016-09-05 Thread Gary Gregory

I updated this test to use try with resources, which is also one less
warning per instance of the allocate/close pattern.

Gary

On Mon, Sep 5, 2016 at 1:49 PM,  wrote:

> Repository: commons-compress
> Updated Branches:
>   refs/heads/master 52dd5908e -> 159d9c646
>
>
> Avoid unclosed stream warnings
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/
> commit/159d9c64
> Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/
> tree/159d9c64
> Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/
> diff/159d9c64
>
> Branch: refs/heads/master
> Commit: 159d9c646d598edde1dbf2e20bb3879abaea7694
> Parents: 52dd590
> Author: Sebb 
> Authored: Mon Sep 5 18:48:57 2016 +0100
> Committer: Sebb 
> Committed: Mon Sep 5 18:48:57 2016 +0100
>
> --
>  .../java/org/apache/commons/compress/utils/BitInputStreamTest.java | 2 ++
>  1 file changed, 2 insertions(+)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/commons-compress/
> blob/159d9c64/src/test/java/org/apache/commons/compress/
> utils/BitInputStreamTest.java
> --
> diff --git 
> a/src/test/java/org/apache/commons/compress/utils/BitInputStreamTest.java
> b/src/test/java/org/apache/commons/compress/utils/BitInputStreamTest.java
> index 11ff956..c9cfbd2 100644
> --- a/src/test/java/org/apache/commons/compress/utils/
> BitInputStreamTest.java
> +++ b/src/test/java/org/apache/commons/compress/utils/
> BitInputStreamTest.java
> @@ -143,6 +143,7 @@ public class BitInputStreamTest {
>  assertEquals(1186, // 01001010-0010
>   bin.readBits(12));
>  assertEquals(-1 , bin.readBits(1));
> +bin.close();
>  }
>
>  @Test
> @@ -167,6 +168,7 @@ public class BitInputStreamTest {
>  assertEquals(330, // 0001-01001010
>   bin.readBits(12));
>  assertEquals(-1 , bin.readBits(1));
> +bin.close();
>  }
>
>  private ByteArrayInputStream getStream() {
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Build failed in Jenkins: Commons-Compress-Windows #53

2016-09-05 Thread Apache Jenkins Server

See 

Changes:

[sebb] Avoid unclosed stream warnings

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on windows2 (Windows) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/commons-compress.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/commons-compress.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/commons-compress.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse "refs/remotes/origin/master^{commit}" # timeout=10
 > git rev-parse "refs/remotes/origin/origin/master^{commit}" # timeout=10
Checking out Revision 159d9c646d598edde1dbf2e20bb3879abaea7694 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 159d9c646d598edde1dbf2e20bb3879abaea7694
 > git rev-list 52dd5908e374973d69c51856b74d4d93d591c90a # timeout=10
Setting JDK_1_7_LATEST__HOME=f:\jenkins\tools\java\latest-1.7-64
Parsing POMs
Established TCP socket on 51254
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[Commons-Compress-Windows] $ f:\jenkins\tools\java\latest-1.7-64/bin/java 
-Xmx2g -Xms256m -XX:MaxPermSize=512m -cp 
f:\jenkins\jenkins-slave\maven32-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\jenkins\tools\maven\latest3/conf/logging
 jenkins.maven3.agent.Maven32Main f:\jenkins\tools\maven\latest3 
F:\jenkins\jenkins-slave\slave.jar 
f:\jenkins\jenkins-slave\maven32-interceptor.jar 
f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 51254
ERROR: Failed to parse POMs
java.io.IOException: Cannot run program 
"f:\jenkins\tools\java\latest-1.7-64/bin/java" (in directory 
": CreateProcess 
error=2, The system cannot find the file specified
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:240)
at hudson.Proc$LocalProc.(Proc.java:212)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1148)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1113)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:328)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at hudson.remoting.Engine$1$1.run(Engine.java:63)
at java.lang.Thread.run(Unknown Source)
at ..remote call to windows2(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:781)
at hudson.Launcher$RemoteLauncher.launch(Launcher.java:928)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at 
hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:281)
at hudson.maven.ProcessCache.get(ProcessCache.java:236)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:778)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1741)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:531)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find 
the file specified
at java.lang.ProcessImpl.create(Native Method)
at java.lang.ProcessImpl.(Unknown Source)
at java.lang.ProcessImpl.start(Unknown Source)
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:240)
at hudson.Proc$LocalProc.(Proc.java:212)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
at hudson.Launcher$ProcStarter.start(Launcher.java:381)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1148)
at hudson.Launcher$RemoteLaunchCallable.call(Launc

Early Access builds of JDK 9 b134 are available on java.net

2016-09-05 Thread Rory O'Donnell



Hi Benedikt,

Early Access b134  for JDK 9 is 
available on java.net, summary of  changes are listed here 
.


 There have been a number of fixes , since the last availability email 
, to bugs reported by Open Source projects :


 * 8156841sun.security.pkcs11.SunPKCS11 poller thread retains a
   strong reference to the context class loader
 * 8146961   Fix PermGen memory leaks caused by static final Exceptions
 * 8163353   NPE in ConcurrentHashMap.removeAll()
 * 8160328   ClassCastException: sun.awt.image.BufImgSurfaceData cannot
   be cast to sun.java2d.xr.XRSurfaceData after xrandr change output

Secondly, there are a number of interesting items to bring to our attention

 * JDK 9 Rampdown Phase 1: Process proposal [1]
 * The Java team has published the “Oracle JRE and JDK Cryptographic
   Roadmap” [2] java.com/cryptoroadmap 
 * The Quality Report for September 2016 is now available [3], thank
   you for your continued support!


Highlights from the Quality Report for September :

 * 21 new Open Source projects have joined the Outreach program
 * Projects filed 35 new issues in the JDK Bug System, this is almost
   double the number of bugs in the previous six months!
 * Continuing to provide excellent feedback via the OpenJDK dev mailing
   lists

Thank you!

Rgds,Rory

[1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004777.html
[2] java.com/cryptoroadmap 
[3] 
https://wiki.openjdk.java.net/display/quality/Quality+Outreach+Report+September+2016


--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

Re: Back to contributing to Commons Imaging

[GitHub] commons-bcel pull request #10: BCEL-276 LocalVariableTypeTable is not update...

Jenkins build is back to normal : Commons-Compress-Windows » Apache Commons Compress #56

Jenkins build is back to normal : Commons-Compress-Windows #56

Build failed in Jenkins: Commons-Compress-Windows #55

Build failed in Jenkins: Commons-Compress-Windows #54

Re: commons-compress git commit: Avoid unclosed stream warnings

Build failed in Jenkins: Commons-Compress-Windows #53

Early Access builds of JDK 9 b134 are available on java.net

9 matches

Site Navigation

Mail list logo

Footer information