Re: [ALL] hashes of signatures

[Matt Benson]

Hi Chas,
  I saw that change but the hashes of signatures to which I am referring
applied to all uploaded artifacts, not just the source archives. :)

Matt

On Mon, Oct 31, 2016 at 1:06 PM, Chas Honton  wrote:

> There was an update in parent to prevent excess jars from being attached
> as artifacts.
>
> https://svn.apache.org/viewvc/view=revision=1755904
>
>
> I don't believe it's been released.
>
> Chas
>
> > On Oct 31, 2016, at 9:53 AM, Matt Benson  wrote:
> >
> > Thanks for repying, but that seems backward: signatures of hashes. I'm
> > talking about ending up with *.jar.asc.md5 and *.jar.asc.sha1 . :)
> >
> > Matt
> >
> > On Mon, Oct 31, 2016 at 11:32 AM, Stian Soiland-Reyes 
> > wrote:
> >
> >> In Commons RDF we used this:
> >>
> >>
> >>
> >>   
> >>org.apache.maven.plugins
> >>maven-gpg-plugin
> >>
> >>
> >>**/*.asc
> >>**/*.md5
> >>**/*.sha1
> >>
> >>
> >>
> >>
> >>
> >> is that sufficient in Bval?  If so we can add it to commons-parent.
> >>
> >>
> >>
> >>> On 31 October 2016 at 15:58, Matt Benson  wrote:
> >>> The release procedures mention the problem of these extraneous files in
> >> the
> >>> Nexus staging repo. I have noticed during the last couple of [weaver]
> >>> release cycles that these files no longer show up and had thought it
> was
> >>> something they had fixed on Nexus. Then I rolled a vote candidate for
> >>> Apache BVal and find the files are there on the staging repo. Is anyone
> >>> aware of having fixed this issue in the Commons build? I can't find any
> >>> config that seems relevant.
> >>>
> >>> Thanks,
> >>> Matt
> >>
> >>
> >>
> >> --
> >> Stian Soiland-Reyes
> >> http://orcid.org/-0001-9842-9718
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [ALL] hashes of signatures

[Chas Honton]

There was an update in parent to prevent excess jars from being attached as 
artifacts. 

https://svn.apache.org/viewvc/view=revision=1755904


I don't believe it's been released. 

Chas

> On Oct 31, 2016, at 9:53 AM, Matt Benson  wrote:
> 
> Thanks for repying, but that seems backward: signatures of hashes. I'm
> talking about ending up with *.jar.asc.md5 and *.jar.asc.sha1 . :)
> 
> Matt
> 
> On Mon, Oct 31, 2016 at 11:32 AM, Stian Soiland-Reyes 
> wrote:
> 
>> In Commons RDF we used this:
>> 
>>
>>
>>   
>>org.apache.maven.plugins
>>maven-gpg-plugin
>>
>>
>>**/*.asc
>>**/*.md5
>>**/*.sha1
>>
>>
>>
>>
>> 
>> is that sufficient in Bval?  If so we can add it to commons-parent.
>> 
>> 
>> 
>>> On 31 October 2016 at 15:58, Matt Benson  wrote:
>>> The release procedures mention the problem of these extraneous files in
>> the
>>> Nexus staging repo. I have noticed during the last couple of [weaver]
>>> release cycles that these files no longer show up and had thought it was
>>> something they had fixed on Nexus. Then I rolled a vote candidate for
>>> Apache BVal and find the files are there on the staging repo. Is anyone
>>> aware of having fixed this issue in the Commons build? I can't find any
>>> config that seems relevant.
>>> 
>>> Thanks,
>>> Matt
>> 
>> 
>> 
>> --
>> Stian Soiland-Reyes
>> http://orcid.org/-0001-9842-9718
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL] hashes of signatures

[Matt Benson]

Thanks for repying, but that seems backward: signatures of hashes. I'm
talking about ending up with *.jar.asc.md5 and *.jar.asc.sha1 . :)

Matt

On Mon, Oct 31, 2016 at 11:32 AM, Stian Soiland-Reyes 
wrote:

> In Commons RDF we used this:
>
> 
> 
>
> org.apache.maven.plugins
> maven-gpg-plugin
> 
> 
> **/*.asc
> **/*.md5
> **/*.sha1
> 
> 
> 
> 
>
> is that sufficient in Bval?  If so we can add it to commons-parent.
>
>
>
> On 31 October 2016 at 15:58, Matt Benson  wrote:
> > The release procedures mention the problem of these extraneous files in
> the
> > Nexus staging repo. I have noticed during the last couple of [weaver]
> > release cycles that these files no longer show up and had thought it was
> > something they had fixed on Nexus. Then I rolled a vote candidate for
> > Apache BVal and find the files are there on the staging repo. Is anyone
> > aware of having fixed this issue in the Commons build? I can't find any
> > config that seems relevant.
> >
> > Thanks,
> > Matt
>
>
>
> --
> Stian Soiland-Reyes
> http://orcid.org/-0001-9842-9718
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [ALL] hashes of signatures

[Stian Soiland-Reyes]

In Commons RDF we used this:



   
org.apache.maven.plugins
maven-gpg-plugin


**/*.asc
**/*.md5
**/*.sha1





is that sufficient in Bval?  If so we can add it to commons-parent.



On 31 October 2016 at 15:58, Matt Benson  wrote:
> The release procedures mention the problem of these extraneous files in the
> Nexus staging repo. I have noticed during the last couple of [weaver]
> release cycles that these files no longer show up and had thought it was
> something they had fixed on Nexus. Then I rolled a vote candidate for
> Apache BVal and find the files are there on the staging repo. Is anyone
> aware of having fixed this issue in the Commons build? I can't find any
> config that seems relevant.
>
> Thanks,
> Matt



-- 
Stian Soiland-Reyes
http://orcid.org/-0001-9842-9718

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ALL] hashes of signatures

[Matt Benson]

The release procedures mention the problem of these extraneous files in the
Nexus staging repo. I have noticed during the last couple of [weaver]
release cycles that these files no longer show up and had thought it was
something they had fixed on Nexus. Then I rolled a vote candidate for
Apache BVal and find the files are there on the staging repo. Is anyone
aware of having fixed this issue in the Commons build? I can't find any
config that seems relevant.

Thanks,
Matt

Re: [VOTE] DBCP 2.2 rc2

[Stian Soiland-Reyes]

Here's an approach we used in Jena with partial success:

https://github.com/apache/jena/tree/master/apache-jena-osgi/jena-osgi-test

Uses PaxExam - https://ops4j1.jira.com/wiki/display/paxexam/Pax+Exam


On 31 October 2016 at 15:22, Matt Sicker  wrote:
> Oh, yes, rc2 is cancelled. I forgot to clean up.
>
> And yes, help is appreciated. I haven't had a chance to look back at this,
> but one of the things we wanted to accomplish with this bug fix was to also
> introduce a pattern for black box testing Commons libraries in OSGi.
>
> On 31 October 2016 at 10:15, Stian Soiland-Reyes  wrote:
>
>> Hi, Matt,
>>
>> Was this DBCP Release Candidate vote cancelled..? I noticed it is still in
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1196/
>> https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC2/
>>
>>
>> BTW - do you need some help with
>> https://issues.apache.org/jira/browse/DBCP-454 ?
>>
>> In Taverna we had as simular issue which we worked around by declaring
>> javax.activation as part of org.osgi.framework.system.packages.extra
>> .. not sure if that helps:
>>
>> https://github.com/apache/incubator-taverna-commandline/commit/
>> d63f91eea3c15a2df56c5eb3000f7c4f8c6152d5
>>
>> On 9 August 2016 at 17:01, Gary Gregory  wrote:
>> > On Tue, Aug 9, 2016 at 8:27 AM, Matt Sicker  wrote:
>> >
>> >> Yes, I'd like to make a decent integration test for this. This could
>> have
>> >> helped the original bugfix that caused this new bug, too. :)
>> >>
>> >
>> > Yes, that's worth doing. Too bad it will delay DBCP, but there is a nice
>> > upshot with a new reusable integration test.
>> >
>> > Gary
>> >
>> >>
>> >> On 9 August 2016 at 10:23, Gary Gregory  wrote:
>> >>
>> >> > This is more than likely something all Commons components could
>> benefit
>> >> > from... I would be really nice to capture your testing in an
>> integration
>> >> > test we can run from Maven.
>> >> >
>> >> > We could put anything generic in a Commons OSGi component even if it
>> only
>> >> > has test code.
>> >> >
>> >> > Gary
>> >> >
>> >> > On Mon, Aug 8, 2016 at 10:17 AM, Matt Sicker 
>> wrote:
>> >> >
>> >> > > Damn, I'm still having OSGi issues with this RC. I've reopened
>> >> > > https://issues.apache.org/jira/browse/DBCP-454 to investigate. I
>> may
>> >> > need
>> >> > > to cut an rc3, though.
>> >> > >
>> >> > > On 7 August 2016 at 14:03, Matt Sicker  wrote:
>> >> > >
>> >> > > > We have fixed quite a few bugs and added some significant
>> >> enhancements
>> >> > > > since DBCP 2.1.1 was released, so I would like to release DBCP
>> 2.2.
>> >> > > >
>> >> > > > Changes since 2.2 rc1:
>> >> > > > * Added a bug fix from jira that wasn't included in the release
>> notes
>> >> > as
>> >> > > > it had the wrong fix version attached.
>> >> > > > * Fixed DBCP-454.
>> >> > > > * Fixed scm link to point to the future DBCP_2_2 tag instead of
>> the
>> >> > > > release candidate tag.
>> >> > > > * Added link to 2.2 javadocs on sidebar.
>> >> > > > * Various fumblings with subversion.
>> >> > > >
>> >> > > > DBCP 2.2 RC2 is available for review here:
>> >> > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_
>> 2_RC2
>> >> > > (svn
>> >> > > > revision 14694)
>> >> > > >
>> >> > > > The tag is here:
>> >> > > > https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/
>> >> > > > DBCP_2_2_RC2/ (svn revision 1755453)
>> >> > > > N.B. the SVN revision is required because SVN tags are not
>> >> > immutable.
>> >> > > >
>> >> > > > Maven artifacts are here:
>> >> > > > https://repository.apache.org/content/repositories/
>> >> > > > orgapachecommons-1196/
>> >> > > >
>> >> > > > These are the Maven artifacts and their sha256 hashes
>> >> > > >
>> >> > > > 64a093b7fa2ca077b8f1cce5847308c0c89fed20fc33e499f559e00b7ba526aa
>> >> > > > commons-dbcp2-2.2.jar
>> >> > > > 22c3b706e8590f92688dc91399427daa3bbd35e3da0b31375d45877d2ca193f2
>> >> > > > commons-dbcp2-2.2-javadoc.jar
>> >> > > > 5dfe8ead3d3626d76e37f19fe26555c1caeedc071e74cacab0693bdf41c33e08
>> >> > > > commons-dbcp2-2.2-sources.jar
>> >> > > > 32c35b92a48f179ad9de8ee3d3a8acad4baf002a4878f03174adb0d486e8b98c
>> >> > > > commons-dbcp2-2.2-tests.jar
>> >> > > > 6333a2bca35bd127b364b8494b1eee69942fe00474af4fd2a33ec493aa9b1997
>> >> > > > commons-dbcp2-2.2-test-sources.jar
>> >> > > >
>> >> > > > I have tested this with JDK 1.7 (u111) and 1.8 (u102) using Maven
>> >> > 3.3.9.
>> >> > > >
>> >> > > > Details of changes since 2.1.1 are in the release notes:
>> >> > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_
>> >> > > > 2_RC2/RELEASE-NOTES.txt
>> >> > > > http://musigma.org/dbcp/changes-report.html
>> >> > > >
>> >> > > > Site (hosted on GitHub ):
>> >> > > > http://musigma.org/dbcp/
>> >> > > >   (note some *relative* links are broken and the 2.2 

Re: [VOTE] DBCP 2.2 rc2

[Matt Sicker]

Oh, yes, rc2 is cancelled. I forgot to clean up.

And yes, help is appreciated. I haven't had a chance to look back at this,
but one of the things we wanted to accomplish with this bug fix was to also
introduce a pattern for black box testing Commons libraries in OSGi.

On 31 October 2016 at 10:15, Stian Soiland-Reyes  wrote:

> Hi, Matt,
>
> Was this DBCP Release Candidate vote cancelled..? I noticed it is still in
>
> https://repository.apache.org/content/repositories/orgapachecommons-1196/
> https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC2/
>
>
> BTW - do you need some help with
> https://issues.apache.org/jira/browse/DBCP-454 ?
>
> In Taverna we had as simular issue which we worked around by declaring
> javax.activation as part of org.osgi.framework.system.packages.extra
> .. not sure if that helps:
>
> https://github.com/apache/incubator-taverna-commandline/commit/
> d63f91eea3c15a2df56c5eb3000f7c4f8c6152d5
>
> On 9 August 2016 at 17:01, Gary Gregory  wrote:
> > On Tue, Aug 9, 2016 at 8:27 AM, Matt Sicker  wrote:
> >
> >> Yes, I'd like to make a decent integration test for this. This could
> have
> >> helped the original bugfix that caused this new bug, too. :)
> >>
> >
> > Yes, that's worth doing. Too bad it will delay DBCP, but there is a nice
> > upshot with a new reusable integration test.
> >
> > Gary
> >
> >>
> >> On 9 August 2016 at 10:23, Gary Gregory  wrote:
> >>
> >> > This is more than likely something all Commons components could
> benefit
> >> > from... I would be really nice to capture your testing in an
> integration
> >> > test we can run from Maven.
> >> >
> >> > We could put anything generic in a Commons OSGi component even if it
> only
> >> > has test code.
> >> >
> >> > Gary
> >> >
> >> > On Mon, Aug 8, 2016 at 10:17 AM, Matt Sicker 
> wrote:
> >> >
> >> > > Damn, I'm still having OSGi issues with this RC. I've reopened
> >> > > https://issues.apache.org/jira/browse/DBCP-454 to investigate. I
> may
> >> > need
> >> > > to cut an rc3, though.
> >> > >
> >> > > On 7 August 2016 at 14:03, Matt Sicker  wrote:
> >> > >
> >> > > > We have fixed quite a few bugs and added some significant
> >> enhancements
> >> > > > since DBCP 2.1.1 was released, so I would like to release DBCP
> 2.2.
> >> > > >
> >> > > > Changes since 2.2 rc1:
> >> > > > * Added a bug fix from jira that wasn't included in the release
> notes
> >> > as
> >> > > > it had the wrong fix version attached.
> >> > > > * Fixed DBCP-454.
> >> > > > * Fixed scm link to point to the future DBCP_2_2 tag instead of
> the
> >> > > > release candidate tag.
> >> > > > * Added link to 2.2 javadocs on sidebar.
> >> > > > * Various fumblings with subversion.
> >> > > >
> >> > > > DBCP 2.2 RC2 is available for review here:
> >> > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_
> 2_RC2
> >> > > (svn
> >> > > > revision 14694)
> >> > > >
> >> > > > The tag is here:
> >> > > > https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/
> >> > > > DBCP_2_2_RC2/ (svn revision 1755453)
> >> > > > N.B. the SVN revision is required because SVN tags are not
> >> > immutable.
> >> > > >
> >> > > > Maven artifacts are here:
> >> > > > https://repository.apache.org/content/repositories/
> >> > > > orgapachecommons-1196/
> >> > > >
> >> > > > These are the Maven artifacts and their sha256 hashes
> >> > > >
> >> > > > 64a093b7fa2ca077b8f1cce5847308c0c89fed20fc33e499f559e00b7ba526aa
> >> > > > commons-dbcp2-2.2.jar
> >> > > > 22c3b706e8590f92688dc91399427daa3bbd35e3da0b31375d45877d2ca193f2
> >> > > > commons-dbcp2-2.2-javadoc.jar
> >> > > > 5dfe8ead3d3626d76e37f19fe26555c1caeedc071e74cacab0693bdf41c33e08
> >> > > > commons-dbcp2-2.2-sources.jar
> >> > > > 32c35b92a48f179ad9de8ee3d3a8acad4baf002a4878f03174adb0d486e8b98c
> >> > > > commons-dbcp2-2.2-tests.jar
> >> > > > 6333a2bca35bd127b364b8494b1eee69942fe00474af4fd2a33ec493aa9b1997
> >> > > > commons-dbcp2-2.2-test-sources.jar
> >> > > >
> >> > > > I have tested this with JDK 1.7 (u111) and 1.8 (u102) using Maven
> >> > 3.3.9.
> >> > > >
> >> > > > Details of changes since 2.1.1 are in the release notes:
> >> > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_
> >> > > > 2_RC2/RELEASE-NOTES.txt
> >> > > > http://musigma.org/dbcp/changes-report.html
> >> > > >
> >> > > > Site (hosted on GitHub ):
> >> > > > http://musigma.org/dbcp/
> >> > > >   (note some *relative* links are broken and the 2.2 directories
> are
> >> > > >   not yet created - these will be OK once the site is deployed)
> >> > > >
> >> > > > Clirr Report (compared to 2.1.1):
> >> > > > http://musigma.org/dbcp/clirr-report.html
> >> > > >
> >> > > > RAT Report:
> >> > > > http://musigma.org/dbcp/rat-report.html
> >> > > >
> >> > > > KEYS:
> >> > > >   https://www.apache.org/dist/commons/KEYS
> >> > > >
> >> > > > 

Re: [VOTE] DBCP 2.2 rc2

[Stian Soiland-Reyes]

Hi, Matt,

Was this DBCP Release Candidate vote cancelled..? I noticed it is still in

https://repository.apache.org/content/repositories/orgapachecommons-1196/
https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC2/


BTW - do you need some help with
https://issues.apache.org/jira/browse/DBCP-454 ?

In Taverna we had as simular issue which we worked around by declaring
javax.activation as part of org.osgi.framework.system.packages.extra
.. not sure if that helps:

https://github.com/apache/incubator-taverna-commandline/commit/d63f91eea3c15a2df56c5eb3000f7c4f8c6152d5

On 9 August 2016 at 17:01, Gary Gregory  wrote:
> On Tue, Aug 9, 2016 at 8:27 AM, Matt Sicker  wrote:
>
>> Yes, I'd like to make a decent integration test for this. This could have
>> helped the original bugfix that caused this new bug, too. :)
>>
>
> Yes, that's worth doing. Too bad it will delay DBCP, but there is a nice
> upshot with a new reusable integration test.
>
> Gary
>
>>
>> On 9 August 2016 at 10:23, Gary Gregory  wrote:
>>
>> > This is more than likely something all Commons components could benefit
>> > from... I would be really nice to capture your testing in an integration
>> > test we can run from Maven.
>> >
>> > We could put anything generic in a Commons OSGi component even if it only
>> > has test code.
>> >
>> > Gary
>> >
>> > On Mon, Aug 8, 2016 at 10:17 AM, Matt Sicker  wrote:
>> >
>> > > Damn, I'm still having OSGi issues with this RC. I've reopened
>> > > https://issues.apache.org/jira/browse/DBCP-454 to investigate. I may
>> > need
>> > > to cut an rc3, though.
>> > >
>> > > On 7 August 2016 at 14:03, Matt Sicker  wrote:
>> > >
>> > > > We have fixed quite a few bugs and added some significant
>> enhancements
>> > > > since DBCP 2.1.1 was released, so I would like to release DBCP 2.2.
>> > > >
>> > > > Changes since 2.2 rc1:
>> > > > * Added a bug fix from jira that wasn't included in the release notes
>> > as
>> > > > it had the wrong fix version attached.
>> > > > * Fixed DBCP-454.
>> > > > * Fixed scm link to point to the future DBCP_2_2 tag instead of the
>> > > > release candidate tag.
>> > > > * Added link to 2.2 javadocs on sidebar.
>> > > > * Various fumblings with subversion.
>> > > >
>> > > > DBCP 2.2 RC2 is available for review here:
>> > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC2
>> > > (svn
>> > > > revision 14694)
>> > > >
>> > > > The tag is here:
>> > > > https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/
>> > > > DBCP_2_2_RC2/ (svn revision 1755453)
>> > > > N.B. the SVN revision is required because SVN tags are not
>> > immutable.
>> > > >
>> > > > Maven artifacts are here:
>> > > > https://repository.apache.org/content/repositories/
>> > > > orgapachecommons-1196/
>> > > >
>> > > > These are the Maven artifacts and their sha256 hashes
>> > > >
>> > > > 64a093b7fa2ca077b8f1cce5847308c0c89fed20fc33e499f559e00b7ba526aa
>> > > > commons-dbcp2-2.2.jar
>> > > > 22c3b706e8590f92688dc91399427daa3bbd35e3da0b31375d45877d2ca193f2
>> > > > commons-dbcp2-2.2-javadoc.jar
>> > > > 5dfe8ead3d3626d76e37f19fe26555c1caeedc071e74cacab0693bdf41c33e08
>> > > > commons-dbcp2-2.2-sources.jar
>> > > > 32c35b92a48f179ad9de8ee3d3a8acad4baf002a4878f03174adb0d486e8b98c
>> > > > commons-dbcp2-2.2-tests.jar
>> > > > 6333a2bca35bd127b364b8494b1eee69942fe00474af4fd2a33ec493aa9b1997
>> > > > commons-dbcp2-2.2-test-sources.jar
>> > > >
>> > > > I have tested this with JDK 1.7 (u111) and 1.8 (u102) using Maven
>> > 3.3.9.
>> > > >
>> > > > Details of changes since 2.1.1 are in the release notes:
>> > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_
>> > > > 2_RC2/RELEASE-NOTES.txt
>> > > > http://musigma.org/dbcp/changes-report.html
>> > > >
>> > > > Site (hosted on GitHub ):
>> > > > http://musigma.org/dbcp/
>> > > >   (note some *relative* links are broken and the 2.2 directories are
>> > > >   not yet created - these will be OK once the site is deployed)
>> > > >
>> > > > Clirr Report (compared to 2.1.1):
>> > > > http://musigma.org/dbcp/clirr-report.html
>> > > >
>> > > > RAT Report:
>> > > > http://musigma.org/dbcp/rat-report.html
>> > > >
>> > > > KEYS:
>> > > >   https://www.apache.org/dist/commons/KEYS
>> > > >
>> > > > Please review the release candidate and vote.
>> > > > This vote will close no sooner that 72 hours from now,
>> > > > i.e. sometime after 10-Aug-2016
>> > > >
>> > > >   [ ] +1 Release these artifacts
>> > > >   [ ] +0 OK, but...
>> > > >   [ ] -0 OK, but really should fix...
>> > > >   [ ] -1 I oppose this release because...
>> > > >
>> > > > Thanks!
>> > > >
>> > > > --
>> > > > Matt Sicker 
>> > > >
>> > >
>> > >
>> > >
>> > > --
>> > > Matt Sicker 
>> > >
>> >
>> >
>> >
>> > --
>> > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> > Java 

Re: [Math] Re: LU decomposition very SLOW (commons.math3.linear)

[wilbur]

OK, I built 'LUDecomposition' back to match the original Jama version and
fixed a few things on the way. Performance is consistently much better and I
did not notice any differences in numerical accuracy. While this appears to
be the same algorithm, I have not figured out why (though I can see WHERE)
the current CM implementation wastes so much time.

Working myself through the code I ran into two other issues that should be
fixed but will change the behavior of this class:

1) The decomposition algorithm works fine even if the input matrix A is
singular. However, the current implementation exits the constructor as soon
as singularity is detected and the methods getL(), getU(), and getP() return
null. I propose to let the decomposition complete even for singular matrices
and always return a valid decomposition. As usual, the returned
'DecompositionSolver' will raise an exception when solve() is invoked on a
singular matrix.

2) In the current implementation, the methods getL(), getU(), and getP()
return references to the SAME (cached) matrix objects in successive calls.
This appears to be unjustified and bad programming practice, since
RealMatrix objects are mutable. For some reason, though, this is considered
an important feature, since it is explicitly tested for in the JUnit test. I
propose to cache the corresponding primitive arrays and return a new matrix
instance in every call (modified the JUnit test).

Also, I see no reason to make the inner class 'Solver' *static*, since such
an object cannot exist without the associated LUDecomposition itself. I this
changed this to a non-static inner class. (Same strange pattern is used in
QRDecomposition and probably elsewhere.)

My proposed re-implementation can be found  here

  
and the associated JUnit tests  here

 
.

TODO: The class 'FieldLUDecomposition' does the same but on a different
matrix type -- needs to be reworked as well (possibly avoiding code
duplication).

Anyone please let me know in case of any objections or possible
enhancements.

Regards,
Wilhelm

___
PS: Being new to this list I am not sure how to properly create issues,
since they are not open on GitHub.





--
View this message in context: 
http://apache-commons.680414.n4.nabble.com/Re-Math-Re-LU-decomposition-very-SLOW-commons-math3-linear-tp4692297p4692312.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org