Re: New git mirror created: commons-pool.git

[Matt Sicker]

By the way, a link to this guide in the wiki could be useful for future
reference:

https://git-scm.com/book/en/v2/Git-and-Other-Systems-Migrating-to-Git

On 12 March 2017 at 14:54, Matt Sicker  wrote:

> I've imported the repo into git and pushed here:
>
> https://git-wip-us.apache.org/repos/asf/commons-pool.git
>
> Web interface: https://git-wip-us.apache.org/repos/asf?p=commons-pool.git
>
> The remaining steps here still need to be done by a PMC (moving old svn
> repo into the _moved_to_git directory and the other stuff:
>
> https://wiki.apache.org/commons/MovingToGit
>
> On 11 March 2017 at 22:23, Gary Gregory  wrote:
>
>> On Sat, Mar 11, 2017 at 10:02 AM, Matt Sicker  wrote:
>>
>> > Welp, I'm stuck on step one.
>> >
>> > $ svn mkdir -m"POOL => Git"
>> > https://svn.apache.org/repos/asf/commons/_moved_to_git/pool
>> > svn: E175013: Access to
>> > '/repos/asf/!svn/txr/1786516-137xq/commons/_moved_to_git/pool'
>> forbidden
>> >
>>
>> Done.
>>
>> Committing transaction...
>> Committed revision 1786557.
>>
>> Gary
>>
>>
>> > On 9 March 2017 at 17:02, Matt Sicker  wrote:
>> >
>> > > You can use "git svn rebase" to pull down any updates from svn since
>> you
>> > > last imported by the way. I used to use git-svn when working with svn
>> > > projects here, but that's not a very easy way to perform release
>> > management.
>> > >
>> > > On 9 March 2017 at 16:38, sebb  wrote:
>> > >
>> > >> On 9 March 2017 at 21:24, Matt Sicker  wrote:
>> > >> > The steps are pretty straightforward now:
>> > >> >
>> > >> > 1. Do a lazy majority vote to make sure nobody has problems with
>> the
>> > >> > migration.
>> > >> > 2. Create a new git repo via the reporeq webapp.
>> > >> > 3. Get the authors.txt file: https://git-wip-us.apache.org/
>> > authors.txt
>> > >>
>> > >> Warn devs not to commit to SVN
>> > >> Record the current SVN revision details
>> > >>
>> > >> > 4. Use git-svn to import the subversion repo (there are
>> instructions
>> > >> > somewhere on how to do this so you don't have to scan the entire
>> svn
>> > >> > history to find the first revision of that subdirectory).
>> > >>
>> > >> Double-check that SVN has not been changed since the start of the
>> > process
>> > >> If necessary, redo the conversion
>> > >>
>> > >> > 5. Push that converted repo to the newly created one.
>> > >>
>> > >> Rename SVN to https://svn.apache.org/repos/a
>> sf/commons/_moved_to_git/
>> > >> and leave text file behind, e.g. as per
>> > >>
>> > >> https://svn.apache.org/repos/asf/commons/proper/compress/
>> > >>
>> > >> Moving the SVN tree could be done earlier, to make it less likely
>> that
>> > >> devs will accidentally commit.
>> > >>
>> > >> There will probably be some noise from CI jobs whilst the changes are
>> > >> made...
>> > >>
>> > >> > It's actually somewhat of a pain in the ass and is probably why
>> infra
>> > >> made
>> > >> > it self-service. ;)
>> > >> >
>> > >> > On 9 March 2017 at 14:30, Oliver Heger <
>> oliver.he...@oliver-heger.de>
>> > >> wrote:
>> > >> >
>> > >> >> Hi,
>> > >> >>
>> > >> >> Am 09.03.2017 um 15:58 schrieb Matt Sicker:
>> > >> >> > Thanks! I don't think I'll be able to convert the repo until
>> > >> tomorrow,
>> > >> >> > however.
>> > >> >>
>> > >> >> I would be interested to also move [configuration] to git, but -
>> as
>> > >> >> usual - am pretty busy currently. Is there a documentation
>> somewhere
>> > >> for
>> > >> >> the single steps that need to be done?
>> > >> >>
>> > >> >> Thanks
>> > >> >> Oliver
>> > >> >>
>> > >> >> >
>> > >> >> > On 9 March 2017 at 02:11, Gary Gregory 
>> > >> wrote:
>> > >> >> >
>> > >> >> >> FYI
>> > >> >> >> -- Forwarded message --
>> > >> >> >> From: 
>> > >> >> >> Date: Wed, Mar 8, 2017 at 11:25 PM
>> > >> >> >> Subject: New git mirror created: commons-pool.git
>> > >> >> >> To: infrastruct...@apache.org, priv...@commons.apache.org
>> > >> >> >>
>> > >> >> >>
>> > >> >> >> New repository commons-pool.git was mirrored to git.a.o (and
>> thus
>> > >> >> GitHub),
>> > >> >> >> as requested by ggregory.
>> > >> >> >> New mirrors are available on GitHub no more than 24 hours
>> later.
>> > >> >> >>
>> > >> >> >> With regards,
>> > >> >> >> Apache Infrastructure.
>> > >> >> >>
>> > >> >> >> 
>> > >> -
>> > >> >> >> To unsubscribe, e-mail: private-unsubscr...@commons.apache.org
>> > >> >> >> For additional commands, e-mail:
>> private-h...@commons.apache.org
>> > >> >> >>
>> > >> >> >>
>> > >> >> >>
>> > >> >> >>
>> > >> >> >> --
>> > >> >> >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> > >> >> >> Java Persistence with Hibernate, Second Edition
>> > >> >> >> > > >> >> >> tl?ie=UTF8=1789=9325=1617290459&
>> > >> >> >> 

Re: New git mirror created: commons-pool.git

[Matt Sicker]

I've imported the repo into git and pushed here:

https://git-wip-us.apache.org/repos/asf/commons-pool.git

Web interface: https://git-wip-us.apache.org/repos/asf?p=commons-pool.git

The remaining steps here still need to be done by a PMC (moving old svn
repo into the _moved_to_git directory and the other stuff:

https://wiki.apache.org/commons/MovingToGit

On 11 March 2017 at 22:23, Gary Gregory  wrote:

> On Sat, Mar 11, 2017 at 10:02 AM, Matt Sicker  wrote:
>
> > Welp, I'm stuck on step one.
> >
> > $ svn mkdir -m"POOL => Git"
> > https://svn.apache.org/repos/asf/commons/_moved_to_git/pool
> > svn: E175013: Access to
> > '/repos/asf/!svn/txr/1786516-137xq/commons/_moved_to_git/pool' forbidden
> >
>
> Done.
>
> Committing transaction...
> Committed revision 1786557.
>
> Gary
>
>
> > On 9 March 2017 at 17:02, Matt Sicker  wrote:
> >
> > > You can use "git svn rebase" to pull down any updates from svn since
> you
> > > last imported by the way. I used to use git-svn when working with svn
> > > projects here, but that's not a very easy way to perform release
> > management.
> > >
> > > On 9 March 2017 at 16:38, sebb  wrote:
> > >
> > >> On 9 March 2017 at 21:24, Matt Sicker  wrote:
> > >> > The steps are pretty straightforward now:
> > >> >
> > >> > 1. Do a lazy majority vote to make sure nobody has problems with the
> > >> > migration.
> > >> > 2. Create a new git repo via the reporeq webapp.
> > >> > 3. Get the authors.txt file: https://git-wip-us.apache.org/
> > authors.txt
> > >>
> > >> Warn devs not to commit to SVN
> > >> Record the current SVN revision details
> > >>
> > >> > 4. Use git-svn to import the subversion repo (there are instructions
> > >> > somewhere on how to do this so you don't have to scan the entire svn
> > >> > history to find the first revision of that subdirectory).
> > >>
> > >> Double-check that SVN has not been changed since the start of the
> > process
> > >> If necessary, redo the conversion
> > >>
> > >> > 5. Push that converted repo to the newly created one.
> > >>
> > >> Rename SVN to https://svn.apache.org/repos/asf/commons/_moved_to_git/
> > >> and leave text file behind, e.g. as per
> > >>
> > >> https://svn.apache.org/repos/asf/commons/proper/compress/
> > >>
> > >> Moving the SVN tree could be done earlier, to make it less likely that
> > >> devs will accidentally commit.
> > >>
> > >> There will probably be some noise from CI jobs whilst the changes are
> > >> made...
> > >>
> > >> > It's actually somewhat of a pain in the ass and is probably why
> infra
> > >> made
> > >> > it self-service. ;)
> > >> >
> > >> > On 9 March 2017 at 14:30, Oliver Heger <
> oliver.he...@oliver-heger.de>
> > >> wrote:
> > >> >
> > >> >> Hi,
> > >> >>
> > >> >> Am 09.03.2017 um 15:58 schrieb Matt Sicker:
> > >> >> > Thanks! I don't think I'll be able to convert the repo until
> > >> tomorrow,
> > >> >> > however.
> > >> >>
> > >> >> I would be interested to also move [configuration] to git, but - as
> > >> >> usual - am pretty busy currently. Is there a documentation
> somewhere
> > >> for
> > >> >> the single steps that need to be done?
> > >> >>
> > >> >> Thanks
> > >> >> Oliver
> > >> >>
> > >> >> >
> > >> >> > On 9 March 2017 at 02:11, Gary Gregory 
> > >> wrote:
> > >> >> >
> > >> >> >> FYI
> > >> >> >> -- Forwarded message --
> > >> >> >> From: 
> > >> >> >> Date: Wed, Mar 8, 2017 at 11:25 PM
> > >> >> >> Subject: New git mirror created: commons-pool.git
> > >> >> >> To: infrastruct...@apache.org, priv...@commons.apache.org
> > >> >> >>
> > >> >> >>
> > >> >> >> New repository commons-pool.git was mirrored to git.a.o (and
> thus
> > >> >> GitHub),
> > >> >> >> as requested by ggregory.
> > >> >> >> New mirrors are available on GitHub no more than 24 hours later.
> > >> >> >>
> > >> >> >> With regards,
> > >> >> >> Apache Infrastructure.
> > >> >> >>
> > >> >> >> 
> > >> -
> > >> >> >> To unsubscribe, e-mail: private-unsubscr...@commons.apache.org
> > >> >> >> For additional commands, e-mail: private-help@commons.apache.
> org
> > >> >> >>
> > >> >> >>
> > >> >> >>
> > >> >> >>
> > >> >> >> --
> > >> >> >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > >> >> >> Java Persistence with Hibernate, Second Edition
> > >> >> >>  > >> >> >> tl?ie=UTF8=1789=9325=1617290459&
> > >> >> >> linkCode=as2=garygregory-20=cadb800f39946ec62ea2b
> > >> 1af9fe6a2
> > >> >> b8>
> > >> >> >>
> > >> >> >>  > >> am2=1=
> > >> >> >> 1617290459>
> > >> >> >> JUnit in Action, Second Edition
> > >> >> >>  > >> >> >> tl?ie=UTF8=1789=9325=1935182021&
> > >> >> >> linkCode=as2=garygregory-20=31ecd1f6b6d1eaf8886ac

Re: [lang] - deprecated classes moved to text and release?

[Pascal Schumacher]

Am 12.03.2017 um 14:36 schrieb Gary Gregory:

Sounds like a plan. Ideally each Javadoc deprecated tag should point to the
Javadoc of the Commons Text version. Or at least the main Text Javadoc site.
Good idea. I have updated the pull request and replaced the fully 
qualified class names of the commons text classes with links to their 
javadoc.


Cheers,
Pascal

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [jexl] 3.1 release review

[Matt Sicker]

BC can be handled a couple ways here besides renaming:

* Are there already abstract classes that implementations are meant to
extend? If so, that limits the possibility of problems here without using
default methods in Java 8.
* If these are truly public interfaces for users to implement, then you can
extend the interface with an extended version which adds new methods. Try
not to name them Options31 if you can help it.

On 12 March 2017 at 05:16, henrib  wrote:

>
> I've reworded the warning about the source compatibility break in the
> release notes:
>
>
>
> If this source compatibility break is not 'permitted' despite its
> improbability, what option should we take:
> - move to another (jexl31) package ?
> - add 'extended' interfaces (Options31, JexlExpression31, Template31) ?
> - add a utility helper class (Jexl31Helper?) to put the 3 methods as
> functions ( boolean isCancellable(JExlEngine.Options opt) ?
>
>
> Comments welcome,
> Thanks
>
>
>
> --
> View this message in context: http://apache-commons.680414.
> n4.nabble.com/jexl-3-1-release-review-tp4691513p4696416.html
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
Matt Sicker 

Re: [lang] - deprecated classes moved to text and release?

[Pascal Schumacher]

jira issue: https://issues.apache.org/jira/browse/LANG-1316
pull request: https://github.com/apache/commons-lang/pull/255

Am 12.03.2017 um 12:56 schrieb Benedikt Ritter:

Full ACK. I can prepare an RC tomorrow morning.

Regards
Benedikt

Pascal Schumacher  schrieb am So. 12. März 2017
um 12:44:


Hello everybody,

now that commons-text was released (thanks to Rob Tompkins), I think we
should deprecated the classes moved from lang to text and release a new
version of lang.

What do you think?

Cheers,

Pascal

p.s.: There are already 34 fixed issues waiting for a release:


https://issues.apache.org/jira/issues/?jql=project%20%3D%20LANG%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%203.6


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] Question with the StringEscapeUtils.(un)escapeEcmaScript

[sebb]

On 12 March 2017 at 10:43, Benedikt Ritter  wrote:
> Hello,
>
>> Am 11.03.2017 um 13:08 schrieb Yasser Zamani :
>>
>>
>>
>> On 3/8/2017 12:21 PM, Benedikt Ritter wrote:
>>> Hello Yasser,
>>>
>>> Sorry for the late reply! I have been on vacation and needed some time to 
>>> go through all the mails that have piled up :-)
>> Hello Benedikt , thank you very much for your answer
>>>
>>> StringEscapeUtils contains general String escaping routines. It does not 
>>> focus on business related escaping (how would you draw that line anyway?). 
>>> escapeEcmaScript just escapes the characters in a String using EcmaScript 
>>> String rules.
>>> Can you please provide a failing test case showing the problem you see?
>>>
>> Yes, you're right. I mis-used the method. it is for escaping an ecma
>> string that can be used inside an another ecma string but I wrongly used
>> that  for escape from script injection!
>>> So „<" and „>“ are not escaped by escapeEcmaScript..
>> My failure :(

 And finally just for a curious, why `ESCAPE_ECMASCRIPT` does not include
 `OctalUnescaper` but `UNESCAPE_ECMASCRIPT = UNESCAPE_JAVA` does?
>>>
>>> Again it is because it just escapes according to EcmaScript escaping rules.
>> It's some weird , you mean escaping ecma script does not need escaping
>> octal, but un-escaping ecma script does need also un-escaping octal?
>> i.e. inverse of escaping is not equal to unescaping and vice versa.
>
> To be honest, I don’t know :o) I’ve added Rob to the thread, because he has 
> done quite some work in Commons Text and may know why this makes sense…

OctalUnescaper is for UNESCAPE translators only.
There is no OctalEscaper.
Nor would it make sense to escape input as octal.

The other reason is that one should be strict in what one generates,
but liberal in what one accepts.

None of the types need Octal escaping, but if octal escapes are found
on input, I assume they need to be unescaped.

> Regards,
> Benedikt
>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] - deprecated classes moved to text and release?

[Gary Gregory]

Sounds like a plan. Ideally each Javadoc deprecated tag should point to the
Javadoc of the Commons Text version. Or at least the main Text Javadoc site.

Gary

On Mar 12, 2017 11:44 AM, "Pascal Schumacher" 
wrote:

> Hello everybody,
>
> now that commons-text was released (thanks to Rob Tompkins), I think we
> should deprecated the classes moved from lang to text and release a new
> version of lang.
>
> What do you think?
>
> Cheers,
>
> Pascal
>
> p.s.: There are already 34 fixed issues waiting for a release:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> 20LANG%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%
> 20fixVersion%20%3D%203.6
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [lang] - deprecated classes moved to text and release?

[Benedikt Ritter]

Full ACK. I can prepare an RC tomorrow morning.

Regards
Benedikt

Pascal Schumacher  schrieb am So. 12. März 2017
um 12:44:

> Hello everybody,
>
> now that commons-text was released (thanks to Rob Tompkins), I think we
> should deprecated the classes moved from lang to text and release a new
> version of lang.
>
> What do you think?
>
> Cheers,
>
> Pascal
>
> p.s.: There are already 34 fixed issues waiting for a release:
>
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20LANG%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%203.6
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[lang] - deprecated classes moved to text and release?

[Pascal Schumacher]

Hello everybody,

now that commons-text was released (thanks to Rob Tompkins), I think we 
should deprecated the classes moved from lang to text and release a new 
version of lang.


What do you think?

Cheers,

Pascal

p.s.: There are already 34 fixed issues waiting for a release:

https://issues.apache.org/jira/issues/?jql=project%20%3D%20LANG%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%203.6


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] Question with the StringEscapeUtils.(un)escapeEcmaScript

[Benedikt Ritter]

Hello,

> Am 11.03.2017 um 13:08 schrieb Yasser Zamani :
> 
> 
> 
> On 3/8/2017 12:21 PM, Benedikt Ritter wrote:
>> Hello Yasser,
>> 
>> Sorry for the late reply! I have been on vacation and needed some time to go 
>> through all the mails that have piled up :-)
> Hello Benedikt , thank you very much for your answer
>> 
>> StringEscapeUtils contains general String escaping routines. It does not 
>> focus on business related escaping (how would you draw that line anyway?). 
>> escapeEcmaScript just escapes the characters in a String using EcmaScript 
>> String rules.
>> Can you please provide a failing test case showing the problem you see?
>> 
> Yes, you're right. I mis-used the method. it is for escaping an ecma 
> string that can be used inside an another ecma string but I wrongly used 
> that  for escape from script injection!
>> So „<" and „>“ are not escaped by escapeEcmaScript..
> My failure :(
>>> 
>>> And finally just for a curious, why `ESCAPE_ECMASCRIPT` does not include
>>> `OctalUnescaper` but `UNESCAPE_ECMASCRIPT = UNESCAPE_JAVA` does?
>> 
>> Again it is because it just escapes according to EcmaScript escaping rules.
> It's some weird , you mean escaping ecma script does not need escaping 
> octal, but un-escaping ecma script does need also un-escaping octal? 
> i.e. inverse of escaping is not equal to unescaping and vice versa.

To be honest, I don’t know :o) I’ve added Rob to the thread, because he has 
done quite some work in Commons Text and may know why this makes sense…

Regards,
Benedikt

> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [jexl] 3.1 release review

[henrib]

I've reworded the warning about the source compatibility break in the
release notes:



If this source compatibility break is not 'permitted' despite its
improbability, what option should we take:
- move to another (jexl31) package ? 
- add 'extended' interfaces (Options31, JexlExpression31, Template31) ?
- add a utility helper class (Jexl31Helper?) to put the 3 methods as
functions ( boolean isCancellable(JExlEngine.Options opt) ?


Comments welcome,
Thanks



--
View this message in context: 
http://apache-commons.680414.n4.nabble.com/jexl-3-1-release-review-tp4691513p4696416.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org