[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/54
  

[![Coverage 
Status](https://:/builds/12108852/badge)](https://:/builds/12108852)

Coverage decreased (-0.02%) to 97.305% when pulling 
**df30bf96856287478f3a7dfa7f017ca175bdd352 on ameyjadiye:TEXT-93** into 
**569dbc09402a6f28334936567a597e3d0db9185c on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [configuration] checkstyle fails build

[Gary Gregory]

I

P.S.

Agree

P.P.S.

With

P.P.P.S.

you!

Gary

On Jun 23, 2017 10:28, "Simon Spero"  wrote:

> On Jun 23, 2017 11:03 AM, "Oliver Heger" 
> wrote:
>
> However, letting the build fail because of checkstyle error is too
> restrictive IMHO. My approach is to work through the errors before creating
> a new release. This has the disadvantage that errors might accumulate; but
> from one release to the next one there is typically not that much.
>
>
> That's still my gut feeling- checkstyle build fails are infuriating - but
> annoyingly there are issues doing things at the release stage that are
> worse  
>
> The big problem is related to recent discussions about code styles and
> commits, and the diff bloats and blame/praise shifting that happen when
> formatting drifts during a development cycle.  Things turn out much better
> if formatting / style checking is done before a commit, or at least fails
> the build so that things can be fixed and disappeared if a PR is merged as
> a SquashBase (so a change  + a revert cancels out ).
>
> IntelliJ has a checkstyle plugin, which, um, checks for checkstyle
> violations. This can run as a real time inspection, or during pre-commit
> analysis. It can also adjust code formatting options to match the
> checkstyle profile,which helps avoid many issues in the first place.
> Eclipse has  similar support, but I am not an Eclipse user so I don't know
> the details.
>
> The validate phase checkstyle execution then becomes more of a backstop
> (validation is usually the right phase, since that is prior to
> compilation).  It's a lot less annoying if it doesn't have too many
> "violations".
>
> Since checkstyle can be configured to allow a small number of violations,
> and to only treat rule-breakings above a certain severity  as violations
> (error by default, but a pre-release execution could increase fussiness to
> include warnings).
>
> One thing that is tricky, but which can be worth it, is having a pseudo
> flag-day reformatting, where you use an ide to apply the code style to the
> entire project, then apply the changes all at once (possibly using a
> disposable committer, though this isn't as important if the annotate view
> you use shows a bit of commit message).
>
> It is a bit more effort if there a bunch of unmerged branches, but since
> the formatting changes  are automated, they can be applied on the branch so
> it's not *that* horrible to get a mergeable branch back.
>
> History checking for a few lines may require going one revision back, but
> having all the format fixes in a single commit is a lot better than having
> them mixed in with real changes.
>
> Simon
>  P. S.
>
> I prefer the builtin /google_checks.xml styleguide to the older sun_checks,
> partly because it's more up to date, and partly because Google provides
> native  ide configuration files for Eclipse and intellij so there's no need
> to import the checkstyle file.
> The Checkstyle plugin  tracks the Google style guide pretty closely, so as
> long as the plugin is up to date, there won't be much divergence. The most
> significant changes happen when there are new constructs to consider (e.g.
> lambda).
>
> P.P.S.
> I do think the google rules are wrong about horizontal alignment (at least
> for continuation lines). It makes a huge difference when you have to use
> obnoxious amounts of chained methods (can't say fluent without saying flu).
>
>
> P.P.S.
> I do like their tip on the appropriate use of finalize:
>
> *Tip:* Don't do it. If you absolutely must, first read and understand
> *Effective
> Java* Item 7,  "Avoid
> Finalizers," very carefully, and *then* don't do it.
>
> I say finalizers are OK as long as they  warn, and don't actually  do
> anything ("you didn't commit a batch insert of 10M items. Were you sure?
> Yes / Tough").
>

Some ideas for improving Travis build performance improvements:

[Simon Spero]

COMPRESS-413 has some examples  which include:

   - Switching to the trusty container, which doesn't require installing as
   many updates.
   - Use only two JDKs: openjdk7 and openjdk8.
  - JDK 7 is obsolete -
  - Oracle EOL'ed JDK7  over two years ago; openjdk7 occasionally gets
  patched (though it's not available from the default source in recent
  versions of ubuntu, including xenial (16.0.4), which is the current LTS.
  - Java 7 is mostly relevant only for older versions of Android. Some
  JLS 8 features are not supported for versions of Android prior
to 7.0 (e.g.
  Repeatable annotations, and interface default/ static methods).  However,
  this environment is not tested for under oracle or openjdk 7.  It's also
  painful to build for under maven.
   - Run the entire CI process in the build phase. This avoids compiling
   and testing two or three times over. However, any errors will fail the
   build.
   - Cache build dependencies (this is another reason to move plugin work
   to the build phase, since the cache is saved before after_success is run).
   - Add a mvnw setup. 3.5.0 may be  needed if jdk9ea is added to the build
   matrix.
   - The pull request also has random test coverage increases to pacify a
   confused coveralls.

See: https://github.com/apache/commons-compress/pull/39

which combined with previous changes from~

 Ran for 5 min 4 sec
 Total time 13 min 26 sec

to:

 Ran for 1 min 56 sec
 Total time 1 min 50 sec


[Note that some variation comes from primed/unprimed caches]

Re: [configuration] checkstyle fails build

[Simon Spero]

On Jun 23, 2017 11:03 AM, "Oliver Heger" 
wrote:

However, letting the build fail because of checkstyle error is too
restrictive IMHO. My approach is to work through the errors before creating
a new release. This has the disadvantage that errors might accumulate; but
from one release to the next one there is typically not that much.


That's still my gut feeling- checkstyle build fails are infuriating - but
annoyingly there are issues doing things at the release stage that are
worse  

The big problem is related to recent discussions about code styles and
commits, and the diff bloats and blame/praise shifting that happen when
formatting drifts during a development cycle.  Things turn out much better
if formatting / style checking is done before a commit, or at least fails
the build so that things can be fixed and disappeared if a PR is merged as
a SquashBase (so a change  + a revert cancels out ).

IntelliJ has a checkstyle plugin, which, um, checks for checkstyle
violations. This can run as a real time inspection, or during pre-commit
analysis. It can also adjust code formatting options to match the
checkstyle profile,which helps avoid many issues in the first place.
Eclipse has  similar support, but I am not an Eclipse user so I don't know
the details.

The validate phase checkstyle execution then becomes more of a backstop
(validation is usually the right phase, since that is prior to
compilation).  It's a lot less annoying if it doesn't have too many
"violations".

Since checkstyle can be configured to allow a small number of violations,
and to only treat rule-breakings above a certain severity  as violations
(error by default, but a pre-release execution could increase fussiness to
include warnings).

One thing that is tricky, but which can be worth it, is having a pseudo
flag-day reformatting, where you use an ide to apply the code style to the
entire project, then apply the changes all at once (possibly using a
disposable committer, though this isn't as important if the annotate view
you use shows a bit of commit message).

It is a bit more effort if there a bunch of unmerged branches, but since
the formatting changes  are automated, they can be applied on the branch so
it's not *that* horrible to get a mergeable branch back.

History checking for a few lines may require going one revision back, but
having all the format fixes in a single commit is a lot better than having
them mixed in with real changes.

Simon
 P. S.

I prefer the builtin /google_checks.xml styleguide to the older sun_checks,
partly because it's more up to date, and partly because Google provides
native  ide configuration files for Eclipse and intellij so there's no need
to import the checkstyle file.
The Checkstyle plugin  tracks the Google style guide pretty closely, so as
long as the plugin is up to date, there won't be much divergence. The most
significant changes happen when there are new constructs to consider (e.g.
lambda).

P.P.S.
I do think the google rules are wrong about horizontal alignment (at least
for continuation lines). It makes a huge difference when you have to use
obnoxious amounts of chained methods (can't say fluent without saying flu).


P.P.S.
I do like their tip on the appropriate use of finalize:

*Tip:* Don't do it. If you absolutely must, first read and understand
*Effective
Java* Item 7,  "Avoid
Finalizers," very carefully, and *then* don't do it.

I say finalizers are OK as long as they  warn, and don't actually  do
anything ("you didn't commit a batch insert of 10M items. Were you sure?
Yes / Tough").

Re: [configuration] checkstyle fails build

[Gary Gregory]

On Fri, Jun 23, 2017 at 9:35 AM, sebb  wrote:

> On 23 June 2017 at 17:29, Gary Gregory  wrote:
> > On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren  wrote:
> >
> >> How about an eclipse format configuration that will correct the error on
> >> demand.  Granted you have to run eclipse but if such a file were created
> >> (and checked in) then it would be easy for anyone running eclipse to fix
> >> it.
> >>
> >
> > I use Eclipse and would appreciate such a file. In the past we've not
> > included IDE files in the repo but making it easier would be nice.
>
> If added, these should be optional.
> i.e. don't use the same name as Eclipse uses, but copy the required
> settings to another file.
>
> See for example how Tomcat do it:
>
> http://svn.apache.org/repos/asf/tomcat/trunk/res/ide-support/eclipse/


Putting the files in a separate folder is one thing but flattening the
folders and changing file names is -1. Just put the Eclipse .settings
folder I should be using so I can overlay it on top of my project.
Otherwise, a user has to know where to sprinkle each file in each place.
Maybe something like:

.../eclipse/.classpath
.../eclipse/.project
.../eclipse/.settings/fileA
.../eclipse/.settings/fileB
.../eclipse/.settings/folderA

and so on.

Gary

>
>
> > Gary
> >
> >>
> >> Claude
> >>
> >> On Fri, Jun 23, 2017 at 4:03 PM, Oliver Heger <
> >> oliver.he...@oliver-heger.de>
> >> wrote:
> >>
> >> >
> >> >
> >> > Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> >> > > The root cause, IMHO, is having failValidation=false configured in
> the
> >> > > pom.xml. This way, when you introduce a new problem your only
> option to
> >> > > notice it is if you visually scan mvn's output. As evident by the
> >> current
> >> > > state of the build, not everyone notices these.
> >> > > A more robust approach would be to set failValidation=true, and
> >> actively
> >> > > fail the build if checkstyle's rules are violated.
> >> > >
> >> > > I've submitted a PR to fix all the existing issues and enable this
> >> > > validation. Reviews are welcome:
> >> > > https://github.com/apache/commons-configuration/pull/5
> >> > >
> >> >
> >> > Thanks for the PR, I will have a look.
> >> >
> >> > However, letting the build fail because of checkstyle error is too
> >> > restrictive IMHO. My approach is to work through the errors before
> >> > creating a new release. This has the disadvantage that errors might
> >> > accumulate; but from one release to the next one there is typically
> not
> >> > that much.
> >> >
> >> > Oliver
> >> >
> >> > >
> >> > > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory <
> garydgreg...@gmail.com
> >> >
> >> > > wrote:
> >> > >
> >> > >> FYI, to whom can take the time to fix this.
> >> > >>
> >> > >> When I run 'mvn clean install', I get:
> >> > >>
> >> > >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> >> > >> commons-configuration2 ---
> >> > >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> >> > >> C:\vcs\svn\apache\commons\trunks-proper\configuration/
> >> > conf/checkstyle.xml
> >> > >> ruleset.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> AbstractHierarchicalConfiguration.java[976]
> >> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> AbstractHierarchicalConfiguration.java[978:30]
> >> > >> (blocks) LeftCurly: '{' should be on a new line.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> AbstractYAMLBasedConfiguration.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\fluent\
> >> > >> INIBuilderParameters.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\
> >> > >> INIBuilderParametersImpl.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\
> >> > >> INIBuilderParametersImpl.java[42:5]
> >> > >> (whitespace) FileTabCharacter: File contains tab characters (this
> is
> >> the
> >> > >> first instance).
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\
> >> > >> INIBuilderParametersImpl.java[52:84]
> >> > >> (blocks) LeftCurly: '{' should be on a new line.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> builder\INIBuilderProperties.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\ex\
> >> > >> ConfigurationRuntimeException.java[68]
> >> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> > >> [ERROR]
> >> > >> 

Re: [configuration] checkstyle fails build

[Allon Mureinik]

Instead of a per-IDE specific file, it may be useful to look into
EditorConfig [1]. A lot of IDEs support it either natively or via plugin,
and it may help having to replicate the same styling "logic" per IDE.

[1] http://editorconfig.org/

On Fri, Jun 23, 2017 at 7:35 PM, sebb  wrote:

> On 23 June 2017 at 17:29, Gary Gregory  wrote:
> > On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren  wrote:
> >
> >> How about an eclipse format configuration that will correct the error on
> >> demand.  Granted you have to run eclipse but if such a file were created
> >> (and checked in) then it would be easy for anyone running eclipse to fix
> >> it.
> >>
> >
> > I use Eclipse and would appreciate such a file. In the past we've not
> > included IDE files in the repo but making it easier would be nice.
>
> If added, these should be optional.
> i.e. don't use the same name as Eclipse uses, but copy the required
> settings to another file.
>
> See for example how Tomcat do it:
>
> http://svn.apache.org/repos/asf/tomcat/trunk/res/ide-support/eclipse/
>
> > Gary
> >
> >>
> >> Claude
> >>
> >> On Fri, Jun 23, 2017 at 4:03 PM, Oliver Heger <
> >> oliver.he...@oliver-heger.de>
> >> wrote:
> >>
> >> >
> >> >
> >> > Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> >> > > The root cause, IMHO, is having failValidation=false configured in
> the
> >> > > pom.xml. This way, when you introduce a new problem your only
> option to
> >> > > notice it is if you visually scan mvn's output. As evident by the
> >> current
> >> > > state of the build, not everyone notices these.
> >> > > A more robust approach would be to set failValidation=true, and
> >> actively
> >> > > fail the build if checkstyle's rules are violated.
> >> > >
> >> > > I've submitted a PR to fix all the existing issues and enable this
> >> > > validation. Reviews are welcome:
> >> > > https://github.com/apache/commons-configuration/pull/5
> >> > >
> >> >
> >> > Thanks for the PR, I will have a look.
> >> >
> >> > However, letting the build fail because of checkstyle error is too
> >> > restrictive IMHO. My approach is to work through the errors before
> >> > creating a new release. This has the disadvantage that errors might
> >> > accumulate; but from one release to the next one there is typically
> not
> >> > that much.
> >> >
> >> > Oliver
> >> >
> >> > >
> >> > > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory <
> garydgreg...@gmail.com
> >> >
> >> > > wrote:
> >> > >
> >> > >> FYI, to whom can take the time to fix this.
> >> > >>
> >> > >> When I run 'mvn clean install', I get:
> >> > >>
> >> > >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> >> > >> commons-configuration2 ---
> >> > >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> >> > >> C:\vcs\svn\apache\commons\trunks-proper\configuration/
> >> > conf/checkstyle.xml
> >> > >> ruleset.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> AbstractHierarchicalConfiguration.java[976]
> >> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> AbstractHierarchicalConfiguration.java[978:30]
> >> > >> (blocks) LeftCurly: '{' should be on a new line.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> AbstractYAMLBasedConfiguration.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\fluent\
> >> > >> INIBuilderParameters.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\
> >> > >> INIBuilderParametersImpl.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\
> >> > >> INIBuilderParametersImpl.java[42:5]
> >> > >> (whitespace) FileTabCharacter: File contains tab characters (this
> is
> >> the
> >> > >> first instance).
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\builder\
> >> > >> INIBuilderParametersImpl.java[52:84]
> >> > >> (blocks) LeftCurly: '{' should be on a new line.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> builder\INIBuilderProperties.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\ex\
> >> > >> ConfigurationRuntimeException.java[68]
> >> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > JSONConfiguration.java[0]
> >> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> > >> [ERROR]
> >> > >> src\main\java\org\apache\commons\configuration2\
> >> > >> 

Re: [configuration] checkstyle fails build

[sebb]

On 23 June 2017 at 17:29, Gary Gregory  wrote:
> On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren  wrote:
>
>> How about an eclipse format configuration that will correct the error on
>> demand.  Granted you have to run eclipse but if such a file were created
>> (and checked in) then it would be easy for anyone running eclipse to fix
>> it.
>>
>
> I use Eclipse and would appreciate such a file. In the past we've not
> included IDE files in the repo but making it easier would be nice.

If added, these should be optional.
i.e. don't use the same name as Eclipse uses, but copy the required
settings to another file.

See for example how Tomcat do it:

http://svn.apache.org/repos/asf/tomcat/trunk/res/ide-support/eclipse/

> Gary
>
>>
>> Claude
>>
>> On Fri, Jun 23, 2017 at 4:03 PM, Oliver Heger <
>> oliver.he...@oliver-heger.de>
>> wrote:
>>
>> >
>> >
>> > Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
>> > > The root cause, IMHO, is having failValidation=false configured in the
>> > > pom.xml. This way, when you introduce a new problem your only option to
>> > > notice it is if you visually scan mvn's output. As evident by the
>> current
>> > > state of the build, not everyone notices these.
>> > > A more robust approach would be to set failValidation=true, and
>> actively
>> > > fail the build if checkstyle's rules are violated.
>> > >
>> > > I've submitted a PR to fix all the existing issues and enable this
>> > > validation. Reviews are welcome:
>> > > https://github.com/apache/commons-configuration/pull/5
>> > >
>> >
>> > Thanks for the PR, I will have a look.
>> >
>> > However, letting the build fail because of checkstyle error is too
>> > restrictive IMHO. My approach is to work through the errors before
>> > creating a new release. This has the disadvantage that errors might
>> > accumulate; but from one release to the next one there is typically not
>> > that much.
>> >
>> > Oliver
>> >
>> > >
>> > > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory > >
>> > > wrote:
>> > >
>> > >> FYI, to whom can take the time to fix this.
>> > >>
>> > >> When I run 'mvn clean install', I get:
>> > >>
>> > >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
>> > >> commons-configuration2 ---
>> > >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
>> > >> C:\vcs\svn\apache\commons\trunks-proper\configuration/
>> > conf/checkstyle.xml
>> > >> ruleset.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > >> AbstractHierarchicalConfiguration.java[976]
>> > >> (regexp) RegexpSingleline: Line has trailing spaces.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > >> AbstractHierarchicalConfiguration.java[978:30]
>> > >> (blocks) LeftCurly: '{' should be on a new line.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > >> AbstractYAMLBasedConfiguration.java[0]
>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\builder\fluent\
>> > >> INIBuilderParameters.java[0]
>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\builder\
>> > >> INIBuilderParametersImpl.java[0]
>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\builder\
>> > >> INIBuilderParametersImpl.java[42:5]
>> > >> (whitespace) FileTabCharacter: File contains tab characters (this is
>> the
>> > >> first instance).
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\builder\
>> > >> INIBuilderParametersImpl.java[52:84]
>> > >> (blocks) LeftCurly: '{' should be on a new line.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > >> builder\INIBuilderProperties.java[0]
>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\ex\
>> > >> ConfigurationRuntimeException.java[68]
>> > >> (regexp) RegexpSingleline: Line has trailing spaces.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > JSONConfiguration.java[0]
>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > >> JSONConfiguration.java[43:5]
>> > >> (javadoc) JavadocVariable: Missing a Javadoc comment.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\
>> > >> JSONConfiguration.java[44:5]
>> > >> (javadoc) JavadocVariable: Missing a Javadoc comment.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\tree\
>> > >> ImmutableNode.java[106]
>> > >> (regexp) RegexpSingleline: Line has trailing spaces.
>> > >> [ERROR]
>> > >> src\main\java\org\apache\commons\configuration2\tree\
>> > >> ImmutableNode.java[114:27]

Re: [configuration] checkstyle fails build

[Gary Gregory]

On Fri, Jun 23, 2017 at 8:24 AM, Allon Mureinik  wrote:

> On Fri, Jun 23, 2017 at 6:03 PM, Oliver Heger <
> oliver.he...@oliver-heger.de>
> wrote:
>
> >
> >
> > Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> > > The root cause, IMHO, is having failValidation=false configured in the
> > > pom.xml. This way, when you introduce a new problem your only option to
> > > notice it is if you visually scan mvn's output. As evident by the
> current
> > > state of the build, not everyone notices these.
> > > A more robust approach would be to set failValidation=true, and
> actively
> > > fail the build if checkstyle's rules are violated.
> > >
> > > I've submitted a PR to fix all the existing issues and enable this
> > > validation. Reviews are welcome:
> > > https://github.com/apache/commons-configuration/pull/5
> > >
> >
> > Thanks for the PR, I will have a look.
> >
> > However, letting the build fail because of checkstyle error is too
> > restrictive IMHO. My approach is to work through the errors before
> > creating a new release. This has the disadvantage that errors might
> > accumulate; but from one release to the next one there is typically not
> > that much.
> >
> > Oliver
> >
>
> This is ultimately a matter of taste, but let me try to explain this point
> of view better.
> The baseline is that the project should pass checkstyle with no issues (the
> first three patches in this PR will get us there).
>
> From that point on, the goal is not accept any patch that would break the
> styling.
>

Over at HttpComponents, checkstyle can break the build and that helps keeps
the code tidy.

Gary


> Think of it way - If you were reviewing a patch that didn't comply to the
> project's style, you'd comment about it and ask the author to fix it before
> merging.
> Having checkstyle do this *as part of the CI* has the same effect, but it
> takes some responsibility off the maintainers' shoulders.
> First, contributers can easily see if they need to improve their patch by
> running mvn install (arguably, they could do this even without enabling
> checkstyle validations, but it makes it much easier to notice). Second, and
> more importantly, it allows the CI to block such patches, so maintainers
> can decide whether to reject them (or even fix them themselves, if they are
> so inclined) so that checking checkstyle before the release becomes a
> non-issue - it just always passes.
>
>
>
> >
> > >
> > > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory  >
> > > wrote:
> > >
> > >> FYI, to whom can take the time to fix this.
> > >>
> > >> When I run 'mvn clean install', I get:
> > >>
> > >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> > >> commons-configuration2 ---
> > >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> > >> C:\vcs\svn\apache\commons\trunks-proper\configuration/conf/
> > checkstyle.xml
> > >> ruleset.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> AbstractHierarchicalConfiguration.java[976]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> AbstractHierarchicalConfiguration.java[978:30]
> > >> (blocks) LeftCurly: '{' should be on a new line.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> AbstractYAMLBasedConfiguration.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\fluent\
> > >> INIBuilderParameters.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\
> > >> INIBuilderParametersImpl.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\
> > >> INIBuilderParametersImpl.java[42:5]
> > >> (whitespace) FileTabCharacter: File contains tab characters (this is
> the
> > >> first instance).
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\
> > >> INIBuilderParametersImpl.java[52:84]
> > >> (blocks) LeftCurly: '{' should be on a new line.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> builder\INIBuilderProperties.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\ex\
> > >> ConfigurationRuntimeException.java[68]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\JSONConfigur
> > ation.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> JSONConfiguration.java[43:5]
> > >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> > >> [ERROR]
> > >> 

Re: [configuration] checkstyle fails build

[Gary Gregory]

On Fri, Jun 23, 2017 at 8:21 AM, Claude Warren  wrote:

> How about an eclipse format configuration that will correct the error on
> demand.  Granted you have to run eclipse but if such a file were created
> (and checked in) then it would be easy for anyone running eclipse to fix
> it.
>

I use Eclipse and would appreciate such a file. In the past we've not
included IDE files in the repo but making it easier would be nice.

Gary

>
> Claude
>
> On Fri, Jun 23, 2017 at 4:03 PM, Oliver Heger <
> oliver.he...@oliver-heger.de>
> wrote:
>
> >
> >
> > Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> > > The root cause, IMHO, is having failValidation=false configured in the
> > > pom.xml. This way, when you introduce a new problem your only option to
> > > notice it is if you visually scan mvn's output. As evident by the
> current
> > > state of the build, not everyone notices these.
> > > A more robust approach would be to set failValidation=true, and
> actively
> > > fail the build if checkstyle's rules are violated.
> > >
> > > I've submitted a PR to fix all the existing issues and enable this
> > > validation. Reviews are welcome:
> > > https://github.com/apache/commons-configuration/pull/5
> > >
> >
> > Thanks for the PR, I will have a look.
> >
> > However, letting the build fail because of checkstyle error is too
> > restrictive IMHO. My approach is to work through the errors before
> > creating a new release. This has the disadvantage that errors might
> > accumulate; but from one release to the next one there is typically not
> > that much.
> >
> > Oliver
> >
> > >
> > > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory  >
> > > wrote:
> > >
> > >> FYI, to whom can take the time to fix this.
> > >>
> > >> When I run 'mvn clean install', I get:
> > >>
> > >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> > >> commons-configuration2 ---
> > >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> > >> C:\vcs\svn\apache\commons\trunks-proper\configuration/
> > conf/checkstyle.xml
> > >> ruleset.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> AbstractHierarchicalConfiguration.java[976]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> AbstractHierarchicalConfiguration.java[978:30]
> > >> (blocks) LeftCurly: '{' should be on a new line.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> AbstractYAMLBasedConfiguration.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\fluent\
> > >> INIBuilderParameters.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\
> > >> INIBuilderParametersImpl.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\
> > >> INIBuilderParametersImpl.java[42:5]
> > >> (whitespace) FileTabCharacter: File contains tab characters (this is
> the
> > >> first instance).
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\builder\
> > >> INIBuilderParametersImpl.java[52:84]
> > >> (blocks) LeftCurly: '{' should be on a new line.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> builder\INIBuilderProperties.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\ex\
> > >> ConfigurationRuntimeException.java[68]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > JSONConfiguration.java[0]
> > >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> JSONConfiguration.java[43:5]
> > >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\
> > >> JSONConfiguration.java[44:5]
> > >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\tree\
> > >> ImmutableNode.java[106]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\tree\
> > >> ImmutableNode.java[114:27]
> > >> (blocks) LeftCurly: '{' should be on a new line.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\tree\
> > >> ImmutableNode.java[117]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> src\main\java\org\apache\commons\configuration2\tree\
> > >> ImmutableNode.java[666]
> > >> (regexp) RegexpSingleline: Line has trailing spaces.
> > >> [ERROR]
> > >> 

Re: [configuration] checkstyle fails build

[Allon Mureinik]

On Fri, Jun 23, 2017 at 6:03 PM, Oliver Heger 
wrote:

>
>
> Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> > The root cause, IMHO, is having failValidation=false configured in the
> > pom.xml. This way, when you introduce a new problem your only option to
> > notice it is if you visually scan mvn's output. As evident by the current
> > state of the build, not everyone notices these.
> > A more robust approach would be to set failValidation=true, and actively
> > fail the build if checkstyle's rules are violated.
> >
> > I've submitted a PR to fix all the existing issues and enable this
> > validation. Reviews are welcome:
> > https://github.com/apache/commons-configuration/pull/5
> >
>
> Thanks for the PR, I will have a look.
>
> However, letting the build fail because of checkstyle error is too
> restrictive IMHO. My approach is to work through the errors before
> creating a new release. This has the disadvantage that errors might
> accumulate; but from one release to the next one there is typically not
> that much.
>
> Oliver
>

This is ultimately a matter of taste, but let me try to explain this point
of view better.
The baseline is that the project should pass checkstyle with no issues (the
first three patches in this PR will get us there).

>From that point on, the goal is not accept any patch that would break the
styling.
Think of it way - If you were reviewing a patch that didn't comply to the
project's style, you'd comment about it and ask the author to fix it before
merging.
Having checkstyle do this *as part of the CI* has the same effect, but it
takes some responsibility off the maintainers' shoulders.
First, contributers can easily see if they need to improve their patch by
running mvn install (arguably, they could do this even without enabling
checkstyle validations, but it makes it much easier to notice). Second, and
more importantly, it allows the CI to block such patches, so maintainers
can decide whether to reject them (or even fix them themselves, if they are
so inclined) so that checking checkstyle before the release becomes a
non-issue - it just always passes.



>
> >
> > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory 
> > wrote:
> >
> >> FYI, to whom can take the time to fix this.
> >>
> >> When I run 'mvn clean install', I get:
> >>
> >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> >> commons-configuration2 ---
> >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> >> C:\vcs\svn\apache\commons\trunks-proper\configuration/conf/
> checkstyle.xml
> >> ruleset.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> AbstractHierarchicalConfiguration.java[976]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> AbstractHierarchicalConfiguration.java[978:30]
> >> (blocks) LeftCurly: '{' should be on a new line.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> AbstractYAMLBasedConfiguration.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\fluent\
> >> INIBuilderParameters.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\
> >> INIBuilderParametersImpl.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\
> >> INIBuilderParametersImpl.java[42:5]
> >> (whitespace) FileTabCharacter: File contains tab characters (this is the
> >> first instance).
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\
> >> INIBuilderParametersImpl.java[52:84]
> >> (blocks) LeftCurly: '{' should be on a new line.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> builder\INIBuilderProperties.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\ex\
> >> ConfigurationRuntimeException.java[68]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\JSONConfigur
> ation.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> JSONConfiguration.java[43:5]
> >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> JSONConfiguration.java[44:5]
> >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\tree\
> >> ImmutableNode.java[106]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\tree\
> >> ImmutableNode.java[114:27]
> >> (blocks) LeftCurly: 

Re: [configuration] checkstyle fails build

[Claude Warren]

How about an eclipse format configuration that will correct the error on
demand.  Granted you have to run eclipse but if such a file were created
(and checked in) then it would be easy for anyone running eclipse to fix it.

Claude

On Fri, Jun 23, 2017 at 4:03 PM, Oliver Heger 
wrote:

>
>
> Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> > The root cause, IMHO, is having failValidation=false configured in the
> > pom.xml. This way, when you introduce a new problem your only option to
> > notice it is if you visually scan mvn's output. As evident by the current
> > state of the build, not everyone notices these.
> > A more robust approach would be to set failValidation=true, and actively
> > fail the build if checkstyle's rules are violated.
> >
> > I've submitted a PR to fix all the existing issues and enable this
> > validation. Reviews are welcome:
> > https://github.com/apache/commons-configuration/pull/5
> >
>
> Thanks for the PR, I will have a look.
>
> However, letting the build fail because of checkstyle error is too
> restrictive IMHO. My approach is to work through the errors before
> creating a new release. This has the disadvantage that errors might
> accumulate; but from one release to the next one there is typically not
> that much.
>
> Oliver
>
> >
> > On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory 
> > wrote:
> >
> >> FYI, to whom can take the time to fix this.
> >>
> >> When I run 'mvn clean install', I get:
> >>
> >> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> >> commons-configuration2 ---
> >> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> >> C:\vcs\svn\apache\commons\trunks-proper\configuration/
> conf/checkstyle.xml
> >> ruleset.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> AbstractHierarchicalConfiguration.java[976]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> AbstractHierarchicalConfiguration.java[978:30]
> >> (blocks) LeftCurly: '{' should be on a new line.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> AbstractYAMLBasedConfiguration.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\fluent\
> >> INIBuilderParameters.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\
> >> INIBuilderParametersImpl.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\
> >> INIBuilderParametersImpl.java[42:5]
> >> (whitespace) FileTabCharacter: File contains tab characters (this is the
> >> first instance).
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\builder\
> >> INIBuilderParametersImpl.java[52:84]
> >> (blocks) LeftCurly: '{' should be on a new line.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> builder\INIBuilderProperties.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\ex\
> >> ConfigurationRuntimeException.java[68]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> JSONConfiguration.java[0]
> >> (misc) NewlineAtEndOfFile: File does not end with a newline.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> JSONConfiguration.java[43:5]
> >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> JSONConfiguration.java[44:5]
> >> (javadoc) JavadocVariable: Missing a Javadoc comment.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\tree\
> >> ImmutableNode.java[106]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\tree\
> >> ImmutableNode.java[114:27]
> >> (blocks) LeftCurly: '{' should be on a new line.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\tree\
> >> ImmutableNode.java[117]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\tree\
> >> ImmutableNode.java[666]
> >> (regexp) RegexpSingleline: Line has trailing spaces.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> XMLConfiguration.java[1169:15]
> >> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> XMLConfiguration.java[1210:15]
> >> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
> >> [ERROR]
> >> src\main\java\org\apache\commons\configuration2\
> >> XMLConfiguration.java[1212:19]
> >> (whitespace) WhitespaceAround: 'if' is 

Re: [configuration] checkstyle fails build

[Oliver Heger]

Am 23.06.2017 um 08:58 schrieb Allon Mureinik:
> The root cause, IMHO, is having failValidation=false configured in the
> pom.xml. This way, when you introduce a new problem your only option to
> notice it is if you visually scan mvn's output. As evident by the current
> state of the build, not everyone notices these.
> A more robust approach would be to set failValidation=true, and actively
> fail the build if checkstyle's rules are violated.
> 
> I've submitted a PR to fix all the existing issues and enable this
> validation. Reviews are welcome:
> https://github.com/apache/commons-configuration/pull/5
> 

Thanks for the PR, I will have a look.

However, letting the build fail because of checkstyle error is too
restrictive IMHO. My approach is to work through the errors before
creating a new release. This has the disadvantage that errors might
accumulate; but from one release to the next one there is typically not
that much.

Oliver

> 
> On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory 
> wrote:
> 
>> FYI, to whom can take the time to fix this.
>>
>> When I run 'mvn clean install', I get:
>>
>> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
>> commons-configuration2 ---
>> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
>> C:\vcs\svn\apache\commons\trunks-proper\configuration/conf/checkstyle.xml
>> ruleset.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> AbstractHierarchicalConfiguration.java[976]
>> (regexp) RegexpSingleline: Line has trailing spaces.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> AbstractHierarchicalConfiguration.java[978:30]
>> (blocks) LeftCurly: '{' should be on a new line.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> AbstractYAMLBasedConfiguration.java[0]
>> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\builder\fluent\
>> INIBuilderParameters.java[0]
>> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\builder\
>> INIBuilderParametersImpl.java[0]
>> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\builder\
>> INIBuilderParametersImpl.java[42:5]
>> (whitespace) FileTabCharacter: File contains tab characters (this is the
>> first instance).
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\builder\
>> INIBuilderParametersImpl.java[52:84]
>> (blocks) LeftCurly: '{' should be on a new line.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> builder\INIBuilderProperties.java[0]
>> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\ex\
>> ConfigurationRuntimeException.java[68]
>> (regexp) RegexpSingleline: Line has trailing spaces.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\JSONConfiguration.java[0]
>> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> JSONConfiguration.java[43:5]
>> (javadoc) JavadocVariable: Missing a Javadoc comment.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> JSONConfiguration.java[44:5]
>> (javadoc) JavadocVariable: Missing a Javadoc comment.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\tree\
>> ImmutableNode.java[106]
>> (regexp) RegexpSingleline: Line has trailing spaces.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\tree\
>> ImmutableNode.java[114:27]
>> (blocks) LeftCurly: '{' should be on a new line.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\tree\
>> ImmutableNode.java[117]
>> (regexp) RegexpSingleline: Line has trailing spaces.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\tree\
>> ImmutableNode.java[666]
>> (regexp) RegexpSingleline: Line has trailing spaces.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> XMLConfiguration.java[1169:15]
>> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> XMLConfiguration.java[1210:15]
>> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> XMLConfiguration.java[1212:19]
>> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\
>> XMLConfiguration.java[1311:20]
>> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\XMLListReference.java[0]
>> (misc) NewlineAtEndOfFile: File does not end with a newline.
>> [ERROR]
>> src\main\java\org\apache\commons\configuration2\XMLListReference.java[45]
>> (design) FinalClass: Class XMLListReference should be declared as final.
>> [ERROR]
>> 

[GitHub] commons-rng issue #3: Rng 38

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-rng/pull/3
  

[![Coverage 
Status](https://:/builds/12102911/badge)](https://:/builds/12102911)

Coverage decreased (-0.02%) to 96.919% when pulling 
**3179fd6a6bbbdb3cd2fb492ad27b7dfadcb21fb4 on C0rWin:RNG-38** into 
**acb61071ae681732a5d70e6d2587dc95a6eb64d4 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-cli/pull/15
  

[![Coverage 
Status](https://:/builds/12101592/badge)](https://:/builds/12101592)

Coverage decreased (-0.1%) to 96.122% when pulling 
**4f17a89ad04bcf718aeac43d202f8c261ce0b796 on rubin55:master** into 
**c246bd419ee0efccd9a96f9d33486617d5d38a56 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-cli/pull/15
  

[![Coverage 
Status](https://:/builds/12101592/badge)](https://:/builds/12101592)

Coverage decreased (-0.1%) to 96.122% when pulling 
**4f17a89ad04bcf718aeac43d202f8c261ce0b796 on rubin55:master** into 
**c246bd419ee0efccd9a96f9d33486617d5d38a56 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

[rubin55]

GitHub user rubin55 opened a pull request:

https://github.com/apache/commons-cli/pull/15

CLI-217: Optional partial matching

At request of Gary, I (re)created an old patch against the current code 
base to enable partial matching to be set as optional. This fixes problems for 
people that have short options that, concatenated, also partial-match a long 
option.

For example:
-d, --debug
-e, --extract

foo -de

Is ambiguous in the case that partial matching is enabled. This patch 
allows a user to turn off partial matching in such a case.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rubin55/commons-cli master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-cli/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 186612c45b973f0b2f9e7a5a9ee97a6e3bfc3cad
Author: Rubin Simons 
Date:   2017-06-22T13:33:03Z

Ignore IDE specific files

commit 6e7850b99024032c8cf4979d2eea61302dfd6a09
Author: Rubin Simons 
Date:   2017-06-23T09:51:56Z

Ignore IntelliJ IDEA files too

commit bdb4a09ceaceab7e3d214b1beadb93bd9c911342
Author: Rubin Simons 
Date:   2017-06-23T11:04:27Z

Added support for disabling partial option matching

commit 4f17a89ad04bcf718aeac43d202f8c261ce0b796
Author: Rubin Simons 
Date:   2017-06-23T11:04:59Z

Added tests for partial matching enable/disable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [RNG] Pending issues

[Gilles]

Hi Artem.

On Fri, 23 Jun 2017 02:55:02 +0300, Artem Barger wrote:

​Hi,

Can you please take a look on PRs which suppose to handle both 
issues?


Please see my comments on the JIRA pages.

Thanks for looking into this,
Gilles


​

On Fri, Jun 23, 2017 at 1:35 AM, Gilles 


wrote:


Github and Maven experts, please have a look at the
following issues:
  https://issues.apache.org/jira/browse/RNG-38



​PR #1: ​
https://github.com/apache/commons-rng/pull/3




  https://issues.apache.org/jira/browse/RNG-31



​PR #
​2​
: https://github.com/apache/commons-rng/pull/4




Regards,
Gilles





Best regards,
  Artem Barger.



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [configuration] checkstyle fails build

[Allon Mureinik]

The root cause, IMHO, is having failValidation=false configured in the
pom.xml. This way, when you introduce a new problem your only option to
notice it is if you visually scan mvn's output. As evident by the current
state of the build, not everyone notices these.
A more robust approach would be to set failValidation=true, and actively
fail the build if checkstyle's rules are violated.

I've submitted a PR to fix all the existing issues and enable this
validation. Reviews are welcome:
https://github.com/apache/commons-configuration/pull/5


On Thu, Jun 22, 2017 at 11:10 PM, Gary Gregory 
wrote:

> FYI, to whom can take the time to fix this.
>
> When I run 'mvn clean install', I get:
>
> [INFO] --- maven-checkstyle-plugin:2.15:check (default) @
> commons-configuration2 ---
> [INFO] There are 23 errors reported by Checkstyle 6.1.1 with
> C:\vcs\svn\apache\commons\trunks-proper\configuration/conf/checkstyle.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> AbstractHierarchicalConfiguration.java[976]
> (regexp) RegexpSingleline: Line has trailing spaces.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> AbstractHierarchicalConfiguration.java[978:30]
> (blocks) LeftCurly: '{' should be on a new line.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> AbstractYAMLBasedConfiguration.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\builder\fluent\
> INIBuilderParameters.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\builder\
> INIBuilderParametersImpl.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\builder\
> INIBuilderParametersImpl.java[42:5]
> (whitespace) FileTabCharacter: File contains tab characters (this is the
> first instance).
> [ERROR]
> src\main\java\org\apache\commons\configuration2\builder\
> INIBuilderParametersImpl.java[52:84]
> (blocks) LeftCurly: '{' should be on a new line.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> builder\INIBuilderProperties.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\ex\
> ConfigurationRuntimeException.java[68]
> (regexp) RegexpSingleline: Line has trailing spaces.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\JSONConfiguration.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> JSONConfiguration.java[43:5]
> (javadoc) JavadocVariable: Missing a Javadoc comment.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> JSONConfiguration.java[44:5]
> (javadoc) JavadocVariable: Missing a Javadoc comment.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\tree\
> ImmutableNode.java[106]
> (regexp) RegexpSingleline: Line has trailing spaces.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\tree\
> ImmutableNode.java[114:27]
> (blocks) LeftCurly: '{' should be on a new line.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\tree\
> ImmutableNode.java[117]
> (regexp) RegexpSingleline: Line has trailing spaces.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\tree\
> ImmutableNode.java[666]
> (regexp) RegexpSingleline: Line has trailing spaces.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> XMLConfiguration.java[1169:15]
> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> XMLConfiguration.java[1210:15]
> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> XMLConfiguration.java[1212:19]
> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\
> XMLConfiguration.java[1311:20]
> (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\XMLListReference.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\XMLListReference.java[45]
> (design) FinalClass: Class XMLListReference should be declared as final.
> [ERROR]
> src\main\java\org\apache\commons\configuration2\YAMLConfiguration.java[0]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [WARNING] checkstyle:check violations detected but failOnViolation set to
> false
>
> Gary
>