Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Amey Jadiye 
fair enough not to remove keys ;) , Thanks.

Regards,
Amey

On Wed, Jul 19, 2017, 1:32 AM Stefan Bodewig  wrote:

> On 2017-07-18, Amey Jadiye wrote:
>
> > I observed we have lot of keys in
> https://www.apache.org/dist/commons/KEYS,
> > even keys of developers who might have resigned from commons, can we just
> > review and  remove keys of developers who resigned or no more active ?
>
> We shouldn't remove any key that has been used to sign a release in the
> past. No matter how long in the past :-)
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Jonathan Bluett-Duncan 
>
> Yes, of course, that's one way to go and also create a bunch of methods to
> delegate to the wrapped Properties... BUT I cannot pass this object to a
> method typed with "Properties".
>

Oh, that's a fair point. You've convinced me. :)

On 18 July 2017 at 23:44, Gary Gregory  wrote:

> On Tue, Jul 18, 2017 at 11:27 AM, Jonathan Bluett-Duncan <
> jbluettdun...@gmail.com> wrote:
>
> > I would strongly discourage subclassing `Properties` and instead I'd
> > encourage composing it into the proposed `SortedProperties` class, as
> > subclassing classes which weren't designed for inheritance is risky
> > according to Effective Java 2nd Edition, Items 16 and 17.
> >
> > So for example:
> > ```
> > public final class SortedProperties {
> >   private final Properties properties;
> >   ...
> >   public static SortedProperties from(Properties properties,
> > Comparator<...> keyComparator) {
> > ...
> > return new SortedProperties(...);
> >   }
> >   private SortedProperties(...) { ... }
> >   ...
> > }
> > ```
> >
>
> Yes, of course, that's one way to go and also create a bunch of methods to
> delegate to the wrapped Properties... BUT I cannot pass this object to a
> method typed with "Properties".
>
> Gary
>
>
> > On 18 July 2017 at 19:25, Rob Tompkins  wrote:
> >
> > >
> > >
> > > > On Jul 18, 2017, at 4:43 AM, Jörg Schaible
>  > > com> wrote:
> > > >
> > > > Hi Gary,
> > > >
> > > > Gary Gregory wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> I'd to have a new class called SortedProperties that extends
> > > >> java.util.Properties.
> > > >>
> > > >> Should that go in [lang] or [collections]?
> > > >>
> > > >> I first thought [lang], but it _is_ a collection after all.
> > > >>
> > > >> Gary
> > > >
> > > > for me it's [collections]. [collections] is like [lang] also an
> > > extension to
> > > > the Java runtime, specialized for the collection/map/array stuff of
> > > > java.util. Especially since we tried to strip [lang] down and have
> > > already
> > > > moved stuff now into more specialized components.
> > >
> > > I'm stuck in the in-between here with the following thought: HashTable
> > > certainly feels like a collection of objects, but it clearly extends
> > > Dictionary and isn't in the collections family. But we are in java.util
> > > here and not in java.lang, so that feels more like it could be in
> > > collections. Plus properties are essentially a map, despite they're
> being
> > > implemented on top of hashtable.
> > >
> > > -Rob
> > >
> > > >
> > > > Cheers,
> > > > Jörg
> > > >
> > > >
> > > > 
> -
> > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > > For additional commands, e-mail: dev-h...@commons.apache.org
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > >
> >
>

[all] Linking to sites will break or become misleading overtime.

2017-07-18 Thread Gary Gregory 
Hi All,

A comment more than anything:

In our DBCP 1.7 RC2 VOTE email thread in progress now, you can read:

=

On Tue, Jul 18, 2017 at 1:13 PM, Oliver Heger 
 wrote:

> Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and site
> look good.
>
> There is a bunch of checkstyle errors, especially in
> BaseResultSetHandler.java; but I assume they have been in there before,
> so not a blocker.
>

Yeah, if you look at
https://commons.apache.org/proper/commons-dbutils/checkstyle-aggregate.html
you'll see 1104 errors.

=

The page at the link I pasted:

https://commons.apache.org/proper/commons-dbutils/checkstyle-aggregate.html

is about version 1.6 and works today but will be overwritten once we
publish 1.7 making tractability impossible.

I wish we archived sites for all releases... which would be handy when
someone is stuck to using an old version.

Then my link could have been:

https://commons.apache.org/proper/commons-dbutils/1.6/checkstyle-aggregate.html

or something like that. I think a few components here and there do archive
old sites but we do not have a generic and automatic way to do that for all
components.

Gary

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

2017-07-18 Thread Gary Gregory 
On Tue, Jul 18, 2017 at 1:13 PM, Oliver Heger 
wrote:

> Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and site
> look good.
>
> There is a bunch of checkstyle errors, especially in
> BaseResultSetHandler.java; but I assume they have been in there before,
> so not a blocker.
>

Yeah, if you look at
https://commons.apache.org/proper/commons-dbutils/checkstyle-aggregate.html
you'll see 1104 errors.

[Starting a separate thread]

Gary

>
> +1, good work!
>
> Oliver
>
> Am 17.07.2017 um 00:41 schrieb Carl Hall:
> > Hi,
> >
> > It's been almost 3 years to the day since we've had a DbUtils release.
> > We've fixed several important bugs and added some new features, so I
> would
> > like to release DbUtils 1.7.
> >
> > Furthermore, we have fixed these issues for RC2, which were discovered in
> > RC1:
> > - resource leaks as found by FindBugs
> > - updated links & text in generated texts and site
> >
> > DbUtils 1.7 RC2 is available for review here:
> >https://dist.apache.org/repos/dist/dev/commons/dbutils/
> DBUTILS_1_7_RC2/ (svn
> > revision 20455)
> >
> > The tag is here:
> >*https://git-wip-us.apache.org/repos/asf?p=commons-
> dbutils.git;a=tag;h=c7b9d1229aeacd1884c9ca126c5d65af0221404a
> >  c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
> >
> > Maven artifacts are here:
> >https://repository.apache.org/content/repositories/
> orgapachecommons-1254
> >
> > These are the Maven Artifacts and their hashes:
> >
> > commons-dbutils-1.7-javadoc.jar
> > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> > commons-dbutils-1.7-javadoc.jar.asc
> > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> > commons-dbutils-1.7-javadoc.jar.md5
> > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> > commons-dbutils-1.7-javadoc.jar.sha1
> > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> > commons-dbutils-1.7-sources.jar
> > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> > commons-dbutils-1.7-sources.jar.asc
> > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> > commons-dbutils-1.7-sources.jar.md5
> > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> > commons-dbutils-1.7-sources.jar.sha1
> > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> > commons-dbutils-1.7-test-sources.jar
> > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> > commons-dbutils-1.7-test-sources.jar.asc
> > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> > commons-dbutils-1.7-test-sources.jar.md5
> > (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> > commons-dbutils-1.7-test-sources.jar.sha1
> > (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> > commons-dbutils-1.7-tests.jar
> > (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> > commons-dbutils-1.7-tests.jar.asc
> > (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> > commons-dbutils-1.7-tests.jar.md5
> > (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> > commons-dbutils-1.7-tests.jar.sha1
> > (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> > commons-dbutils-1.7.jar
> > (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> > commons-dbutils-1.7.jar.asc
> > (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> > commons-dbutils-1.7.jar.md5
> > (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> > commons-dbutils-1.7.jar.sha1
> > (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> > commons-dbutils-1.7.pom
> > (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> > commons-dbutils-1.7.pom.asc
> > (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> > commons-dbutils-1.7.pom.md5
> > (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> > commons-dbutils-1.7.pom.sha1
> > (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
> >
> > Details of changes since 1.6 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/dbutils/
> DBUTILS_1_7_RC2/RELEASE-NOTES.txt
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> changes-report.html
> >
> > Site:
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> >
> > Clirr Report (compared to 1.6):
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> clirr-report.html
> >
> >- All changes are additions and do not represent any fundamental or
> > breaking changes in how to use the library, so not revving the version.
> >
> > RAT Report:
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/rat-report.html
> >
> > KEYS:
> >https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now,
> > i.e. sometime after 23:00 UTC 19-July-2017
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> > Thanks!
> > -Carl
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Gary Gregory 
On Tue, Jul 18, 2017 at 1:16 PM, Oliver Heger 
wrote:

>
>
> Am 18.07.2017 um 20:39 schrieb Gary Gregory:
> > On Tue, Jul 18, 2017 at 11:25 AM, Rob Tompkins 
> wrote:
> >
> >>
> >>
> >>> On Jul 18, 2017, at 4:43 AM, Jörg Schaible  >> com> wrote:
> >>>
> >>> Hi Gary,
> >>>
> >>> Gary Gregory wrote:
> >>>
>  Hi,
> 
>  I'd to have a new class called SortedProperties that extends
>  java.util.Properties.
> 
>  Should that go in [lang] or [collections]?
> 
>  I first thought [lang], but it _is_ a collection after all.
> 
>  Gary
> >>>
> >>> for me it's [collections]. [collections] is like [lang] also an
> >> extension to
> >>> the Java runtime, specialized for the collection/map/array stuff of
> >>> java.util. Especially since we tried to strip [lang] down and have
> >> already
> >>> moved stuff now into more specialized components.
> >>
> >> I'm stuck in the in-between here with the following thought: HashTable
> >> certainly feels like a collection of objects, but it clearly extends
> >> Dictionary and isn't in the collections family. But we are in java.util
> >> here and not in java.lang, so that feels more like it could be in
> >> collections. Plus properties are essentially a map, despite they're
> being
> >> implemented on top of hashtable.
> >>
> >
> > You know what, after scanning the [lang] and [collections] code base, it
> > really seems better in [collections].
> >
> > I'd like to propose
> > org.apache.commons.collections4.properties.SortedProperties.
>
> A heretical question: Is the use case generic enough that such a class
> should be added to Commons?
>
> Most users do not care about the order of properties. And if they do,
> there might be special requirements, e.g. should the order be
> case-sensitive or not, should newly added properties appear at the end
> (keeping the original order), ...
>

Valid question. Take a look at [collections] though. It is full of
variations on different kinds of collections.

Supporting some way of sorting a Properties object seems quite reasonable
in that context.

Gary


>
> Oliver
>
> >
> > Gary
> >
> >
> >>
> >> -Rob
> >>
> >>>
> >>> Cheers,
> >>> Jörg
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >>> For additional commands, e-mail: dev-h...@commons.apache.org
> >>>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Gary Gregory 
On Tue, Jul 18, 2017 at 1:02 PM, Stefan Bodewig  wrote:

> On 2017-07-18, Amey Jadiye wrote:
>
> > I observed we have lot of keys in https://www.apache.org/dist/
> commons/KEYS,
> > even keys of developers who might have resigned from commons, can we just
> > review and  remove keys of developers who resigned or no more active ?
>
> We shouldn't remove any key that has been used to sign a release in the
> past. No matter how long in the past :-)
>

+1

Gary


>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[GitHub] commons-collections pull request #25: COLLECTIONS-575: Add synchronized queu...

2017-07-18 Thread Xaerxess 
GitHub user Xaerxess opened a pull request:

https://github.com/apache/commons-collections/pull/25

COLLECTIONS-575: Add synchronized queue wrapper

Added QueueUtils#synchronizedQueue(Queue) wrapper and SynchronizedQueue 
with tests. Please check if I used proper conventions as it's my first PR to 
commons-collections.

Follow-up to PR #19 which was closed during migration.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Xaerxess/commons-collections 
COLLECTIONS-575-synchronized-queue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit bfdce1dbac170d76890c223beb71e0c0b6684f1a
Author: Grzegorz Rożniecki 
Date:   2016-10-28T20:04:43Z

COLLECTIONS-575: Add synchronized queue wrapper

commit 5daa2123ecba3ed52e0d049d492cafab2ea3ae2b
Author: Grzegorz Rożniecki 
Date:   2016-10-28T20:04:52Z

COLLECTIONS-575: Add test for QueueUtils#synchronizedQueue(Queue)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Oliver Heger 


Am 18.07.2017 um 20:39 schrieb Gary Gregory:
> On Tue, Jul 18, 2017 at 11:25 AM, Rob Tompkins  wrote:
> 
>>
>>
>>> On Jul 18, 2017, at 4:43 AM, Jörg Schaible > com> wrote:
>>>
>>> Hi Gary,
>>>
>>> Gary Gregory wrote:
>>>
 Hi,

 I'd to have a new class called SortedProperties that extends
 java.util.Properties.

 Should that go in [lang] or [collections]?

 I first thought [lang], but it _is_ a collection after all.

 Gary
>>>
>>> for me it's [collections]. [collections] is like [lang] also an
>> extension to
>>> the Java runtime, specialized for the collection/map/array stuff of
>>> java.util. Especially since we tried to strip [lang] down and have
>> already
>>> moved stuff now into more specialized components.
>>
>> I'm stuck in the in-between here with the following thought: HashTable
>> certainly feels like a collection of objects, but it clearly extends
>> Dictionary and isn't in the collections family. But we are in java.util
>> here and not in java.lang, so that feels more like it could be in
>> collections. Plus properties are essentially a map, despite they're being
>> implemented on top of hashtable.
>>
> 
> You know what, after scanning the [lang] and [collections] code base, it
> really seems better in [collections].
> 
> I'd like to propose
> org.apache.commons.collections4.properties.SortedProperties.

A heretical question: Is the use case generic enough that such a class
should be added to Commons?

Most users do not care about the order of properties. And if they do,
there might be special requirements, e.g. should the order be
case-sensitive or not, should newly added properties appear at the end
(keeping the original order), ...

Oliver

> 
> Gary
> 
> 
>>
>> -Rob
>>
>>>
>>> Cheers,
>>> Jörg
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

2017-07-18 Thread Oliver Heger 
Build works fine with Java 1.6 and 1.8 on Windows 10. Artifacts and site
look good.

There is a bunch of checkstyle errors, especially in
BaseResultSetHandler.java; but I assume they have been in there before,
so not a blocker.

+1, good work!

Oliver

Am 17.07.2017 um 00:41 schrieb Carl Hall:
> Hi,
> 
> It's been almost 3 years to the day since we've had a DbUtils release.
> We've fixed several important bugs and added some new features, so I would
> like to release DbUtils 1.7.
> 
> Furthermore, we have fixed these issues for RC2, which were discovered in
> RC1:
> - resource leaks as found by FindBugs
> - updated links & text in generated texts and site
> 
> DbUtils 1.7 RC2 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/ 
> (svn
> revision 20455)
> 
> The tag is here:
>
> *https://git-wip-us.apache.org/repos/asf?p=commons-dbutils.git;a=tag;h=c7b9d1229aeacd1884c9ca126c5d65af0221404a
> *
> 
> Maven artifacts are here:
>https://repository.apache.org/content/repositories/orgapachecommons-1254
> 
> These are the Maven Artifacts and their hashes:
> 
> commons-dbutils-1.7-javadoc.jar
> (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> commons-dbutils-1.7-javadoc.jar.asc
> (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> commons-dbutils-1.7-javadoc.jar.md5
> (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> commons-dbutils-1.7-javadoc.jar.sha1
> (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> commons-dbutils-1.7-sources.jar
> (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> commons-dbutils-1.7-sources.jar.asc
> (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> commons-dbutils-1.7-sources.jar.md5
> (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> commons-dbutils-1.7-sources.jar.sha1
> (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> commons-dbutils-1.7-test-sources.jar
> (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> commons-dbutils-1.7-test-sources.jar.asc
> (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> commons-dbutils-1.7-test-sources.jar.md5
> (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> commons-dbutils-1.7-test-sources.jar.sha1
> (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> commons-dbutils-1.7-tests.jar
> (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> commons-dbutils-1.7-tests.jar.asc
> (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> commons-dbutils-1.7-tests.jar.md5
> (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> commons-dbutils-1.7-tests.jar.sha1
> (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> commons-dbutils-1.7.jar
> (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> commons-dbutils-1.7.jar.asc
> (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> commons-dbutils-1.7.jar.md5
> (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> commons-dbutils-1.7.jar.sha1
> (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> commons-dbutils-1.7.pom
> (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> commons-dbutils-1.7.pom.asc
> (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> commons-dbutils-1.7.pom.md5
> (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> commons-dbutils-1.7.pom.sha1
> (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
> 
> Details of changes since 1.6 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/RELEASE-NOTES.txt
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/changes-report.html
> 
> Site:
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> 
> Clirr Report (compared to 1.6):
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/clirr-report.html
> 
>- All changes are additions and do not represent any fundamental or
> breaking changes in how to use the library, so not revving the version.
> 
> RAT Report:
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/rat-report.html
> 
> KEYS:
>https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 23:00 UTC 19-July-2017
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
> Thanks!
> -Carl
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Stefan Bodewig 
On 2017-07-18, Amey Jadiye wrote:

> I observed we have lot of keys in https://www.apache.org/dist/commons/KEYS,
> even keys of developers who might have resigned from commons, can we just
> review and  remove keys of developers who resigned or no more active ?

We shouldn't remove any key that has been used to sign a release in the
past. No matter how long in the past :-)

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #49: TEXT-89: WordUtils.initials support for UTF-1...

2017-07-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Simon Spero 
On Jul 18, 2017 2:25 PM, "Rob Tompkins"  wrote:

I'm stuck in the in-between here with the following thought: HashTable
certainly feels like a collection of objects, but it clearly extends
Dictionary and isn't in the collections family. But we are in java.util
here and not in java.lang, so that feels more like it could be in
collections. Plus properties are essentially a map, despite they're being
implemented on top of hashtable.


HashTable extends Dictionary implements Map.

Of course,  Properties extends HashTable  because legacy.

In jdk 9, Properties still extends HashTable.
 However, HashTable now has a magic package private constructor
"HashTable(Void)", which is used by Properties to tell HashTable to go sit
in a corner, with all fields left set to default values.

Properties now uses a ConcurrentHashMap internally, with only a few methods
remaining synchronized. Everything gets delegated to the chm.

Still full of unchecked goodness.

And a great example of  how sometimes inheritance is so useless you just
compose and delegate anyway.

Simon

[GitHub] commons-collections issue #18: COLLECTIONS-586 PatriciaTrie prefixMap clear ...

2017-07-18 Thread marko-bekhta 
Github user marko-bekhta commented on the issue:

https://github.com/apache/commons-collections/pull/18
  
Hi @chtompki there seems nothing to rebase now. The patch was copied and 
applied here 

https://github.com/apache/commons-collections/commit/a270ff62852e62b5ac0f943a7e57292a72b77271
let me know if anything else is needed. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Gary Gregory 
On Tue, Jul 18, 2017 at 11:25 AM, Rob Tompkins  wrote:

>
>
> > On Jul 18, 2017, at 4:43 AM, Jörg Schaible  com> wrote:
> >
> > Hi Gary,
> >
> > Gary Gregory wrote:
> >
> >> Hi,
> >>
> >> I'd to have a new class called SortedProperties that extends
> >> java.util.Properties.
> >>
> >> Should that go in [lang] or [collections]?
> >>
> >> I first thought [lang], but it _is_ a collection after all.
> >>
> >> Gary
> >
> > for me it's [collections]. [collections] is like [lang] also an
> extension to
> > the Java runtime, specialized for the collection/map/array stuff of
> > java.util. Especially since we tried to strip [lang] down and have
> already
> > moved stuff now into more specialized components.
>
> I'm stuck in the in-between here with the following thought: HashTable
> certainly feels like a collection of objects, but it clearly extends
> Dictionary and isn't in the collections family. But we are in java.util
> here and not in java.lang, so that feels more like it could be in
> collections. Plus properties are essentially a map, despite they're being
> implemented on top of hashtable.
>

You know what, after scanning the [lang] and [collections] code base, it
really seems better in [collections].

I'd like to propose
org.apache.commons.collections4.properties.SortedProperties.

Gary


>
> -Rob
>
> >
> > Cheers,
> > Jörg
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread jbduncan 
Github user jbduncan commented on the issue:

https://github.com/apache/commons-text/pull/56
  
@TheRealHaui Yes, precisely. :)

(With hindsight, I should have used the word "violations" instead of 
"cases"; it would have been clearer that I was referring to the errors that 
Checkstyle reports, rather than something else.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Amey Jadiye 
How about developers who resigned ? It means whoever sent mail that they
are not willing to be the part of community.?

I think keeping keys of  non-active developers of Ok.

Ex.
James have resigned http://commons.markmail.org/message/i2davy3nf4fr7xqp
But I can see his key.

pub   1024D/9EEDB2D5 2006-04-14
uid  James Carman 
sig 39EEDB2D5 2006-04-14  James Carman 
sub   2048g/4240E713 2006-04-14
sig  9EEDB2D5 2006-04-14  James Carman 


Also I see lot of people resigned here
http://commons.markmail.org/message/2fzh5qgwhppkdslj

Regards,
Amey


On Tue, Jul 18, 2017 at 11:55 PM, Gary Gregory 
wrote:

> There is no criteria for "not active"; either you are a committer or you
> are not per: https://people.apache.org/phonebook.html?unix=commons
>
> Gary
>
> On Tue, Jul 18, 2017 at 11:21 AM, Amey Jadiye 
> wrote:
>
> > I observed we have lot of keys in https://www.apache.org/dist/
> commons/KEYS
> > ,
> > even keys of developers who might have resigned from commons, can we just
> > review and  remove keys of developers who resigned or no more active ?
> >
> > Regards,
> > Amey
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>



-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Rob Tompkins 


> On Jul 18, 2017, at 2:25 PM, Gary Gregory  wrote:
> 
> There is no criteria for "not active"; either you are a committer or you
> are not per: https://people.apache.org/phonebook.html?unix=commons
> 

It feels like a bad idea because we may have very old releases that could still 
be verified by using the archaic keys in the file. 

My 2 cents,
-Rob

> Gary
> 
>> On Tue, Jul 18, 2017 at 11:21 AM, Amey Jadiye  wrote:
>> 
>> I observed we have lot of keys in https://www.apache.org/dist/commons/KEYS
>> ,
>> even keys of developers who might have resigned from commons, can we just
>> review and  remove keys of developers who resigned or no more active ?
>> 
>> Regards,
>> Amey
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Jonathan Bluett-Duncan 
I would strongly discourage subclassing `Properties` and instead I'd
encourage composing it into the proposed `SortedProperties` class, as
subclassing classes which weren't designed for inheritance is risky
according to Effective Java 2nd Edition, Items 16 and 17.

So for example:
```
public final class SortedProperties {
  private final Properties properties;
  ...
  public static SortedProperties from(Properties properties,
Comparator<...> keyComparator) {
...
return new SortedProperties(...);
  }
  private SortedProperties(...) { ... }
  ...
}
```

On 18 July 2017 at 19:25, Rob Tompkins  wrote:

>
>
> > On Jul 18, 2017, at 4:43 AM, Jörg Schaible  com> wrote:
> >
> > Hi Gary,
> >
> > Gary Gregory wrote:
> >
> >> Hi,
> >>
> >> I'd to have a new class called SortedProperties that extends
> >> java.util.Properties.
> >>
> >> Should that go in [lang] or [collections]?
> >>
> >> I first thought [lang], but it _is_ a collection after all.
> >>
> >> Gary
> >
> > for me it's [collections]. [collections] is like [lang] also an
> extension to
> > the Java runtime, specialized for the collection/map/array stuff of
> > java.util. Especially since we tried to strip [lang] down and have
> already
> > moved stuff now into more specialized components.
>
> I'm stuck in the in-between here with the following thought: HashTable
> certainly feels like a collection of objects, but it clearly extends
> Dictionary and isn't in the collections family. But we are in java.util
> here and not in java.lang, so that feels more like it could be in
> collections. Plus properties are essentially a map, despite they're being
> implemented on top of hashtable.
>
> -Rob
>
> >
> > Cheers,
> > Jörg
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Gary Gregory 
Also, the KEYS list can include ANY Apache Committer, not just members
Apache Commons.

IOW, I think the only people to remove are people that no longer are Apache
Committers.

Gary

On Tue, Jul 18, 2017 at 11:25 AM, Gary Gregory 
wrote:

> There is no criteria for "not active"; either you are a committer or you
> are not per: https://people.apache.org/phonebook.html?unix=commons
>
> Gary
>
> On Tue, Jul 18, 2017 at 11:21 AM, Amey Jadiye 
> wrote:
>
>> I observed we have lot of keys in https://www.apache.org/dist/co
>> mmons/KEYS,
>> even keys of developers who might have resigned from commons, can we just
>> review and  remove keys of developers who resigned or no more active ?
>>
>> Regards,
>> Amey
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>
>

[GitHub] commons-text issue #49: TEXT-89: WordUtils.initials support for UTF-16 surro...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/49
  
Cool. Will look at this in just a bit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Gary Gregory 
There is no criteria for "not active"; either you are a committer or you
are not per: https://people.apache.org/phonebook.html?unix=commons

Gary

On Tue, Jul 18, 2017 at 11:21 AM, Amey Jadiye  wrote:

> I observed we have lot of keys in https://www.apache.org/dist/commons/KEYS
> ,
> even keys of developers who might have resigned from commons, can we just
> review and  remove keys of developers who resigned or no more active ?
>
> Regards,
> Amey
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Rob Tompkins 


> On Jul 18, 2017, at 4:43 AM, Jörg Schaible  
> wrote:
> 
> Hi Gary,
> 
> Gary Gregory wrote:
> 
>> Hi,
>> 
>> I'd to have a new class called SortedProperties that extends
>> java.util.Properties.
>> 
>> Should that go in [lang] or [collections]?
>> 
>> I first thought [lang], but it _is_ a collection after all.
>> 
>> Gary
> 
> for me it's [collections]. [collections] is like [lang] also an extension to 
> the Java runtime, specialized for the collection/map/array stuff of 
> java.util. Especially since we tried to strip [lang] down and have already 
> moved stuff now into more specialized components.

I'm stuck in the in-between here with the following thought: HashTable 
certainly feels like a collection of objects, but it clearly extends Dictionary 
and isn't in the collections family. But we are in java.util here and not in 
java.lang, so that feels more like it could be in collections. Plus properties 
are essentially a map, despite they're being implemented on top of hashtable. 

-Rob

> 
> Cheers,
> Jörg
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-18 Thread Amey Jadiye 
I observed we have lot of keys in https://www.apache.org/dist/commons/KEYS,
even keys of developers who might have resigned from commons, can we just
review and  remove keys of developers who resigned or no more active ?

Regards,
Amey

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread TheRealHaui 
Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-text/pull/56
  
You mean the cases reported by the checkstyle plugin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...

2017-07-18 Thread TheRealHaui 
Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-collections/pull/24#discussion_r128054680
  
--- Diff: 
src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
 ---
@@ -16,12 +16,14 @@
  */
 package org.apache.commons.collections4.iterators;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Comparator;
-import java.util.List;
-
 import org.apache.commons.collections4.comparators.ComparableComparator;
+import org.junit.Test;
+
+import java.lang.reflect.Array;
+import java.util.*;
--- End diff --

Thanks for your advice!
However, in general I've turned that feature in Intellij off.

However again, I often reorganize imports manually to make the code more 
compact.
And in the end often select the code developed by me and reformat it.

Honestly, couldn't simply imagine that this is such a BIG THING in Open 
Source projects ...
At first I thought some are joking or trying to play tricks on me ...

Thanks for turning it back in this commit.
Furthermore, if you want me to recheck this commit regarding this I'll do 
and push the changes.

And I vow to try to keep this in mind and try to improve regarding this in 
Open Source projects. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #49: TEXT-89: WordUtils.initials support for UTF-16 surro...

2017-07-18 Thread ameyjadiye 
Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/49
  
@chtompki , @PascalSchumacher this seems good to me for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/56
  

[![Coverage 
Status](https://coveralls.io/builds/12445709/badge)](https://coveralls.io/builds/12445709)

Coverage increased (+1.04%) to 98.34% when pulling 
**04788b92e136e4e621c6b2799e2d86d52cd8f7d5 on TheRealHaui:add-some-Unit-Tests** 
into **aaf4aba369ed0b97d17bc9343f763b0d099dbc2f on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

2017-07-18 Thread Gary Gregory 
On Tue, Jul 18, 2017 at 11:12 AM, Amey Jadiye  wrote:

> Checked RC2, and here is my +1 (non-binding).
>
> 1. Build and Tests are passing clean
> 2. Clirr and Rat looks good.
> 3. Findbug show two DM_DEFAULT_ENCODING warning but non-blocker to release.
> 3. There are few of bugs in Checkstyle report but they are non-blocker to
> release.
> 4. Hashes given in files looks good.
> 5. Site looks fine.
>
> I observed we have quite a lot keys in
> https://www.apache.org/dist/commons/KEYS, even developers who might have
> resigned from commons, can we just remove keys of developers who resigned
> or no more active ?
>

Please start a separate thread for this since we do not want a VOTE thread
verge off into tangents.

Gary

>
> Checked on :-
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T22:11:47+05:30)
> Maven home: /opt/apache/maven
> Java version: 1.8.0_111, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_IN, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-31-generic", arch: "amd64", family:
> "unix"
>
>
>
> Regards,
> Amey
>
> On Mon, Jul 17, 2017 at 4:11 AM, Carl Hall  wrote:
>
> > Hi,
> >
> > It's been almost 3 years to the day since we've had a DbUtils release.
> > We've fixed several important bugs and added some new features, so I
> would
> > like to release DbUtils 1.7.
> >
> > Furthermore, we have fixed these issues for RC2, which were discovered in
> > RC1:
> > - resource leaks as found by FindBugs
> > - updated links & text in generated texts and site
> >
> > DbUtils 1.7 RC2 is available for review here:
> >https://dist.apache.org/repos/dist/dev/commons/dbutils/
> DBUTILS_1_7_RC2/
> > (svn
> > revision 20455)
> >
> > The tag is here:
> >*https://git-wip-us.apache.org/repos/asf?p=commons-
> dbutils.git;a=tag;h=
> > c7b9d1229aeacd1884c9ca126c5d65af0221404a
> >  > c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
> >
> > Maven artifacts are here:
> >https://repository.apache.org/content/repositories/
> > orgapachecommons-1254
> >
> > These are the Maven Artifacts and their hashes:
> >
> > commons-dbutils-1.7-javadoc.jar
> > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> > commons-dbutils-1.7-javadoc.jar.asc
> > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> > commons-dbutils-1.7-javadoc.jar.md5
> > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> > commons-dbutils-1.7-javadoc.jar.sha1
> > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> > commons-dbutils-1.7-sources.jar
> > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> > commons-dbutils-1.7-sources.jar.asc
> > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> > commons-dbutils-1.7-sources.jar.md5
> > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> > commons-dbutils-1.7-sources.jar.sha1
> > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> > commons-dbutils-1.7-test-sources.jar
> > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> > commons-dbutils-1.7-test-sources.jar.asc
> > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> > commons-dbutils-1.7-test-sources.jar.md5
> > (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> > commons-dbutils-1.7-test-sources.jar.sha1
> > (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> > commons-dbutils-1.7-tests.jar
> > (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> > commons-dbutils-1.7-tests.jar.asc
> > (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> > commons-dbutils-1.7-tests.jar.md5
> > (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> > commons-dbutils-1.7-tests.jar.sha1
> > (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> > commons-dbutils-1.7.jar
> > (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> > commons-dbutils-1.7.jar.asc
> > (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> > commons-dbutils-1.7.jar.md5
> > (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> > commons-dbutils-1.7.jar.sha1
> > (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> > commons-dbutils-1.7.pom
> > (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> > commons-dbutils-1.7.pom.asc
> > (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> > commons-dbutils-1.7.pom.md5
> > (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> > commons-dbutils-1.7.pom.sha1
> > (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
> >
> > Details of changes since 1.6 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/dbutils/
> > DBUTILS_1_7_RC2/RELEASE-NOTES.txt
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> > changes-report.html
> >
> > Site:
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> >
> > Clirr Report (compared to 1.6):
> >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> clirr-report.html
> >
> >- All changes are additions and do not represent any fundamental or
> > breaking changes in how to use the library, so not revving the version.
> >
> > RAT Report:
> >

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

2017-07-18 Thread Amey Jadiye 
Checked RC2, and here is my +1 (non-binding).

1. Build and Tests are passing clean
2. Clirr and Rat looks good.
3. Findbug show two DM_DEFAULT_ENCODING warning but non-blocker to release.
3. There are few of bugs in Checkstyle report but they are non-blocker to
release.
4. Hashes given in files looks good.
5. Site looks fine.

I observed we have quite a lot keys in
https://www.apache.org/dist/commons/KEYS, even developers who might have
resigned from commons, can we just remove keys of developers who resigned
or no more active ?

Checked on :-
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T22:11:47+05:30)
Maven home: /opt/apache/maven
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_IN, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-31-generic", arch: "amd64", family: "unix"



Regards,
Amey

On Mon, Jul 17, 2017 at 4:11 AM, Carl Hall  wrote:

> Hi,
>
> It's been almost 3 years to the day since we've had a DbUtils release.
> We've fixed several important bugs and added some new features, so I would
> like to release DbUtils 1.7.
>
> Furthermore, we have fixed these issues for RC2, which were discovered in
> RC1:
> - resource leaks as found by FindBugs
> - updated links & text in generated texts and site
>
> DbUtils 1.7 RC2 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/
> (svn
> revision 20455)
>
> The tag is here:
>*https://git-wip-us.apache.org/repos/asf?p=commons-dbutils.git;a=tag;h=
> c7b9d1229aeacd1884c9ca126c5d65af0221404a
>  c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
>
> Maven artifacts are here:
>https://repository.apache.org/content/repositories/
> orgapachecommons-1254
>
> These are the Maven Artifacts and their hashes:
>
> commons-dbutils-1.7-javadoc.jar
> (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> commons-dbutils-1.7-javadoc.jar.asc
> (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> commons-dbutils-1.7-javadoc.jar.md5
> (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> commons-dbutils-1.7-javadoc.jar.sha1
> (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> commons-dbutils-1.7-sources.jar
> (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> commons-dbutils-1.7-sources.jar.asc
> (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> commons-dbutils-1.7-sources.jar.md5
> (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> commons-dbutils-1.7-sources.jar.sha1
> (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> commons-dbutils-1.7-test-sources.jar
> (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> commons-dbutils-1.7-test-sources.jar.asc
> (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> commons-dbutils-1.7-test-sources.jar.md5
> (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> commons-dbutils-1.7-test-sources.jar.sha1
> (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> commons-dbutils-1.7-tests.jar
> (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> commons-dbutils-1.7-tests.jar.asc
> (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> commons-dbutils-1.7-tests.jar.md5
> (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> commons-dbutils-1.7-tests.jar.sha1
> (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> commons-dbutils-1.7.jar
> (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> commons-dbutils-1.7.jar.asc
> (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> commons-dbutils-1.7.jar.md5
> (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> commons-dbutils-1.7.jar.sha1
> (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> commons-dbutils-1.7.pom
> (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> commons-dbutils-1.7.pom.asc
> (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> commons-dbutils-1.7.pom.md5
> (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> commons-dbutils-1.7.pom.sha1
> (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
>
> Details of changes since 1.6 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/dbutils/
> DBUTILS_1_7_RC2/RELEASE-NOTES.txt
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> changes-report.html
>
> Site:
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
>
> Clirr Report (compared to 1.6):
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/clirr-report.html
>
>- All changes are additions and do not represent any fundamental or
> breaking changes in how to use the library, so not revving the version.
>
> RAT Report:
>https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/rat-report.html
>
> KEYS:
>https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 23:00 UTC 19-July-2017
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
> -Carl
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Gary Gregory 
Nope. All that I want is to write a Properties object with sorted lines.
Simple as that. I do not even need to read a properties file into a
SortedProperties but we can do that as well of course.

This works:

https://github.com/h2database/h2database/blob/master/h2/src/main/org/h2/util/SortedProperties.java

Gary

On Tue, Jul 18, 2017 at 11:02 AM, Simon Spero  wrote:

> On Jul 18, 2017 11:39 AM, "Gary Gregory"  wrote:
>
> My use case is to write a Properties object in sorted key order, nothing
> fancy. The simplest way is to subclass Properties and override keys().
>
> Loading a SortedProperties with a Map is not on my to-do list.
>
>
>
>
> Would your use case be served by one or more static methods?
> These methods might need as  arguments:
> 1) Some form of output sink
> 2) An instance of Map m satisfying the conditions:
>a) every key in m is an instance of String.
>b) every value in m is an instance of String.
>
> The constraints 2a and 2b   are required   be satisfied by any Properties
> object  any time at  it is output.
>
> (Because of the legacy derivation from Hashtable, these  conditions may be
> violated at other times without an error being signaled. This also makes
> the concept of a Sorted Properties instance problematic, as these
> keys/values may be comparable with String.)
>
> There might be different entry points for sorted output, and for output in
> the natural order of the map (which might  be sorted).
>
> There may need to be a specialized default comparator if parts of the keys
> are to be compared in non lexicographic order (for example, if  a key
> contains sequences of digits that should be compared as numbers, or if keys
> are hierarchical, with components  separated by periods).
>
> Values need to be encoded wrt the special escape format defined for
> properties files.
>
> As a separate set of functionality, a corresponding method or set of
> methods could be provided to support populating a Map from an input source
> containing contents formatted as specified in j.u.Properties.
>
> So,  io with a touch of codec?
>
> Simon
>

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread jbduncan 
Github user jbduncan commented on the issue:

https://github.com/apache/commons-text/pull/56
  
Thanks @TheRealHaui!

I think handling the rest of the cases reported by Checkstyle should be 
done in a separate PR (or series of PRs if needed) by whoever feels up to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Simon Spero 
On Jul 18, 2017 11:39 AM, "Gary Gregory"  wrote:

My use case is to write a Properties object in sorted key order, nothing
fancy. The simplest way is to subclass Properties and override keys().

Loading a SortedProperties with a Map is not on my to-do list.




Would your use case be served by one or more static methods?
These methods might need as  arguments:
1) Some form of output sink
2) An instance of Map m satisfying the conditions:
   a) every key in m is an instance of String.
   b) every value in m is an instance of String.

The constraints 2a and 2b   are required   be satisfied by any Properties
object  any time at  it is output.

(Because of the legacy derivation from Hashtable, these  conditions may be
violated at other times without an error being signaled. This also makes
the concept of a Sorted Properties instance problematic, as these
keys/values may be comparable with String.)

There might be different entry points for sorted output, and for output in
the natural order of the map (which might  be sorted).

There may need to be a specialized default comparator if parts of the keys
are to be compared in non lexicographic order (for example, if  a key
contains sequences of digits that should be compared as numbers, or if keys
are hierarchical, with components  separated by periods).

Values need to be encoded wrt the special escape format defined for
properties files.

As a separate set of functionality, a corresponding method or set of
methods could be provided to support populating a Map from an input source
containing contents formatted as specified in j.u.Properties.

So,  io with a touch of codec?

Simon

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread TheRealHaui 
Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-text/pull/56
  
Reformatted requested code artifacts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/56
  
@ameyjadiye Try adding the same suppression as commons-lang:

```


```

That should reduce the errors. Maybe their are other checks which can be 
reasonably suppressed for tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread ameyjadiye 
Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/56
  
@PascalSchumacher I just enabled in my local, seems very cumbersome task to 
me at this point.

```

[INFO] There are 2551 checkstyle errors.
.
.
.
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 41.252 s
[INFO] Finished at: 2017-07-18T23:18:57+05:30
[INFO] Final Memory: 36M/621M
[INFO] 

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (default-cli) on 
project commons-text: You have 2551 Checkstyle violations. -> [Help 1]
.
.
.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Gary Gregory 
My use case is to write a Properties object in sorted key order, nothing
fancy. The simplest way is to subclass Properties and override keys().

Loading a SortedProperties with a Map is not on my to-do list.

Gary

On Jul 18, 2017 00:41, "Javen O'Neal"  wrote:

> +1 for Lang.
>
> There aren't any persistent data structures in Collections, nor would I
> think to look in Collections to find one.
>
> Properties is a persistent hashtable. SortedProperties is a persistent
> TreeMap.
>
> Unless you're thinking about a new family of SortedProperties. Were you
> thinking about letting the user provide the Map implementation and the
> SortedProperties would handle the persistence?
> For example, if I wanted to persist a MultiValuedMap or a BidiMap, could I
> do that?
> new PersistentMap>();
> new PersistentMap>();
> Is there a real scenario where this would be needed?
>
> On Jul 18, 2017 00:19, "Amey Jadiye"  wrote:
>
> > My opinion is this should go to *lang* because the fact is it's extended
> > utility and not exactly as data structures though it looks like one. It's
> > main purpose is to hold properties and not the data.  Commons collection
> > aims to provide utlilities and extension to data structures and not to
> > properties  related utilities. Properties is very basic thing no matter
> > it's sorted or not sorted and should go to lang.
> >
> > Regards,
> > Amey
> >
> > On Tue, Jul 18, 2017, 11:58 AM Gary Gregory 
> > wrote:
> >
> > > Hi,
> > >
> > > I'd to have a new class called SortedProperties that extends
> > > java.util.Properties.
> > >
> > > Should that go in [lang] or [collections]?
> > >
> > > I first thought [lang], but it _is_ a collection after all.
> > >
> > > Gary
> > >
> >
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Matt Sicker 
Yeah, I was confused. Persistent collections have a meaning (e.g., see <
https://pcollections.org/> for a Java library implementation) a bit
different from persistent entities.

On 18 July 2017 at 05:18, Jonathan Bluett-Duncan 
wrote:

> Javen,
>
> Just for clarity, by persistent collections, are you talking about
> _functional_ persistent collections (a la Scala, Clojure and Haskell),
> _disk_-persisted collections, or some other definition of "persistent"?
>
> Jonathan
>
> On 18 Jul 2017 08:41, "Javen O'Neal"  wrote:
>
> +1 for Lang.
>
> There aren't any persistent data structures in Collections, nor would I
> think to look in Collections to find one.
>
> Properties is a persistent hashtable. SortedProperties is a persistent
> TreeMap.
>
> Unless you're thinking about a new family of SortedProperties. Were you
> thinking about letting the user provide the Map implementation and the
> SortedProperties would handle the persistence?
> For example, if I wanted to persist a MultiValuedMap or a BidiMap, could I
> do that?
> new PersistentMap>();
> new PersistentMap>();
> Is there a real scenario where this would be needed?
>
> On Jul 18, 2017 00:19, "Amey Jadiye"  wrote:
>
> > My opinion is this should go to *lang* because the fact is it's extended
> > utility and not exactly as data structures though it looks like one. It's
> > main purpose is to hold properties and not the data.  Commons collection
> > aims to provide utlilities and extension to data structures and not to
> > properties  related utilities. Properties is very basic thing no matter
> > it's sorted or not sorted and should go to lang.
> >
> > Regards,
> > Amey
> >
> > On Tue, Jul 18, 2017, 11:58 AM Gary Gregory 
> > wrote:
> >
> > > Hi,
> > >
> > > I'd to have a new class called SortedProperties that extends
> > > java.util.Properties.
> > >
> > > Should that go in [lang] or [collections]?
> > >
> > > I first thought [lang], but it _is_ a collection after all.
> > >
> > > Gary
> > >
> >
>



-- 
Matt Sicker

[GitHub] commons-collections issue #15: Allow minus index

2017-07-18 Thread lamrongol 
Github user lamrongol commented on the issue:

https://github.com/apache/commons-collections/pull/15
  
@chtompki Honestly, I didn't think the effect to other class and can't 
predict the effect. I hope experts of this repository decide.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...

2017-07-18 Thread chtompki 
Github user chtompki commented on a diff in the pull request:

https://github.com/apache/commons-collections/pull/24#discussion_r127966801
  
--- Diff: 
src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
 ---
@@ -16,12 +16,14 @@
  */
 package org.apache.commons.collections4.iterators;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Comparator;
-import java.util.List;
-
 import org.apache.commons.collections4.comparators.ComparableComparator;
+import org.junit.Test;
+
+import java.lang.reflect.Array;
+import java.util.*;
--- End diff --

This looks like you're using IntelliJ with the default settings. I've had 
to disable the change to `import package.name.*` for 5 or more from the same 
location. I would try to turn that off. Further it may not run on save as some 
folks suggested in https://github.com/apache/commons-text/pull/56 I think it 
runs when you do a file format command or "reorganize imports" command. 
Regardless I'll try to change it back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #5: gitignore and CollectionUtils improvements

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/5
  
@huseyincelik - Do you mind rebasing this work onto the `master` branch and 
opening a new pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #9: COLLECTIONS-551

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/9
  
@gonmarques - Do you mind rebasing this work onto the `master` branch and 
opening a new pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #10: Add CollectionUtils#containsQuietly method an...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/10
  
@AndersDJohnson - Do you mind rebasing this work on the `master` branch and 
opening a new pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #13: [COLLECTIONS-574] Improve ListUtils#longestCo...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/13
  
@kaching88 - Do you mind rebasing to the `master` branch and re-opening 
this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #15: Allow minus index

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/15
  
@lamrongol - Do you mind rebasing to the `master` branch, and re-opening 
this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #18: COLLECTIONS-586 PatriciaTrie prefixMap clear ...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/18
  
@marko-bekhta - Do you mind rebasing to the `master` branch, and re-opening 
this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #19: COLLECTIONS-575: Add synchronized queue wrapp...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/19
  
@Xaerxess - As posted in the [Jira 
Issue](https://issues.apache.org/jira/browse/COLLECTIONS-575), do you mind 
rebasing to master and re-opening this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #21: Add VI[M] temporary files to .gitignore

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/21
  
@mureinik - Do you mind rebasing to master and re-opening this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #22: [COLLECTIONS-600] Null-safe implementation of...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/22
  
@jonasholtkamp - Do you mind rebasing to master and re-opening this pull 
request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #3: Added MultiValuedLinkedHashMap to preserve ins...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/3
  
@geoffschoeman - Do you mind rebasing to master and re-opening this pull 
request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #12: [COLLECTIONS-573] Add CollectionUtils#deepMer...

2017-07-18 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/12
  
Do you mind rebasing to master and re-opening this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

2017-07-18 Thread Rob Tompkins 
+1

Checked ASC/SHA1 for all artifacts. All ok.

RAT and CLIRR check OK

New issues found:
  - Reported in previous email, typographic error on SHA1 on jar file (namely 
commons-dbutils-1.7.jar). But, all is correct in nexus, so no worries to me.

-Rob

> On Jul 16, 2017, at 6:41 PM, Carl Hall  wrote:
> 
> Hi,
> 
> It's been almost 3 years to the day since we've had a DbUtils release.
> We've fixed several important bugs and added some new features, so I would
> like to release DbUtils 1.7.
> 
> Furthermore, we have fixed these issues for RC2, which were discovered in
> RC1:
> - resource leaks as found by FindBugs
> - updated links & text in generated texts and site
> 
> DbUtils 1.7 RC2 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/ (svn
> revision 20455)
> 
> The tag is here:
>   
> *https://git-wip-us.apache.org/repos/asf?p=commons-dbutils.git;a=tag;h=c7b9d1229aeacd1884c9ca126c5d65af0221404a
> *
> 
> Maven artifacts are here:
>   https://repository.apache.org/content/repositories/orgapachecommons-1254
> 
> These are the Maven Artifacts and their hashes:
> 
> commons-dbutils-1.7-javadoc.jar
> (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> commons-dbutils-1.7-javadoc.jar.asc
> (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> commons-dbutils-1.7-javadoc.jar.md5
> (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> commons-dbutils-1.7-javadoc.jar.sha1
> (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> commons-dbutils-1.7-sources.jar
> (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> commons-dbutils-1.7-sources.jar.asc
> (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> commons-dbutils-1.7-sources.jar.md5
> (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> commons-dbutils-1.7-sources.jar.sha1
> (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> commons-dbutils-1.7-test-sources.jar
> (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> commons-dbutils-1.7-test-sources.jar.asc
> (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> commons-dbutils-1.7-test-sources.jar.md5
> (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> commons-dbutils-1.7-test-sources.jar.sha1
> (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> commons-dbutils-1.7-tests.jar
> (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> commons-dbutils-1.7-tests.jar.asc
> (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> commons-dbutils-1.7-tests.jar.md5
> (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> commons-dbutils-1.7-tests.jar.sha1
> (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> commons-dbutils-1.7.jar
> (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> commons-dbutils-1.7.jar.asc
> (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> commons-dbutils-1.7.jar.md5
> (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> commons-dbutils-1.7.jar.sha1
> (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> commons-dbutils-1.7.pom
> (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> commons-dbutils-1.7.pom.asc
> (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> commons-dbutils-1.7.pom.md5
> (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> commons-dbutils-1.7.pom.sha1
> (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
> 
> Details of changes since 1.6 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/RELEASE-NOTES.txt
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/changes-report.html
> 
> Site:
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> 
> Clirr Report (compared to 1.6):
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/clirr-report.html
> 
>   - All changes are additions and do not represent any fundamental or
> breaking changes in how to use the library, so not revving the version.
> 
> RAT Report:
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/rat-report.html
> 
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 23:00 UTC 19-July-2017
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thanks!
> -Carl


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

2017-07-18 Thread Rob Tompkins 
Note:
The SHA1 listed in the email below for "commons-dbutils-1.7.jar” does not match 
the SHA1 "a2d6e515aa87e5d38f6b3003e70b13c1b1f19ca0” of the artifact in the 
Apache Nexus instance. However, the commons-dbutils-1.7.jar.sha1 does contain 
the correct SHA1, so it seems to be a typographic error on the part of the 
drafting of the email. 

This feels to me to be a non-blocker. I will continue with validation and will 
return with a vote.

Cheers,
-Rob

> On Jul 16, 2017, at 6:41 PM, Carl Hall  wrote:
> 
> Hi,
> 
> It's been almost 3 years to the day since we've had a DbUtils release.
> We've fixed several important bugs and added some new features, so I would
> like to release DbUtils 1.7.
> 
> Furthermore, we have fixed these issues for RC2, which were discovered in
> RC1:
> - resource leaks as found by FindBugs
> - updated links & text in generated texts and site
> 
> DbUtils 1.7 RC2 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/ (svn
> revision 20455)
> 
> The tag is here:
>   
> *https://git-wip-us.apache.org/repos/asf?p=commons-dbutils.git;a=tag;h=c7b9d1229aeacd1884c9ca126c5d65af0221404a
> *
> 
> Maven artifacts are here:
>   https://repository.apache.org/content/repositories/orgapachecommons-1254
> 
> These are the Maven Artifacts and their hashes:
> 
> commons-dbutils-1.7-javadoc.jar
> (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> commons-dbutils-1.7-javadoc.jar.asc
> (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> commons-dbutils-1.7-javadoc.jar.md5
> (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> commons-dbutils-1.7-javadoc.jar.sha1
> (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> commons-dbutils-1.7-sources.jar
> (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> commons-dbutils-1.7-sources.jar.asc
> (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> commons-dbutils-1.7-sources.jar.md5
> (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> commons-dbutils-1.7-sources.jar.sha1
> (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> commons-dbutils-1.7-test-sources.jar
> (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> commons-dbutils-1.7-test-sources.jar.asc
> (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> commons-dbutils-1.7-test-sources.jar.md5
> (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> commons-dbutils-1.7-test-sources.jar.sha1
> (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> commons-dbutils-1.7-tests.jar
> (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> commons-dbutils-1.7-tests.jar.asc
> (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> commons-dbutils-1.7-tests.jar.md5
> (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> commons-dbutils-1.7-tests.jar.sha1
> (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> commons-dbutils-1.7.jar
> (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> commons-dbutils-1.7.jar.asc
> (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> commons-dbutils-1.7.jar.md5
> (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> commons-dbutils-1.7.jar.sha1
> (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> commons-dbutils-1.7.pom
> (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> commons-dbutils-1.7.pom.asc
> (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> commons-dbutils-1.7.pom.md5
> (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> commons-dbutils-1.7.pom.sha1
> (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
> 
> Details of changes since 1.6 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTILS_1_7_RC2/RELEASE-NOTES.txt
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/changes-report.html
> 
> Site:
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> 
> Clirr Report (compared to 1.6):
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/clirr-report.html
> 
>   - All changes are additions and do not represent any fundamental or
> breaking changes in how to use the library, so not revving the version.
> 
> RAT Report:
>   https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/rat-report.html
> 
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 23:00 UTC 19-July-2017
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thanks!
> -Carl


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Jonathan Bluett-Duncan 
Javen,

Just for clarity, by persistent collections, are you talking about
_functional_ persistent collections (a la Scala, Clojure and Haskell),
_disk_-persisted collections, or some other definition of "persistent"?

Jonathan

On 18 Jul 2017 08:41, "Javen O'Neal"  wrote:

+1 for Lang.

There aren't any persistent data structures in Collections, nor would I
think to look in Collections to find one.

Properties is a persistent hashtable. SortedProperties is a persistent
TreeMap.

Unless you're thinking about a new family of SortedProperties. Were you
thinking about letting the user provide the Map implementation and the
SortedProperties would handle the persistence?
For example, if I wanted to persist a MultiValuedMap or a BidiMap, could I
do that?
new PersistentMap>();
new PersistentMap>();
Is there a real scenario where this would be needed?

On Jul 18, 2017 00:19, "Amey Jadiye"  wrote:

> My opinion is this should go to *lang* because the fact is it's extended
> utility and not exactly as data structures though it looks like one. It's
> main purpose is to hold properties and not the data.  Commons collection
> aims to provide utlilities and extension to data structures and not to
> properties  related utilities. Properties is very basic thing no matter
> it's sorted or not sorted and should go to lang.
>
> Regards,
> Amey
>
> On Tue, Jul 18, 2017, 11:58 AM Gary Gregory 
> wrote:
>
> > Hi,
> >
> > I'd to have a new class called SortedProperties that extends
> > java.util.Properties.
> >
> > Should that go in [lang] or [collections]?
> >
> > I first thought [lang], but it _is_ a collection after all.
> >
> > Gary
> >
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Jörg Schaible 
Hi Gary,

Gary Gregory wrote:

> Hi,
> 
> I'd to have a new class called SortedProperties that extends
> java.util.Properties.
> 
> Should that go in [lang] or [collections]?
> 
> I first thought [lang], but it _is_ a collection after all.
> 
> Gary

for me it's [collections]. [collections] is like [lang] also an extension to 
the Java runtime, specialized for the collection/map/array stuff of 
java.util. Especially since we tried to strip [lang] down and have already 
moved stuff now into more specialized components.

Cheers,
Jörg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

2017-07-18 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/56
  
@jbduncan Check-style for commons-text does is currently not applied to 
tests. I think we should look into  enabling it.

@TheRealHaui Please fix the things @jbduncan suggested. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][collections] SortedProperties

2017-07-18 Thread Javen O'Neal 
+1 for Lang.

There aren't any persistent data structures in Collections, nor would I
think to look in Collections to find one.

Properties is a persistent hashtable. SortedProperties is a persistent
TreeMap.

Unless you're thinking about a new family of SortedProperties. Were you
thinking about letting the user provide the Map implementation and the
SortedProperties would handle the persistence?
For example, if I wanted to persist a MultiValuedMap or a BidiMap, could I
do that?
new PersistentMap>();
new PersistentMap>();
Is there a real scenario where this would be needed?

On Jul 18, 2017 00:19, "Amey Jadiye"  wrote:

> My opinion is this should go to *lang* because the fact is it's extended
> utility and not exactly as data structures though it looks like one. It's
> main purpose is to hold properties and not the data.  Commons collection
> aims to provide utlilities and extension to data structures and not to
> properties  related utilities. Properties is very basic thing no matter
> it's sorted or not sorted and should go to lang.
>
> Regards,
> Amey
>
> On Tue, Jul 18, 2017, 11:58 AM Gary Gregory 
> wrote:
>
> > Hi,
> >
> > I'd to have a new class called SortedProperties that extends
> > java.util.Properties.
> >
> > Should that go in [lang] or [collections]?
> >
> > I first thought [lang], but it _is_ a collection after all.
> >
> > Gary
> >
>

Re: [lang][collections] SortedProperties

2017-07-18 Thread Amey Jadiye 
My opinion is this should go to *lang* because the fact is it's extended
utility and not exactly as data structures though it looks like one. It's
main purpose is to hold properties and not the data.  Commons collection
aims to provide utlilities and extension to data structures and not to
properties  related utilities. Properties is very basic thing no matter
it's sorted or not sorted and should go to lang.

Regards,
Amey

On Tue, Jul 18, 2017, 11:58 AM Gary Gregory  wrote:

> Hi,
>
> I'd to have a new class called SortedProperties that extends
> java.util.Properties.
>
> Should that go in [lang] or [collections]?
>
> I first thought [lang], but it _is_ a collection after all.
>
> Gary
>

[lang][collections] SortedProperties

2017-07-18 Thread Gary Gregory 
Hi,

I'd to have a new class called SortedProperties that extends
java.util.Properties.

Should that go in [lang] or [collections]?

I first thought [lang], but it _is_ a collection after all.

Gary