Re: [collections][proposal] Java 7

[Amey Jadiye]

+1

Regards,
Amey

On Wed, Jul 26, 2017, 3:48 AM Gary Gregory  wrote:

> Hi All:
>
> I propose we make Java 7 the minimum for Commons Collection 4.2.
>
> Gary
>

Re: [lang][collections] SortedProperties

[Gary Gregory]

I committed a simple SortedProperties class to [collections]. It's goal as
Javadoc'd is only to sort keys.

Tracking with: [COLLECTIONS-654] Add class SortedProperties to sort keys.

Gary

On Tue, Jul 18, 2017 at 3:50 PM, Jonathan Bluett-Duncan <
jbluettdun...@gmail.com> wrote:

> >
> > Yes, of course, that's one way to go and also create a bunch of methods
> to
> > delegate to the wrapped Properties... BUT I cannot pass this object to a
> > method typed with "Properties".
> >
>
> Oh, that's a fair point. You've convinced me. :)
>
> On 18 July 2017 at 23:44, Gary Gregory  wrote:
>
> > On Tue, Jul 18, 2017 at 11:27 AM, Jonathan Bluett-Duncan <
> > jbluettdun...@gmail.com> wrote:
> >
> > > I would strongly discourage subclassing `Properties` and instead I'd
> > > encourage composing it into the proposed `SortedProperties` class, as
> > > subclassing classes which weren't designed for inheritance is risky
> > > according to Effective Java 2nd Edition, Items 16 and 17.
> > >
> > > So for example:
> > > ```
> > > public final class SortedProperties {
> > >   private final Properties properties;
> > >   ...
> > >   public static SortedProperties from(Properties properties,
> > > Comparator<...> keyComparator) {
> > > ...
> > > return new SortedProperties(...);
> > >   }
> > >   private SortedProperties(...) { ... }
> > >   ...
> > > }
> > > ```
> > >
> >
> > Yes, of course, that's one way to go and also create a bunch of methods
> to
> > delegate to the wrapped Properties... BUT I cannot pass this object to a
> > method typed with "Properties".
> >
> > Gary
> >
> >
> > > On 18 July 2017 at 19:25, Rob Tompkins  wrote:
> > >
> > > >
> > > >
> > > > > On Jul 18, 2017, at 4:43 AM, Jörg Schaible
> >  > > > com> wrote:
> > > > >
> > > > > Hi Gary,
> > > > >
> > > > > Gary Gregory wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> I'd to have a new class called SortedProperties that extends
> > > > >> java.util.Properties.
> > > > >>
> > > > >> Should that go in [lang] or [collections]?
> > > > >>
> > > > >> I first thought [lang], but it _is_ a collection after all.
> > > > >>
> > > > >> Gary
> > > > >
> > > > > for me it's [collections]. [collections] is like [lang] also an
> > > > extension to
> > > > > the Java runtime, specialized for the collection/map/array stuff of
> > > > > java.util. Especially since we tried to strip [lang] down and have
> > > > already
> > > > > moved stuff now into more specialized components.
> > > >
> > > > I'm stuck in the in-between here with the following thought:
> HashTable
> > > > certainly feels like a collection of objects, but it clearly extends
> > > > Dictionary and isn't in the collections family. But we are in
> java.util
> > > > here and not in java.lang, so that feels more like it could be in
> > > > collections. Plus properties are essentially a map, despite they're
> > being
> > > > implemented on top of hashtable.
> > > >
> > > > -Rob
> > > >
> > > > >
> > > > > Cheers,
> > > > > Jörg
> > > > >
> > > > >
> > > > > 
> > -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > > > For additional commands, e-mail: dev-h...@commons.apache.org
> > > > >
> > > >
> > > > 
> -
> > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > > For additional commands, e-mail: dev-h...@commons.apache.org
> > > >
> > > >
> > >
> >
>

[collections][proposal] Java 7

[Gary Gregory]

Hi All:

I propose we make Java 7 the minimum for Commons Collection 4.2.

Gary

[GitHub] commons-dbutils pull request #1: Add-some-Unit-Tests

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-dbutils/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-text/pull/56
  
You're welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [wiki] access

[Stefan Bodewig]

On 2017-07-25, Rob Tompkins wrote:

> Would someone with sufficient wiki karma add “RobTompkins” to the list
> of folks that can edit the commons wiki?

Done

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[Commons Wiki] Update of "ContributorsGroup" by StefanBodewig

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Commons Wiki" for 
change notification.

The "ContributorsGroup" page has been changed by StefanBodewig:
https://wiki.apache.org/commons/ContributorsGroup?action=diff=15=16

   * NiallPemberton
   * OliverHeger
   * PhilSteitz
+  * RobTompkins
   * SebastienBrisard
   * SimoneTripodi
   * ThomasNeidhart
   * ThomasVandahl
   * Woonsan Ko
  
- 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

git migration guide (was Re: [ANNOUNCE] Apache Commons Collections moved to git)

[Stefan Bodewig]

On 2017-07-25, Rob Tompkins wrote:

>> When I wanted to begin a new page I found this one

>> https://wiki.apache.org/commons/MovingToGit

> If I recall correctly Benedikt was the last to update this page when
> he migrated [cli] over (even as late as last month on 6/28). So I
> think that it’s fairly up to date, aside from the bit that you did
> with “trunks-proper” in svn.

That's been present already as well.

> I unfortunately don’t have permissions to edit out pages on the wiki
> (I think that I need some one with the karma to add me).

I should be able to do so. What is your account name?

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

[ameyjadiye]

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/57
  
@chtompki , I think whichever items are piled up for 2.x are not too 
critical, we should wait for 2.x release.
If we are releasing some major improvement or fix we can release all queued 
items in that. ATM I don't see anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

[chtompki]

Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/57
  
This all opens the question about going `2.x`. I think we have a couple of 
things that would warrant a 2.x move. Do we want to attempt that in the fall, 
or is it still too premature?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[wiki] access

[Rob Tompkins]

Hello All,

Would someone with sufficient wiki karma add “RobTompkins” to the list of folks 
that can edit the commons wiki? Specifically, this list: 
https://wiki.apache.org/commons/ContributorsGroup 
. I personally wouldn’t be 
opposed to having Admin privileges, but I’m in relatively indifferent about 
that if folks believe admin privileges to be sensitive.

Cheers,
-Rob

Re: [ANNOUNCE] Apache Commons Collections moved to git

[Rob Tompkins]

> On Jul 25, 2017, at 5:04 AM, Stefan Bodewig  wrote:
> 
> On 2017-07-21, Stefan Bodewig wrote:
> 
>> On 2017-07-19, Rob Tompkins wrote:
> 
 On Jul 19, 2017, at 8:13 AM, Stefan Bodewig  wrote:
> 
 On 2017-07-19, Rob Tompkins wrote:
> 
> The Apache Commons Collections component has been moved to git.
> 
 Many thanks for doing that, Rob!
> 
 Are you following some kind of playbook with the git migration? If so,
 we should add one point:
> 
 * edit the svn:externals property of
 https://svn.apache.org/repos/asf/commons/trunks-proper and remove the
 entry for the component just migrated.
> 
>>> Good point, and no playbook here. I suppose we should either:
>>> 1. create such a playbook, or 2. do the remainder of the repos so that
>>> such a playbook is no longer needed. :-)
> 
>> True.
> 
>> I'm all for option 1 and may find some time over the weekend to start a
>> page inside the wiki, based on what I recall doing back when I migrated
>> Compress.
> 
> Not really weekend anymore. :-)

Ha….fair point :-)

If I recall correctly Benedikt was the last to update this page when he 
migrated [cli] over (even as late as last month on 6/28). So I think that it’s 
fairly up to date, aside from the bit that you did with “trunks-proper” in svn.

I unfortunately don’t have permissions to edit out pages on the wiki (I think 
that I need some one with the karma to add me). I would guess that it would be 
a subset of these folks https://wiki.apache.org/commons/ContributorsGroup 
. I suppose I’ll request 
access now.

Cheers,
-Rob


> 
> When I wanted to begin a new page I found this one
> 
> https://wiki.apache.org/commons/MovingToGit 
> 
> 
> Not sure whether everything on it is still accurate, but at least it
> contains all the data points that I remembered myself.
> 
> Cheers
> 
>Stefan
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
> 
> For additional commands, e-mail: dev-h...@commons.apache.org 
> 

Re: [ANNOUNCE] Apache Commons Collections moved to git

[Stefan Bodewig]

On 2017-07-21, Stefan Bodewig wrote:

> On 2017-07-19, Rob Tompkins wrote:

>>> On Jul 19, 2017, at 8:13 AM, Stefan Bodewig  wrote:

>>> On 2017-07-19, Rob Tompkins wrote:

 The Apache Commons Collections component has been moved to git.

>>> Many thanks for doing that, Rob!

>>> Are you following some kind of playbook with the git migration? If so,
>>> we should add one point:

>>> * edit the svn:externals property of
>>>  https://svn.apache.org/repos/asf/commons/trunks-proper and remove the
>>>  entry for the component just migrated.

>> Good point, and no playbook here. I suppose we should either:
>> 1. create such a playbook, or 2. do the remainder of the repos so that
>> such a playbook is no longer needed. :-)

> True.

> I'm all for option 1 and may find some time over the weekend to start a
> page inside the wiki, based on what I recall doing back when I migrated
> Compress.

Not really weekend anymore. :-)

When I wanted to begin a new page I found this one

https://wiki.apache.org/commons/MovingToGit

Not sure whether everything on it is still accurate, but at least it
contains all the data points that I remembered myself.

Cheers

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org