Re: [LOGGING] Release with Java 9 Module support
On Sep 30, 2017 11:24, "Ralph Goers" wrote: Looking at the build script it appears that both the api and adapters modules contain a subset of what is in commons-logging.jar. I have no idea why this is but all three of them cannot be modularized. I would suggest only modularizing commons-logging.jar and ignoring the other two. Makes sense to me. Gary Ralph > On Sep 30, 2017, at 1:28 AM, Benedikt Ritter wrote: > > >> Am 26.09.2017 um 23:34 schrieb Stephen Colebourne : >> >> The contents of pom.xml look OK. I can't seem to browse to see if you >> changed anything else in that commit. >> >> I would suggest being extra cautious when releasing, as a newer >> version of maven may have changed some of the config, and you don't >> want to release the two extra jars to maven central. (In fact, why not >> just delete their creation in pom.xml ?) > > They are part of our standard distribution (I don’t know why) [1]. In fact I saw commons-logging-api.jar fly by last time I build my Spring Boot project. So it seems that those additional artifacts are still in use. > > I don’t know how well this plays with Automatic-Module-Name. If I understand correctly only one jar can have org.apache.common.logging. > > Benedikt > > [1] http://commons.apache.org/proper/commons-logging/guide. html#Jars_Included_in_the_Standard_Distribution > >> Stephen >> >> On 26 September 2017 at 22:05, Benedikt Ritter wrote: >>> Am 26.09.2017 um 22:54 schrieb Stephen Colebourne : On 26 September 2017 at 18:48, Jörg Schaible wrote: > AFAICS we have only commons-logging. The other artifacts have not been part > of any release in the last decade. Simple then! >>> >>> Please review revision 1809785. The build still creates all those jars, the Automatic-Module-Name header is added to commons-logging.jar MANIFEST.MF with value org.apache.commons.logging. >>> >>> Regards, >>> Benedikt >>> Stephen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.
great, thank you! Gary On Sep 30, 2017 10:04, "Benedikt Ritter" wrote: > > > Am 29.09.2017 um 15:47 schrieb Gary Gregory : > > > > Would a few of you please find the time to review this RC? > > Sorry for the delay. I will take a look tomorrow. Preparing IO 2.6 RC1 > took longer than I thought… > > Benedikt > > > > > Thank you in advance for your input, > > Gary > > > > On Sat, Sep 23, 2017 at 10:43 AM, Gary Gregory > wrote: > > > >> We have fixed quite a few bugs and added some significant enhancements > >> since Apache Commons VFS 2.1 was released, so I would like to release > >> Apache Commons VFS 2.2. > >> > >> Apache Commons VFS 2.2 RC1 is available for review here: > >>https://dist.apache.org/repos/dist/dev/commons/vfs/ (svn revision > >> 21925) > >>Get it: svn co https://dist.apache.org/repos/dist/dev/commons/vfs/ > >> > >> The tag is here: > >>https://svn.apache.org/repos/asf/commons/proper/vfs/tags/ > >> commons-vfs2-project-2.2-rc1/ (svn revision 1809435) > >>N.B. the SVN revision is required because SVN tags are not immutable. > >>Get it: svn co https://svn.apache.org/repos/ > >> asf/commons/proper/vfs/tags/commons-vfs2-project-2.2-rc1/ > >> > >> Maven artifacts are here: > >>https://repository.apache.org/service/local/repositories/ > >> orgapachecommons-1268/content/org/apache/commons/commons- > >> vfs2-distribution/2.2/ > >> > >> These are the artifacts and their SHA1 hashes: > >> > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-src.tar.gz > >> (SHA1: 212a069b5b1534686b68fe35a6984920d9413fde) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-bin.zip.asc > >> (SHA1: aac456496d4af37a1d1912b8348b4701cf337c85) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2.pom > >> (SHA1: d8053a146c0d7e4b9cf649e8d6a0aff680dc3946) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-src.zip.asc > >> (SHA1: dbdddf332fc7929672c3cf5211d97aaafb5f4aa2) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-bin.zip > >> (SHA1: d3021e90433d666715ffbef729036af1514e1fad) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-bin.tar.gz > >> (SHA1: 6c363670be91fbacdbc2d67012952f30e56001c2) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2.pom.asc > >> (SHA1: 0ceb2511d213875ec5f99d471075c5dc700282c4) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-src.tar.gz.asc > >> (SHA1: 54bcff53b916a9285926e9df20874d69a10325a9) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-src.zip > >> (SHA1: 7b99183a0e7c57d67b857c5a8ad57a1fdb126047) > >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- > >> vfs2-distribution-2.2-bin.tar.gz.asc > >> (SHA1: 7061382cf7e04adf78b24972ccd6698cc374cc16) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.jar.asc > >> (SHA1: dcba69041d5c882598655f05db26a4742885a85b) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-test-sources.jar > >> (SHA1: a36920f558b04a941d87a1efde85bd9d4559c2c3) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-tests.jar.asc > >> (SHA1: fc31bf4504414da6d2b2290314fac060335a) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-javadoc.jar.asc > >> (SHA1: 2b9ff24d85e9ead07add09f976211d594dd1c3e5) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.pom.asc > >> (SHA1: 2dd6bee343974fccf75f2ccb406827b996da7ddc) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.pom > >> (SHA1: 8ddc26fc8729a7f3a6a1c642e4069b58d3a5ec04) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2- > test-sources.jar.asc > >> (SHA1: cbc27431defc0c34c7303d7f6ba0e367feea19cf) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-sources.jar.asc > >> (SHA1: 29d1e2c30e404ea5cf9d7e5544479e04a78314cb) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.jar > >> (SHA1: 18f974ce4c6a978eca23f769af8c6898d9694424) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-sources.jar > >> (SHA1: 8694cec165e6ef6c796a8bfae2ef565f32a5b82c) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-javadoc.jar > >> (SHA1: 972e8bd4c3d4e3b5fbd2033aa4d80013eb1ec694) > >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-tests.jar > >> (SHA1: 5e238e41b28c10f2ca21dc56f5bca471cd892ebd) > >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- > >> project-2.2-site.xml > >> (SHA1: 45db714de819ec12adc528479bf9a4a2e15ba323) > >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- > project-2.2.pom > >> (SHA1: dece2db6026f36f9dbbad8668cfb1fca867fbb64) > >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- > >> project-2.2.pom.asc > >> (SHA1: d2998c437160b336480b7faed21256eed16ffc95) > >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- > >> project
Re: [LOGGING] Release with Java 9 Module support
Looking at the build script it appears that both the api and adapters modules contain a subset of what is in commons-logging.jar. I have no idea why this is but all three of them cannot be modularized. I would suggest only modularizing commons-logging.jar and ignoring the other two. Ralph > On Sep 30, 2017, at 1:28 AM, Benedikt Ritter wrote: > > >> Am 26.09.2017 um 23:34 schrieb Stephen Colebourne : >> >> The contents of pom.xml look OK. I can't seem to browse to see if you >> changed anything else in that commit. >> >> I would suggest being extra cautious when releasing, as a newer >> version of maven may have changed some of the config, and you don't >> want to release the two extra jars to maven central. (In fact, why not >> just delete their creation in pom.xml ?) > > They are part of our standard distribution (I don’t know why) [1]. In fact I > saw commons-logging-api.jar fly by last time I build my Spring Boot project. > So it seems that those additional artifacts are still in use. > > I don’t know how well this plays with Automatic-Module-Name. If I understand > correctly only one jar can have org.apache.common.logging. > > Benedikt > > [1] > http://commons.apache.org/proper/commons-logging/guide.html#Jars_Included_in_the_Standard_Distribution > >> Stephen >> >> On 26 September 2017 at 22:05, Benedikt Ritter wrote: >>> Am 26.09.2017 um 22:54 schrieb Stephen Colebourne : On 26 September 2017 at 18:48, Jörg Schaible wrote: > AFAICS we have only commons-logging. The other artifacts have not been > part > of any release in the last decade. Simple then! >>> >>> Please review revision 1809785. The build still creates all those jars, the >>> Automatic-Module-Name header is added to commons-logging.jar MANIFEST.MF >>> with value org.apache.commons.logging. >>> >>> Regards, >>> Benedikt >>> Stephen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.
> Am 29.09.2017 um 15:47 schrieb Gary Gregory : > > Would a few of you please find the time to review this RC? Sorry for the delay. I will take a look tomorrow. Preparing IO 2.6 RC1 took longer than I thought… Benedikt > > Thank you in advance for your input, > Gary > > On Sat, Sep 23, 2017 at 10:43 AM, Gary Gregory wrote: > >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons VFS 2.1 was released, so I would like to release >> Apache Commons VFS 2.2. >> >> Apache Commons VFS 2.2 RC1 is available for review here: >>https://dist.apache.org/repos/dist/dev/commons/vfs/ (svn revision >> 21925) >>Get it: svn co https://dist.apache.org/repos/dist/dev/commons/vfs/ >> >> The tag is here: >>https://svn.apache.org/repos/asf/commons/proper/vfs/tags/ >> commons-vfs2-project-2.2-rc1/ (svn revision 1809435) >>N.B. the SVN revision is required because SVN tags are not immutable. >>Get it: svn co https://svn.apache.org/repos/ >> asf/commons/proper/vfs/tags/commons-vfs2-project-2.2-rc1/ >> >> Maven artifacts are here: >>https://repository.apache.org/service/local/repositories/ >> orgapachecommons-1268/content/org/apache/commons/commons- >> vfs2-distribution/2.2/ >> >> These are the artifacts and their SHA1 hashes: >> >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-src.tar.gz >> (SHA1: 212a069b5b1534686b68fe35a6984920d9413fde) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-bin.zip.asc >> (SHA1: aac456496d4af37a1d1912b8348b4701cf337c85) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2.pom >> (SHA1: d8053a146c0d7e4b9cf649e8d6a0aff680dc3946) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-src.zip.asc >> (SHA1: dbdddf332fc7929672c3cf5211d97aaafb5f4aa2) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-bin.zip >> (SHA1: d3021e90433d666715ffbef729036af1514e1fad) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-bin.tar.gz >> (SHA1: 6c363670be91fbacdbc2d67012952f30e56001c2) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2.pom.asc >> (SHA1: 0ceb2511d213875ec5f99d471075c5dc700282c4) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-src.tar.gz.asc >> (SHA1: 54bcff53b916a9285926e9df20874d69a10325a9) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-src.zip >> (SHA1: 7b99183a0e7c57d67b857c5a8ad57a1fdb126047) >> /org/apache/commons/commons-vfs2-distribution/2.2/commons- >> vfs2-distribution-2.2-bin.tar.gz.asc >> (SHA1: 7061382cf7e04adf78b24972ccd6698cc374cc16) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.jar.asc >> (SHA1: dcba69041d5c882598655f05db26a4742885a85b) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-test-sources.jar >> (SHA1: a36920f558b04a941d87a1efde85bd9d4559c2c3) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-tests.jar.asc >> (SHA1: fc31bf4504414da6d2b2290314fac060335a) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-javadoc.jar.asc >> (SHA1: 2b9ff24d85e9ead07add09f976211d594dd1c3e5) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.pom.asc >> (SHA1: 2dd6bee343974fccf75f2ccb406827b996da7ddc) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.pom >> (SHA1: 8ddc26fc8729a7f3a6a1c642e4069b58d3a5ec04) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-test-sources.jar.asc >> (SHA1: cbc27431defc0c34c7303d7f6ba0e367feea19cf) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-sources.jar.asc >> (SHA1: 29d1e2c30e404ea5cf9d7e5544479e04a78314cb) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.jar >> (SHA1: 18f974ce4c6a978eca23f769af8c6898d9694424) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-sources.jar >> (SHA1: 8694cec165e6ef6c796a8bfae2ef565f32a5b82c) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-javadoc.jar >> (SHA1: 972e8bd4c3d4e3b5fbd2033aa4d80013eb1ec694) >> /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-tests.jar >> (SHA1: 5e238e41b28c10f2ca21dc56f5bca471cd892ebd) >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- >> project-2.2-site.xml >> (SHA1: 45db714de819ec12adc528479bf9a4a2e15ba323) >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2-project-2.2.pom >> (SHA1: dece2db6026f36f9dbbad8668cfb1fca867fbb64) >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- >> project-2.2.pom.asc >> (SHA1: d2998c437160b336480b7faed21256eed16ffc95) >> /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2- >> project-2.2-site.xml.asc >> (SHA1: 1c3ca11863fa8a12356c19fd35602aad51cc9052) >> /org/apache/commons/commons-vfs2-examples/2.2/commons- >> vfs2-examples-2.2-sources.jar.asc >> (SHA1: dcbedc0faceff7b5694352b28286fb706e30712f) >> /org/apache/commons/commons-vfs2-examples/2.2/commons-
[VOTE] Release Apache Commons IO 2.6 based on RC1
Hello, we have fixed quite a few bugs and added some nice new features since Apache Commons IO 2.5 was released, so I would like to release Apache Commons IO 2.6 based on RC1. Commons IO 2.6 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/io/commons-io-2.6-RC1 (svn revision 22054) The tag is here: https://git-wip-us.apache.org/repos/asf?p=commons-io.git;a=tag;h=fabd0a40735c664d56f04915ea8d7efcdcff319b Commit ID the tag points at: 79e236e0508c43519a7ff7868e8d48883628b6e4 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecommons-1270 These are the Maven artifacts and their hashes: /commons-io/commons-io/2.6/commons-io-2.6-test-sources.jar.asc (SHA1: 54c3042e2b950be96df68825e0889ba5b79189fb) /commons-io/commons-io/2.6/commons-io-2.6.pom.asc (SHA1: 988f223b4653ebfef0948480588269551cc0be20) /commons-io/commons-io/2.6/commons-io-2.6-tests.jar.asc (SHA1: f33d781c4094f9073f6f8e68177e2921eea9bef9) /commons-io/commons-io/2.6/commons-io-2.6.pom (SHA1: ecfafbe3b00367c7f5af85ce7b0d5280185b04bc) /commons-io/commons-io/2.6/commons-io-2.6.jar.asc (SHA1: 063958192131b0a9fde210b8689be6bb17e00cfa) /commons-io/commons-io/2.6/commons-io-2.6-test-sources.jar (SHA1: 4d3a2e96fc18e1b36072d95f0fe5ad619fdf0298) /commons-io/commons-io/2.6/commons-io-2.6-javadoc.jar (SHA1: c5c3a79a913d3a1b72269dafb50cadccff2a21f9) /commons-io/commons-io/2.6/commons-io-2.6-sources.jar (SHA1: 4bd49983c052672d77d0ae7b1acebcbf8d722b53) /commons-io/commons-io/2.6/commons-io-2.6-tests.jar (SHA1: c6779917952b18cf7de73d114b955528fc6efc95) /commons-io/commons-io/2.6/commons-io-2.6.jar (SHA1: 251d45c4adffe1ad8013be29e5d3d0642d7d25f1) /commons-io/commons-io/2.6/commons-io-2.6-javadoc.jar.asc (SHA1: 2e8f429f3465ee2c4d4a924f6c8baae6291f2edf) /commons-io/commons-io/2.6/commons-io-2.6-sources.jar.asc (SHA1: 26960e0113cf4621d0a4fec21dc358c231e5ae88) I have tested this with JDK 7, JDK 8 and JDK 9 using Maven 3.5.0. Details of changes since 2.5 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/io/commons-io-2.6-RC1/RELEASE-NOTES.txt http://home.apache.org/~britter/commons/commons-io-2.6-RC1/changes-report.html Site: http://home.apache.org/~britter/commons/commons-io-2.6-RC1/ (note some *relative* links are broken and the 2.6 directories are not yet created - these will be OK once the site is deployed) Clirr Report (compared to 2.5): http://home.apache.org/~britter/commons/commons-io-2.6-RC1//clirr-report.html RAT Report: http://home.apache.org/~britter/commons/commons-io-2.6-RC1/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now, i.e. sometime after 18:00 CEST (UTC+2) 03-October 2017 [ ] +1 Release these artifacts [ ] +0 OK, but… [ ] -0 OK, but really should fix… [ ] -1 I oppose this release because... Thanks! Benedikt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [IO] Releasing 2.6
On Sep 30, 2017 02:58, "Benedikt Ritter" wrote:
Okay, I'll cut RC1 this afternoon.
Benedikt
Great!
Gary
Pascal Schumacher schrieb am Sa. 30. Sep. 2017
um 10:47:
> Am 30.09.2017 um 10:26 schrieb Benedikt Ritter:
> > Am 28.09.2017 um 09:39 schrieb Pascal Schumacher
> > :
> >> Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
> >>> The new error is:
> >>>FileSystemUtilsTestCase.testGetFreeSpace_String:89
> >>> expected:<1.02861164E8> but was:<1.0286066E8>
> >>>
> >>> I have:
> >>> 5 Dir(s) 104,991,649,792 bytes free
> >>>
> >>> Test calls:
> >>>
> >>> final long bytes = FileSystemUtils.freeSpace("");
> >>> final long kb = FileSystemUtils.freeSpaceKb("");
> >>> assertEquals((double) bytes / 1024, kb, 256d);
> >>>
> >>> Presumably something else on my machine downloaded 504 kB between the
> >>> two freeSpace calls – which is not much these days – perhaps one email
> >>> :-)
> >>>
> >>> I changed the test to use instead a 1% delta, which should generally
> >>> be a considerable amount of disk space (1 GB in my case), which is
> >>> still small enough to detect the ~2.4% difference between a kilobyte
> >>> vs kibibyte (the legacy freeSpaceKb is misnamed, it actually returns
> >>> kibibyte instead of pre-1998 “kilobyte”)
> >> Thanks!
> >>> I think then we can deprecate the whole FileSystemUtils class as well.
> >> +1
> > I read that there is still one test failing on Windows.
>
> No, Stain made the test more stable (less likely to fail).
>
> I think we are ready for a release.
>
> Cheer,
> Pascal
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
[GitHub] commons-text issue #66: Adding validation for pair
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/66 [](https://coveralls.io/builds/13508778) Coverage increased (+0.0005%) to 98.236% when pulling **0fd044f4b88bfb5055c53dc84463831a0c42972d on codeinventory:master** into **2b3f09be6ddea78bf2550699be0229280e25ddc0 on apache:master**. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #66: Adding validation for pair
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/66 Adding validation for pair adding validation of pairs where each pair must contain only 2 char min and max. You can merge this pull request into a Git repository by running: $ git pull https://github.com/codeinventory/commons-text master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 99409ac1450dfeb1210d28ae80fb97eab6251406 Author: Amey Jadiye Date: 2017-09-30T09:27:48Z adding validation for pair commit 0fd044f4b88bfb5055c53dc84463831a0c42972d Author: Amey Jadiye Date: 2017-09-30T09:30:18Z added amey's mail id --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [IO] Releasing 2.6
Okay, I'll cut RC1 this afternoon.
Benedikt
Pascal Schumacher schrieb am Sa. 30. Sep. 2017
um 10:47:
> Am 30.09.2017 um 10:26 schrieb Benedikt Ritter:
> > Am 28.09.2017 um 09:39 schrieb Pascal Schumacher
> > :
> >> Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
> >>> The new error is:
> >>>FileSystemUtilsTestCase.testGetFreeSpace_String:89
> >>> expected:<1.02861164E8> but was:<1.0286066E8>
> >>>
> >>> I have:
> >>> 5 Dir(s) 104,991,649,792 bytes free
> >>>
> >>> Test calls:
> >>>
> >>> final long bytes = FileSystemUtils.freeSpace("");
> >>> final long kb = FileSystemUtils.freeSpaceKb("");
> >>> assertEquals((double) bytes / 1024, kb, 256d);
> >>>
> >>> Presumably something else on my machine downloaded 504 kB between the
> >>> two freeSpace calls – which is not much these days – perhaps one email
> >>> :-)
> >>>
> >>> I changed the test to use instead a 1% delta, which should generally
> >>> be a considerable amount of disk space (1 GB in my case), which is
> >>> still small enough to detect the ~2.4% difference between a kilobyte
> >>> vs kibibyte (the legacy freeSpaceKb is misnamed, it actually returns
> >>> kibibyte instead of pre-1998 “kilobyte”)
> >> Thanks!
> >>> I think then we can deprecate the whole FileSystemUtils class as well.
> >> +1
> > I read that there is still one test failing on Windows.
>
> No, Stain made the test more stable (less likely to fail).
>
> I think we are ready for a release.
>
> Cheer,
> Pascal
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
Re: [IO] Releasing 2.6
Am 30.09.2017 um 10:26 schrieb Benedikt Ritter:
Am 28.09.2017 um 09:39 schrieb Pascal Schumacher
:
Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
The new error is:
FileSystemUtilsTestCase.testGetFreeSpace_String:89
expected:<1.02861164E8> but was:<1.0286066E8>
I have:
5 Dir(s) 104,991,649,792 bytes free
Test calls:
final long bytes = FileSystemUtils.freeSpace("");
final long kb = FileSystemUtils.freeSpaceKb("");
assertEquals((double) bytes / 1024, kb, 256d);
Presumably something else on my machine downloaded 504 kB between the
two freeSpace calls – which is not much these days – perhaps one email
:-)
I changed the test to use instead a 1% delta, which should generally
be a considerable amount of disk space (1 GB in my case), which is
still small enough to detect the ~2.4% difference between a kilobyte
vs kibibyte (the legacy freeSpaceKb is misnamed, it actually returns
kibibyte instead of pre-1998 “kilobyte”)
Thanks!
I think then we can deprecate the whole FileSystemUtils class as well.
+1
I read that there is still one test failing on Windows.
No, Stain made the test more stable (less likely to fail).
I think we are ready for a release.
Cheer,
Pascal
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LOGGING] Release with Java 9 Module support
> Am 26.09.2017 um 23:34 schrieb Stephen Colebourne : > > The contents of pom.xml look OK. I can't seem to browse to see if you > changed anything else in that commit. > > I would suggest being extra cautious when releasing, as a newer > version of maven may have changed some of the config, and you don't > want to release the two extra jars to maven central. (In fact, why not > just delete their creation in pom.xml ?) They are part of our standard distribution (I don’t know why) [1]. In fact I saw commons-logging-api.jar fly by last time I build my Spring Boot project. So it seems that those additional artifacts are still in use. I don’t know how well this plays with Automatic-Module-Name. If I understand correctly only one jar can have org.apache.common.logging. Benedikt [1] http://commons.apache.org/proper/commons-logging/guide.html#Jars_Included_in_the_Standard_Distribution > Stephen > > On 26 September 2017 at 22:05, Benedikt Ritter wrote: >> >>> Am 26.09.2017 um 22:54 schrieb Stephen Colebourne : >>> >>> On 26 September 2017 at 18:48, Jörg Schaible wrote: AFAICS we have only commons-logging. The other artifacts have not been part of any release in the last decade. >>> >>> Simple then! >> >> Please review revision 1809785. The build still creates all those jars, the >> Automatic-Module-Name header is added to commons-logging.jar MANIFEST.MF >> with value org.apache.commons.logging. >> >> Regards, >> Benedikt >> >>> Stephen >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [IO] Releasing 2.6
> Am 28.09.2017 um 09:39 schrieb Pascal Schumacher :
>
> Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
>> The new error is:
>> FileSystemUtilsTestCase.testGetFreeSpace_String:89
>> expected:<1.02861164E8> but was:<1.0286066E8>
>>
>> I have:
>>5 Dir(s) 104,991,649,792 bytes free
>>
>> Test calls:
>>
>> final long bytes = FileSystemUtils.freeSpace("");
>> final long kb = FileSystemUtils.freeSpaceKb("");
>> assertEquals((double) bytes / 1024, kb, 256d);
>>
>> Presumably something else on my machine downloaded 504 kB between the
>> two freeSpace calls – which is not much these days – perhaps one email
>> :-)
>>
>> I changed the test to use instead a 1% delta, which should generally
>> be a considerable amount of disk space (1 GB in my case), which is
>> still small enough to detect the ~2.4% difference between a kilobyte
>> vs kibibyte (the legacy freeSpaceKb is misnamed, it actually returns
>> kibibyte instead of pre-1998 “kilobyte”)
> Thanks!
>> I think then we can deprecate the whole FileSystemUtils class as well.
> +1
Okay, so where are we standing? The random failures have been resolved by using
JUnit temporary folder rule. I read that there is still one test failing on
Windows.
Further more we want to deprecate FileSystemUtils class. I can do that later.
Benedikt
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
