date:20171002

Re: [vfs] VFS 2.2 and Java 9

2017-10-02 Thread Gary Gregory

OK, I will not spend time on this and create a JIRA so we have it
documented.

RC2 should be out soon.

Gary

On Oct 2, 2017 13:03, "Pascal Schumacher"  wrote:

> Am 02.10.2017 um 19:46 schrieb Gary Gregory:
>
>> Hi All:
>>
>> I just canceled 2.2 RC1 due to:
>>
>> - Some silly test failures on non-Windows platform
>> - Test failures on Java 9
>>
>> The fixes for the tests are already in trunk.
>>
>> For Java 9, the current behavior is the same as we have in 2.1: the two
>> tests fail in the same way:
>>
>> Tests run: 84, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 4.146 sec
>> <<< FAILURE! - in
>> org.apache.commons.vfs2.provider.jar.test.NestedJarTestCase
>> testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)
>> Time
>> elapsed: 0 sec  <<< ERROR!
>> java.lang.ClassNotFoundException: code.ClassToLoad
>>  at
>> org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSCla
>> ssLoader.java:152)
>>  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:
>> 563)
>>  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:
>> 496)
>>  at
>> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testLo
>> adClass(VfsClassLoaderTests.java:61)
>>  at
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
>> Method)
>>  at
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invo
>> ke(NativeMethodAccessorImpl.java:62)
>>  at
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.
>> invoke(DelegatingMethodAccessorImpl.java:43)
>>  at java.base/java.lang.reflect.Method.invoke(Method.java:564)
>>  at
>> org.apache.commons.vfs2.test.AbstractProviderTestCase.runTes
>> t(AbstractProviderTestCase.java:190)
>>  at junit.framework.TestCase.runBare(TestCase.java:141)
>>  at junit.framework.TestResult$1.protect(TestResult.java:122)
>>  at junit.framework.TestResult.runProtected(TestResult.java:142)
>>  at junit.framework.TestResult.run(TestResult.java:125)
>>  at junit.framework.TestCase.run(TestCase.java:129)
>>  at junit.framework.TestSuite.runTest(TestSuite.java:252)
>>  at junit.framework.TestSuite.run(TestSuite.java:247)
>>  at junit.extensions.TestDecorator.basicRun(TestDecorator.java:
>> 23)
>>  at
>> org.apache.commons.vfs2.test.AbstractTestSuite$1.protect(Abs
>> tractTestSuite.java:132)
>>  at junit.framework.TestResult.runProtected(TestResult.java:142)
>>  at
>> org.apache.commons.vfs2.test.AbstractTestSuite.run(AbstractT
>> estSuite.java:137)
>>  at
>> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38Cla
>> ssRunner.java:86)
>>  at
>> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUni
>> t4Provider.java:367)
>>  at
>> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithR
>> erun(JUnit4Provider.java:274)
>>  at
>> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestS
>> et(JUnit4Provider.java:238)
>>  at
>> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit
>> 4Provider.java:161)
>>  at
>> org.apache.maven.surefire.booter.ForkedBooter.invokeProvider
>> InSameClassLoader(ForkedBooter.java:290)
>>  at
>> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInPro
>> cess(ForkedBooter.java:242)
>>  at
>> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
>> Caused by: org.apache.commons.vfs2.FileSystemException: Could not
>> retrieve
>> the certificates of
>> "jar:jar:file:///C:/vcs/svn/apache/commons/trunks-proper/vfs
>> /commons-vfs2/target/test-classes/test-data/nested.jar!/test
>> .jar!/code/ClassToLoad.class".
>>  at
>> org.apache.commons.vfs2.provider.DefaultFileContent.getCerti
>> ficates(DefaultFileContent.java:331)
>>  at
>> org.apache.commons.vfs2.impl.VFSClassLoader.defineClass(VFSC
>> lassLoader.java:180)
>>  at
>> org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSCla
>> ssLoader.java:150)
>>  ... 27 more
>> Caused by: java.lang.IllegalStateException: zip file closed
>>  at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:664)
>>  at java.base/java.util.zip.ZipFile.getInputStream(ZipFile.java:
>> 334)
>>  at java.base/java.util.jar.JarFile.getBytes(JarFile.java:761)
>>  at
>> java.base/java.util.jar.JarFile.checkForSpecialAttributes(Ja
>> rFile.java:970)
>>  at java.base/java.util.jar.JarFile.isMultiRelease(JarFile.java:
>> 366)
>>  at
>> java.base/java.util.jar.JarFile$JarFileEntry.realEntry(JarFile.java:642)
>>  at
>> java.base/java.util.jar.JarFile$JarFileEntry.getCertificates
>> (JarFile.java:626)
>>  at
>> org.apache.commons.vfs2.provider.jar.JarFileObject.doGetCert
>> ificates(JarFileObject.java:120)
>>  at
>> org.apache.commons.vfs2.provider.DefaultFileContent.getCerti
>>

[GitHub] commons-codec pull request #9: CODEC-240 Percent-Encoding codec proposal

2017-10-02 Thread sermojohn

GitHub user sermojohn opened a pull request:

https://github.com/apache/commons-codec/pull/9

CODEC-240 Percent-Encoding codec proposal



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sermojohn/commons-codec CODEC-240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-codec/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit cdde0085266245dacbe66ed42dab3c4604069012
Author: Ioannis Sermetziadis 
Date:   2017-10-02T19:34:52Z

CODEC-240 Percent-Encoding codec proposal. Due to the requirement of 
supporting a dynamic set of characters to always encode (apart from the 
non-ASCII that are always encoded), I added a constructor that takes an array 
of characters to force encode. This is useful because different encoding 
requirements apply in different parts of the HTTP 1.1 protocol (e.g. for URL, 
Multipart entity fields, etc.)




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [vfs] VFS 2.2 and Java 9

2017-10-02 Thread Pascal Schumacher


Am 02.10.2017 um 19:46 schrieb Gary Gregory:

Hi All:

I just canceled 2.2 RC1 due to:

- Some silly test failures on non-Windows platform
- Test failures on Java 9

The fixes for the tests are already in trunk.

For Java 9, the current behavior is the same as we have in 2.1: the two
tests fail in the same way:

Tests run: 84, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 4.146 sec
<<< FAILURE! - in
org.apache.commons.vfs2.provider.jar.test.NestedJarTestCase
testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)  Time
elapsed: 0 sec  <<< ERROR!
java.lang.ClassNotFoundException: code.ClassToLoad
 at
org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:152)
 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:563)
 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
 at
org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testLoadClass(VfsClassLoaderTests.java:61)
 at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
 at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.base/java.lang.reflect.Method.invoke(Method.java:564)
 at
org.apache.commons.vfs2.test.AbstractProviderTestCase.runTest(AbstractProviderTestCase.java:190)
 at junit.framework.TestCase.runBare(TestCase.java:141)
 at junit.framework.TestResult$1.protect(TestResult.java:122)
 at junit.framework.TestResult.runProtected(TestResult.java:142)
 at junit.framework.TestResult.run(TestResult.java:125)
 at junit.framework.TestCase.run(TestCase.java:129)
 at junit.framework.TestSuite.runTest(TestSuite.java:252)
 at junit.framework.TestSuite.run(TestSuite.java:247)
 at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
 at
org.apache.commons.vfs2.test.AbstractTestSuite$1.protect(AbstractTestSuite.java:132)
 at junit.framework.TestResult.runProtected(TestResult.java:142)
 at
org.apache.commons.vfs2.test.AbstractTestSuite.run(AbstractTestSuite.java:137)
 at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
 at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
 at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
 at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
 at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
 at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
 at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
 at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
Caused by: org.apache.commons.vfs2.FileSystemException: Could not retrieve
the certificates of
"jar:jar:file:///C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/target/test-classes/test-data/nested.jar!/test.jar!/code/ClassToLoad.class".
 at
org.apache.commons.vfs2.provider.DefaultFileContent.getCertificates(DefaultFileContent.java:331)
 at
org.apache.commons.vfs2.impl.VFSClassLoader.defineClass(VFSClassLoader.java:180)
 at
org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:150)
 ... 27 more
Caused by: java.lang.IllegalStateException: zip file closed
 at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:664)
 at java.base/java.util.zip.ZipFile.getInputStream(ZipFile.java:334)
 at java.base/java.util.jar.JarFile.getBytes(JarFile.java:761)
 at
java.base/java.util.jar.JarFile.checkForSpecialAttributes(JarFile.java:970)
 at java.base/java.util.jar.JarFile.isMultiRelease(JarFile.java:366)
 at
java.base/java.util.jar.JarFile$JarFileEntry.realEntry(JarFile.java:642)
 at
java.base/java.util.jar.JarFile$JarFileEntry.getCertificates(JarFile.java:626)
 at
org.apache.commons.vfs2.provider.jar.JarFileObject.doGetCertificates(JarFileObject.java:120)
 at
org.apache.commons.vfs2.provider.DefaultFileContent.getCertificates(DefaultFileContent.java:325)
 ... 29 more

testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)  Time
elapsed: 0.001 sec  <<< ERROR!
java.lang.ClassNotFoundException: code.sealed.AnotherClass
 at
org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:152)
 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:563)
 at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
 at
org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testSealing(VfsClassLoaderTests.java:88)
 at

[vfs] VFS 2.2 and Java 9

2017-10-02 Thread Gary Gregory

Hi All:

I just canceled 2.2 RC1 due to:

- Some silly test failures on non-Windows platform
- Test failures on Java 9

The fixes for the tests are already in trunk.

For Java 9, the current behavior is the same as we have in 2.1: the two
tests fail in the same way:

Tests run: 84, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 4.146 sec
<<< FAILURE! - in
org.apache.commons.vfs2.provider.jar.test.NestedJarTestCase
testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)  Time
elapsed: 0 sec  <<< ERROR!
java.lang.ClassNotFoundException: code.ClassToLoad
at
org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:152)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:563)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
at
org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testLoadClass(VfsClassLoaderTests.java:61)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at
org.apache.commons.vfs2.test.AbstractProviderTestCase.runTest(AbstractProviderTestCase.java:190)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at
org.apache.commons.vfs2.test.AbstractTestSuite$1.protect(AbstractTestSuite.java:132)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at
org.apache.commons.vfs2.test.AbstractTestSuite.run(AbstractTestSuite.java:137)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
Caused by: org.apache.commons.vfs2.FileSystemException: Could not retrieve
the certificates of
"jar:jar:file:///C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/target/test-classes/test-data/nested.jar!/test.jar!/code/ClassToLoad.class".
at
org.apache.commons.vfs2.provider.DefaultFileContent.getCertificates(DefaultFileContent.java:331)
at
org.apache.commons.vfs2.impl.VFSClassLoader.defineClass(VFSClassLoader.java:180)
at
org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:150)
... 27 more
Caused by: java.lang.IllegalStateException: zip file closed
at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:664)
at java.base/java.util.zip.ZipFile.getInputStream(ZipFile.java:334)
at java.base/java.util.jar.JarFile.getBytes(JarFile.java:761)
at
java.base/java.util.jar.JarFile.checkForSpecialAttributes(JarFile.java:970)
at java.base/java.util.jar.JarFile.isMultiRelease(JarFile.java:366)
at
java.base/java.util.jar.JarFile$JarFileEntry.realEntry(JarFile.java:642)
at
java.base/java.util.jar.JarFile$JarFileEntry.getCertificates(JarFile.java:626)
at
org.apache.commons.vfs2.provider.jar.JarFileObject.doGetCertificates(JarFileObject.java:120)
at
org.apache.commons.vfs2.provider.DefaultFileContent.getCertificates(DefaultFileContent.java:325)
... 29 more

testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)  Time
elapsed: 0.001 sec  <<< ERROR!
java.lang.ClassNotFoundException: code.sealed.AnotherClass
at
org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:152)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:563)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
at
org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testSealing(VfsClassLoaderTests.java:88)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-10-02 Thread Gary Gregory

FTR, I went back to the 2.1 tag and tested 'mvn clean test' on Windows 10
and Maven 3.5.0 and got:

- Oracle Java 1.7.0_80: PASS
- Oracle Java 1.8.0_144: PASS
- Oracle Java 9 release: FAIL in the same way.

Gary

On Sun, Oct 1, 2017 at 4:11 AM, Benedikt Ritter  wrote:

> Hello Gary,
>
> - signatures are good
> - Release notes look good
> - Website looks good
>
> With Java 7 and Java 8 I get these test failures:
>
> Results :
>
> Failed tests:
>   ZipFileObjectTestCase.testReadingFilesInZipFile:98->readAndAssert:61
> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7cgn/T/
> ZipFileObjectTestCase7763728418042728238.zip!/read-xml-tests/file1.xml
> expected:<..." encoding="UTF-8"?>[
> foo1]
> > but was:<..." encoding="UTF-8"?>[
> ]Root1>foo1
> >
>   
> ZipFileObjectTestCase.testReadingOneAfterClosingAnotherFile:133->readAndAssert:61
> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7cgn/T/
> ZipFileObjectTestCase3559195487083894265.zip!/read-xml-tests/file1.xml
> expected:<..." encoding="UTF-8"?>[
> foo1]
> > but was:<..." encoding="UTF-8"?>[
> ]Root1>foo1
> >
>   ZipFileObjectTestCase.testReadingOneAfterClosingAnotherStream:155->
> resolveReadAssert:110->readAndAssert:61 zip:file:///var/folders/r3/
> mg882fyn5553f6wdhfb_6m7cgn/T/ZipFileObjectTestCase112008393
> 0847510889.zip!/read-xml-tests/file2.xml expected:<..."
> encoding="UTF-8"?>[
> foo2]
> > but was:<..." encoding="UTF-8"?>[
> ]Root2>foo2
> >
>
> Tests run: 2341, Failures: 3, Errors: 0, Skipped: 4
>
> On Java 9 I get four test errors in addition:
>
> Tests in error:
> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.
> testLoadClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)
>   Run 1: PASS
>   Run 2: PASS
>   Run 3: PASS
>   Run 4: PASS
>   Run 5: PASS
>   Run 6: 
> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testLoadClass:61
> » ClassNotFound
>   Run 7: 
> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testLoadClass:61
> » ClassNotFound
>   Run 8: PASS
>   Run 9: PASS
>   Run 10: PASS
>   Run 11: PASS
>   Run 12: PASS
>   Run 13: PASS
>   Run 14: PASS
>   Run 15: PASS
>   Run 16: PASS
>   Run 17: PASS
>   Run 18: PASS
>   Run 19: PASS
>   Run 20: PASS
>   Run 21: PASS
>   Run 22: PASS
>   Run 23: PASS
>   Run 24: PASS
>   Run 25: PASS
>
> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.
> testSealing(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)
>   Run 1: PASS
>   Run 2: PASS
>   Run 3: PASS
>   Run 4: PASS
>   Run 5: PASS
>   Run 6: 
> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testSealing:88
> » ClassNotFound
>   Run 7: 
> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testSealing:88
> » ClassNotFound
>   Run 8: PASS
>   Run 9: PASS
>   Run 10: PASS
>   Run 11: PASS
>   Run 12: PASS
>   Run 13: PASS
>   Run 14: PASS
>   Run 15: PASS
>   Run 16: PASS
>   Run 17: PASS
>   Run 18: PASS
>   Run 19: PASS
>   Run 20: PASS
>   Run 21: PASS
>   Run 22: PASS
>   Run 23: PASS
>   Run 24: PASS
>   Run 25: PASS
>
> org.apache.commons.vfs2.provider.hdfs.test.HdfsFileProviderTest.org.
> apache.commons.vfs2.provider.hdfs.test.HdfsFileProviderTest
>   Run 1: HdfsFileProviderTest.setUp:91 » ExceptionInInitializer
>   Run 2: HdfsFileProviderTest.tearDown:135 NullPointer
>
>   HdfsFileProviderTestCase$HdfsProviderTestSuite>
> AbstractTestSuite.run:137->setUp:98 » NoClassDefFound
>
> I building with:
>
> ~ > mvn -version
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> MaxPermSize=128m; support was removed in 8.0
> Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
> 2017-04-03T21:39:06+02:00)
> Maven home: /usr/local/Cellar/maven/3.5.0/libexec
> Java version: 1.8.0_144, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_
> 144.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>
> So I’m -1 on this release.
>
> Benedikt
>
> > Am 23.09.2017 um 18:43 schrieb Gary Gregory :
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Apache Commons VFS 2.1 was released, so I would like to release
> > Apache Commons VFS 2.2.
> >
> > Apache Commons VFS 2.2 RC1 is available for review here:
> >https://dist.apache.org/repos/dist/dev/commons/vfs/ (svn revision
> 21925)
> >Get it: svn co https://dist.apache.org/repos/dist/dev/commons/vfs/
> >
> > The tag is here:
> >
> > https://svn.apache.org/repos/asf/commons/proper/vfs/tags/
> commons-vfs2-project-2.2-rc1/
> > (svn revision 1809435)
> >N.B. the SVN revision is required because SVN tags are not immutable.
> >Get it: svn co
> > https://svn.apache.org/repos/asf/commons/proper/vfs/tags/
> commons-vfs2-project-2.2-rc1/
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/service/local/repositories/
> orgapachecommons-1268/content/org/apache/commons/commons-
>

[CANCEL][VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-10-02 Thread Gary Gregory

Due to the -1 VOTE from Benedikt, I am canceling this VOTE and will roll
out RC2 ASAP.

Gary

On Sun, Oct 1, 2017 at 8:08 AM, Gary Gregory  wrote:

> I also had not considered building on Java 9 since Java 9 has made such a
> mess with backward compatibility and a lot of Maven plugins fail on Java 9.
>
> Gary
>
> On Oct 1, 2017 04:12, "Benedikt Ritter"  wrote:
>
>> Hello Gary,
>>
>> - signatures are good
>> - Release notes look good
>> - Website looks good
>>
>> With Java 7 and Java 8 I get these test failures:
>>
>> Results :
>>
>> Failed tests:
>>   ZipFileObjectTestCase.testReadingFilesInZipFile:98->readAndAssert:61
>> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7cgn/T/
>> ZipFileObjectTestCase7763728418042728238 <(804)%20272-8238>
>> .zip!/read-xml-tests/file1.xml expected:<..." encoding="UTF-8"?>[
>> foo1]
>> > but was:<..." encoding="UTF-8"?>[
>> ]Root1>foo1
>> >
>>   
>> ZipFileObjectTestCase.testReadingOneAfterClosingAnotherFile:133->readAndAssert:61
>> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7cgn/T/
>> ZipFileObjectTestCase3559195487083894265 <(708)%20389-4265>
>> .zip!/read-xml-tests/file1.xml expected:<..." encoding="UTF-8"?>[
>> foo1]
>> > but was:<..." encoding="UTF-8"?>[
>> ]Root1>foo1
>> >
>>   ZipFileObjectTestCase.testReadingOneAfterClosingAnotherStrea
>> m:155->resolveReadAssert:110->readAndAssert:61
>> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7cgn/T/
>> ZipFileObjectTestCase1120083930847510889.zip!/read-xml-tests/file2.xml
>> expected:<..." encoding="UTF-8"?>[
>> foo2]
>> > but was:<..." encoding="UTF-8"?>[
>> ]Root2>foo2
>> >
>>
>> Tests run: 2341, Failures: 3, Errors: 0, Skipped: 4
>>
>> On Java 9 I get four test errors in addition:
>>
>> Tests in error:
>> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testLo
>> adClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)
>>   Run 1: PASS
>>   Run 2: PASS
>>   Run 3: PASS
>>   Run 4: PASS
>>   Run 5: PASS
>>   Run 6: 
>> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testLoadClass:61
>> » ClassNotFound
>>   Run 7: 
>> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testLoadClass:61
>> » ClassNotFound
>>   Run 8: PASS
>>   Run 9: PASS
>>   Run 10: PASS
>>   Run 11: PASS
>>   Run 12: PASS
>>   Run 13: PASS
>>   Run 14: PASS
>>   Run 15: PASS
>>   Run 16: PASS
>>   Run 17: PASS
>>   Run 18: PASS
>>   Run 19: PASS
>>   Run 20: PASS
>>   Run 21: PASS
>>   Run 22: PASS
>>   Run 23: PASS
>>   Run 24: PASS
>>   Run 25: PASS
>>
>> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testSe
>> aling(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests)
>>   Run 1: PASS
>>   Run 2: PASS
>>   Run 3: PASS
>>   Run 4: PASS
>>   Run 5: PASS
>>   Run 6: 
>> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testSealing:88
>> » ClassNotFound
>>   Run 7: 
>> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testSealing:88
>> » ClassNotFound
>>   Run 8: PASS
>>   Run 9: PASS
>>   Run 10: PASS
>>   Run 11: PASS
>>   Run 12: PASS
>>   Run 13: PASS
>>   Run 14: PASS
>>   Run 15: PASS
>>   Run 16: PASS
>>   Run 17: PASS
>>   Run 18: PASS
>>   Run 19: PASS
>>   Run 20: PASS
>>   Run 21: PASS
>>   Run 22: PASS
>>   Run 23: PASS
>>   Run 24: PASS
>>   Run 25: PASS
>>
>> org.apache.commons.vfs2.provider.hdfs.test.HdfsFileProviderT
>> est.org.apache.commons.vfs2.provider.hdfs.test.HdfsFileProviderTest
>>   Run 1: HdfsFileProviderTest.setUp:91 » ExceptionInInitializer
>>   Run 2: HdfsFileProviderTest.tearDown:135 NullPointer
>>
>>   
>> HdfsFileProviderTestCase$HdfsProviderTestSuite>AbstractTestSuite.run:137->setUp:98
>> » NoClassDefFound
>>
>> I building with:
>>
>> ~ > mvn -version
>> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
>> MaxPermSize=128m; support was removed in 8.0
>> Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
>> 2017-04-03T21:39:06+02:00)
>> Maven home: /usr/local/Cellar/maven/3.5.0/libexec
>> Java version: 1.8.0_144, vendor: Oracle Corporation
>> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/
>> Home/jre
>> Default locale: de_DE, platform encoding: UTF-8
>> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>>
>> So I’m -1 on this release.
>>
>> Benedikt
>>
>> > Am 23.09.2017 um 18:43 schrieb Gary Gregory :
>> >
>> > We have fixed quite a few bugs and added some significant enhancements
>> > since Apache Commons VFS 2.1 was released, so I would like to release
>> > Apache Commons VFS 2.2.
>> >
>> > Apache Commons VFS 2.2 RC1 is available for review here:
>> >https://dist.apache.org/repos/dist/dev/commons/vfs/ (svn revision
>> 21925)
>> >Get it: svn co https://dist.apache.org/repos/dist/dev/commons/vfs/
>> >
>> > The tag is here:
>> >
>> > https://svn.apache.org/repos/asf/commons/proper/vfs/tags/com
>> mons-vfs2-project-2.2-rc1/
>> > (svn revision 1809435)
>> >N.B. the SVN revision is required because SVN tags are

Re: [IO] Design of ByteOrderFactory (Was: svn commit: r1301835 - in /commons/proper/io/trunk: RELEASE-NOTES.txt src/changes/ src/changes/changes.xml src/changes/release-notes.vm)

2017-10-02 Thread Gary Gregory

Hi Benedikt,

First, thank you for being the RM here.

Granted, I might have documented this new class better (and made the ctor
private.)

That said, while it is a new class for 2.6, we cannot RERO and change the
class name later.

I do believe that in this case, the narrow class name of "Factory" is
better but I will not -1 the release. Maybe ByteOrderParser would be even
better.

If other operations are needed in the future, like some conversion gadgets,
then a good class name should be created for that, and not dumped in a Util
class. But, hey, that's just me, YMMV. I just like clear names that
demonstrate intent.

Cheers,
Gary


Gary




On Mon, Oct 2, 2017 at 10:42 AM, Benedikt Ritter  wrote:

> Hey Gary,
>
> > Am 02.10.2017 um 16:15 schrieb Gary Gregory :
> >
> > I am not happy about the change of class name from ByteOrderFactory to
> > ByteOrderUtils. I am also did a knee jerk -1 when I saw the commit go by
> > but I have in the middle of moving.
> >
> > - A ByteOrderFactory creates ByteOrder objects and that's it. The intent
> is
> > clear and focused.
> > - The use of ByteOrder "Utils" does not have any use ATM, there are no
> > other "util" methods.
> > - The use of ByteOrder "Utils" leads to the same problems we have seen
> with
> > [lang]'s StringUtils: An endless, unorganized, dumping ground.
> > - Granted there is less room for expansion with ByteOrder than with
> > Strings. But, having dealt with byte order code in the past, I can tell
> you
> > from experience it can grow a plenty to deal with all sorts of funky
> cases.
> > Ever heard of middle-endian? ;-)
>
> Thank you for your feedback! To be honest I was confused when I came along
> that class. My observations were:
>
> - Only static methods, but instantiable
> - It is really a parser but it was called factory (okay, „utils" isn’t
> better…)
> - strange special handling of Strings „Little“ and „Big“ with no
> explanation
>
> So I tried to change it in a way, that it makes more sense to me, but that
> doesn’t seem to make sense for everybody :-)
>
> I have no problem with RERO, if this class need more polishing.
>
> Regards,
> Benedikt
>
> >
> > Gary
> >
> > On Fri, Mar 16, 2012 at 6:28 PM,  wrote:
> >
> >> Author: sebb
> >> Date: Sat Mar 17 00:28:40 2012
> >> New Revision: 1301835
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1301835=rev
> >> Log:
> >> Move changes.xml to location expected by CP24
> >> Add previous release notes to end of .vm file so we keep history when
> >> regenerating
> >>
> >> Added:
> >>commons/proper/io/trunk/src/changes/
> >>  - copied from r1178270, commons/proper/io/trunk/src/changes/
> >>commons/proper/io/trunk/src/changes/changes.xml
> >>  - copied unchanged from r1300447, commons/proper/io/trunk/src/
> >> changes/changes.xml
> >>commons/proper/io/trunk/src/changes/release-notes.vm   (with props)
> >> Modified:
> >>commons/proper/io/trunk/RELEASE-NOTES.txt
> >>
> >> Modified: commons/proper/io/trunk/RELEASE-NOTES.txt
> >> URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/
> >> RELEASE-NOTES.txt?rev=1301835=1301834=1301835=diff
> >> 
> >> ==
> >> --- commons/proper/io/trunk/RELEASE-NOTES.txt (original)
> >> +++ commons/proper/io/trunk/RELEASE-NOTES.txt Sat Mar 17 00:28:40 2012
> >> @@ -1,8 +1,7 @@
> >> -$Id$
> >>
> >> -Commons IO Package
> >> -   Version 2.1
> >> -  Release Notes
> >> + Commons IO Package
> >> +Version 2.2
> >> +   Release Notes
> >>
> >> INTRODUCTION:
> >>
> >> @@ -17,31 +16,39 @@ file comparators and endian transformati
> >> Commons IO Package Version 2.2
> >> 
> >> ==
> >>
> >> +The Commons IO library contains utility classes, stream
> implementations,
> >> file filters, file comparators and endian classes.
> >> +
> >> +$release.description.replaceAll("  ", "
> >> +")
> >> +
> >> +Changes in this version include:
> >> +
> >> New features:
> >> -o Use terabyte (TB) , petabyte (PB) and exabyte (EB) in FileUtils.
> byteCountToDisplaySize(long
> >> size)  Issue: IO-287. Thanks to Ron Kuris, Gary Gregory.
> >> -o FileUtils.listFiles() doesn't return directories  Issue: IO-173.
> Thanks
> >> to Marcos Vinícius da Silva.
> >> -o CharSequenceInputStream to efficiently stream content of a
> >> CharSequence  Issue: IO-297. Thanks to Oleg Kalnichevski.
> >> -o The second constructor of Tailer class does not pass 'delay' to the
> >> third one  Issue: IO-304. Thanks to liangly.
> >> -o TeeOutputStream does not call branch.close() when main.close() throws
> >> an exception  Issue: IO-303. Thanks to fabian.barney.
> >> -o ArrayIndexOutOfBoundsException in BOMInputStream when reading a file
> >> without BOM multiple times  Issue: IO-302. Thanks to

[IO] Design of ByteOrderFactory (Was: svn commit: r1301835 - in /commons/proper/io/trunk: RELEASE-NOTES.txt src/changes/ src/changes/changes.xml src/changes/release-notes.vm)

2017-10-02 Thread Benedikt Ritter

Hey Gary,

> Am 02.10.2017 um 16:15 schrieb Gary Gregory :
> 
> I am not happy about the change of class name from ByteOrderFactory to
> ByteOrderUtils. I am also did a knee jerk -1 when I saw the commit go by
> but I have in the middle of moving.
> 
> - A ByteOrderFactory creates ByteOrder objects and that's it. The intent is
> clear and focused.
> - The use of ByteOrder "Utils" does not have any use ATM, there are no
> other "util" methods.
> - The use of ByteOrder "Utils" leads to the same problems we have seen with
> [lang]'s StringUtils: An endless, unorganized, dumping ground.
> - Granted there is less room for expansion with ByteOrder than with
> Strings. But, having dealt with byte order code in the past, I can tell you
> from experience it can grow a plenty to deal with all sorts of funky cases.
> Ever heard of middle-endian? ;-)

Thank you for your feedback! To be honest I was confused when I came along that 
class. My observations were:

- Only static methods, but instantiable
- It is really a parser but it was called factory (okay, „utils" isn’t better…)
- strange special handling of Strings „Little“ and „Big“ with no explanation

So I tried to change it in a way, that it makes more sense to me, but that 
doesn’t seem to make sense for everybody :-)

I have no problem with RERO, if this class need more polishing.

Regards,
Benedikt

> 
> Gary
> 
> On Fri, Mar 16, 2012 at 6:28 PM,  wrote:
> 
>> Author: sebb
>> Date: Sat Mar 17 00:28:40 2012
>> New Revision: 1301835
>> 
>> URL: http://svn.apache.org/viewvc?rev=1301835=rev
>> Log:
>> Move changes.xml to location expected by CP24
>> Add previous release notes to end of .vm file so we keep history when
>> regenerating
>> 
>> Added:
>>commons/proper/io/trunk/src/changes/
>>  - copied from r1178270, commons/proper/io/trunk/src/changes/
>>commons/proper/io/trunk/src/changes/changes.xml
>>  - copied unchanged from r1300447, commons/proper/io/trunk/src/
>> changes/changes.xml
>>commons/proper/io/trunk/src/changes/release-notes.vm   (with props)
>> Modified:
>>commons/proper/io/trunk/RELEASE-NOTES.txt
>> 
>> Modified: commons/proper/io/trunk/RELEASE-NOTES.txt
>> URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/
>> RELEASE-NOTES.txt?rev=1301835=1301834=1301835=diff
>> 
>> ==
>> --- commons/proper/io/trunk/RELEASE-NOTES.txt (original)
>> +++ commons/proper/io/trunk/RELEASE-NOTES.txt Sat Mar 17 00:28:40 2012
>> @@ -1,8 +1,7 @@
>> -$Id$
>> 
>> -Commons IO Package
>> -   Version 2.1
>> -  Release Notes
>> + Commons IO Package
>> +Version 2.2
>> +   Release Notes
>> 
>> INTRODUCTION:
>> 
>> @@ -17,31 +16,39 @@ file comparators and endian transformati
>> Commons IO Package Version 2.2
>> 
>> ==
>> 
>> +The Commons IO library contains utility classes, stream implementations,
>> file filters, file comparators and endian classes.
>> +
>> +$release.description.replaceAll("  ", "
>> +")
>> +
>> +Changes in this version include:
>> +
>> New features:
>> -o Use terabyte (TB) , petabyte (PB) and exabyte (EB) in 
>> FileUtils.byteCountToDisplaySize(long
>> size)  Issue: IO-287. Thanks to Ron Kuris, Gary Gregory.
>> -o FileUtils.listFiles() doesn't return directories  Issue: IO-173. Thanks
>> to Marcos Vinícius da Silva.
>> -o CharSequenceInputStream to efficiently stream content of a
>> CharSequence  Issue: IO-297. Thanks to Oleg Kalnichevski.
>> -o The second constructor of Tailer class does not pass 'delay' to the
>> third one  Issue: IO-304. Thanks to liangly.
>> -o TeeOutputStream does not call branch.close() when main.close() throws
>> an exception  Issue: IO-303. Thanks to fabian.barney.
>> -o ArrayIndexOutOfBoundsException in BOMInputStream when reading a file
>> without BOM multiple times  Issue: IO-302. Thanks to jsteuerwald, detinho.
>> -o Add IOUtils.closeQuietly(Selector) necessary  Issue: IO-301. Thanks to
>> kaykay.unique.
>> -o IOUtils.closeQuietly() should take a ServerSocket as a parameter
>> Issue: IO-292. Thanks to sebb.
>> -o Add read/readFully methods to IOUtils  Issue: IO-290. Thanks to sebb.
>> -o Supply a ReversedLinesFileReader  Issue: IO-288. Thanks to Georg
>> Henzler.
>> -o Add new function FileUtils.directoryContains.  Issue: IO-291. Thanks to
>> ggregory.
>> -o FileUtils.contentEquals and IOUtils.contentEquals - Add option to
>> ignore "line endings"
>> -Added contentEqualsIgnoreEOL methods to both classes  Issue:
>> IO-275. Thanks to CJ Aspromgos.
>> +o IO-287:  Use terabyte (TB) , petabyte (PB) and exabyte (EB) in
>> FileUtils.byteCountToDisplaySize(long size) Thanks to Ron Kuris, Gary
>> Gregory.
>> +o IO-173:  FileUtils.listFiles() doesn't return directories Thanks to
>> Marcos Vinícius da Silva.

Re: svn commit: r1301835 - in /commons/proper/io/trunk: RELEASE-NOTES.txt src/changes/ src/changes/changes.xml src/changes/release-notes.vm

2017-10-02 Thread Gary Gregory

I am not happy about the change of class name from ByteOrderFactory to
ByteOrderUtils. I am also did a knee jerk -1 when I saw the commit go by
but I have in the middle of moving.

- A ByteOrderFactory creates ByteOrder objects and that's it. The intent is
clear and focused.
- The use of ByteOrder "Utils" does not have any use ATM, there are no
other "util" methods.
- The use of ByteOrder "Utils" leads to the same problems we have seen with
[lang]'s StringUtils: An endless, unorganized, dumping ground.
- Granted there is less room for expansion with ByteOrder than with
Strings. But, having dealt with byte order code in the past, I can tell you
from experience it can grow a plenty to deal with all sorts of funky cases.
Ever heard of middle-endian? ;-)

Gary

On Fri, Mar 16, 2012 at 6:28 PM,  wrote:

> Author: sebb
> Date: Sat Mar 17 00:28:40 2012
> New Revision: 1301835
>
> URL: http://svn.apache.org/viewvc?rev=1301835=rev
> Log:
> Move changes.xml to location expected by CP24
> Add previous release notes to end of .vm file so we keep history when
> regenerating
>
> Added:
> commons/proper/io/trunk/src/changes/
>   - copied from r1178270, commons/proper/io/trunk/src/changes/
> commons/proper/io/trunk/src/changes/changes.xml
>   - copied unchanged from r1300447, commons/proper/io/trunk/src/
> changes/changes.xml
> commons/proper/io/trunk/src/changes/release-notes.vm   (with props)
> Modified:
> commons/proper/io/trunk/RELEASE-NOTES.txt
>
> Modified: commons/proper/io/trunk/RELEASE-NOTES.txt
> URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/
> RELEASE-NOTES.txt?rev=1301835=1301834=1301835=diff
> 
> ==
> --- commons/proper/io/trunk/RELEASE-NOTES.txt (original)
> +++ commons/proper/io/trunk/RELEASE-NOTES.txt Sat Mar 17 00:28:40 2012
> @@ -1,8 +1,7 @@
> -$Id$
>
> -Commons IO Package
> -   Version 2.1
> -  Release Notes
> + Commons IO Package
> +Version 2.2
> +   Release Notes
>
>  INTRODUCTION:
>
> @@ -17,31 +16,39 @@ file comparators and endian transformati
>  Commons IO Package Version 2.2
>  
> ==
>
> +The Commons IO library contains utility classes, stream implementations,
> file filters, file comparators and endian classes.
> +
> +$release.description.replaceAll("  ", "
> +")
> +
> +Changes in this version include:
> +
>  New features:
> -o Use terabyte (TB) , petabyte (PB) and exabyte (EB) in 
> FileUtils.byteCountToDisplaySize(long
> size)  Issue: IO-287. Thanks to Ron Kuris, Gary Gregory.
> -o FileUtils.listFiles() doesn't return directories  Issue: IO-173. Thanks
> to Marcos Vinícius da Silva.
> -o CharSequenceInputStream to efficiently stream content of a
> CharSequence  Issue: IO-297. Thanks to Oleg Kalnichevski.
> -o The second constructor of Tailer class does not pass 'delay' to the
> third one  Issue: IO-304. Thanks to liangly.
> -o TeeOutputStream does not call branch.close() when main.close() throws
> an exception  Issue: IO-303. Thanks to fabian.barney.
> -o ArrayIndexOutOfBoundsException in BOMInputStream when reading a file
> without BOM multiple times  Issue: IO-302. Thanks to jsteuerwald, detinho.
> -o Add IOUtils.closeQuietly(Selector) necessary  Issue: IO-301. Thanks to
> kaykay.unique.
> -o IOUtils.closeQuietly() should take a ServerSocket as a parameter
> Issue: IO-292. Thanks to sebb.
> -o Add read/readFully methods to IOUtils  Issue: IO-290. Thanks to sebb.
> -o Supply a ReversedLinesFileReader  Issue: IO-288. Thanks to Georg
> Henzler.
> -o Add new function FileUtils.directoryContains.  Issue: IO-291. Thanks to
> ggregory.
> -o FileUtils.contentEquals and IOUtils.contentEquals - Add option to
> ignore "line endings"
> -Added contentEqualsIgnoreEOL methods to both classes  Issue:
> IO-275. Thanks to CJ Aspromgos.
> +o IO-287:  Use terabyte (TB) , petabyte (PB) and exabyte (EB) in
> FileUtils.byteCountToDisplaySize(long size) Thanks to Ron Kuris, Gary
> Gregory.
> +o IO-173:  FileUtils.listFiles() doesn't return directories Thanks to
> Marcos Vinícius da Silva.
> +o IO-297:  CharSequenceInputStream to efficiently stream content of a
> CharSequence Thanks to Oleg Kalnichevski.
> +o IO-304:  The second constructor of Tailer class does not pass 'delay'
> to the third one Thanks to liangly.
> +o IO-303:  TeeOutputStream does not call branch.close() when main.close()
> throws an exception Thanks to fabian.barney.
> +o IO-302:  ArrayIndexOutOfBoundsException in BOMInputStream when reading
> a file without BOM multiple times Thanks to jsteuerwald, detinho.
> +o IO-301:  Add IOUtils.closeQuietly(Selector) necessary Thanks to
> kaykay.unique.
> +o IO-292:  IOUtils.closeQuietly() should take a ServerSocket as a
> parameter Thanks to sebb.
> +o IO-290:  Add read/readFully methods

Re: [lang][text] TEXT-101: RandomStringUtils

2017-10-02 Thread Amey Jadiye

No worries Pascal, it was good experience to change core logic of
RandomStringUtils, also I'm free to pickup something else now ;-)

Regards,
Amey

On Mon, Oct 2, 2017, 3:49 PM Pascal Schumacher 
wrote:

> Sorry about wasting your work porting RandomStringUtils to commons-text. :(
>
> Sorry,
> Pascal
>
> Am 29.09.2017 um 17:18 schrieb Amey Jadiye:
> > Okey, no problem folks. I'm going to close my PR. also we might need to
> > release lang-3.6.1 for undoing deprecation of RandomStringUtils  if
> > lang-3.7 is far.
> >
> > Regards,
> > Amey
> >
> > On Fri, Sep 29, 2017 at 1:41 PM, Pascal Schumacher <
> pascalschumac...@gmx.net
> >> wrote:
> >> After thinking more about it, I came the conclusion that
> RandomStringUtils
> >> fits into [lang], so I'm for option (b).
> >>
> >> Cheers,
> >> Pascal
> >>
> >>
> >> Am 28.09.2017 um 23:26 schrieb Rob Tompkins:
> >>
> >>> Options:
> >>>
> >>> (a) leave RandomStringUtils deprecated in [lang] and pull in Amey’s
> pull
> >>> request moving it into [text].
> >>> (b) undeprecate it in [lang].
> >>>
> >>> The question is where should it reside? Does it fit as a general java
> >>> Lang extension or is it more focused on text?
> >>>
> >>> I’m in the middle here. Note also that we had some users ask why it had
> >>> been deprecated with no alternative.
> >>>
> >>> Amey - keep me honest here. I don’t want to overlook anything.
> >>>
> >>> -Rob
> >>>
> >>> On Sep 28, 2017, at 5:13 PM, Gary Gregory 
> wrote:
>  Can someone summarize what our options are here please? I'd rather
> see it
>  fresh than chasing links in mailing list archives and try to un-nest
> all
>  the nesting... ;-)
> 
>  Gary
> 
> 
> 
>  On Wed, Sep 27, 2017 at 1:01 PM, Rob Tompkins <
> notificati...@github.com>
>  wrote:
> 
>  As I'm pulling this in this crosses my mind:
> > Wait I'm curious here. Weren't folks leaning towards keeping
> > RandomStringUtils in [lang]?
> >
> > The thread in question is this one: http://markmail.org/message/
> > 5tblwhldrwsbfdym
> >
> > It feels like @britter ,
> @PascalSchumacher
> > , and @garydgregory
> >  were all leaning towards the
> [lang]
> > option. If that's the case we should probably go with that.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/apache/commons-text/pull/62#issuecomment-332622968
> >> ,
> > or mute the thread
> >  > OJew2JaosTy8DEkFh8bqjU8ks5smpuVgaJpZM4PO83B>
> > .
> >
> > -
> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >>> For additional commands, e-mail: dev-h...@commons.apache.org
> >>>
> >>>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[GitHub] commons-text issue #66: Adding validation for pair

2017-10-02 Thread PascalSchumacher

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/66
  
Thanks!


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #66: Adding validation for pair

2017-10-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/66


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][text] TEXT-101: RandomStringUtils

2017-10-02 Thread Pascal Schumacher


Sorry about wasting your work porting RandomStringUtils to commons-text. :(

Sorry,
Pascal

Am 29.09.2017 um 17:18 schrieb Amey Jadiye:

Okey, no problem folks. I'm going to close my PR. also we might need to
release lang-3.6.1 for undoing deprecation of RandomStringUtils  if
lang-3.7 is far.

Regards,
Amey

On Fri, Sep 29, 2017 at 1:41 PM, Pascal Schumacher  wrote:

Can someone summarize what our options are here please? I'd rather see it
fresh than chasing links in mailing list archives and try to un-nest all
the nesting... ;-)

Gary



On Wed, Sep 27, 2017 at 1:01 PM, Rob Tompkins 
wrote:

As I'm pulling this in this crosses my mind:

Wait I'm curious here. Weren't folks leaning towards keeping
RandomStringUtils in [lang]?

The thread in question is this one: http://markmail.org/message/
5tblwhldrwsbfdym

It feels like @britter , @PascalSchumacher
, and @garydgregory
 were all leaning towards the [lang]
option. If that's the case we should probably go with that.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub

.

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org







-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #27: travis: add java 9 to build

2017-10-02 Thread PascalSchumacher

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-collections/pull/27
  
 test failure on java 9: `ListIteratorWrapperTest.testRemove:116 Â» 
ServiceConfiguration sun.util.locale`


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #27: travis: add java 9 to build

2017-10-02 Thread coveralls

Github user coveralls commented on the issue:

https://github.com/apache/commons-collections/pull/27
  

[![Coverage 
Status](https://coveralls.io/builds/13523031/badge)](https://coveralls.io/builds/13523031)

Coverage decreased (-0.02%) to 85.118% when pulling 
**61ed424d6841f4a7feae1f06d4e0b3970889227d on 
PascalSchumacher:travis_add_java_9** into 
**6f356338786c4243a21b0e506469d2e3a71148e2 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #27: travis: add java 9 to build

2017-10-02 Thread PascalSchumacher

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-collections/pull/27

travis: add java 9 to build

pom.xml: add java 9 profile to make build pass

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-collections 
travis_add_java_9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 61ed424d6841f4a7feae1f06d4e0b3970889227d
Author: Pascal Schumacher 
Date:   2017-10-02T09:46:34Z

travis: add java 9 to build

pom.xml: add java 9 profile to make build pass




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [COLLECTIONS] Test failures on Windows

2017-10-02 Thread Pascal Schumacher

Looks like the random failures are not limited to window. The travis
build (ubuntu), just failed with 44 failures, e.g.

AbstractMultiValuedMapTest$TestMultiValuedMapAsMap>AbstractMapTest.testMapToString:745->AbstractMapTest.verify:1947->AbstractMapTest.verifyMap:1958
hashCodes should be the same expected:<205172737> but was:<9372706>

see: https://travis-ci.org/apache/commons-collections/jobs/282169803

Am 28.09.2017 um 20:23 schrieb Andreas Kuhtz:

Hi,

2017-09-27 22:28 GMT+02:00 Bruno P. Kinoshita :

Forgot to mention something important. When I was debugging the hash
tests, they would pretty much always pass.

But if I ran the tests normally in maven or eclipse they would always fail.

Debugging adds a small overhead I think, that could be slowing down some
part of the code with a concurrency issue?

That's an explanation. If I start a Virtualbox instance that prepares some
load I can see the tests pass under Java 9 ... I had the Virtualbox running
yesterday when the tests passed.

Just in case it helps...

Interesting this surefire configuration Andreas. Do you have more
information about it? Is it something we may have to worry about in
components that use locale and jvm 9?

I ran into an issue with the language selection dialog of izpack and found
that this configuration solved the problem there.
It's noted in the release notes of Java 9:
http://www.oracle.com/technetwork/java/javase/9-relnote-issues-3704069.html#JDK-8008577

Cheers,
Andreas

Cheers
Bruno

Sent from Yahoo Mail on Android

On Thu, 28 Sep 2017 at 4:45, Andreas Kuhtz
wrote:
Hi,

I'm running Win7 and with "mvn clean verify". Checkout master.

I got the hash code errors, too. But sometimes the tests pass, the next
time they failed with 44 failures (the hash code verification).

As I'm not sure if my antivirus kicks in and keep some files in the target
dir, I ran "mvn clean" and after that "mvn clean verify".
But now I have the 44 failures with jdk-1.7.0_67, jdk-1.8.0_131 and 9+181

Gary:
To get around the issue with ServiceConfiguration sun.util.locale... I
added the following profile to the pom.xml. After that I only got the 44
errors (hash code) as with Java 7 and 8.

jdk9-build

maven-surefire-plugin

-Djava.locale.providers=COMPAT

I'm not sure if I can help more, but if you need more info just let me
know.

Andreas

2017-09-27 19:10 GMT+02:00 Gary Gregory :

Using git master and 'mvn clean verify', on Windows 10, with Java 7, I

get

44 failures, and I think this is all/mostly hash code problems.

With Java 8, all tests pass.

With Java 9, I get ONE failure: ListIteratorWrapperTest.testRemove:116 ╗
ServiceConfiguration sun.util.locale

If I checkout the 4.1 tag and use Java 7, I get 44 failures. ARG! What

the

heck?

Gary

On Mon, Sep 25, 2017 at 12:02 PM, Benedikt Ritter
wrote:

Hi,

who can help with the test failures on Windows? I’d like to push out

the

next release soon to get Collections Java 9 ready. I don’t have access

to a

Windows installation and I don’t feel like debugging inside a VM :o)

Regards,
Benedikt

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #67: travis: remove travis profile from pom and us...

2017-10-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/67


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...

2017-10-02 Thread PascalSchumacher

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/67
  
The reason for the coveralls failure:

```
Failed to execute goal 
[32morg.eluder.coveralls:coveralls-maven-plugin:4.3.0:report[m 
[1m(default-cli)[m on project [36mcommons-text[m: [1;31mProcessing of 
input or output data failed[m: Unable to parse timestamp "2017-10-02 
07:50:36+": For input string: "2017-10-02 07:50:36+"
```

The cause: `{0,date,-MM-dd 
HH:mm:ssZ}` which was required because 
coveralls-plugin-versions before 4.2 did not support the maven default of 
`EpochMillis`. The commons-parent coveralls configuration sets 
`${commons.coveralls.timestampFormat}` and 
`commons.coveralls.timestampFormat` defaults to `EpochMillis`.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...

2017-10-02 Thread coveralls

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/67
  

[![Coverage 
Status](https://coveralls.io/builds/13522420/badge)](https://coveralls.io/builds/13522420)

Coverage remained the same at 98.236% when pulling 
**778345ee86f0c5e780fd2c7fa74f741752da1e81 on PascalSchumacher:travis_profile** 
into **1bd8e544101969574a6f07b8470623eb36a8f93b on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [vfs] VFS 2.2 and Java 9

[GitHub] commons-codec pull request #9: CODEC-240 Percent-Encoding codec proposal

Re: [vfs] VFS 2.2 and Java 9

[vfs] VFS 2.2 and Java 9

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

[CANCEL][VOTE] Release Apache Commons VFS 2.2 from RC1.

Re: [IO] Design of ByteOrderFactory (Was: svn commit: r1301835 - in /commons/proper/io/trunk: RELEASE-NOTES.txt src/changes/ src/changes/changes.xml src/changes/release-notes.vm)

[IO] Design of ByteOrderFactory (Was: svn commit: r1301835 - in /commons/proper/io/trunk: RELEASE-NOTES.txt src/changes/ src/changes/changes.xml src/changes/release-notes.vm)

Re: svn commit: r1301835 - in /commons/proper/io/trunk: RELEASE-NOTES.txt src/changes/ src/changes/changes.xml src/changes/release-notes.vm

Re: [lang][text] TEXT-101: RandomStringUtils

[GitHub] commons-text issue #66: Adding validation for pair

[GitHub] commons-text pull request #66: Adding validation for pair

Re: [lang][text] TEXT-101: RandomStringUtils

[GitHub] commons-collections issue #27: travis: add java 9 to build

[GitHub] commons-collections issue #27: travis: add java 9 to build

[GitHub] commons-collections pull request #27: travis: add java 9 to build

Re: [COLLECTIONS] Test failures on Windows

[GitHub] commons-text pull request #67: travis: remove travis profile from pom and us...

[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...

[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...

20 matches

Site Navigation

Mail list logo

Footer information