[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/commons-pool/pull/4
  
I should be able to take a look tomorrow or the next day.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/79
  
The only problem I encountered was that I had to delete the existing JUnit 
run configurations for commons-text (I'm using Eclipse Oxygen.3 and it does not 
seem to be able to update a run configuration from JUnit 4 to JUnit 5).


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/commons-text/pull/79
  
Hi Pascal! Thank you for the PR. My only hesitation with JUnit 5 is that it 
does not work in Eclipse yet, for me at least.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/79
  

[![Coverage 
Status](https://coveralls.io/builds/16348620/badge)](https://coveralls.io/builds/16348620)

Coverage remained the same at 97.83% when pulling 
**f37a81c7bf965d593722d55ba1108c0c19b0fdb4 on PascalSchumacher:junit_5** into 
**6f06de9eb939599bb46a011a41764723953105ea on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #79: Upgrade to JUnit 5.1

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-text/pull/79

Upgrade to JUnit 5.1



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-text junit_5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit f37a81c7bf965d593722d55ba1108c0c19b0fdb4
Author: Pascal Schumacher 
Date:   2018-04-04T20:33:48Z

Upgrade to JUnit 5.1




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #78: Require Java 8

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/78


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #78: Require Java 8

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/78
  

[![Coverage 
Status](https://coveralls.io/builds/16343223/badge)](https://coveralls.io/builds/16343223)

Coverage decreased (-0.0004%) to 97.83% when pulling 
**a383506a21c82ae85fee109f7013686f2bf6ce64 on PascalSchumacher:java_8** into 
**51e22754a685519b80fd16d5c24c43f1b73863e7 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #78: Require Java 8

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-text/pull/78

Require Java 8



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-text java_8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit a383506a21c82ae85fee109f7013686f2bf6ce64
Author: Pascal Schumacher 
Date:   2018-04-04T16:29:17Z

Require Java 8




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [text] Move to Java 8?

[Rob Tompkins]

> On Apr 4, 2018, at 9:27 AM, Gary Gregory  wrote:
> 
> Go for it.
> 

+1

> Gary
> 
> On Wed, Apr 4, 2018, 04:49 Pascal Schumacher 
> wrote:
> 
>> Hello,
>> 
>> what about moving text to Java 8, now that version 1.3 has been released?
>> 
>> Cheers,
>> 
>> Pascal
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [text] Move to Java 8?

[Gary Gregory]

Go for it.

Gary

On Wed, Apr 4, 2018, 04:49 Pascal Schumacher 
wrote:

> Hello,
>
> what about moving text to Java 8, now that version 1.3 has been released?
>
> Cheers,
>
> Pascal
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[text] Move to Java 8?

[Pascal Schumacher]

Hello,

what about moving text to Java 8, now that version 1.3 has been released?

Cheers,

Pascal


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org