[RESULT][LAZY][VOTE] Release Apache Commons Release Plugin 1.3 based on RC1

2018-06-18 Thread Rob Tompkins 
This [LAZY][VOTE] passes with a +1 from Gary Gregory, a +1 from myself and no 
-1’s, I will proceed with promoting the release. Many thanks for the release 
validation.

-Rob

> On Jun 15, 2018, at 12:45 PM, Rob Tompkins  wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements since 
> Apache Commons Release Plugin 1.2 was released, so I would like to release 
> Apache Commons Release Plugin 1.3.
> 
> Apache Commons Release Plugin 1.3 RC1 is available for review here:
> 
> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.3-RC1 
> 
>  (svn revision 27489)
> 
> The Git tag commons-commons-release-plugin-1.3-RC1 commit for this RC is 
> fatal: ambiguous argument 'commons-commons-release-plugin-1.3-RC1': unknown 
> revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git  [...] -- [...]' which you can browse here:
> 
> https://git-wip-us.apache.org/repos/asf?p=commons-commons-release-plugin.git;a=tag;h=refs/tags/commons-commons-release-plugin-1.3-RC1
>  
> 
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1336/org/apache/commons/commons-release-plugin/1.3/
>  
> 
> 
> These are the Maven artifacts and their hashes in Nexus:
> 
> #Release SHA-1s
> #Fri Jun 15 12:08:38 EDT 2018
> commons-release-plugin-1.3-bin-zip=32a3da15ef466eaa43dfec8c93490df5b6dd8acf
> commons-release-plugin-1.3-bin-tar.gz=af71049855b71e37c7a20ffe3676b960b33617fe
> commons-release-plugin-1.3-tests-test-jar=0eaeb7ec6d16880e076ee066288ecd02feb503ea
> commons-release-plugin-1.3-tests-jar.asc=356322900d2f987868c11709c73d40fdbbf8db35
> commons-release-plugin-1.3-sources-jar.asc=af07ad503c2a76d1800d88be57de07e881fb934e
> commons-release-plugin-1.3-bin-zip.asc=ecb06e34f67d407d296b7fbb5eccc21a78dd
> commons-release-plugin-1.3-test-sources-jar.asc=ac0f78689f5af7ec15a5c928b84221b3a43fad59
> commons-release-plugin-1.3-bin-tar.gz.asc=399f74d29fa215cb022d99304e325dd267d923cb
> commons-release-plugin-1.3-jar.asc=9792d1407fe9a68a76da197c93ac3388298a9e9d
> commons-release-plugin-1.3-javadoc-jar.asc=bc950f7111a5723c0f8525331754664b12e29a9e
> commons-release-plugin-1.3-src-tar.gz.asc=9a644c637792570f93029bd897e109a9c5672992
> commons-release-plugin-1.3-src-zip.asc=88f129cfad36ff87c6afc043b0ab37899e04a5c5
> commons-release-plugin-1.3-test-sources-java-source=4cb3779a3960c129ab2c07d2e69b36080712aae9
> commons-release-plugin-1.3-src-zip=f53ca736bb85e9d8d48ded946ce4bf57d0fed213
> commons-release-plugin-1.3-sources-java-source=db086aacc9e4f287daacb2a72df36ff0bb8e016c
> commons-release-plugin-1.3-pom.asc=03451012bb384dde4d05b2a7b71c4a38960bcaa5
> commons-release-plugin-1.3-src-tar.gz=cedbe7e7021ebe45d81dbe0bc467302e2b8d87be
> commons-release-plugin-1.3-javadoc-javadoc=2e7298d31b48bd4241afe391cbe20dae79830095
> 
> #Release SHA-256s
> #Fri Jun 15 12:08:38 EDT 2018
> commons-release-plugin-1.3-bin-zip=ef7f1fb397204aa11c53f6260b894b8b451dd5306ea86953ef41eb71ec268f76
> commons-release-plugin-1.3-bin-tar.gz=f72bb461862b8b622a5ad873bc99121467adbde6c2d9fa0dc9fbddbdb05b86ef
> commons-release-plugin-1.3-tests-test-jar=135df2cf9a204188df970c0e7e5cd6a89d0ac6747ec1b44acdd1c7bf30c3e441
> commons-release-plugin-1.3-tests-jar.asc=ec5c7c56ba111cc90a295b8e2e54fbdd6a2c907cf774326e1e6ed9a5dc9d1b51
> commons-release-plugin-1.3-sources-jar.asc=d9eb399525c67c0f393c32aa997ada09ef7c0d5f0e8a535ec39bca5424565444
> commons-release-plugin-1.3-bin-zip.asc=e78f7180b0ed01aa330345fa1a78d12bba153cc79411fa153e510721c0b00a61
> commons-release-plugin-1.3-test-sources-jar.asc=ee9cf3b9f0588b8958ae6194d1dbb2563df1dfe834d165ba456865ec6aefffa2
> commons-release-plugin-1.3-bin-tar.gz.asc=19fe2a3baef3c192dc5a9ad38d4a6d6235f4f22e822e51754c661337f614f91f
> commons-release-plugin-1.3-jar.asc=7515106ffdfb6b08cc6a8c3557f79e31c7199c3a97f55478296a2f9c1f17f137
> commons-release-plugin-1.3-javadoc-jar.asc=1adced754fae7ee7fb61163510f8e4f1ea6efc270808085ce339a8ac2d3f8d08
> commons-release-plugin-1.3-src-tar.gz.asc=df8c02badd70be5c563491bdbc01c7854f2d55127448d88ea91755d39a83931e
> commons-release-plugin-1.3-src-zip.asc=5fc3ebe043588243e56001a36695527b0c12ca807359a37dc08e3ebfb34974df
> commons-release-plugin-1.3-test-sources-java-source=3d1b7725d411976f440a4eba79026348d7809bd081b1738104c4ab480b872c04
> commons-release-plugin-1.3-src-zip=30492410173efb950ddaf613e7c0670ef6cc3e96c53ba865b5edca5dc09cb114
> commons-release-plugin-1.3-sources-java-source=8bae96c79ccf6778b9ac91f72cb732363cda3f73aa976a2526b9302ebaee1d82
> commons-release-plugin-1.3-pom.asc=ff6fb495722d0ff9fa3d3cdd740248a0a95d34eba583e7cfbbe507930b030b1a
>

Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.3 based on RC1

2018-06-18 Thread Rob Tompkins 
Here’s my +1

> On Jun 15, 2018, at 12:45 PM, Rob Tompkins  wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements since 
> Apache Commons Release Plugin 1.2 was released, so I would like to release 
> Apache Commons Release Plugin 1.3.
> 
> Apache Commons Release Plugin 1.3 RC1 is available for review here:
> 
> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.3-RC1 
> 
>  (svn revision 27489)
> 
> The Git tag commons-commons-release-plugin-1.3-RC1 commit for this RC is 
> fatal: ambiguous argument 'commons-commons-release-plugin-1.3-RC1': unknown 
> revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git  [...] -- [...]' which you can browse here:
> 
> https://git-wip-us.apache.org/repos/asf?p=commons-commons-release-plugin.git;a=tag;h=refs/tags/commons-commons-release-plugin-1.3-RC1
>  
> 
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1336/org/apache/commons/commons-release-plugin/1.3/
>  
> 
> 
> These are the Maven artifacts and their hashes in Nexus:
> 
> #Release SHA-1s
> #Fri Jun 15 12:08:38 EDT 2018
> commons-release-plugin-1.3-bin-zip=32a3da15ef466eaa43dfec8c93490df5b6dd8acf
> commons-release-plugin-1.3-bin-tar.gz=af71049855b71e37c7a20ffe3676b960b33617fe
> commons-release-plugin-1.3-tests-test-jar=0eaeb7ec6d16880e076ee066288ecd02feb503ea
> commons-release-plugin-1.3-tests-jar.asc=356322900d2f987868c11709c73d40fdbbf8db35
> commons-release-plugin-1.3-sources-jar.asc=af07ad503c2a76d1800d88be57de07e881fb934e
> commons-release-plugin-1.3-bin-zip.asc=ecb06e34f67d407d296b7fbb5eccc21a78dd
> commons-release-plugin-1.3-test-sources-jar.asc=ac0f78689f5af7ec15a5c928b84221b3a43fad59
> commons-release-plugin-1.3-bin-tar.gz.asc=399f74d29fa215cb022d99304e325dd267d923cb
> commons-release-plugin-1.3-jar.asc=9792d1407fe9a68a76da197c93ac3388298a9e9d
> commons-release-plugin-1.3-javadoc-jar.asc=bc950f7111a5723c0f8525331754664b12e29a9e
> commons-release-plugin-1.3-src-tar.gz.asc=9a644c637792570f93029bd897e109a9c5672992
> commons-release-plugin-1.3-src-zip.asc=88f129cfad36ff87c6afc043b0ab37899e04a5c5
> commons-release-plugin-1.3-test-sources-java-source=4cb3779a3960c129ab2c07d2e69b36080712aae9
> commons-release-plugin-1.3-src-zip=f53ca736bb85e9d8d48ded946ce4bf57d0fed213
> commons-release-plugin-1.3-sources-java-source=db086aacc9e4f287daacb2a72df36ff0bb8e016c
> commons-release-plugin-1.3-pom.asc=03451012bb384dde4d05b2a7b71c4a38960bcaa5
> commons-release-plugin-1.3-src-tar.gz=cedbe7e7021ebe45d81dbe0bc467302e2b8d87be
> commons-release-plugin-1.3-javadoc-javadoc=2e7298d31b48bd4241afe391cbe20dae79830095
> 
> #Release SHA-256s
> #Fri Jun 15 12:08:38 EDT 2018
> commons-release-plugin-1.3-bin-zip=ef7f1fb397204aa11c53f6260b894b8b451dd5306ea86953ef41eb71ec268f76
> commons-release-plugin-1.3-bin-tar.gz=f72bb461862b8b622a5ad873bc99121467adbde6c2d9fa0dc9fbddbdb05b86ef
> commons-release-plugin-1.3-tests-test-jar=135df2cf9a204188df970c0e7e5cd6a89d0ac6747ec1b44acdd1c7bf30c3e441
> commons-release-plugin-1.3-tests-jar.asc=ec5c7c56ba111cc90a295b8e2e54fbdd6a2c907cf774326e1e6ed9a5dc9d1b51
> commons-release-plugin-1.3-sources-jar.asc=d9eb399525c67c0f393c32aa997ada09ef7c0d5f0e8a535ec39bca5424565444
> commons-release-plugin-1.3-bin-zip.asc=e78f7180b0ed01aa330345fa1a78d12bba153cc79411fa153e510721c0b00a61
> commons-release-plugin-1.3-test-sources-jar.asc=ee9cf3b9f0588b8958ae6194d1dbb2563df1dfe834d165ba456865ec6aefffa2
> commons-release-plugin-1.3-bin-tar.gz.asc=19fe2a3baef3c192dc5a9ad38d4a6d6235f4f22e822e51754c661337f614f91f
> commons-release-plugin-1.3-jar.asc=7515106ffdfb6b08cc6a8c3557f79e31c7199c3a97f55478296a2f9c1f17f137
> commons-release-plugin-1.3-javadoc-jar.asc=1adced754fae7ee7fb61163510f8e4f1ea6efc270808085ce339a8ac2d3f8d08
> commons-release-plugin-1.3-src-tar.gz.asc=df8c02badd70be5c563491bdbc01c7854f2d55127448d88ea91755d39a83931e
> commons-release-plugin-1.3-src-zip.asc=5fc3ebe043588243e56001a36695527b0c12ca807359a37dc08e3ebfb34974df
> commons-release-plugin-1.3-test-sources-java-source=3d1b7725d411976f440a4eba79026348d7809bd081b1738104c4ab480b872c04
> commons-release-plugin-1.3-src-zip=30492410173efb950ddaf613e7c0670ef6cc3e96c53ba865b5edca5dc09cb114
> commons-release-plugin-1.3-sources-java-source=8bae96c79ccf6778b9ac91f72cb732363cda3f73aa976a2526b9302ebaee1d82
> commons-release-plugin-1.3-pom.asc=ff6fb495722d0ff9fa3d3cdd740248a0a95d34eba583e7cfbbe507930b030b1a
> commons-release-plugin-1.3-src-tar.gz=cea44c8f5cb8aa63404856a704db6c7afc791aaec399c11759d2d099871f2289
>

[GitHub] commons-pool issue #8: Format DefaultPooledObject getIdleTimeMillis method w...

2018-06-18 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-pool/pull/8
  

[![Coverage 
Status](https://coveralls.io/builds/17560250/badge)](https://coveralls.io/builds/17560250)

Coverage decreased (-0.1%) to 85.04% when pulling 
**4cb2054b3eae569c82a0cb531ae86712a726efb1 on wangyulin:dev** into 
**dfef97be70e8b1c3edb44b972fc7f700f3fe6255 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool pull request #8: Format DefaultPooledObject getIdleTimeMillis m...

2018-06-18 Thread wangyulin 
GitHub user wangyulin opened a pull request:

https://github.com/apache/commons-pool/pull/8

Format DefaultPooledObject getIdleTimeMillis method white spaces



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wangyulin/commons-pool dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-pool/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 4cb2054b3eae569c82a0cb531ae86712a726efb1
Author: jieyebing 
Date:   2018-06-19T00:07:25Z

Format DefaultPooledObject getIdleTimeMillis method tab space




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [dbcp] Next

2018-06-18 Thread Gary Gregory 
Git master is now on JDBC 4.2 on Java 8.

Are we OK calling the next release 2.5.0?

Gary

On Sun, Jun 17, 2018 at 5:21 PM Gary Gregory  wrote:

> Note that while I am working on getting git master up to JDBC 4.2 on Java
> 8, the current version is JDBC 4.3 on Java 9. I am only looking at 4.2.
>
> Gary
>
> On Sun, Jun 17, 2018, 11:06 Rob Tompkins  wrote:
>
>>
>>
>> > On Jun 17, 2018, at 12:38 PM, Matt Sicker  wrote:
>> >
>> > Ideally, if we can just keep various branches around in releasable
>> states,
>> > then we can keep old dbcp 2.x.* maintenance releases moving forward.
>> Based
>> > on my experiences trying to release this module before, though, I think
>> > that process would need to be streamlined and backported.
>> >
>>
>> That’s what was running through my mind yesterday when I was reading the
>> discussion.
>>
>> -Rob
>>
>> >> On 17 June 2018 at 07:58, sebb  wrote:
>> >>
>> >>> On 16 June 2018 at 22:41, Gary Gregory 
>> wrote:
>> >>> Hello Mark and all,
>> >>>
>> >>> Thank you for the heads up on the Tomcat plans.
>> >>>
>> >>> Asking DBCP to stay on Java 7 for 4-5 years is insane IMO, and it
>> >> certainly
>> >>> is not going to attract anyone to maintain and grow this component
>> (IMO
>> >>> again.) If that is a set of handcuffs you want to live with, then by
>> all
>> >>> means ;-)
>> >>>
>> >>> I am sure there is nothing stopping anyone at Apache to keep patches
>> >> coming
>> >>> to the DBCP 2.4.x line. I plan on keeping the release train going for
>> >> many
>> >>> Commons component, so I am happy to release DBCP at will.
>> >>>
>> >>> You will notice that
>> >>> https://commons.apache.org/proper/commons-dbcp/download_dbcp.cgi
>> >> presents
>> >>> no less than tree different versions of DBCP for different antique
>> Java
>> >>> platforms. We are just going to make that list one deeper.
>> >>
>> >> I think we can now drop support for JDBC 3 and JDBC 4 (Java 6)
>> >> That leaves only JDBC 4.1 (Java 7.0) as a current release.
>> >>
>> >> Is that really too much to continue to support?
>> >>
>> >>> Again, patches are more than welcome. And do feel free to call for a
>> RC
>> >> or
>> >>> RM it yourself ;-)
>> >>>
>> >>> Gary
>> >>>
>> >>>
>>  On Sat, Jun 16, 2018 at 2:34 PM Mark Thomas 
>> wrote:
>> 
>> > On 16/06/18 21:14, Matt Sicker wrote:
>> >> On 16 June 2018 at 14:11, Mark Thomas  wrote:
>> >>
>> >> What is driving the desire to move to Java 8?
>> >>
>> >
>> > What's driving the desire to maintain support for a seven year old
>>  release
>> > of Java which is not supported without paying large sums of money to
>> > Oracle?
>> 
>>  As I said, Tomcat 8 which has at least another 4 to 5 years of life
>> in
>>  it, depends on DBCP 2 and has a specification mandated requirement to
>>  maintain compatibility with Java 7.
>> 
>>  There are ways the Tomcat community could work around this. Because
>> Java
>>  7 is EOL does not - on its own - strike me as a sufficiently good
>> reason
>>  to create hassle for another ASF community.
>> 
>>  If there are new features in Java 8 we want to take advantage of or
>> an
>>  update to the JDBC API that we want to support then fair enough.
>> Those
>>  are good reasons but I'd like to see them explicitly articulated.
>> 
>>  Mark
>> 
>>  -
>>  To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>  For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 
>> >>
>> >> -
>> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> >> For additional commands, e-mail: dev-h...@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > --
>> > Matt Sicker 
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>