[text] Recently added Checkstyle Violations
Hi, the build of text fails, because of checkstyle violations: [INFO] There are 8 errors reported by Checkstyle 8.12 with /home/travis/build/apache/commons-text/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java:[27,5] (javadoc) JavadocVariable: Missing a Javadoc comment. [ERROR] src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java:[28,5] (javadoc) JavadocVariable: Missing a Javadoc comment. [ERROR] src/main/java/org/apache/commons/text/lookup/ScriptStringLookup.java:[81] (sizes) LineLength: Line is longer than 120 characters (found 121). [ERROR] src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java:[21,8] (imports) UnusedImports: Unused import - java.io.InputStream. [ERROR] src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java:[25,8] (imports) UnusedImports: Unused import - java.nio.file.Files. [ERROR] src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java:[78,44] (coding) MagicNumber: '8192' is a magic number. [ERROR] target/test-classes/document.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [ERROR] src/test/resources/document.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. It would be nice, if these were fixed by whoever added them. Thanks, Pascal
Re: [ALL] SHA256/512 hashes
On Sun, 26 Aug 2018 10:43:02 +0200, Thomas Vandahl wrote: On 25.08.18 16:14, Gilles wrote: Probably for those who don't want to use the release plugin :-) I was mainly following up on the thread about updating CP to AP 21 [1] But yes, it could be used as an alternative hashing method. I thought that the release plugin was intended for all components to converge on the same release "recipe"... This is unlikely to happen as long as it does not cover multi-module builds. "Commons RNG" is multi-module and v1.1 was RMed by Rob with his release-plugin. Gilles P.S. I hope that Rob will update the [RNG] step-by-step howto, currently in "doc/release" directory, so that anyone else can duplicate his feat. ;-) Bye, Thomas. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [ALL] SHA256/512 hashes
On 25.08.18 16:14, Gilles wrote: >>> Probably for those who don't want to use the release plugin :-) >> >> I was mainly following up on the thread about updating CP to AP 21 [1] >> >> But yes, it could be used as an alternative hashing method. > > I thought that the release plugin was intended for all > components to converge on the same release "recipe"... This is unlikely to happen as long as it does not cover multi-module builds. Bye, Thomas. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
