Re: [CRYPTO] Drop support for Java 7?

2018-09-27 Thread Marcelo Vanzin
Hi Gary, thanks.

I pushed the change but that broke the java 7 jenkins job (obviously).
Who can remove that job? I found on the ASF docs that PMCs have access
to the jenkins servers...

(At some point it would also be good to set up some extra jobs for
Windows and Macs - I see there are slaves for those - but I don't
think I'll have time to play with that at the moment.)


On Thu, Sep 27, 2018 at 10:25 AM Gary Gregory  wrote:
>
> +1 to update to Java 8.
>
> Gary
>
> On Thu, Sep 27, 2018 at 11:02 AM Marcelo Vanzin 
> wrote:
>
> > Any concerns with dropping support for Java 7 in the next release of
> > commons-crypto? Are there any rules about not doing that kind of thing
> > in a "minor" release?
> >
> > I was trying to fix up the Travis builds to work on JDK7 but it seems
> > that Travis's support for JDK7 is kinda broken at the moment... and I
> > don't even know where to download the JDK anymore if I need to prepare
> > a release.
> >
> > --
> > Marcelo
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >



-- 
Marcelo

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [validator] moving to jdk 8 / git?

2018-09-27 Thread Eitan Adler
(please make sure to include me directly on email; the Apache Commons
Dev list appears to be broken)

In terms of moving to JDK 8, it seems like it it'd warrant more of a
discussion first. Other Commons projects wanted to a do a "final
release" for the previous JDK version.  I'm not sure if I could help
shepherd that or not.

In terms of moving to git: while github PRs for mirrored repositories
are alright, it'd be better if the canonical repo was in git, so you
don't lose fidelity by transferring between systems. This also does
not seem like something viable to do via a PR.


On Thu, 27 Sep 2018 at 14:42, Gary Gregory  wrote:
>
> The best way to contribute is with GitHub PRs here:
> https://github.com/apache/commons-validator/
>
> Gary
>
> On Thu, Sep 27, 2018 at 2:30 PM Eitan Adler  wrote:
>
> > I'd like to make some simple changes to Commons Validator. It seems it
> > hasn't been touched for some time and I am not sure what the process
> > to deal with this is.
> >
> > If we wanted to do that, what would it take? Could I help?
> >
> > --
> > Eitan Adler
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >



--
Eitan Adler

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [validator] moving to jdk 8 / git?

2018-09-27 Thread Gary Gregory
The best way to contribute is with GitHub PRs here:
https://github.com/apache/commons-validator/

Gary

On Thu, Sep 27, 2018 at 2:30 PM Eitan Adler  wrote:

> I'd like to make some simple changes to Commons Validator. It seems it
> hasn't been touched for some time and I am not sure what the process
> to deal with this is.
>
> If we wanted to do that, what would it take? Could I help?
>
> --
> Eitan Adler
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


[validator] moving to jdk 8 / git?

2018-09-27 Thread Eitan Adler
I'd like to make some simple changes to Commons Validator. It seems it
hasn't been touched for some time and I am not sure what the process
to deal with this is.

If we wanted to do that, what would it take? Could I help?

--
Eitan Adler

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1842139 - in /commons/proper/configuration/trunk: pom.xml src/changes/changes.xml src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java src/main/java

2018-09-27 Thread Oliver Heger



Am 27.09.2018 um 20:43 schrieb ggreg...@apache.org:
> Author: ggregory
> Date: Thu Sep 27 18:43:37 2018
> New Revision: 1842139
> 
> URL: http://svn.apache.org/viewvc?rev=1842139=rev
> Log:
> [CONFIGURATION-720] Replace use of deprecated Commons Lang string 
> substitution code for Commons Text.
> 
> Modified:
> commons/proper/configuration/trunk/pom.xml
> commons/proper/configuration/trunk/src/changes/changes.xml
> 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java
> 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ExprLookup.java
> 
> Modified: commons/proper/configuration/trunk/pom.xml
> URL: 
> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/pom.xml?rev=1842139=1842138=1842139=diff
> ==
> --- commons/proper/configuration/trunk/pom.xml (original)
> +++ commons/proper/configuration/trunk/pom.xml Thu Sep 27 18:43:37 2018
> @@ -274,6 +274,11 @@
>commons-lang3
>3.8.1
>  
> +
> +  org.apache.commons
> +  commons-text
> +  1.4
> +

In the site there is a manually maintained page with the dependencies of
this project (dependencies.xml). This one should be updated as well for
the new dependency to [text].

Thanks.

Oliver

>  
>  
>commons-logging
> 
> Modified: commons/proper/configuration/trunk/src/changes/changes.xml
> URL: 
> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/changes/changes.xml?rev=1842139=1842138=1842139=diff
> ==
> --- commons/proper/configuration/trunk/src/changes/changes.xml (original)
> +++ commons/proper/configuration/trunk/src/changes/changes.xml Thu Sep 27 
> 18:43:37 2018
> @@ -44,6 +44,9 @@
>
>  Configuration properties can now be converted to regular expressions.
>
> +  
> +Replace use of deprecated Commons Lang string substitution code for 
> Commons Text.
> +  
>  
>  
>   
> Modified: 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java?rev=1842139=1842138=1842139=diff
> ==
> --- 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java
>  (original)
> +++ 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java
>  Thu Sep 27 18:43:37 2018
> @@ -26,8 +26,8 @@ import java.util.Set;
>  import java.util.concurrent.ConcurrentHashMap;
>  import java.util.concurrent.CopyOnWriteArrayList;
>  
> -import org.apache.commons.lang3.text.StrLookup;
> -import org.apache.commons.lang3.text.StrSubstitutor;
> +import org.apache.commons.text.StringSubstitutor;
> +import org.apache.commons.text.lookup.StringLookup;
>  
>  /**
>   * 
> @@ -107,7 +107,7 @@ public class ConfigurationInterpolator
>  private final List defaultLookups;
>  
>  /** The helper object performing variable substitution. */
> -private final StrSubstitutor substitutor;
> +private final StringSubstitutor substitutor;
>  
>  /** Stores a parent interpolator objects if the interpolator is nested 
> hierarchically. */
>  private volatile ConfigurationInterpolator parentInterpolator;
> @@ -474,9 +474,9 @@ public class ConfigurationInterpolator
>   *
>   * @return the {@code StrSubstitutor} used by this object
>   */
> -private StrSubstitutor initSubstitutor()
> +private StringSubstitutor initSubstitutor()
>  {
> -return new StrSubstitutor(new StrLookup()
> +return new StringSubstitutor(new StringLookup()
>  {
>  @Override
>  public String lookup(String key)
> 
> Modified: 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ExprLookup.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ExprLookup.java?rev=1842139=1842138=1842139=diff
> ==
> --- 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ExprLookup.java
>  (original)
> +++ 
> commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration2/interpol/ExprLookup.java
>  Thu Sep 27 18:43:37 2018
> @@ -18,16 +18,16 @@ package org.apache.commons.configuration
>  
>  import java.util.ArrayList;
>  
> -import org.apache.commons.configuration2.io.ConfigurationLogger;
>  

Re: [configuration] Update from java 7 to Java 8.

2018-09-27 Thread Oliver Heger



Am 27.09.2018 um 19:27 schrieb Gary Gregory:
> Hi All:
> 
> I'd like to update [configuration] from java 7 to Java 8.

Just go on. I think it was consensus that after the latest release the
Java version should be upgraded.

Oliver

> 
> Gary
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[configuration] Update from java 7 to Java 8.

2018-09-27 Thread Gary Gregory
Hi All:

I'd like to update [configuration] from java 7 to Java 8.

Gary


Re: [CRYPTO] Drop support for Java 7?

2018-09-27 Thread Gary Gregory
+1 to update to Java 8.

Gary

On Thu, Sep 27, 2018 at 11:02 AM Marcelo Vanzin 
wrote:

> Any concerns with dropping support for Java 7 in the next release of
> commons-crypto? Are there any rules about not doing that kind of thing
> in a "minor" release?
>
> I was trying to fix up the Travis builds to work on JDK7 but it seems
> that Travis's support for JDK7 is kinda broken at the moment... and I
> don't even know where to download the JDK anymore if I need to prepare
> a release.
>
> --
> Marcelo
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


[CRYPTO] Drop support for Java 7?

2018-09-27 Thread Marcelo Vanzin
Any concerns with dropping support for Java 7 in the next release of
commons-crypto? Are there any rules about not doing that kind of thing
in a "minor" release?

I was trying to fix up the Travis builds to work on JDK7 but it seems
that Travis's support for JDK7 is kinda broken at the moment... and I
don't even know where to download the JDK anymore if I need to prepare
a release.

-- 
Marcelo

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org