Re: [CRYPTO] Drop support for Java 7?

2018-09-28 Thread Marcelo Vanzin
Thanks! If I find some time I'll try to figure out the Windows build.
>From the comments I saw it seems to need mingw. But first I need to
find where I stashed that Windows VM...
On Fri, Sep 28, 2018 at 5:01 AM sebb  wrote:
>
> I've updated the job to run on Windows.
>
> However it fails when trying to execute 'make'.
>
> I don't know if make is available on those boxes.
> Needs further investigation.
>
> On Fri, 28 Sep 2018 at 11:27, sebb  wrote:
> >
> > On Fri, 28 Sep 2018 at 02:24, Marcelo Vanzin
> >  wrote:
> > >
> > > Hi Gary, thanks.
> > >
> > > I pushed the change but that broke the java 7 jenkins job (obviously).
> > > Who can remove that job? I found on the ASF docs that PMCs have access
> > > to the jenkins servers...
> >
> > I think you just need to be a member of
> > https://whimsy.apache.org/roster/group/hudson-jobadmin
> >
> > I've disabled it for now in case there's any useful data we want to
> > extract before deletion.
> > Or it could be converted into a Windows build; I'll take a look later.
> >
> > > (At some point it would also be good to set up some extra jobs for
> > > Windows and Macs - I see there are slaves for those - but I don't
> > > think I'll have time to play with that at the moment.)
> >
> > I don't think there are any working Macs at present.
> >
> > >
> > > On Thu, Sep 27, 2018 at 10:25 AM Gary Gregory  
> > > wrote:
> > > >
> > > > +1 to update to Java 8.
> > > >
> > > > Gary
> > > >
> > > > On Thu, Sep 27, 2018 at 11:02 AM Marcelo Vanzin 
> > > > 
> > > > wrote:
> > > >
> > > > > Any concerns with dropping support for Java 7 in the next release of
> > > > > commons-crypto? Are there any rules about not doing that kind of thing
> > > > > in a "minor" release?
> > > > >
> > > > > I was trying to fix up the Travis builds to work on JDK7 but it seems
> > > > > that Travis's support for JDK7 is kinda broken at the moment... and I
> > > > > don't even know where to download the JDK anymore if I need to prepare
> > > > > a release.
> > > > >
> > > > > --
> > > > > Marcelo
> > > > >
> > > > > -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > > > For additional commands, e-mail: dev-h...@commons.apache.org
> > > > >
> > > > >
> > >
> > >
> > >
> > > --
> > > Marcelo
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>


-- 
Marcelo

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-28 Thread Gary Gregory
Hi,

It looks like I did not spot what Spotbugs found :-(

https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html


The only real worrisome one IMO is:
"org.apache.commons.text.lookup.PropertiesStringLookup.lookup(String)
may fail to close stream"

If we fix one, we might as well fix them all.

WDYT?

Gary

On Fri, Sep 28, 2018 at 12:37 PM Rob Tompkins  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Text 1.4 was released, so I would like to release
> Apache Commons Text 1.5.
>
> Apache Commons Text 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1 (svn
> revision 29768)
>
> The Git tag commons-text-1.5-RC1 commit for this RC is
> d3d93c4e68ce5d8c25aecbfff9d17017594bf3f2 which you can browse here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=tag;h=refs/tags/commons-text-1.5-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1382/org/apache/commons/commons-text/1.5/
>
> These are the Maven artifacts and their hashes in Nexus:
>
> #Nexus SHA-1s
> commons-text-1.5.pom
> (SHA1: 82df3464f1d6b7b99eb6cc92069739a6234c9710)
> commons-text-1.5-sources.jar
> (SHA1: 3e39eac3b213fe33e2b60eb4322cb44f7d7a1680)
> commons-text-1.5.jar
> (SHA1: 9fdbd9e3d4507ef6640fb762f1e0e27c0fabbfe2)
> commons-text-1.5-tests.jar
> (SHA1: 142ea354f65e5db0ae291d2eec8a2100defd45af)
> commons-text-1.5-test-sources.jar
> (SHA1: e60a4ce76ff8f91ae034340c11fc2e01e332f644)
> commons-text-1.5-javadoc.jar
> (SHA1: c3d0e95dc0d2971ccc50fd9b92a54ff78d92338a)
>
>
> #Release SHA-256s
> #Fri Sep 28 14:18:44 EDT 2018
>
> commons-text-1.5-tests-jar.asc=83bb485bddd78093e3989a03700c275b4ef1fd83beb8abffd8661bb5f87de3ef
>
> commons-text-1.5-src-tar.gz=d73cf4c19b2348d342b74736daade40f7de29542ba8522110d997f40d6384085
>
> commons-text-1.5-javadoc-javadoc=effed126a7686c33ae9a37da820a0e8f06bb540b35e0cda7e0ada1034d82c64a
>
> commons-text-1.5-src-zip=c550dfa289c0f0a53a7b3683eea1181e9080cc5db930fd7f8b5f8969573a915d
>
> commons-text-1.5-bin-tar.gz=6ad6fed2c51c8de75492d889d23876d5b7cfdad4db4cfda241e71d976830fd50
>
> commons-text-1.5-tests-test-jar=b4f77797fd5bb41fecf518cb94cf5dd8b8e6a463ca6d0a9cb7807a46cd894466
>
> commons-text-1.5-bin-zip=02a121a4d223c0f5cdf86b36dd362685faaa359ea2fc114437a199942d2f8f82
>
> commons-text-1.5-test-sources-java-source=13f22c7fdd74c5f12fd4d2855367d446f159030d91cf182d1597ffbf8c1cbd16
>
> commons-text-1.5-sources-java-source=6540b6ea96f39fe5df2dd4aad3f4a7c0eea239222073742edc8693483d300438
>
> #Release SHA-512s
> #Fri Sep 28 14:18:44 EDT 2018
>
> commons-text-1.5-src-tar.gz=41e0aa28dd89579f6b3731069082dac3e69b8d946fba841c344851d112ed944f974c37f5a355259afe1fada0faf35f18fed01e74150ecda19fc0764f1ae4f48c
>
> commons-text-1.5-javadoc-javadoc=abbcf3a3b87af36808603eea8cb7db96d53cdedbfb924bc41c88776774db494cdf09fa9e112118afef825114eda79a4faa1eed554273777a9113b54c823ce73c
>
> commons-text-1.5-src-zip=b9014bc80ca991cc119e57365aee1feffc697233abf72fbdc2d71ed42ab28721374feef827720cde97219e935cdb5b07c3a2bf9c78c8ae498674022bbac829f6
>
> commons-text-1.5-bin-tar.gz=068e000563e522a1f4b96f6b1769284edcdf360f1e706317e2f09f9c7b3fc4eeb2c19274db64cf2312160ad3a94f4f63d4676f09f16380c592b7fe0eace3cad6
>
> commons-text-1.5-tests-test-jar=2008550b1f5c3ca83d9bed8fa8a668ad8e5830de0325df95626dfe1a716c81c4a51983673b49fc37216e38e22e0b799a6fae0b8884abeb6bcec066ba9a1a
>
> commons-text-1.5-bin-zip=6d3e249627b770bfa538f656d7fd91ed4582c0065fe8c41fa2cce57a1693dd4432d789ed1753e38bf839f4ac235e3f0b8b97d6974f565ea679e1289bf00929af
>
> commons-text-1.5-test-sources-java-source=9b194d7c5c8ab3bc9704a5c79e48bcaac350a33eab4cbdad486d1cd8acea3b1f6749940f797222eff7c8039a3855f3393d5ff3c7b3114a1d7af3fc48408f9a98
>
> commons-text-1.5-sources-java-source=c9c897abbdfabf418444806e69f0eb0a955fad81194efe13192985533741739f38407973d7a6c3977198f74a70e6907a524f4b3de634cad0991a4bb0757f
>
>
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14", arch: "x86_64", family: "mac"
>
>
> Details of changes since 1.4 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/changes-report.html
>
> Site:
> https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site
> (note some *relative* links are broken and the 1.5 directories are not
> yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 1.4):
>
> 

Hashes in VOTES (was: [VOTE] Release Apache Commons Text 1.5 based on RC1)

2018-09-28 Thread sebb
On Fri, 28 Sep 2018 at 19:37, Rob Tompkins  wrote:

The standard VOTE email (example below) has become rather long.
In particular I don't think *all* the hashes should to be quoted in the mail.

The point of having the hashes in the VOTE mail is to be able to tie
the published artifacts back to the VOTE, so only one is needed per
artifact.

Reviewers should check that the VOTE hashes agree with the artifacts
so let's use the minimum number necessary.

Reviewers should still check all the hashes in the files, but that is
a separate task.


>
> We have fixed quite a few bugs and added some significant enhancements since 
> Apache Commons Text 1.4 was released, so I would like to release Apache 
> Commons Text 1.5.
>
> Apache Commons Text 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1 (svn revision 
> 29768)

The above URL contains the official ASF source release and binaries
for the mirrors.
As such, I think their hashes should be shown here (they should be the
same as below, but I think they belong here)

> The Git tag commons-text-1.5-RC1 commit for this RC is 
> d3d93c4e68ce5d8c25aecbfff9d17017594bf3f2 which you can browse here:
> 
> https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=tag;h=refs/tags/commons-text-1.5-RC1
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1382/org/apache/commons/commons-text/1.5/
>
> These are the Maven artifacts and their hashes in Nexus:

We only need one set of hashes for the VOTE; I suggest we use SHA256
as SHA-1 is deprecated and SHA512 is rather long so it wraps.

> #Nexus SHA-1s
> commons-text-1.5.pom
> (SHA1: 82df3464f1d6b7b99eb6cc92069739a6234c9710)
> commons-text-1.5-sources.jar
> (SHA1: 3e39eac3b213fe33e2b60eb4322cb44f7d7a1680)
> commons-text-1.5.jar
> (SHA1: 9fdbd9e3d4507ef6640fb762f1e0e27c0fabbfe2)
> commons-text-1.5-tests.jar
> (SHA1: 142ea354f65e5db0ae291d2eec8a2100defd45af)
> commons-text-1.5-test-sources.jar
> (SHA1: e60a4ce76ff8f91ae034340c11fc2e01e332f644)
> commons-text-1.5-javadoc.jar
> (SHA1: c3d0e95dc0d2971ccc50fd9b92a54ff78d92338a)
>
>
> #Release SHA-256s
> #Fri Sep 28 14:18:44 EDT 2018
> commons-text-1.5-tests-jar.asc=83bb485bddd78093e3989a03700c275b4ef1fd83beb8abffd8661bb5f87de3ef
> commons-text-1.5-src-tar.gz=d73cf4c19b2348d342b74736daade40f7de29542ba8522110d997f40d6384085
> commons-text-1.5-javadoc-javadoc=effed126a7686c33ae9a37da820a0e8f06bb540b35e0cda7e0ada1034d82c64a
> commons-text-1.5-src-zip=c550dfa289c0f0a53a7b3683eea1181e9080cc5db930fd7f8b5f8969573a915d
> commons-text-1.5-bin-tar.gz=6ad6fed2c51c8de75492d889d23876d5b7cfdad4db4cfda241e71d976830fd50
> commons-text-1.5-tests-test-jar=b4f77797fd5bb41fecf518cb94cf5dd8b8e6a463ca6d0a9cb7807a46cd894466
> commons-text-1.5-bin-zip=02a121a4d223c0f5cdf86b36dd362685faaa359ea2fc114437a199942d2f8f82
> commons-text-1.5-test-sources-java-source=13f22c7fdd74c5f12fd4d2855367d446f159030d91cf182d1597ffbf8c1cbd16
> commons-text-1.5-sources-java-source=6540b6ea96f39fe5df2dd4aad3f4a7c0eea239222073742edc8693483d300438
>
> #Release SHA-512s
> #Fri Sep 28 14:18:44 EDT 2018
> commons-text-1.5-src-tar.gz=41e0aa28dd89579f6b3731069082dac3e69b8d946fba841c344851d112ed944f974c37f5a355259afe1fada0faf35f18fed01e74150ecda19fc0764f1ae4f48c
> commons-text-1.5-javadoc-javadoc=abbcf3a3b87af36808603eea8cb7db96d53cdedbfb924bc41c88776774db494cdf09fa9e112118afef825114eda79a4faa1eed554273777a9113b54c823ce73c
> commons-text-1.5-src-zip=b9014bc80ca991cc119e57365aee1feffc697233abf72fbdc2d71ed42ab28721374feef827720cde97219e935cdb5b07c3a2bf9c78c8ae498674022bbac829f6
> commons-text-1.5-bin-tar.gz=068e000563e522a1f4b96f6b1769284edcdf360f1e706317e2f09f9c7b3fc4eeb2c19274db64cf2312160ad3a94f4f63d4676f09f16380c592b7fe0eace3cad6
> commons-text-1.5-tests-test-jar=2008550b1f5c3ca83d9bed8fa8a668ad8e5830de0325df95626dfe1a716c81c4a51983673b49fc37216e38e22e0b799a6fae0b8884abeb6bcec066ba9a1a
> commons-text-1.5-bin-zip=6d3e249627b770bfa538f656d7fd91ed4582c0065fe8c41fa2cce57a1693dd4432d789ed1753e38bf839f4ac235e3f0b8b97d6974f565ea679e1289bf00929af
> commons-text-1.5-test-sources-java-source=9b194d7c5c8ab3bc9704a5c79e48bcaac350a33eab4cbdad486d1cd8acea3b1f6749940f797222eff7c8039a3855f3393d5ff3c7b3114a1d7af3fc48408f9a98
> commons-text-1.5-sources-java-source=c9c897abbdfabf418444806e69f0eb0a955fad81194efe13192985533741739f38407973d7a6c3977198f74a70e6907a524f4b3de634cad0991a4bb0757f
>
>
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
> 2018-06-17T14:33:14-04:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14", arch: "x86_64", family: "mac"
>
>
> Details of changes since 1.4 are in the release notes:
> 
> 

[VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-28 Thread Rob Tompkins
We have fixed quite a few bugs and added some significant enhancements since 
Apache Commons Text 1.4 was released, so I would like to release Apache Commons 
Text 1.5.

Apache Commons Text 1.5 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1 (svn revision 
29768)
  
The Git tag commons-text-1.5-RC1 commit for this RC is 
d3d93c4e68ce5d8c25aecbfff9d17017594bf3f2 which you can browse here:

https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=tag;h=refs/tags/commons-text-1.5-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1382/org/apache/commons/commons-text/1.5/

These are the Maven artifacts and their hashes in Nexus:

#Nexus SHA-1s
commons-text-1.5.pom
(SHA1: 82df3464f1d6b7b99eb6cc92069739a6234c9710)
commons-text-1.5-sources.jar
(SHA1: 3e39eac3b213fe33e2b60eb4322cb44f7d7a1680)
commons-text-1.5.jar
(SHA1: 9fdbd9e3d4507ef6640fb762f1e0e27c0fabbfe2)
commons-text-1.5-tests.jar
(SHA1: 142ea354f65e5db0ae291d2eec8a2100defd45af)
commons-text-1.5-test-sources.jar
(SHA1: e60a4ce76ff8f91ae034340c11fc2e01e332f644)
commons-text-1.5-javadoc.jar
(SHA1: c3d0e95dc0d2971ccc50fd9b92a54ff78d92338a)


#Release SHA-256s
#Fri Sep 28 14:18:44 EDT 2018
commons-text-1.5-tests-jar.asc=83bb485bddd78093e3989a03700c275b4ef1fd83beb8abffd8661bb5f87de3ef
commons-text-1.5-src-tar.gz=d73cf4c19b2348d342b74736daade40f7de29542ba8522110d997f40d6384085
commons-text-1.5-javadoc-javadoc=effed126a7686c33ae9a37da820a0e8f06bb540b35e0cda7e0ada1034d82c64a
commons-text-1.5-src-zip=c550dfa289c0f0a53a7b3683eea1181e9080cc5db930fd7f8b5f8969573a915d
commons-text-1.5-bin-tar.gz=6ad6fed2c51c8de75492d889d23876d5b7cfdad4db4cfda241e71d976830fd50
commons-text-1.5-tests-test-jar=b4f77797fd5bb41fecf518cb94cf5dd8b8e6a463ca6d0a9cb7807a46cd894466
commons-text-1.5-bin-zip=02a121a4d223c0f5cdf86b36dd362685faaa359ea2fc114437a199942d2f8f82
commons-text-1.5-test-sources-java-source=13f22c7fdd74c5f12fd4d2855367d446f159030d91cf182d1597ffbf8c1cbd16
commons-text-1.5-sources-java-source=6540b6ea96f39fe5df2dd4aad3f4a7c0eea239222073742edc8693483d300438

#Release SHA-512s
#Fri Sep 28 14:18:44 EDT 2018
commons-text-1.5-src-tar.gz=41e0aa28dd89579f6b3731069082dac3e69b8d946fba841c344851d112ed944f974c37f5a355259afe1fada0faf35f18fed01e74150ecda19fc0764f1ae4f48c
commons-text-1.5-javadoc-javadoc=abbcf3a3b87af36808603eea8cb7db96d53cdedbfb924bc41c88776774db494cdf09fa9e112118afef825114eda79a4faa1eed554273777a9113b54c823ce73c
commons-text-1.5-src-zip=b9014bc80ca991cc119e57365aee1feffc697233abf72fbdc2d71ed42ab28721374feef827720cde97219e935cdb5b07c3a2bf9c78c8ae498674022bbac829f6
commons-text-1.5-bin-tar.gz=068e000563e522a1f4b96f6b1769284edcdf360f1e706317e2f09f9c7b3fc4eeb2c19274db64cf2312160ad3a94f4f63d4676f09f16380c592b7fe0eace3cad6
commons-text-1.5-tests-test-jar=2008550b1f5c3ca83d9bed8fa8a668ad8e5830de0325df95626dfe1a716c81c4a51983673b49fc37216e38e22e0b799a6fae0b8884abeb6bcec066ba9a1a
commons-text-1.5-bin-zip=6d3e249627b770bfa538f656d7fd91ed4582c0065fe8c41fa2cce57a1693dd4432d789ed1753e38bf839f4ac235e3f0b8b97d6974f565ea679e1289bf00929af
commons-text-1.5-test-sources-java-source=9b194d7c5c8ab3bc9704a5c79e48bcaac350a33eab4cbdad486d1cd8acea3b1f6749940f797222eff7c8039a3855f3393d5ff3c7b3114a1d7af3fc48408f9a98
commons-text-1.5-sources-java-source=c9c897abbdfabf418444806e69f0eb0a955fad81194efe13192985533741739f38407973d7a6c3977198f74a70e6907a524f4b3de634cad0991a4bb0757f


I have tested this with ***'mvn clean install site'*** using: 
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
2018-06-17T14:33:14-04:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14", arch: "x86_64", family: "mac"


Details of changes since 1.4 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/changes-report.html

Site:
https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site
(note some *relative* links are broken and the 1.5 directories are not yet 
created - these will be OK once the site is deployed.)

CLIRR Report (compared to 1.4):

https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/clirr-report.html

JApiCmp Report (compared to 1.4):

https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Rob 

[GitHub] commons-text pull request #88: [TEXT-139] Improve JaccardSimilarity computat...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/88


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text pull request #89: TEXT-118: JSON escaping incorrect for the del...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/89


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text pull request #89: TEXT-118: JSON escaping incorrect for the del...

2018-09-28 Thread nandorKollar
GitHub user nandorKollar opened a pull request:

https://github.com/apache/commons-text/pull/89

TEXT-118: JSON escaping incorrect for the delete control character



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nandorKollar/commons-text TEXT-118

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 47aefa392ebe7e2ea777318b9c5d7f8b9d201b85
Author: Nandor Kollar 
Date:   2018-09-28T13:35:11Z

TEXT-118: JSON escaping incorrect for the delete control character




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [CRYPTO] Drop support for Java 7?

2018-09-28 Thread sebb
I've updated the job to run on Windows.

However it fails when trying to execute 'make'.

I don't know if make is available on those boxes.
Needs further investigation.

On Fri, 28 Sep 2018 at 11:27, sebb  wrote:
>
> On Fri, 28 Sep 2018 at 02:24, Marcelo Vanzin
>  wrote:
> >
> > Hi Gary, thanks.
> >
> > I pushed the change but that broke the java 7 jenkins job (obviously).
> > Who can remove that job? I found on the ASF docs that PMCs have access
> > to the jenkins servers...
>
> I think you just need to be a member of
> https://whimsy.apache.org/roster/group/hudson-jobadmin
>
> I've disabled it for now in case there's any useful data we want to
> extract before deletion.
> Or it could be converted into a Windows build; I'll take a look later.
>
> > (At some point it would also be good to set up some extra jobs for
> > Windows and Macs - I see there are slaves for those - but I don't
> > think I'll have time to play with that at the moment.)
>
> I don't think there are any working Macs at present.
>
> >
> > On Thu, Sep 27, 2018 at 10:25 AM Gary Gregory  
> > wrote:
> > >
> > > +1 to update to Java 8.
> > >
> > > Gary
> > >
> > > On Thu, Sep 27, 2018 at 11:02 AM Marcelo Vanzin 
> > > 
> > > wrote:
> > >
> > > > Any concerns with dropping support for Java 7 in the next release of
> > > > commons-crypto? Are there any rules about not doing that kind of thing
> > > > in a "minor" release?
> > > >
> > > > I was trying to fix up the Travis builds to work on JDK7 but it seems
> > > > that Travis's support for JDK7 is kinda broken at the moment... and I
> > > > don't even know where to download the JDK anymore if I need to prepare
> > > > a release.
> > > >
> > > > --
> > > > Marcelo
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > > For additional commands, e-mail: dev-h...@commons.apache.org
> > > >
> > > >
> >
> >
> >
> > --
> > Marcelo
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [validator] moving to jdk 8 / git?

2018-09-28 Thread sebb
On Fri, 28 Sep 2018 at 01:30, Eitan Adler  wrote:
>
> (please make sure to include me directly on email; the Apache Commons
> Dev list appears to be broken)

You are subscribed to dev (and other commons lists), see:
https://whimsy.apache.org/roster/committer/eax

Please contact Infra (us...@infra.etc) with details of the problem.
I know they are dealing with another mail delivery issue at present.

> In terms of moving to JDK 8, it seems like it it'd warrant more of a
> discussion first. Other Commons projects wanted to a do a "final
> release" for the previous JDK version.  I'm not sure if I could help
> shepherd that or not.

What is it about JDK 8 that warrants updating the minimum version for
this particular component?

> In terms of moving to git: while github PRs for mirrored repositories
> are alright, it'd be better if the canonical repo was in git, so you
> don't lose fidelity by transferring between systems. This also does
> not seem like something viable to do via a PR.
>
>
> On Thu, 27 Sep 2018 at 14:42, Gary Gregory  wrote:
> >
> > The best way to contribute is with GitHub PRs here:
> > https://github.com/apache/commons-validator/
> >
> > Gary
> >
> > On Thu, Sep 27, 2018 at 2:30 PM Eitan Adler  wrote:
> >
> > > I'd like to make some simple changes to Commons Validator. It seems it
> > > hasn't been touched for some time and I am not sure what the process
> > > to deal with this is.
> > >
> > > If we wanted to do that, what would it take? Could I help?
> > >
> > > --
> > > Eitan Adler
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > >
>
>
>
> --
> Eitan Adler
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [CRYPTO] Drop support for Java 7?

2018-09-28 Thread sebb
On Fri, 28 Sep 2018 at 02:24, Marcelo Vanzin
 wrote:
>
> Hi Gary, thanks.
>
> I pushed the change but that broke the java 7 jenkins job (obviously).
> Who can remove that job? I found on the ASF docs that PMCs have access
> to the jenkins servers...

I think you just need to be a member of
https://whimsy.apache.org/roster/group/hudson-jobadmin

I've disabled it for now in case there's any useful data we want to
extract before deletion.
Or it could be converted into a Windows build; I'll take a look later.

> (At some point it would also be good to set up some extra jobs for
> Windows and Macs - I see there are slaves for those - but I don't
> think I'll have time to play with that at the moment.)

I don't think there are any working Macs at present.

>
> On Thu, Sep 27, 2018 at 10:25 AM Gary Gregory  wrote:
> >
> > +1 to update to Java 8.
> >
> > Gary
> >
> > On Thu, Sep 27, 2018 at 11:02 AM Marcelo Vanzin 
> > 
> > wrote:
> >
> > > Any concerns with dropping support for Java 7 in the next release of
> > > commons-crypto? Are there any rules about not doing that kind of thing
> > > in a "minor" release?
> > >
> > > I was trying to fix up the Travis builds to work on JDK7 but it seems
> > > that Travis's support for JDK7 is kinda broken at the moment... and I
> > > don't even know where to download the JDK anymore if I need to prepare
> > > a release.
> > >
> > > --
> > > Marcelo
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > >
>
>
>
> --
> Marcelo
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org