[VFS] PR #80 feedback
Hi All, Does anyone have any thoughts or opinions on https://github.com/apache/commons-vfs/pull/80 ? Thank you, Gary
Re: [compress] javadoc (was Re: [VOTE] Release Compress 1.20 based on RC2)
On Sat, Feb 8, 2020 at 3:05 PM Stefan Bodewig wrote: > On 2020-02-08, Gary Gregory wrote: > > > On Sat, Feb 8, 2020 at 11:50 AM Stefan Bodewig > wrote: > > >> On 2020-02-08, Gary Gregory wrote: > > >>> - mvn javadoc:javadoc outputs LOTS of errors. > > >> Not a single one for me (building with Java 8). > > > Did you run 'mvn javadoc:javadoc'? > > Yes > > > Please see https://pastebin.com/ZLVdrEhr > > Th eoutput is talking about modules, so you must be using something > newer than Java8, which may explain the difference. We may need to > change the configuration to get rid of > > , > | javadoc: error - The code being documented uses modules but the packages > defined in https://docs.oracle.com/javase/9/docs/api/ are in the unnamed > module > ` > > but I have no idea how. The whole bunch of error messages prior to that > seem unrelated to Commons Compress. The rest are HTML5 warnings, I'll > look into them. > You're right, I must have been using Java 11. Gary > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
[compress] javadoc (was Re: [VOTE] Release Compress 1.20 based on RC2)
On 2020-02-08, Gary Gregory wrote: > On Sat, Feb 8, 2020 at 11:50 AM Stefan Bodewig wrote: >> On 2020-02-08, Gary Gregory wrote: >>> - mvn javadoc:javadoc outputs LOTS of errors. >> Not a single one for me (building with Java 8). > Did you run 'mvn javadoc:javadoc'? Yes > Please see https://pastebin.com/ZLVdrEhr Th eoutput is talking about modules, so you must be using something newer than Java8, which may explain the difference. We may need to change the configuration to get rid of , | javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/9/docs/api/ are in the unnamed module ` but I have no idea how. The whole bunch of error messages prior to that seem unrelated to Commons Compress. The rest are HTML5 warnings, I'll look into them. Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Compress 1.20 based on RC2
On Sat, Feb 8, 2020 at 11:50 AM Stefan Bodewig wrote: > On 2020-02-08, Gary Gregory wrote: > > > But next time: > > - On the site: it would be nice to keep all "What's new in 1.zzz?" > sections > > so users can see what's new based on the version _they_ currently have. > > Really, this is going to become a pretty long list. I've resurrected all > sections since we started providing them back with 1.6 so we'll see how > the page is going to look like :-) > > > - mvn javadoc:javadoc outputs LOTS of errors. > > Not a single one for me (building with Java 8). > Did you run 'mvn javadoc:javadoc'? Please see https://pastebin.com/ZLVdrEhr Gary > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [VOTE] Release Compress 1.20 based on RC2
On 2020-02-08, Gary Gregory wrote: > But next time: > - On the site: it would be nice to keep all "What's new in 1.zzz?" sections > so users can see what's new based on the version _they_ currently have. Really, this is going to become a pretty long list. I've resurrected all sections since we started providing them back with 1.6 so we'll see how the page is going to look like :-) > - mvn javadoc:javadoc outputs LOTS of errors. Not a single one for me (building with Java 8). Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[RESULT] Release Compress 1.20 based on RC2
With binding +1s by Gary, Rob and myself the vote has passed. I'll start with publishing the artifacts and will announce the release once the mirrors have had time to catch up. Many thanks Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Compress 1.20 based on RC2
+1 But next time: - On the site: it would be nice to keep all "What's new in 1.zzz?" sections so users can see what's new based on the version _they_ currently have. - mvn javadoc:javadoc outputs LOTS of errors. My review is based on the git tag. - Apache RAT check OK. - JApiCmp OK. - Building OK with 'mvn clean package -V' on Oracle Java 8 and 11. Using Maven: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Using Java: java version "1.8.0_241" Java(TM) SE Runtime Environment (build 1.8.0_241-b07) Java HotSpot(TM) 64-Bit Server VM (build 25.241-b07, mixed mode) java version "11.0.6" 2020-01-14 LTS Java(TM) SE Runtime Environment 18.9 (build 11.0.6+8-LTS) Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.6+8-LTS, mixed mode) Using Windows: Microsoft Windows [Version 10.0.16299.1625] Gary On Wed, Feb 5, 2020 at 12:18 AM Stefan Bodewig wrote: > The only change compared to RC1 is one to a unit test which wouldn't > pass unless you already had PAX Exam in your local mvn repo. > > Compress 1.20 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/compress/ > (svn revision 37873) > > The tag is here: > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=tag;h=refs/tags/1.20-RC2 > on commit > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=f7503adfbad8b44eb079d564f2784aeaa034647c > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1492/org/apache/commons/commons-compress/1.20/ > > These are the Maven artifacts and their hashes > > 5d3ce7ae4518c0fe5094b512c5c4825cc213ebc388e1e1e7692475406d5876c893140e5bbaaecb1676262a6b73c7250d40b83653cd03600815693474f92f0fa7 > commons-compress-1.20.jar > 9d6682b6e101e41a3f351267ef684fdc1a9c312c28923e0a921799f7c70aff73f04541b4d01a4a8af1b699e0769d406697a47748ef717c606fc902475aa7a911 > commons-compress-1.20-javadoc.jar > 1208094341901a776e40f81ef48dc5af406a659f1bbc88593156df4c7d46d963d1c14ba67a4e5295694af51c03882b2a60f01aa56973b3d8e0d55f8977eaff75 > commons-compress-1.20-sources.jar > c1df5f8a951ac41f65e62cc48d6c7d19cdb484073d03bd36639b4f383db8f3cb0cf0b587643112f4a3a82ee56b109f8d7213bdd22d648459f54cc8b100de9c7d > commons-compress-1.20-tests.jar > 64d535998785bc884da4698b0445f13656a5f5fad3963c3ca26a7d978e5b1e039080cef97eb4c9de5d1bfb36b75e2130f8b3b934c777918e0a28a34c807d57cc > commons-compress-1.20-test-sources.jar > a7ad5f75c1509aa8d238e583a76fcf7f69fb93c40ac6cf6a3cf33dbb8c5dba98bfc0d81c88815b123d1196d958dd94a79c417e685a3440629d63b2068fe90bc3 > commons-compress-1.20.pom > > I have tested this with JDK 8 using Maven 3.5.4 > > Details of changes since 1.19 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt > > https://stefan.samaflost.de/staging/commons-compress-1.20/changes-report.html > > Site: > https://stefan.samaflost.de/staging/commons-compress-1.20/ > (note Javadocs of 1.20 have not been created right now and this is - > as usual when I cut a release - not the site I'm going to publish > after the release. I'll create a new site once the release date is > known. This is the same site as the one for RC1) > > Japicmp Report (compared to 1.19): > https://stefan.samaflost.de/staging/commons-compress-1.20/japicmp.html > > RAT Report: > > https://stefan.samaflost.de/staging/commons-compress-1.20/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, > i.e. sometime after 05:30 UTC 08-Feb 2020 > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [VOTE] Release Compress 1.20 based on RC2
Making my own vote explicit. We still lack another +1, though. On 2020-02-05, Stefan Bodewig wrote: > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, > i.e. sometime after 05:30 UTC 08-Feb 2020 +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
