Re: [Compress] Java 16 and 17-ea
On 2021-07-03, Gary Gregory wrote: > This is the approach I've taken: I merged the pack200 branch into > master as is. Thank you Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [Compress] Java 16 and 17-ea
On Fri, Jul 2, 2021 at 11:19 AM Stefan Bodewig wrote: > > On 2021-06-12, Gary Gregory wrote: > > > Please have a look at the pack200 branch if you want, there are still > > Javadoc TODOs but it's all there. > > Just so we get this into this list's archive properly: I've propsed a > few changes in https://github.com/apache/commons-compress/pull/210 but > completely leave it up to you whether you want to apply them or just > merge your branch as it is. Thank you for the PR. This is the approach I've taken: I merged the pack200 branch into master as is. That builds green. This allows us to exercise the pack200 code now and on all builds. I think this will be better in the long term because will find out sooner when the code needs adjusting as opposed to when someone only runs on a Java version that does not contain pack200; fail fast and all that. If others feel strongly otherwise, then we can revisit PR 210 and make it build green. TY! Gary > > Thanks > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Create flow to only reflect selected fields on ReflectionToStringBuilder
If you know the fields, why use ReflectionToStringBuilder? Why not use a regular ToStringBuilder? That allows you to append each field you want. Yes, you have to type each field name twice (for the name and the value), but is that so much more work that it would require complicating the ReflectiontoStringBuilder API? On 02/07/2021 20:06, Daniel Augusto Veronezi Salvador wrote: Hello, This is my first interaction with this community, so I may commit some mistakes 😁. *ReflectionToStringBuilder* has methods to exclude fields from *toString*; If we have an object with several fields and want to reflect only a some, we have to list all the fields that we don't want to reflect and pass to *excludeFieldNames*. I did this trick locally, but I was wondering if it would be valid to implement a way to pass the fields that we want and reflect only the selected fields in *ReflectionToStringBuilder*. As the contributing documentation guide, I submitted an issue on Jira too (https://issues.apache.org/jira/browse/LANG-1662). Best regards, Daniel Salvador - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Create flow to only reflect selected fields on ReflectionToStringBuilder
Hello, This is my first interaction with this community, so I may commit some mistakes 😁. *ReflectionToStringBuilder* has methods to exclude fields from *toString*; If we have an object with several fields and want to reflect only a some, we have to list all the fields that we don't want to reflect and pass to *excludeFieldNames*. I did this trick locally, but I was wondering if it would be valid to implement a way to pass the fields that we want and reflect only the selected fields in *ReflectionToStringBuilder*. As the contributing documentation guide, I submitted an issue on Jira too (https://issues.apache.org/jira/browse/LANG-1662). Best regards, Daniel Salvador
Re: [Compress] Java 16 and 17-ea
On 2021-06-12, Gary Gregory wrote: > Please have a look at the pack200 branch if you want, there are still > Javadoc TODOs but it's all there. Just so we get this into this list's archive properly: I've propsed a few changes in https://github.com/apache/commons-compress/pull/210 but completely leave it up to you whether you want to apply them or just merge your branch as it is. Thanks Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
