Re: [compress] poor test coverage of harmony code

2021-07-03 Thread Gary Gregory
Nice!

Gary

On Sat, Jul 3, 2021, 10:15 Stefan Bodewig  wrote:

> On 2021-07-03, Stefan Bodewig wrote:
>
> > I assume the code originates from
> >
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> > and I'd look into porting the tests from
> >
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> > unless anybody else has also started to look into it.
>
> Back at 86% coverage.
>
> The tests are JUnit 3.x style and I have left them at that. I basically
> only changed the package names and removed a test that asserted a given
> class was compiled for Java 1.4.
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [compress] poor test coverage of harmony code

2021-07-03 Thread Stefan Bodewig
On 2021-07-03, Stefan Bodewig wrote:

> I assume the code originates from
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> and I'd look into porting the tests from
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> unless anybody else has also started to look into it.

Back at 86% coverage.

The tests are JUnit 3.x style and I have left them at that. I basically
only changed the package names and removed a test that asserted a given
class was compiled for Java 1.4.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [compress] releasing 1.21 soonish?

2021-07-03 Thread Gary Gregory
Go for it :-)

Gary

On Sat, Jul 3, 2021, 05:57 Stefan Bodewig  wrote:

> Hi all
>
> is there anything you want to work on or can we go ahead with cutting a
> new Compress release in about a week?
>
> There are some test coverage and javadoc issues that need to get
> resolved but other than that at least I do not intend to work on any
> changes or new features.
>
> A current build of the site can be found at
> https://stefan.samaflost.de/staging/commons-compress-1.21/ if you want
> to look at the big number of changes we've accumulated over the past
> sixteen months or review the various reports.
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [compress] poor test coverage of harmony code

2021-07-03 Thread Gary Gregory
Good idea, I mistakenly thought our coverage was better.

Gary

On Sat, Jul 3, 2021, 05:50 Stefan Bodewig  wrote:

> Hi
>
> our current pack200 tests don't seem to cover much of the pack200 code
> imported from harmony and the overall test coverage of Compress as a
> whole has dropped significantly (from 86% to 61%) as the new package
> contains quite a bit of code.
>
> I assume the code originates from
>
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> and I'd look into porting the tests from
>
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> unless anybody else has also started to look into it.
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


[compress] releasing 1.21 soonish?

2021-07-03 Thread Stefan Bodewig
Hi all

is there anything you want to work on or can we go ahead with cutting a
new Compress release in about a week?

There are some test coverage and javadoc issues that need to get
resolved but other than that at least I do not intend to work on any
changes or new features.

A current build of the site can be found at
https://stefan.samaflost.de/staging/commons-compress-1.21/ if you want
to look at the big number of changes we've accumulated over the past
sixteen months or review the various reports.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[compress] poor test coverage of harmony code

2021-07-03 Thread Stefan Bodewig
Hi

our current pack200 tests don't seem to cover much of the pack200 code
imported from harmony and the overall test coverage of Compress as a
whole has dropped significantly (from 86% to 61%) as the new package
contains quite a bit of code.

I assume the code originates from
https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
and I'd look into porting the tests from
https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
unless anybody else has also started to look into it.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org