Re: [numbers][gsoc] GSoC 2022 - NUMBERS-186 Proposal

[Gilles Sadowski]

Hello.

Le ven. 24 juin 2022 à 16:59, Sumanth Rajkumar
 a écrit :
>
> Hi Alex, Gilles, and Matt,
>
> I have raised a PR to the complex-gsoc-22 branch and it has been linked to
> the NUMBERS-188 jira.

One tenet of a project such as "Commons" is that everything must be
documented.[1]
For the Javadoc comments, please apply the same style as in other source files.

Formatting should also be taken care of (to help review, and future
maintenance).[2]

Are we sure that all this code needs to be part of the public API?  If
not, I'd suggest
limiting accessibility to "package-private".

In "DComplex", I propose that the accessors be named "real()" and
"imag()" (or just
"re()" and "im()").  ["DComplex" is not a very satisfying name either...]

Thanks,
Gilles

[1] I'm a bit surprised that the build succeeds despite the missing comments.
[2] E.g. one argument per line improves readability (IMHO).

>
> [...]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [numbers][gsoc] GSoC 2022 - NUMBERS-186 Proposal

[Alex Herbert]

OK. I have approved the CI build to run on the PR.

I will review when I have some more time.

Alex


On Fri, 24 Jun 2022 at 15:59, Sumanth Rajkumar 
wrote:

> Hi Alex, Gilles, and Matt,
>
> I have raised a PR to the complex-gsoc-22 branch and it has been linked to
> the NUMBERS-188 jira.
>
> While the PR is being reviewed, I will start working on NUMBERS-186 (adding
> support for list and matrix of Complex numbers).
>
> Thanks,
> Sumanth
>
> On Mon, 20 Jun 2022 at 09:43, Sumanth Rajkumar  >
> wrote:
>
> > Hello Gilles,
> > Thanks!  I will start a new thread for float support.
> >
> > Thanks
> > Sumanth
> >
> >
> > On Mon, Jun 20, 2022, 18:41 Gilles Sadowski  wrote
> >
> >>
> >> > Also, should we add support for float data type for complex numbers?
> >>
> >> In the "dev" ML, we customarily aim at focussing each discussion,
> >
> >
> >> Thus could you please start a new thread with this question?
> >>
> >
> >
> >
>

Re: [numbers][gsoc] GSoC 2022 - NUMBERS-186 Proposal

[Sumanth Rajkumar]

Hi Alex, Gilles, and Matt,

I have raised a PR to the complex-gsoc-22 branch and it has been linked to
the NUMBERS-188 jira.

While the PR is being reviewed, I will start working on NUMBERS-186 (adding
support for list and matrix of Complex numbers).

Thanks,
Sumanth

On Mon, 20 Jun 2022 at 09:43, Sumanth Rajkumar 
wrote:

> Hello Gilles,
> Thanks!  I will start a new thread for float support.
>
> Thanks
> Sumanth
>
>
> On Mon, Jun 20, 2022, 18:41 Gilles Sadowski  wrote
>
>>
>> > Also, should we add support for float data type for complex numbers?
>>
>> In the "dev" ML, we customarily aim at focussing each discussion,
>
>
>> Thus could you please start a new thread with this question?
>>
>
>
>

Re: [VOTE] Release Apache Commons Configuration 2.8 based on RC2

[Gary Gregory]

Where is the documentation for the new property-based toggles?

It should be at least be documented here:
https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/userguide/howto_basicfeatures.html#Variable_Interpolation

Shouldn't the migration page also mention have a new section for this
version on how to get the features back with the sys prop toggles on
https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/userguide/upgradeto2_0.html
?

Gary

On Tue, Jun 21, 2022 at 11:47 PM Matt Juntunen
 wrote:
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Configuration 2.7 was released, so I would like
> to release Apache Commons Configuration 2.8.
>
> Apache Commons Configuration 2.8 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2
> (svn revision 55251)
>
> The Git tag commons-configuration-2.8-RC2 commit for this RC is
> f540433112b9a93c26c43277c3ec7a3d40565115 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=f540433112b9a93c26c43277c3ec7a3d40565115
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-configuration.git
> --branch commons-configuration-2.8-RC2 commons-configuration-2.8-RC2
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1590/org/apache/commons/commons-configuration2/2.8/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Jun 21 23:27:23 EDT 2022
> commons-configuration2-2.8-bin.tar.gz=b3f4628ecf3fc52feaf68ca13d0518d0ff5de8bea690a3fa625b91f2ffee9ef0fe1c575743d71bd035ba5d1c0be47a668ec1b28fb1953998f6723cecb8b59a38
> commons-configuration2-2.8-bin.zip=86dc5ee9d7581b6c0b2f2807fb4f2179eec0dc4dfdb1246ffd9054a64e4511b534a4be015946403f0d0519362029cef2d4d89c684d38eaa4bd1e6af8d8b8b3a9
> commons-configuration2-2.8-javadoc.jar=91dc9721ebea0345175d02b2d8e4bf08a255034549527edbecd382771540d85ca2423f22a4bc260d42ac33e9c3bd6b36a5fb7713b4919b58a0c06d9661285b0d
> commons-configuration2-2.8-sources.jar=85e4f25fc9a0682bd3376de2741b48bfb6b77e98795a107c818c0bb51578cde8dd60a5e38177a6ce2a73bc4a1b9f925720321f7320fef0173c6f26c0a303bb55
> commons-configuration2-2.8-src.tar.gz=924be9a8c0fd5f5a03d9ccd14a0bf79b83323f424fc4580084e807a5f7f242d40146cbdcd34d8d3a0098aeebe3040f77089230176ef737d649666152f2bda6ea
> commons-configuration2-2.8-src.zip=e6695471c21e0c885b3ad5b0e0ff65a69a65cbc82a7c96d0406342f81b2efb8185b7008dfd7d49603ca96ea44761bb681aacfd997bbbae742ad922d58173305a
> commons-configuration2-2.8-test-sources.jar=d203e063ec6b7ea16688c9015f10cf41bb3c592e990e214f6f808a20f19efe5973b3d30f4b939d571a8f4c1c2094d52c77733b59d0e7cdf412d27133fac7c7d9
> commons-configuration2-2.8-tests.jar=6878c163de212e0617650ecbcd68887db1fc0c29f596ca773598b4ef7314e7062f4671208b8360d6ec2ca8f8408c75763912bcc545903e440fd77a6086af5c49
>
>
>
> I have tested this with ***'mvn clean install site'*** using:
> ***
> Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> Maven home: /home/matt/tools/maven/apache-maven-3.8.4
> Java version: 1.8.0_322, vendor: Temurin, runtime:
> /home/matt/lang/java/jdk8u322-b06/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64",
> family: "unix"
>
> Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> Maven home: /home/matt/tools/maven/apache-maven-3.8.4
> Java version: 11.0.14.1, vendor: Eclipse Adoptium, runtime:
> /home/matt/lang/java/jdk-11.0.14.1+1
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64",
> family: "unix"
> ***
>
> Details of changes since 2.7 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/index.html
> (note some *relative* links are broken and the 2.8 directories are
> not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 2.7):
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/japicmp.html
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Matt Juntunen,
> Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
>
> For following is intended as a helper and refresher for reviewers.
>
> 

Re: [VOTE] Release Apache Commons Configuration 2.8 based on RC2

[Gary Gregory]

The information on the custom page [1] seems to have the same intent
as [2] but the information is different and I am sure has not been
checked since 2.0, how about simply removing the custom page?

[1] 
https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/dependencies.html
[2] 
https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/dependency-convergence.html

Gary

On Fri, Jun 24, 2022 at 7:28 AM Gary Gregory  wrote:
>
> Wrong version on this page:
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/userguide/upgradeto2_0.html
>
> Gary
>
> On Tue, Jun 21, 2022 at 11:47 PM Matt Juntunen
>  wrote:
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Apache Commons Configuration 2.7 was released, so I would like
> > to release Apache Commons Configuration 2.8.
> >
> > Apache Commons Configuration 2.8 RC2 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2
> > (svn revision 55251)
> >
> > The Git tag commons-configuration-2.8-RC2 commit for this RC is
> > f540433112b9a93c26c43277c3ec7a3d40565115 which you can browse here:
> > 
> > https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=f540433112b9a93c26c43277c3ec7a3d40565115
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-configuration.git
> > --branch commons-configuration-2.8-RC2 commons-configuration-2.8-RC2
> >
> > Maven artifacts are here:
> > 
> > https://repository.apache.org/content/repositories/orgapachecommons-1590/org/apache/commons/commons-configuration2/2.8/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Tue Jun 21 23:27:23 EDT 2022
> > commons-configuration2-2.8-bin.tar.gz=b3f4628ecf3fc52feaf68ca13d0518d0ff5de8bea690a3fa625b91f2ffee9ef0fe1c575743d71bd035ba5d1c0be47a668ec1b28fb1953998f6723cecb8b59a38
> > commons-configuration2-2.8-bin.zip=86dc5ee9d7581b6c0b2f2807fb4f2179eec0dc4dfdb1246ffd9054a64e4511b534a4be015946403f0d0519362029cef2d4d89c684d38eaa4bd1e6af8d8b8b3a9
> > commons-configuration2-2.8-javadoc.jar=91dc9721ebea0345175d02b2d8e4bf08a255034549527edbecd382771540d85ca2423f22a4bc260d42ac33e9c3bd6b36a5fb7713b4919b58a0c06d9661285b0d
> > commons-configuration2-2.8-sources.jar=85e4f25fc9a0682bd3376de2741b48bfb6b77e98795a107c818c0bb51578cde8dd60a5e38177a6ce2a73bc4a1b9f925720321f7320fef0173c6f26c0a303bb55
> > commons-configuration2-2.8-src.tar.gz=924be9a8c0fd5f5a03d9ccd14a0bf79b83323f424fc4580084e807a5f7f242d40146cbdcd34d8d3a0098aeebe3040f77089230176ef737d649666152f2bda6ea
> > commons-configuration2-2.8-src.zip=e6695471c21e0c885b3ad5b0e0ff65a69a65cbc82a7c96d0406342f81b2efb8185b7008dfd7d49603ca96ea44761bb681aacfd997bbbae742ad922d58173305a
> > commons-configuration2-2.8-test-sources.jar=d203e063ec6b7ea16688c9015f10cf41bb3c592e990e214f6f808a20f19efe5973b3d30f4b939d571a8f4c1c2094d52c77733b59d0e7cdf412d27133fac7c7d9
> > commons-configuration2-2.8-tests.jar=6878c163de212e0617650ecbcd68887db1fc0c29f596ca773598b4ef7314e7062f4671208b8360d6ec2ca8f8408c75763912bcc545903e440fd77a6086af5c49
> >
> >
> >
> > I have tested this with ***'mvn clean install site'*** using:
> > ***
> > Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> > Maven home: /home/matt/tools/maven/apache-maven-3.8.4
> > Java version: 1.8.0_322, vendor: Temurin, runtime:
> > /home/matt/lang/java/jdk8u322-b06/jre
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64",
> > family: "unix"
> >
> > Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> > Maven home: /home/matt/tools/maven/apache-maven-3.8.4
> > Java version: 11.0.14.1, vendor: Eclipse Adoptium, runtime:
> > /home/matt/lang/java/jdk-11.0.14.1+1
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64",
> > family: "unix"
> > ***
> >
> > Details of changes since 2.7 are in the release notes:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/RELEASE-NOTES.txt
> > 
> > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/changes-report.html
> >
> > Site:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/index.html
> > (note some *relative* links are broken and the 2.8 directories are
> > not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 2.7):
> > 
> > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/japicmp.html
> >
> > RAT Report:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> >   [ ] +1 Release these artifacts
> 

Re: [VOTE] Release Apache Commons Configuration 2.8 based on RC2

[Gary Gregory]

Wrong version on this page:
https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/userguide/upgradeto2_0.html

Gary

On Tue, Jun 21, 2022 at 11:47 PM Matt Juntunen
 wrote:
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Configuration 2.7 was released, so I would like
> to release Apache Commons Configuration 2.8.
>
> Apache Commons Configuration 2.8 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2
> (svn revision 55251)
>
> The Git tag commons-configuration-2.8-RC2 commit for this RC is
> f540433112b9a93c26c43277c3ec7a3d40565115 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=f540433112b9a93c26c43277c3ec7a3d40565115
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-configuration.git
> --branch commons-configuration-2.8-RC2 commons-configuration-2.8-RC2
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1590/org/apache/commons/commons-configuration2/2.8/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Jun 21 23:27:23 EDT 2022
> commons-configuration2-2.8-bin.tar.gz=b3f4628ecf3fc52feaf68ca13d0518d0ff5de8bea690a3fa625b91f2ffee9ef0fe1c575743d71bd035ba5d1c0be47a668ec1b28fb1953998f6723cecb8b59a38
> commons-configuration2-2.8-bin.zip=86dc5ee9d7581b6c0b2f2807fb4f2179eec0dc4dfdb1246ffd9054a64e4511b534a4be015946403f0d0519362029cef2d4d89c684d38eaa4bd1e6af8d8b8b3a9
> commons-configuration2-2.8-javadoc.jar=91dc9721ebea0345175d02b2d8e4bf08a255034549527edbecd382771540d85ca2423f22a4bc260d42ac33e9c3bd6b36a5fb7713b4919b58a0c06d9661285b0d
> commons-configuration2-2.8-sources.jar=85e4f25fc9a0682bd3376de2741b48bfb6b77e98795a107c818c0bb51578cde8dd60a5e38177a6ce2a73bc4a1b9f925720321f7320fef0173c6f26c0a303bb55
> commons-configuration2-2.8-src.tar.gz=924be9a8c0fd5f5a03d9ccd14a0bf79b83323f424fc4580084e807a5f7f242d40146cbdcd34d8d3a0098aeebe3040f77089230176ef737d649666152f2bda6ea
> commons-configuration2-2.8-src.zip=e6695471c21e0c885b3ad5b0e0ff65a69a65cbc82a7c96d0406342f81b2efb8185b7008dfd7d49603ca96ea44761bb681aacfd997bbbae742ad922d58173305a
> commons-configuration2-2.8-test-sources.jar=d203e063ec6b7ea16688c9015f10cf41bb3c592e990e214f6f808a20f19efe5973b3d30f4b939d571a8f4c1c2094d52c77733b59d0e7cdf412d27133fac7c7d9
> commons-configuration2-2.8-tests.jar=6878c163de212e0617650ecbcd68887db1fc0c29f596ca773598b4ef7314e7062f4671208b8360d6ec2ca8f8408c75763912bcc545903e440fd77a6086af5c49
>
>
>
> I have tested this with ***'mvn clean install site'*** using:
> ***
> Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> Maven home: /home/matt/tools/maven/apache-maven-3.8.4
> Java version: 1.8.0_322, vendor: Temurin, runtime:
> /home/matt/lang/java/jdk8u322-b06/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64",
> family: "unix"
>
> Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> Maven home: /home/matt/tools/maven/apache-maven-3.8.4
> Java version: 11.0.14.1, vendor: Eclipse Adoptium, runtime:
> /home/matt/lang/java/jdk-11.0.14.1+1
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64",
> family: "unix"
> ***
>
> Details of changes since 2.7 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/index.html
> (note some *relative* links are broken and the 2.8 directories are
> not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 2.7):
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/japicmp.html
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Matt Juntunen,
> Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-configuration.git
> --branch 

Re: [collections] JMH results for IndexedLinkedList

[Gilles Sadowski]

Hello.

Le mar. 21 juin 2022 à 13:21, Rodion Efremov  a écrit :
>
> Hi,
>
> Data structure: IndexedLinkedList
> 
> Benchmark: IndexedLinkedListBenchmark
> 
>
> Benchmark output:
> https://github.com/coderodde/indexedLinkedList/#benchmark-output
>
> From the benchmark output, we can judge that IndexedLinkedList outperforms
> both java.util.LinkedList and the Apache Commons Collections TreeList. It,
> however, does not seem to supersede the java.util.ArrayList.
>
> Basically, I would expect the IndexedLinkedList to beat the ArrayList where
> we have a lot of following operations:
>
>- addFirst(E)
>- add(int, E)
>- remove(int)
>
> So, what do you think? I am getting anywhere with that?

Do you have use-cases?

Could perhaps extend the benchmarks to all the JDK collections
that could target the same use-cases?
Also, it may be worth actually testing different sizes.
[For easier reading, please make a table with the JMH results.]

Thanks,
Gilles

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [numbers] Complex Float Support

[Gilles Sadowski]

Hello.

Le jeu. 23 juin 2022 à 21:27, Sumanth Rajkumar
 a écrit :
>
> Hi,
>
> As part of NUMBERS-187 (Enhanced Support for complex numbers), should we
> add support for float types?

I'd say no.
At least, any computation should be done with "double" precision.

Converting from/to "float" would only be the first/last step during
in-place processing of large lists of complex numbers.
Hence, it would be oblivious of the "complex" nature of a pair of
"double"s, whatever the input/output layout.

Anyway, this would seem very low priority (unless you have a use
case).

> If yes, for operations on float types, can we reuse functions (part of
> NUMBERS-188) that operate on double types

An example?

> and use Java float-double
> widening and narrowing conversions?

That would be a cast (from "float" to "double" on input and vice-versa
on output), no?

Regards,
Gilles

>
> https://docs.oracle.com/javase/specs/jls/se10/html/jls-5.html#jls-5.1.2
>
> Thanks,
> Sumanth

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org