Re: [VOTE] Release Apache Commons VFS Project 2.10.0 based on RC1
Thanks for reviewing Bruno.
Yes, releases our multi-module components are a pain, especially when
we want the triple play: Release to Nexus, and release to
dist.apache.org, and build a site :-(
- We have lots of tests, so a build takes a little while depending on
your hardware.
- ${commons.sha512list}, ah, darn, our plugin that generates the email
text must not work with a multi-module component.
- The bin zip/tars without jars is not right, that needs fixing. I'm
not sure yet if I need another RC for that or if I can do it without
changing any files, just a different Maven invocation; I'll look into
it.
- For the site, reports like PMD, SpotBugs, and JApiCmp only make
sense for the modules, not at the top level, but again, painful to
generate a site that makes sense. I'll check it out.
Thank you!
Gary
On Mon, Mar 11, 2024 at 5:34 PM Bruno Kinoshita wrote:
>
> Hi Gary,
>
> The build passed after ~13 mins on my old thinkpad
>
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: /opt/apache-maven-3.8.5
> Java version: 17.0.10, vendor: Private Build, runtime:
> /usr/lib/jvm/java-17-openjdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.15.0-100-generic", arch: "amd64", family:
> "unix"
>
> But this called my attention
>
> These are the artifacts and their hashes:
> >
> > ${commons.sha512list}
>
>
> I think that's fine and it's just probably something missing somewhere to
> configure the commons-release-plugin or parent to output the sha here.
>
> But then I decided to take a better look at the archives just to be sure.
>
> Are the bin files for VFS always nearly empty, with just three files?
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/binaries/
>
> Can't really recall, maybe it's because the module is a bit special or
> multi-module... really can't recall seeing an archive with just three text
> files...
>
> The site reports also look messed up, e.g. empty japicmp, and exception
> printed in
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/pmd.html...
> but I do recall needing some command to build multi-module components... so
> maybe that's expected and reviewers need to build it locally?
>
> Running out of time and also wanting to have a quick look at some Imaging
> issues, so won't have time to dig deeper here, can you take a look at these
> points and I will come back to continue the review if the above is fine,
> please? It's also late here, so it could be just me sleepy doing something
> wrong/silly.
>
> Cheers!
>
> On Sun, 10 Mar 2024 at 23:02, Gary Gregory wrote:
>
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons VFS Project 2.9.0 was released, so I would like to release
> > Apache Commons VFS Project 2.10.0.
> >
> > Apache Commons VFS Project 2.10.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1 (svn
> > revision 67866)
> >
> > The Git tag commons-vfs-2.10.0-RC1 commit for this RC is
> > 6aec37ad5fdcd4d0f2ca0330f310eb48a1585462 which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=commit;h=6aec37ad5fdcd4d0f2ca0330f310eb48a1585462
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-vfs.git
> > --branch
> > commons-vfs-2.10.0-RC1 commons-vfs-2.10.0-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1702/org/apache/commons/commons-vfs2-project/2.10.0/
> >
> > These are the artifacts and their hashes:
> >
> > ${commons.sha512list}
> >
> >
> > I have tested this with:
> >
> > mvn
> >
> > and
> >
> > mvn -V -Prelease -Ptest-deploy clean install -DskipTests && \
> > mvn -V -Prelease -Ptest-deploy -P japicmp -P jacoco site deploy
> > -DskipTests && \
> > mvn -V -Prelease -Ptest-deploy site:stage
> >
> > Details of changes since 2.9.0 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/RELEASE-NOTES.txt
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/changes-report.html
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/index.html
> > (note some *relative* links are broken and the 2.10.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 2.9.0):
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2/japicmp.html
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-ant/japicmp.html
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-hdfs/japicmp.html
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-jackrabbit1/japicmp.html
> >
> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.1
Re: [VOTE] Release Apache Commons VFS Project 2.10.0 based on RC1
Hi Gary,
The build passed after ~13 mins on my old thinkpad
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.10, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-100-generic", arch: "amd64", family:
"unix"
But this called my attention
These are the artifacts and their hashes:
>
> ${commons.sha512list}
I think that's fine and it's just probably something missing somewhere to
configure the commons-release-plugin or parent to output the sha here.
But then I decided to take a better look at the archives just to be sure.
Are the bin files for VFS always nearly empty, with just three files?
https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/binaries/
Can't really recall, maybe it's because the module is a bit special or
multi-module... really can't recall seeing an archive with just three text
files...
The site reports also look messed up, e.g. empty japicmp, and exception
printed in
https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/pmd.html...
but I do recall needing some command to build multi-module components... so
maybe that's expected and reviewers need to build it locally?
Running out of time and also wanting to have a quick look at some Imaging
issues, so won't have time to dig deeper here, can you take a look at these
points and I will come back to continue the review if the above is fine,
please? It's also late here, so it could be just me sleepy doing something
wrong/silly.
Cheers!
On Sun, 10 Mar 2024 at 23:02, Gary Gregory wrote:
> We have fixed a few bugs and added some enhancements since Apache
> Commons VFS Project 2.9.0 was released, so I would like to release
> Apache Commons VFS Project 2.10.0.
>
> Apache Commons VFS Project 2.10.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1 (svn
> revision 67866)
>
> The Git tag commons-vfs-2.10.0-RC1 commit for this RC is
> 6aec37ad5fdcd4d0f2ca0330f310eb48a1585462 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=commit;h=6aec37ad5fdcd4d0f2ca0330f310eb48a1585462
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-vfs.git
> --branch
> commons-vfs-2.10.0-RC1 commons-vfs-2.10.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1702/org/apache/commons/commons-vfs2-project/2.10.0/
>
> These are the artifacts and their hashes:
>
> ${commons.sha512list}
>
>
> I have tested this with:
>
> mvn
>
> and
>
> mvn -V -Prelease -Ptest-deploy clean install -DskipTests && \
> mvn -V -Prelease -Ptest-deploy -P japicmp -P jacoco site deploy
> -DskipTests && \
> mvn -V -Prelease -Ptest-deploy site:stage
>
> Details of changes since 2.9.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/index.html
> (note some *relative* links are broken and the 2.10.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 2.9.0):
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-ant/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-hdfs/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-jackrabbit1/japicmp.html
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/commons-vfs2-jackrabbit2/japicmp.html
>
> Note that per the Java Language Specification, "Changes to the
> throws clause of methods or constructors do not break compatibility
> with pre-existing binaries; these clauses are checked only at compile
> time."; see
> https://docs.oracle.com/javase/specs/jls/se21/html/jls-13.html#jls-13.4.21
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.10.0-RC1/site/rat-report.html
>
> KEYS:
> https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can valida
Re: [VOTE] Release Apache Commons Configuration 2.10.0 based on RC1
+1 binding Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /opt/apache-maven-3.8.5 Java version: 17.0.10, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.15.0-100-generic", arch: "amd64", family: "unix" Tested, built, site generated, inspected one binary and one source from dist area, checked files in the tag, site reports look good. Thanks! On Mon, 11 Mar 2024 at 13:36, Gary Gregory wrote: > ping? > TY! > Gary > > On Sat, Mar 9, 2024 at 9:22 AM Gary Gregory > wrote: > > > > My +1 > > > > Gary > > > > On Wed, Mar 6, 2024 at 9:13 AM Gary Gregory > wrote: > > > > > > We have fixed a few bugs and added some enhancements since Apache > > > Commons Configuration 2.9.0 was released, so I would like to release > > > Apache Commons Configuration 2.10.0. > > > > > > Apache Commons Configuration 2.10.0 RC1 is available for review here: > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1 > > > (svn revision 67757) > > > > > > The Git tag commons-configuration-2.10.0-RC1 commit for this RC is > > > 67637998d398d79bf0cc6b830d72fadd8b53a355 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=67637998d398d79bf0cc6b830d72fadd8b53a355 > > > You may checkout this tag using: > > > git clone > https://gitbox.apache.org/repos/asf/commons-configuration.git > > > --branch commons-configuration-2.10.0-RC1 > > > commons-configuration-2.10.0-RC1 > > > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1701/org/apache/commons/commons-configuration2/2.10.0/ > > > > > > These are the artifacts and their hashes: > > > > > > #Release SHA-512s > > > #Wed Mar 06 14:01:58 UTC 2024 > > > > commons-configuration2-2.10.0-bin.tar.gz=4239219274c9e59f897870bf5cbf35210885b2812d74c15c79b1150cb1d0617ebcbc5417c99019addd75a14da67807fb78ca55efe2c8b48b6251584bde051d15 > > > > commons-configuration2-2.10.0-bin.zip=36ea60c2dc927ef06c02c6694278dcd799cb5c9a6902314061347c2ac787bf8dbb7c0fa59f6e39c298352e401b1e5dd82c5214a08354639cbf80044220750df5 > > > > commons-configuration2-2.10.0-bom.json=02fc0b438d1189035f7049bc010961e5309cab6cead5c37fabf2294556fa5e0a9fd223fe3f4a1564fc83e261500905d0795105906ce3fa71df0613f9b746b37c > > > > commons-configuration2-2.10.0-bom.xml=6bbda2ba6c2f0d7af8fd7fee93c71fb3f29a1fb220598cda8d3bbf2dfe19396364a63a6109b5418390da7b41f5e9a2eeaaae1f2fd4ce707d44bee38b19b23409 > > > > commons-configuration2-2.10.0-javadoc.jar=0494fb1bfeabaa246ad7507dc8464c78e76a0223767817123bdf8843aaf56030af512da9feac499fbfee79eaeb4d4cbe6749a28a679a531b0bc6301b711ddf3a > > > > commons-configuration2-2.10.0-sources.jar=bacf3d4538810e095fccdb51479b5739082c97a8fc2572b887b542cc6551583da64cd2104387d9872e990e02af0419e7986b532bb007ae710d118549a046df89 > > > > commons-configuration2-2.10.0-src.tar.gz=fa0959160b85a686886275624b9a7b8cb38480bc502cc930669d97c521cccddc4b2371a01bab85ecb2f88dfe6d1c22558b6525eeabc5b8cf9070163d24ff031b > > > > commons-configuration2-2.10.0-src.zip=e61c68feaddbfddf0985ba904ac5f73c4420b7fb7fdd173a83efd320673df7c3b652120ef6e513572a0c7c8bf5935d934187411b2ab124c5d03ba9072ab02ca3 > > > > commons-configuration2-2.10.0-test-sources.jar=bff3d3e30e1352c759e148641989b65129c235da70ec85b428c3876981b6bace7a00fd65f8b896ee649ba984869635a03ebe28f03226e62d9771db1373686ae9 > > > > commons-configuration2-2.10.0-tests.jar=1fe44c1f1c49e0846836141286d874ac641523bfac4403defc1af2ff8910660189a21c56a255f9e3fc2e4737e644259b23aa22a4bdaffd3296436c6cf1aea44e > > > > org.apache.commons_commons-configuration2-2.10.0.spdx.json=d6329228f13ca56b811ae6f2fae9fb9dd841d4efd6f0c52847728d8fbea44dac67ce1dbad9e766e4a237e06cd99d220cb76c64e3ef4898aa0047a4556411c37b > > > > > > I have tested this with: > > > > > > mvn > > > > > > and > > > > > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site > deploy > > > > > > Using: > > > > > > openjdk version "21.0.2" 2024-01-16 > > > OpenJDK Runtime Environment Homebrew (build 21.0.2) > > > OpenJDK 64-Bit Server VM Homebrew (build 21.0.2, mixed mode, sharing) > > > > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec > > > Java version: 21.0.2, vendor: Homebrew, runtime: > > > /usr/local/Cellar/openjdk/21.0.2/libexec/openjdk.jdk/Contents/Home > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "mac os x", version: "14.3.1", arch: "x86_64", family: "mac" > > > > > > Darwin 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:28:58 > > > PST 2023; root:xnu-10002.81.5~7/RELEASE_X86_64 x86_64 > > > > > > Details of changes since 2.9.0 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/site/changes-report.html > > > > > >
Re: [VOTE] Release Apache Commons Configuration 2.10.0 based on RC1
ping? TY! Gary On Sat, Mar 9, 2024 at 9:22 AM Gary Gregory wrote: > > My +1 > > Gary > > On Wed, Mar 6, 2024 at 9:13 AM Gary Gregory wrote: > > > > We have fixed a few bugs and added some enhancements since Apache > > Commons Configuration 2.9.0 was released, so I would like to release > > Apache Commons Configuration 2.10.0. > > > > Apache Commons Configuration 2.10.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1 > > (svn revision 67757) > > > > The Git tag commons-configuration-2.10.0-RC1 commit for this RC is > > 67637998d398d79bf0cc6b830d72fadd8b53a355 which you can browse here: > > > > https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=67637998d398d79bf0cc6b830d72fadd8b53a355 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-configuration.git > > --branch commons-configuration-2.10.0-RC1 > > commons-configuration-2.10.0-RC1 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1701/org/apache/commons/commons-configuration2/2.10.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Wed Mar 06 14:01:58 UTC 2024 > > commons-configuration2-2.10.0-bin.tar.gz=4239219274c9e59f897870bf5cbf35210885b2812d74c15c79b1150cb1d0617ebcbc5417c99019addd75a14da67807fb78ca55efe2c8b48b6251584bde051d15 > > commons-configuration2-2.10.0-bin.zip=36ea60c2dc927ef06c02c6694278dcd799cb5c9a6902314061347c2ac787bf8dbb7c0fa59f6e39c298352e401b1e5dd82c5214a08354639cbf80044220750df5 > > commons-configuration2-2.10.0-bom.json=02fc0b438d1189035f7049bc010961e5309cab6cead5c37fabf2294556fa5e0a9fd223fe3f4a1564fc83e261500905d0795105906ce3fa71df0613f9b746b37c > > commons-configuration2-2.10.0-bom.xml=6bbda2ba6c2f0d7af8fd7fee93c71fb3f29a1fb220598cda8d3bbf2dfe19396364a63a6109b5418390da7b41f5e9a2eeaaae1f2fd4ce707d44bee38b19b23409 > > commons-configuration2-2.10.0-javadoc.jar=0494fb1bfeabaa246ad7507dc8464c78e76a0223767817123bdf8843aaf56030af512da9feac499fbfee79eaeb4d4cbe6749a28a679a531b0bc6301b711ddf3a > > commons-configuration2-2.10.0-sources.jar=bacf3d4538810e095fccdb51479b5739082c97a8fc2572b887b542cc6551583da64cd2104387d9872e990e02af0419e7986b532bb007ae710d118549a046df89 > > commons-configuration2-2.10.0-src.tar.gz=fa0959160b85a686886275624b9a7b8cb38480bc502cc930669d97c521cccddc4b2371a01bab85ecb2f88dfe6d1c22558b6525eeabc5b8cf9070163d24ff031b > > commons-configuration2-2.10.0-src.zip=e61c68feaddbfddf0985ba904ac5f73c4420b7fb7fdd173a83efd320673df7c3b652120ef6e513572a0c7c8bf5935d934187411b2ab124c5d03ba9072ab02ca3 > > commons-configuration2-2.10.0-test-sources.jar=bff3d3e30e1352c759e148641989b65129c235da70ec85b428c3876981b6bace7a00fd65f8b896ee649ba984869635a03ebe28f03226e62d9771db1373686ae9 > > commons-configuration2-2.10.0-tests.jar=1fe44c1f1c49e0846836141286d874ac641523bfac4403defc1af2ff8910660189a21c56a255f9e3fc2e4737e644259b23aa22a4bdaffd3296436c6cf1aea44e > > org.apache.commons_commons-configuration2-2.10.0.spdx.json=d6329228f13ca56b811ae6f2fae9fb9dd841d4efd6f0c52847728d8fbea44dac67ce1dbad9e766e4a237e06cd99d220cb76c64e3ef4898aa0047a4556411c37b > > > > I have tested this with: > > > > mvn > > > > and > > > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site > > deploy > > > > Using: > > > > openjdk version "21.0.2" 2024-01-16 > > OpenJDK Runtime Environment Homebrew (build 21.0.2) > > OpenJDK 64-Bit Server VM Homebrew (build 21.0.2, mixed mode, sharing) > > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec > > Java version: 21.0.2, vendor: Homebrew, runtime: > > /usr/local/Cellar/openjdk/21.0.2/libexec/openjdk.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "14.3.1", arch: "x86_64", family: "mac" > > > > Darwin 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:28:58 > > PST 2023; root:xnu-10002.81.5~7/RELEASE_X86_64 x86_64 > > > > Details of changes since 2.9.0 are in the release notes: > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/RELEASE-NOTES.txt > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/site/changes-report.html > > > > Site: > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/site/index.html > > (note some *relative* links are broken and the 2.10.0 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 2.9.0): > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/site/japicmp.html > > > > RAT Report: > > > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.10.0-RC1/site/rat-report.html > > > > KEYS: > > https://downloads.apache.org/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close n
