[GitHub] commons-text issue #63: small-code-quality-improvements
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 You're welcome. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #63: small-code-quality-improvements
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 :-) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #63: small-code-quality-improvements
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 Well, of course! And much, much, much more in Java! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #63: small-code-quality-improvements
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 @chtompki If you want me to re-push any minor change to re-trigger the build just tell. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140548121
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,10 +614,7 @@ public static String swapCase(final String str) {
for (int index = 0; index < strLen;) {
final int oldCodepoint = str.codePointAt(index);
final int newCodePoint;
-if (Character.isUpperCase(oldCodepoint)) {
-newCodePoint = Character.toLowerCase(oldCodepoint);
-whitespace = false;
-} else if (Character.isTitleCase(oldCodepoint)) {
+if (Character.isUpperCase(oldCodepoint) ||
Character.isTitleCase(oldCodepoint) ) {
--- End diff --
Removed white space.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140528491
--- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java ---
@@ -46,6 +46,7 @@
* This constructor is public to permit tools that require a
JavaBean
* instance to operate.
*/
+@SuppressWarnings("squid:S1118")
--- End diff --
Removed SuppressWarnings anootations completely.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140526276
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,13 +615,11 @@ public static String swapCase(final String str) {
for (int index = 0; index < strLen;) {
final int oldCodepoint = str.codePointAt(index);
final int newCodePoint;
-if (Character.isUpperCase(oldCodepoint)) {
+if (Character.isUpperCase(oldCodepoint) ||
Character.isTitleCase(oldCodepoint) ) {
newCodePoint = Character.toLowerCase(oldCodepoint);
whitespace = false;
-} else if (Character.isTitleCase(oldCodepoint)) {
-newCodePoint = Character.toLowerCase(oldCodepoint);
-whitespace = false;
-} else if (Character.isLowerCase(oldCodepoint)) {
+}
+else if (Character.isLowerCase(oldCodepoint)) {
--- End diff --
No, you're right.
My mistake.
Corrected and commited the correction.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140525860
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,13 +615,11 @@ public static String swapCase(final String str) {
for (int index = 0; index < strLen;) {
final int oldCodepoint = str.codePointAt(index);
final int newCodePoint;
-if (Character.isUpperCase(oldCodepoint)) {
+if (Character.isUpperCase(oldCodepoint) ||
Character.isTitleCase(oldCodepoint) ) {
--- End diff --
The corresponding lines as the whole method are already completely covered
by existing Unit Tests.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140524746
--- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java ---
@@ -46,6 +46,7 @@
* This constructor is public to permit tools that require a
JavaBean
* instance to operate.
*/
+@SuppressWarnings("squid:S1118")
--- End diff --
Well, works with Sonaqube and Intellij IDEA.
Therefore I assume Eclipse and Netbeans recognizing it too.
I guess you want it to removed.
True?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-text/pull/63 small-code-quality-improvements Made small code quality improvements. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-text small-code-quality-improvements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit d5c840c19792b6c0dee03e0779ac791c73f296cf Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-09-20T18:03:24Z small-code-quality-improvements Made small code quality improvements. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r139785201 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java --- @@ -1,3 +1,19 @@ +/* --- End diff -- Created #31 which contains only license header corrections. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #31: add-missing-license-headers
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/31 add-missing-license-headers Added missing license headers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-imaging add-missing-license-headers Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-imaging/pull/31.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #31 commit 4468e18c5b4b1241477e5a023f22c616d42749fe Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-09-19T18:54:53Z add-missing-license-headers Added missing license headers. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132311416 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- Understand your point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #30: add-tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/30 Changes incorporated. Build working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132308184 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- Well, Equalsverifier checks equals and hashCode methods soroly. Therefore I considered to use it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132307800
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.tiff.taginfos;
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+import java.nio.ByteOrder;
+import org.apache.commons.imaging.formats.tiff.constants.TiffDirectoryType;
+
+/**
+ * Unit tests for class {@link TagInfoByteOrShort}.
+ *
+ * @date 2017-08-01
+ * @see TagInfoByteOrShort
+ *
+ **/
+public class TagInfoByteOrShortTest{
+
+ @Test
+ public void
testEncodeValueTaking1And1AndEncodeValueTaking1And1AndEncodeValueTaking1And1ReturningNonEmptyArrayOne()
{
+ TiffDirectoryType tiffDirectoryType =
TiffDirectoryType.EXIF_DIRECTORY_MAKER_NOTES;
+ TagInfoByteOrShort tagInfoByteOrShort = new TagInfoByteOrShort("r",
500, 500, tiffDirectoryType);
+ ByteOrder byteOrder = ByteOrder.BIG_ENDIAN;
+ short[] shortArray = new short[2];
+ byte[] byteArray = tagInfoByteOrShort.encodeValue(byteOrder,
shortArray);
+
+ assertArrayEquals(new byte[] {(byte)0, (byte)0, (byte)0, (byte)0},
byteArray);
+ }
+
+ @Test
+ public void
testEncodeValueTaking1And1AndEncodeValueTaking1And1AndEncodeValueTaking1And1ReturningNonEmptyArrayTwo()
{
--- End diff --
Renamed test methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132306981
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.pnm;
+
+import org.apache.commons.imaging.ImageReadException;
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+/**
+ * Unit tests for class {@link PgmFileInfo}.
+ *
+ * @date 2017-08-01
+ * @see PgmFileInfo
+ *
+ **/
+public class PgmFileInfoTest{
+
+ @Test(expected = ImageReadException.class)
--- End diff --
Reformatted code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132306138
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.pnm;
+
+import org.apache.commons.imaging.ImageReadException;
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+/**
+ * Unit tests for class {@link PgmFileInfo}.
+ *
+ * @date 2017-08-01
--- End diff --
Removed the class comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #60: additional-tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/60 You're welcome! Thought it would be preferred by comments. However, I will try to keep in mind. And be cautious what you wish. ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #30: add-tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/30 Checks failed due to Travis JDK crashing not due to problems in code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #60: additional-tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/60 Rechecked for blank lines and removed them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #60: additional-tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/60#discussion_r130609309
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI() {
assertEquals("", unescapeXSI("\\"));
}
+@Test
+public void testUnescapeEcmaScript() {
+assertNull("Should be null.",
StringEscapeUtils.unescapeEcmaScript(null));
+assertEquals("8lvc1u+6B#-I",
StringEscapeUtils.unescapeEcmaScript("8lvc1u+6B#-I"));
+assertEquals("",
+StringEscapeUtils.unescapeEcmaScript("")
+);
+assertEquals(">",
+StringEscapeUtils.unescapeEcmaScript(">")
+);
+}
+
+@Test
+public void testEscapeHtmlFour() {
+assertNull("Should be null.", StringEscapeUtils.escapeHtml3(null));
+assertEquals("a", StringEscapeUtils.escapeHtml3("a"));
+assertEquals("ba", StringEscapeUtils.escapeHtml3("a"));
+}
+
+@Test
+public void testUnescapeJson() {
+
+String jsonString =
"{\"age\":100,\"name\":\"kyong.com\n\",\"messages\":[\"msg 1\",\"msg 2\",\"msg
3\"]}";
+
+assertEquals("", StringEscapeUtils.unescapeJson(""));
+assertEquals(" ", StringEscapeUtils.unescapeJson(" "));
+assertEquals("a:b", StringEscapeUtils.unescapeJson("a:b"));
+assertEquals(jsonString,
StringEscapeUtils.unescapeJson(jsonString));
+}
+
+@Ignore("Bug found.")
+@Test
+public void testUnescapeJsonFoundBug() {
--- End diff --
Done.
See https://issues.apache.org/jira/browse/TEXT-100.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #30: add-tests
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/30 add-tests Added new Unit Tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-imaging add-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-imaging/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit d58de6e4e60f6f61ff8e8b37887b62914f8e19c3 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-31T23:03:41Z add-tests Added new Unit Tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #60: additional-tests
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-text/pull/60 additional-tests Added Unit Tests which cover previously untested code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-text additional-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 80ceb20f7a6106195f8975181170cec108428667 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-31T21:58:18Z additional-tests Added Unit Tests which cover previously untested code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #58: Add tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/58 You're welcome! Here we go regarding the exception detection code style. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #58: Add tests
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-text/pull/58 Add tests Created Unit Tests which cover previously uncovered lines and which I want to contribute. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-text add-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit acad335ca6c2c08644063ab0dc0be1e8233d430e Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-17T23:26:06Z add-some-Unit Tests Created Unit Tests to increase code coverage. commit 91039cb23f79921238afebbb4bff3ccbbd049e6a Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-17T23:46:59Z add-some-Unit Tests Added license header to new test class file. commit 04788b92e136e4e621c6b2799e2d86d52cd8f7d5 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-18T18:00:31Z add-some-Unit-Tests Reformatted various code artifacts. commit 12129b2beafc74f8f04957cc52b464a3eacdd3a9 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-24T18:01:34Z add-some-Unit-Tests Corrected required code fragments. commit b1c30952072da6a2e02d70fd3ace6c45a66e388e Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-26T19:00:16Z add-Tests Added Unit Tests that cover previously uncovered lines. commit 6b526277650f42f5805856371b33e5f37ce36286 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-26T19:05:00Z Merge remote-tracking branch 'upstream/master' into add-tests # Conflicts: # src/test/java/org/apache/commons/text/AlphabetConverterTest.java # src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java # src/test/java/org/apache/commons/text/StrBuilderTest.java # src/test/java/org/apache/commons/text/StrSubstitutorTest.java # src/test/java/org/apache/commons/text/similarity/LevenshteinDetailedDistanceTest.java # src/test/java/org/apache/commons/text/similarity/LevenshteinDistanceTest.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 You're welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 Obviously a problem occurred with Travis: > The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed. Retrying, 2 of 3. > Error: JAVA_HOME is not defined correctly. > We cannot execute /usr/lib/jvm/java-7-oracle/bin/java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129109286
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(),
new UpperCaseFormat()});
}
+@Test
+public void
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
+Map<String, FormatFactory> map = new HashMap<String,
FormatFactory>();
+ExtendedMessageFormat extendedMessageFormat = null;
--- End diff --
Corrected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129108740
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(),
new UpperCaseFormat()});
}
+@Test
+public void
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
+Map<String, FormatFactory> map = new HashMap<String,
FormatFactory>();
--- End diff --
Corrected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129106989
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(),
new UpperCaseFormat()});
}
+@Test
+public void
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
--- End diff --
Corrected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #29: Improve various unit tests style
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/29 You're welcome. However, have to get used to the importance of style topics yet ... Regarding the GreyScaleRoundTripTest: Yes. However, I thing or better guess it has to do with the amount of memory the Travis instance got supplied with. As its a free service I'd await it to have very less memory. And the specific test needs on my local machine quit a lot of memory as there is a JUnit theory inside. Therefore I guess a restart won't help. However again, I can only guess and I'am sure only owners can play around with CI instance settings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #28: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/28 Done in #29. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #29: Improve various unit tests style
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/29 Improve various unit tests style Code formatting changed as desired in #27 and #28. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-imaging improve-various-unit-tests-style Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-imaging/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit 5c8b1fcf92fdab412818b20175c617e3690fc060 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T20:12:46Z increase-code-coverage-one Added Unit Tests to increase code coverage. commit 471ac19d179a3eb167930f163117703cf7851aa8 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T21:00:31Z increase-code-coverage-one Added Unit Tests to increase code coverage. commit ff9adf8a87c3963dcc5a0f0be9668f1690f8fd45 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T21:14:08Z increase-code-coverage-one Fixed failing test. commit 489c8c33ad03e9f22762e0520670694f08659c57 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-15T21:39:54Z increase-code-coverage-one Fix directory hierarchy problem. commit d0c70bddfbeff23970702b339de938d6d2876d33 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-19T14:18:07Z improve-various-unit-tests-style Improved code formatting. commit 2e962d12698711f3614fe16ff75036c139d4d1fb Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-19T14:40:55Z improve-various-unit-tests-style Changed various blank lines and blanks as requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #28: Increase code coverage one
Github user TheRealHaui closed the pull request at: https://github.com/apache/commons-imaging/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 You mean the cases reported by the checkstyle plugin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/24#discussion_r128054680 --- Diff: src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java --- @@ -16,12 +16,14 @@ */ package org.apache.commons.collections4.iterators; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Comparator; -import java.util.List; - import org.apache.commons.collections4.comparators.ComparableComparator; +import org.junit.Test; + +import java.lang.reflect.Array; +import java.util.*; --- End diff -- Thanks for your advice! However, in general I've turned that feature in Intellij off. However again, I often reorganize imports manually to make the code more compact. And in the end often select the code developed by me and reformat it. Honestly, couldn't simply imagine that this is such a BIG THING in Open Source projects ... At first I thought some are joking or trying to play tricks on me ... Thanks for turning it back in this commit. Furthermore, if you want me to recheck this commit regarding this I'll do and push the changes. And I vow to try to keep this in mind and try to improve regarding this in Open Source projects. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 Reformatted requested code artifacts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-text/pull/56 add-some-Unit Tests I have created new Unit Tests which cover previously untested lines of code which I want to contribute. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-text add-some-Unit-Tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit acad335ca6c2c08644063ab0dc0be1e8233d430e Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-17T23:26:06Z add-some-Unit Tests Created Unit Tests to increase code coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127843760
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package org.apache.commons.imaging.formats.tiff.fieldtypes;
+
+import org.junit.Test;
+
+import java.nio.ByteOrder;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link FieldTypeByte}.
+ *
+ * @date 13.07.2017
+ * @see FieldTypeByte
+ *
+ **/
+public class FieldTypeByteTest{
+
+
+ @Test
+ public void testWriteDataWithNull() {
+
+ FieldTypeByte fieldTypeByte = FieldType.UNDEFINED;
+ ByteOrder byteOrder = ByteOrder.BIG_ENDIAN;
+
+ try {
+fieldTypeByte.writeData( null, byteOrder);
+fail("Expecting exception: Exception");
+ } catch(Exception e) {
+ assertEquals("Invalid data: null (null)",e.getMessage());
+ assertEquals(FieldTypeByte.class.getName(),
e.getStackTrace()[0].getClassName());
--- End diff --
No, you're not right!
Obviously, became already dizzy ...
The difference is that the approach with the stack trace - of course -
verifies which class the exception originated from.
The verification which exception was thrown and before more over if an
exception was thrown gets already verified in the catch clause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-collections/pull/24 Okay ... Now it's getting definitely a little bit wired. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-collections/pull/24 @jvz Thanks for your answer! I really haven't got any glue as I am not so much experienced with the habits here at Github and Open Source development conventions in general! However, now I know a little bit better. Beside that, we assume I suppose that it was NO accident! :-D As it's not my first contribution to Apache software too. Thanks for your answer again! Was a little bit annoyed about stumbling completely in the dark. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-collections/pull/24 What does it mean that the asfgit bot closed my pull request? Was it accepted or rejected? Or even worse - ignored completely? As there is no reaction in this pull request than from the bot I don't have a glue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Improvements made in #28. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #28: Increase code coverage one
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/28 Increase code coverage one Added various improvements to selected Unit Tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-imaging increase-code-coverage-one Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-imaging/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 127469460ab0ae0d12d35b4e0b5056af6debdea2 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T20:12:46Z increase-code-coverage-one Added Unit Tests to increase code coverage. commit 8e48087803a12106f1d8b88803a94557f031ec62 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T21:00:31Z increase-code-coverage-one Added Unit Tests to increase code coverage. commit 66b929d15a0f03441b58c7cadd42e58da831d5bb Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T21:14:08Z increase-code-coverage-one Fixed failing test. commit 10c8babeff6d0115d4fa440f226e716eaa3bbf79 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-15T21:39:54Z increase-code-coverage-one Fix directory hierarchy problem. commit 48a365d24fecf2a29213f16468d3c165f9f34d1e Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-17T16:51:29Z increase-code-coverage-one Changed date format in comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127775941
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package org.apache.commons.imaging.formats.tiff.fieldtypes;
+
+import org.junit.Test;
+
+import java.nio.ByteOrder;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link FieldTypeByte}.
+ *
+ * @date 13.07.2017
+ * @see FieldTypeByte
+ *
+ **/
+public class FieldTypeByteTest{
+
+
+ @Test
+ public void testWriteDataWithNull() {
+
+ FieldTypeByte fieldTypeByte = FieldType.UNDEFINED;
+ ByteOrder byteOrder = ByteOrder.BIG_ENDIAN;
+
+ try {
+fieldTypeByte.writeData( null, byteOrder);
+fail("Expecting exception: Exception");
+ } catch(Exception e) {
+ assertEquals("Invalid data: null (null)",e.getMessage());
+ assertEquals(FieldTypeByte.class.getName(),
e.getStackTrace()[0].getClassName());
--- End diff --
You're right.
Omitting the stack trace is definitely shorter and more intuitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127770670
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.formats.pnm;
+
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link PbmFileInfo}.
+ *
+ * @date 13.07.2017
+ * @see PbmFileInfo
+ *
+ **/
+public class PbmFileInfoTest{
+
+
+ @Test
+ public void testGetRGBThrowsIOException() throws IOException {
+
+ PbmFileInfo pbmFileInfo = new PbmFileInfo(2764, 354, true);
+ byte[] byteArray = new byte[2];
+ ByteArrayInputStream byteArrayInputStream = new
ByteArrayInputStream(byteArray);
+ byteArrayInputStream.read(byteArray);
+
+ try {
+pbmFileInfo.getRGB((InputStream) byteArrayInputStream);
--- End diff --
Changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127770520
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.formats.pnm;
+
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link PbmFileInfo}.
+ *
+ * @date 13.07.2017
+ * @see PbmFileInfo
+ *
+ **/
+public class PbmFileInfoTest{
+
+
+ @Test
+ public void testGetRGBThrowsIOException() throws IOException {
+
+ PbmFileInfo pbmFileInfo = new PbmFileInfo(2764, 354, true);
+ byte[] byteArray = new byte[2];
+ ByteArrayInputStream byteArrayInputStream = new
ByteArrayInputStream(byteArray);
--- End diff --
Changed to interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127769590
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java
---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.jpeg.segments;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link JfifSegment}.
+ *
+ * @date 13.07.2017
+ * @see JfifSegment
+ *
+ **/
+public class JfifSegmentTest{
+
+
+ @Test
+ public void testCreatesJfifSegment() {
+
+ byte[] byteArray = new byte[25];
+ JfifSegment jfifSegment = null;
+
+ try {
+jfifSegment = new JfifSegment((-2275), byteArray);
+fail("Expecting exception: Exception");
+ } catch(Throwable e) {
--- End diff --
Had to do with the fact that at the beginning the test class resided in a
different hierarchical folder structure than the original class ...
Corrected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127768831
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile(final byte src[]) throws
IOException {
}
final byte longArray[] = (baos.toByteArray());
-return new byte[][] { emptyArray, single, simple, zeroes,
longArray, };
+return new byte[][]{emptyArray, single, simple, zeroes,
longArray,};
+}
+
+@Test
--- End diff --
Yes, I know.
However, for what reason ever I experienced a lot of people preferring the
try/catch notation over the annotation approach.
That's why I write/wrote it this way.
In the hope to have to rewrite as less code in the end as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127768274
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.bmp;
+
+import org.junit.Test;
+
+import java.awt.image.BufferedImage;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link BmpWriterRgb}.
+ *
+ * @date 13.07.2017
+ * @see BmpWriterRgb
+ *
+ **/
+public class BmpWriterRgbTest{
+
+
+@Test
+public void testGetImageData() {
+
+BmpWriterRgb bmpWriterRgb = new BmpWriterRgb();
+BufferedImage bufferedImage = new BufferedImage(2, 2, 5);
+byte[] byteArray = bmpWriterRgb.getImageData(bufferedImage);
+
+assertEquals( 24, bmpWriterRgb.getBitsPerPixel() );
+assertEquals( 0, bmpWriterRgb.getPaletteSize() );
+assertEquals( 16, byteArray.length );
+assertEquals( "[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]",
Arrays.toString(byteArray) );
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 As the pull request is already closed shall I reopen another with the same name? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127761190
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.bmp;
+
+import org.junit.Test;
+
+import java.awt.image.BufferedImage;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link BmpWriterRgb}.
+ *
+ * @date 13.07.2017
--- End diff --
Good idea.
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 The CI fails due to the GrayscaleRountripTest which wasn't changed by me. As it runs locally on my side I consider the timeout problem issued by the Travis server to be a local problem of the Travis installation in conjunction with the \@Theory test that gets executed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 @garydgregory Here we go, directory naming problem solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Well, now I did a "mvn clean verify". It didn't complain about anything than for too less code coverage. However, I've checked what you claimed referring the "directory structure". You're right. That's quite or better very odd. I don't know how this happened right now exactly. But - of course - I'll fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Just sent it to you via email. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Just submitted my ICLA to secret...@apache.org. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 @garydgregory Thanks for your response. Looked over the secretary@ section ... Referring to your question if some of the tests were generated: I use a lot of tools on top of my IDE that advise and suggest me where and how to improve code. Some - like the Sonar plugin give advice concerning code improvements. Some like code coverage tools advice me which lines/branches of code are not covered through automated tests yet. And to those I sticked in the end here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging issue #27: Increase code coverage one
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 @garydgregory You're welcome. Where to send the pdf to? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-imaging pull request #27: Increase code coverage one
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/27 Increase code coverage one I have created Unit Tests to increase code coverage which I want to contribute. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-imaging increase-code-coverage-one Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-imaging/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit 127469460ab0ae0d12d35b4e0b5056af6debdea2 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T20:12:46Z increase-code-coverage-one Added Unit Tests to increase code coverage. commit 8e48087803a12106f1d8b88803a94557f031ec62 Author: Michael Hausegger <hausegger.mich...@googlemail.com> Date: 2017-07-13T21:00:31Z increase-code-coverage-one Added Unit Tests to increase code coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #33: add-some-Unit-Tests Added some Unit Tests to inc...
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-compress/pull/33 Link to the pull request: https://github.com/apache/commons-compress/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #35: Compress 412
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-compress/pull/35 Compress 412 Fixed Jira issue Compress 412: https://issues.apache.org/jira/browse/COMPRESS-412 You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-compress COMPRESS-412 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 2f45456527f2631ef8b4bb09aa0ad30afda02b5f Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-13T21:47:50Z add-some-Unit-Tests Added some Unit Tests to increase code coverage. commit 96ca8ceeddbd20ec38b9211260b4b91107b0be2d Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:12:20Z add-some-Unit-Tests Removed @author tags in comments. commit 5e5dc7f032ffb5b3818410e23d7881a8def46f3d Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:22:10Z add-some-Unit-Tests Removed test testGetValueThrowsNullPointerException in class ChecksumCalculatingInputStreamTest. Test represented a bug/defect which is going to be fixed in a different branch. commit be0f11f4dbffb5ca1f903a6f07de744687d303c3 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:38:00Z add-some-Unit-Tests Minor variable renaming. commit 3b46bb5dc3aeb3ca68062c10589e049c9eb8551d Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:44:40Z add-some-Unit-Tests Added myself as contributor to pom.xml as "requested" by Stefan Bodewig. commit a0e5dd80b9ec43c315021701f9c2334be45c6271 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T19:30:03Z COMPRESS-412 NullPointerException defect in ChecksumCalculatingInputStream#getValue() fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #33: add-some-Unit-Tests Added some Unit Tests to inc...
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-compress/pull/33 @bodewig Thank you for your kind response! Really appreciate that! Therefore I've made all the changes you requested/proposed. And of course added myself as a contributor as heavily requested by you. Really couldn't disappoint you regarding that special topic. :-) Furthermore I've created a Jira Task for the bespoken bug: https://issues.apache.org/jira/browse/COMPRESS-412 And fixed it in an own branch which I've commited, created tests for and pushed too. And which pull request I am going to link here in the next comment after I've created it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #33: add-some-Unit-Tests Added some Unit Tests to inc...
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-compress/pull/33 @bodewig Could you be so kind an review my contribution and - of course - most of all pull it into the code base. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #33: add-some-Unit-Tests Added some Unit Tests...
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-compress/pull/33 add-some-Unit-Tests Added some Unit Tests to increase code coverage. I have added some Unit Tests to increase code coverage and want to contribute them. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-compress add-some-Unit-Tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 2f45456527f2631ef8b4bb09aa0ad30afda02b5f Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-13T21:47:50Z add-some-Unit-Tests Added some Unit Tests to increase code coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
