[GitHub] commons-codec pull request #8: Add methods to DigestUtils to generate hex fr...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-codec/pull/8 Add methods to DigestUtils to generate hex from MessageDigest et. al. *This PR replaces #7 which was associated with the wrong issue number* This PR adds methods to DigestUtils to make it easy to generate hexadecimal strings from: - MessageDigest, - DigestInputStream, - DigestOutputStream. If the underlying digest supports ```clone()```, a clone is created before calling ```MessageDigest::digest``` to avoid resetting the state. If this cannot be done, the original digest is used. [Although clone is optional for MessageDigests, it seems to be almost universally supported (e.g. both the Sun and the IBM providers implement clone for their concrete digests) ] Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-codec CODEC-238 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-codec/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit e83cea6d26c0a74c4dcca8bc3e04f8ca7a1593b7 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-07-04T20:15:28Z Add methods to DigestUtils to generate a hexadecimal string from a MessageDigest, a DigestInputStream, or a DigestOutputStream. If the underlying digest implementation implements clone, a clone will be created before extracting the digest to avoid resetting it. Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-codec pull request #7: CODEC-224 Add methods to DigestUtils to gener...
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-codec/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-codec pull request #7: CODEC-224 Add methods to DigestUtils to gener...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-codec/pull/7 CODEC-224 Add methods to DigestUtils to generate hex from MessageDigests et al. This PR adds methods to DigestUtils to make it easy to generate hexadecimal strings from: - MessageDigest, - DigestInputStream, - DigestOutputStream. If the underlying digest supports ```clone()```, a clone is created before calling ```MessageDigest::digest``` to avoid resetting the state. If this cannot be done, the original digest is used. [Although clone is optional for MessageDigests, it seems to be almost universally supported (e.g. both the Sun and the IBM providers implement clone for their concrete digests) ] Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-codec CODEC-224 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-codec/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit e83cea6d26c0a74c4dcca8bc3e04f8ca7a1593b7 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-07-04T20:15:28Z Add methods to DigestUtils to generate a hexadecimal string from a MessageDigest, a DigestInputStream, or a DigestOutputStream. If the underlying digest implementation implements clone, a clone will be created before extracting the digest to avoid resetting it. Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #38: Testing hudson/jenkins (added contributor line t...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/38 Hudkins is happy. Happy happy Hudkins. So I will close this. Though I think some of the changes might actually be useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #38: Testing hudson/jenkins (added contributor...
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #36: COMPRESS-410 Remove Non-NIO character set...
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #36: COMPRESS-410 Remove Non-NIO character set...
GitHub user sesuncedu reopened a pull request: https://github.com/apache/commons-compress/pull/36 COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 1c9e1d8218ccd102567273eebdfba187ca545fc8 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T00:17:13Z COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 7fdfde85a8ab19c1f47efe4d3a9d0bad653182b2 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T16:45:44Z javadoc for HasCharset Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 651eae5399ba5b980257703b0ff98d7f7d89aee3 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-18T22:55:38Z Do better estimating of required buffer size for character encoding. If an unencodable character is found that requires output buffer expansion, scan buffer for all such characters, and attempt to expand buffer only once. Signed-off-by: Simon Spero <sesunc...@gmail.com> commit c9dfc31dbbbe099927a843197936b19e41f64d5c Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-11T22:48:42Z COMPRESS-407 Validate Block and Record Sizes Require block size >=0 that is multiple of 512 bytes. Use block size of 512 if one is not given. Require record size of 512 bytes. Deprecate constructors taking recordSize as parameter Modify tests to check for enforcement of record size == 512 Modify tests to check for correct overall length for different block sizes including PAX default, USTAR default, and unspecified. Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 15764594371bd8792b28d6cb415b9fcf1a9a60c2 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-13T21:47:50Z add-some-Unit-Tests Added some Unit Tests to increase code coverage. commit 9d81c8fcad4cbedcbe0cfd81a7af492800d1f726 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-15T18:27:48Z Redoing more buffer stuff Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 40736df64b5360f3ea3ad481ed81b47bd6650b30 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-15T18:27:48Z Redoing more buffer stuff Signed-off-by: Simon Spero <sesunc...@gmail.com> commit ead6bc6db225d8da124e37d67ecd081e3167d0ca Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-15T23:26:12Z More ByteBuffer methods for TarUtils Signed-off-by: Simon Spero <sesunc...@gmail.com> commit ab95c59eabdd283ec993bab7559b14864c1bcc57 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-16T20:24:12Z More ByteBuffer methods for TarUtils Signed-off-by: Simon Spero <sesunc...@gmail.com> commit a5db19a7ff84114033d3e8411e1a02497e0c1bd8 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:12:20Z add-some-Unit-Tests Removed @author tags in comments. commit 028b81cf85547edc7c54b6ab8c4395ac8c931c20 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:22:10Z add-some-Unit-Tests Removed test testGetValueThrowsNullPointerException in class ChecksumCalculatingInputStreamTest. Test represented a bug/defect which is going to be fixed in a different branch. commit 3908b334156c8f5a44ac3777d73adb80f0f973d2 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:38:00Z add-some-Unit-Tests Minor variable renaming. commit e5c2cce4f9b7f3aca848b3c608c77f5c7911a662 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T18:44:40Z add-some-Unit-Tests Added myself as contributor to pom.xml as "requested" by Stefan Bodewig. commit 04109a4d0924b7a79319e2ce382bc9fedea51a65 Author: Michael Hausegger <michael.hauseg...@tugraz.at> Date: 2017-06-16T20:16:06Z add-some-Unit-Tests Added additional Unit Tests. commit d7195a8bc61d151227540521b723ca580bd26dab Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T15:54:15Z Initial support for ByteBuffer header out
[GitHub] commons-compress issue #36: COMPRESS-410 Remove Non-NIO character set encode...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/36 reopening just to see if I didn't need to create a new branch and cherry pick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
GitHub user sesuncedu reopened a pull request: https://github.com/apache/commons-compress/pull/37 COMPRESS-410 - cherry picked to fix merging issues Remove non-NIO character set encoders. Fixes rebasing related issues in previous PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410-REDUX Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit 5a7ecf1a52d078cf005082c22d302ee9dcc2faf0 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T00:17:13Z COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit 0d41ac4) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 8125dccb36792fdcc83c7359d13ecade39852562 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T16:45:44Z javadoc for HasCharset Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit b70c7c2) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit cf3fa1ecd677b0d405e6018b91aa13f90ecb3b7c Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T00:17:13Z COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit 1987719) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit fb52100291ed3f69581f6a6dc5062a07e6d52ae8 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-18T22:55:38Z Do better estimating of required buffer size for character encoding. If an unencodable character is found that requires output buffer expansion, scan buffer for all such characters, and attempt to expand buffer only once. Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit aa30e21) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 9f76e86f71d36897895e1e5f49b522d12602f3cc Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-15T18:27:48Z Redoing more buffer stuff Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit 330c8b3) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit b92044a5fe95a8b6901040ee8b4c698c0a650e7d Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-18T23:27:42Z Test that ebcidic encoding is supported (making sure "%U" replacement strings don't use ascii encodings) Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit f1ec715) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit ae1e7b07f0e9483c07d33cf49862660cca3da81e Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-19T00:04:35Z Add licence comment to HasCharset Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 7e01241512f3f4059fa8d909bf7f98379ef4f373 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-19T00:10:46Z Resurrected HasCharset in the wrong place (not beyond the grave). Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 922051d1f2250256697a1b042f1f319b2950fc45 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-19T10:07:02Z Remove methods and change test + throw to assert to please the coveralls Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #38: Testing hudson/jenkins (added contributor...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/38 Testing hudson/jenkins (added contributor line to pom.xml so that there would be a change) They've been failing PRs on the checkout of master. Lets try this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress UPSTREAM-MASTER Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 878f0d7820738c0f79d9b5913c2d9cdf8fdd75d2 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-19T18:50:15Z added contributor line to pom.xml so that there would be a change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/37 There seems to be something amiss with Hudson (it can't checkout origin/master ... ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/37 COMPRESS-410 - cherry picked to fix merging issues Remove non-NIO character set encoders. Fixes rebasing related issues in previous PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410-REDUX Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit 5a7ecf1a52d078cf005082c22d302ee9dcc2faf0 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T00:17:13Z COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit 0d41ac4) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 8125dccb36792fdcc83c7359d13ecade39852562 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T16:45:44Z javadoc for HasCharset Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit b70c7c2) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit cf3fa1ecd677b0d405e6018b91aa13f90ecb3b7c Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T00:17:13Z COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit 1987719) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit fb52100291ed3f69581f6a6dc5062a07e6d52ae8 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-18T22:55:38Z Do better estimating of required buffer size for character encoding. If an unencodable character is found that requires output buffer expansion, scan buffer for all such characters, and attempt to expand buffer only once. Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit aa30e21) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 9f76e86f71d36897895e1e5f49b522d12602f3cc Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-15T18:27:48Z Redoing more buffer stuff Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit 330c8b3) Signed-off-by: Simon Spero <sesunc...@gmail.com> commit b92044a5fe95a8b6901040ee8b4c698c0a650e7d Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-18T23:27:42Z Test that ebcidic encoding is supported (making sure "%U" replacement strings don't use ascii encodings) Signed-off-by: Simon Spero <sesunc...@gmail.com> (cherry picked from commit f1ec715) Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #36: COMPRESS-410 Remove Non-NIO character set...
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #33: add-some-Unit-Tests Added some Unit Tests...
Github user sesuncedu commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/33#discussion_r122569687
--- Diff:
src/test/java/org/apache/commons/compress/compressors/xz/XZCompressorOutputStreamTest.java
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.commons.compress.compressors.xz;
+
+import org.junit.Test;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+
+import static org.junit.Assert.assertEquals;
+
+
+/**
+ * Unit tests for class {@link XZCompressorOutputStream}.
+ *
+ * @date 16.06.2017
+ * @see XZCompressorOutputStream
+ **/
+public class XZCompressorOutputStreamTest {
+
+
+@Test
+public void testWrite() throws IOException {
+
+ByteArrayOutputStream byteArrayOutputStream = new
ByteArrayOutputStream(4590);
+XZCompressorOutputStream xZCompressorOutputStream = new
XZCompressorOutputStream(byteArrayOutputStream);
+xZCompressorOutputStream.write(4590);
+
+assertEquals(24, byteArrayOutputStream.size());
+
assertEquals("\uFFFD7zXZ\u\u\u0004\uFFFD\u05B4F\u0002\u!\u0001\u0016\u\u\ut/\uFFFD",
byteArrayOutputStream.toString());
--- End diff --
It's usually not a good idea to convert an arbitrary byte array to a
string, as on can't rely on a specific default charset, and you may end up
with characters mangled /mapped.
I thinkThat hamcrest has array matchers; if not,
assertTrue(Arrays.equals(exp,act)) should be OK.
I can't remember if there's an assertEquals for byte[]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #36: COMPRESS-410 Remove Non-NIO character set...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/36 COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 1c9e1d8218ccd102567273eebdfba187ca545fc8 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-17T00:17:13Z COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for compatibility with existing behavior. Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #34: COMPRESS-405 : Add javadoc for FixedLengt...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/34 COMPRESS-405 : Add javadoc for FixedLengthBlockOutputStream. Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-405-REDUX Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit eb9aac4bf57c9d668c5f1d311b316481609522bc Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-15T19:25:43Z Add javadoc for FixedLengthBlockOutputStream. Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #28: COMPRESS-405 Create Fixed Length Block Ou...
Github user sesuncedu commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/28#discussion_r122259069
--- Diff:
src/main/java/org/apache/commons/compress/utils/FixedLengthBlockOutputStream.java
---
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.commons.compress.utils;
+
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+import java.nio.channels.ClosedChannelException;
+import java.nio.channels.WritableByteChannel;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+public class FixedLengthBlockOutputStream extends OutputStream implements
WritableByteChannel,
+AutoCloseable {
--- End diff --
Huh. Not only can I think of no good reason, I can't think of what I was
thinking.
It might be because I've been writing a bunch of stuff that I wanted to
use with try-with-resources and which didn't have it (reactive stuff, and stuff
that wrapped closeables), so I added AC automatically when I implemented close
:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #32: Enable maven cache for in travis config
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/32 Enable maven cache for in travis config Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress enable-travis-cache Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 665f2e3351e3d5d3f2c82c23cd6a81adc7be25df Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-13T21:22:23Z Enable maven cache for in travis config Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #27: COMPRESS-400
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #31: COMPRESS-400 It should be possible for us...
GitHub user sesuncedu opened a pull request:
https://github.com/apache/commons-compress/pull/31
COMPRESS-400 It should be possible for users to create and access extra PAX
headers to tar archives
Add extra header map to tar archive entry.
Move PAX header processing code from TarArchiveInputStream to
TarAchiveEntry.
Use same code for processing user supplied extra headers - thus setting
"size "changes the value of getSize().
Add any extra PAX headers to output map when putting entry in
TarArchiveOutputStream.
Add simple tests for getting/setting xattr, setting "size", and round
tripping.
Signed-off-by: Simon Spero <sesunc...@gmail.com>
(cherry picked from commit 1d9b3c8)
Signed-off-by: Simon Spero <sesunc...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-400-REDUX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
commit 3a1d29e2474519c3930742cf3000b6323bb426a8
Author: Simon Spero <sesunc...@gmail.com>
Date: 2017-06-05T19:58:27Z
COMPRESS-400 It should be possible for users to create and access extra PAX
headers to tar archives
Add extra header map to tar archive entry.
Move PAX header processing code from TarArchiveInputStream to
TarAchiveEntry.
Use same code for processing user supplied extra headers - thus setting
"size "changes the value of getSize().
Add any extra PAX headers to output map when putting entry in
TarArchiveOutputStream.
Add simple tests for getting/setting xattr, setting "size", and round
tripping.
Signed-off-by: Simon Spero <sesunc...@gmail.com>
(cherry picked from commit 1d9b3c8)
Signed-off-by: Simon Spero <sesunc...@gmail.com>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #30: COMPRESS-407 - Validate Block and Record ...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/30 COMPRESS-407 - Validate Block and Record Sizes and use 512 blocks if none given. This PR includes the commits for COMPRESS-405 and COMPRESS-406. The new content is https://github.com/sesuncedu/commons-compress/commit/d754d8922a507da887aba70292aa650823a7a38c if cherry-picking. The rest of the block size changes will be all be based on here, since they become less separable You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-407 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit 7f051c9cfe047289045618db3327fca018a25daf Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-11T16:21:16Z COMPRESS-405 Create Fixed Length Block OutputStream / WriteableByteChannel This commit provides a new class that is an OutputStream and WritableByteChannel, and which supports writing to a destination output stream or byte channel in fixed size blocks. Internally, all writes are made using NIO. If the destination is a FileOutputStream the existing channel is used. Other OutputStreams are wrapped with a custom channel implementation which does not attempt to split writes into chunks. If the target channel fails to write the entire buffer in a single call, an exception is thrown, Incoming data is accumulated in a ByteBuffer until a complete block is ready, then written to the target. If WritableByteChannel::write(ByteBuffer) method is called, the code will attempt to avoid copying data into the buffer if the buffer is empty, and a complete block is available. The class and UnitTest are in compress/utils . This is a MINOR change - thus the version number for the package should be increated to 1.15.0. Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 85a22f05b934cf82ddf271d4d800a001738b55d5 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-11T16:29:04Z Added License Headers for the rat Signed-off-by: Simon Spero <sesunc...@gmail.com> commit d754d8922a507da887aba70292aa650823a7a38c Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-11T22:48:42Z COMPRESS-407 Validate Block and Record Sizes Require block size >=0 that is multiple of 512 bytes. Use block size of 512 if one is not given. Require record size of 512 bytes. Deprecate constructors taking recordSize as parameter Modify tests to check for enforcement of record size == 512 Modify tests to check for correct overall length for different block sizes including PAX default, USTAR default, and unspecified. Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #29: COMPRESS-406 BUILDING.md is missing license head...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/29 Pleasing the rat has awakened the coveralls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #29: COMPRESS-406 BUILDING.md is missing licen...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/29 COMPRESS-406 BUILDING.md is missing license header Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-406 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit 135b0b7743633427b09c6c7c90d7809749c9a2fa Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-11T16:43:36Z COMPRESS-406 BUILDING.md is missing license header Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #28: COMPRESS-405 Create Fixed Length Block Ou...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/28 COMPRESS-405 Create Fixed Length Block OutputStream / WriteableByteChannel This PR provides a new class that is an OutputStream and WritableByteChannel, and which supports writing to a destination output stream or byte channel in fixed size blocks. Internally, all writes are made using NIO. If the destination is a FileOutputStream the existing channel is used. Other OutputStreams are wrapped with a custom channel implementation which does not attempt to split writes into chunks. If the target channel fails to write the entire buffer in a single call, an exception is thrown, Incoming data is accumulated in a ByteBuffer until a complete block is ready, then written to the target. If WritableByteChannel::write(ByteBuffer) method is called, the code will attempt to avoid copying data into the buffer if the buffer is empty, and a complete block is available. **The class and UnitTest are in compress/utils . This is a MINOR change - thus the version number for the package should be increated to 1.15.0** Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-405 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 7f051c9cfe047289045618db3327fca018a25daf Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-11T16:21:16Z COMPRESS-405 Create Fixed Length Block OutputStream / WriteableByteChannel This commit provides a new class that is an OutputStream and WritableByteChannel, and which supports writing to a destination output stream or byte channel in fixed size blocks. Internally, all writes are made using NIO. If the destination is a FileOutputStream the existing channel is used. Other OutputStreams are wrapped with a custom channel implementation which does not attempt to split writes into chunks. If the target channel fails to write the entire buffer in a single call, an exception is thrown, Incoming data is accumulated in a ByteBuffer until a complete block is ready, then written to the target. If WritableByteChannel::write(ByteBuffer) method is called, the code will attempt to avoid copying data into the buffer if the buffer is empty, and a complete block is available. The class and UnitTest are in compress/utils . This is a MINOR change - thus the version number for the package should be increated to 1.15.0. Signed-off-by: Simon Spero <sesunc...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #26: COMPRESS-399 OSGI package versions are overly pe...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/26 A key point is that these files that are not modified for each release. They are only changed when the package version changes, which only happens when the API changes (and was supposed to). If the package API does not change, then the package version should _not_ be modified. Also, changing the package version number happens in the development phase of the lifecycle rather than the release phase. On Mon, Jun 5, 2017, 6:26 PM Jörg Schaible <notificati...@github.com> wrote: > ... and again we have a bunch of files that we have to modify for every > release. > > â > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-compress/pull/26#issuecomment-306328119>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAZIGyAYQTfOaV8sY3a7k0YDqMx1qsoaks5sBICggaJpZM4NukX5> > . > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #27: COMPRESS-400
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/27 COMPRESS-400 Add extra header map to tar archive entry. Move PAX header processing code from TarArchiveInputStream to TarAchiveEntry. Use same code for processing user supplied extra headers - thus setting "size "changes the value of getSize(). Add any extra PAX headers to output map when putting entry in TarArchiveOutputStream. Add simple tests for getting/setting xattr, setting "size", and round tripping. This PR uses COMPRESS-399 as a base. To make it easier to cherry-pick + rebase the PR has been split in two. 1d9b3c88455caceca81f0ff6b7eca0958c631359 contains just the code changes and test changes, and does not bump the minor package version . This will cause the bundle:baseline verify goal in 399 to break the build. 82405c13bd2688817108d3f2854387b3417a764d increases the package minor version to the correct value You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit 109b14915cf594e5c2031e58d6f2fd0595fc184f Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-02T17:25:02Z COMPRESS-399 OSGI package versions are overly pessimistic, except when they're overly optimisic Add packageinfo files for per-package version settings. Initialize to 1.14 Copy packageinfo files in resource phase. Use latest bundle plugin. Remove superflous headers from manifest. Pretty-print the manifest. Add bundle:baseline to the verify phase Add bundle:baseline-report to the site phase To change the base version from default (i.e. previous release) set comparisonVersion property Change travis build goal to verify Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 3653a2e19b51c9bd894e3928ed959c0132afd9b6 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-02T17:37:53Z Default rat doesn't ignore packageinfo One line of non copyrightable material does not need the license header :) commit 27b65778eee34805838a0e43777b98fb6714dc2a Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-05T15:55:18Z Replace packageinfo files with annotated package-info.java as source of version info. Add build time dependency on org,osgi.annotation for Version annotation. Remove resource copy. Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 1d9b3c88455caceca81f0ff6b7eca0958c631359 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-05T19:58:27Z COMPRESS-400 It should be possible for users to create and access extra PAX headers to tar archives Add extra header map to tar archive entry. Move PAX header processing code from TarArchiveInputStream to TarAchiveEntry. Use same code for processing user supplied extra headers - thus setting "size "changes the value of getSize(). Add any extra PAX headers to output map when putting entry in TarArchiveOutputStream. Add simple tests for getting/setting xattr, setting "size", and round tripping. This PR uses COMPRESS-399 as a base. To make it easier to cherry-pick, this commit does not bump the minor package version; this will cause the baseline verify stage in 399 to break the build, since the API has changed in a backwards compatible fashion A separate commit increases the package minor version. Signed-off-by: Simon Spero <sesunc...@gmail.com> commit 82405c13bd2688817108d3f2854387b3417a764d Author: Simon Spero <sesunc...@gmail.com> Date: 2017-06-05T20:02:32Z Increase the minor package version for org.apache.commons.compress.archivers.tar to 1.15.0 to reflect backwards compatible changes to API: [INFO] < org.apache.commons.compress.archivers.tar minor 1.15.0 1.14.0 1.15.0 - [INFO] < class org.apache.commons.compress.archivers.tar.TarArchiveEntry [INFO] + method addPaxHeader(java.lang.String,java.lang.String) [INFO] + method addXattr(java.lang.String,java.lang.String) [INFO] + method clearExtraPaxHeaders() [INFO] + method getExtraPaxHeader(java.lang.String) [INFO] + return java.lang.String [INFO] + method getExtraPaxHeaders() [INFO] + return java.util.Map<Ljava.lang.String;Ljava.lang.String;> [INFO] + method getXattr(java.lang.String) [INFO] + return java.lang.String
[GitHub] commons-compress issue #26: COMPRESS-399 OSGI package versions are overly pe...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/26 The packageinfo files are in the source tree because they're source files, and provide metadata for the package. You can also use a package annotation on package-info.java, which puts a Class Retention annotation on the packages package-info.class. Examples: https://github.com/apache/felix/blob/trunk/dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/api/packageinfo https://github.com/apache/felix/blob/trunk/converter/ converter/src/main/java/org/apache/felix/converter/dto/package-info.java (Requires provided / compileOnly dependency on the osgi annotation bundle). On Fri, Jun 2, 2017 at 6:11 PM, Jörg Schaible <notificati...@github.com> wrote: > Why are those packageinfo files in src/main/java instead of > src/main/resources as it is common in Maven builds? Now you have to > configure explicitly these files as resources. On top of it, I don't like > the idea of modifying these files for each release manually. I'd look for a > solution that generates these files automatically into > target/generated-resources. Such a plugin should not be difficult. > > â > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-compress/pull/26#issuecomment-305920965>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAZIGza5aeOCDCCwJhvZ1jufn0jZ7BkWks5sAIitgaJpZM4NukX5> > . > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress issue #26: COMPRESS-399 OSGI package versions are overly pe...
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/26 It's difficult to generalize, since the packageinfo files have to be put in with the source code. Since a export header parameter with an explicit version overrides packageinfo and annotations, defaults can be problematic. Adding the resource copy and rat excludes is good, as is keeping up with the felix bundle versions. Adding a bundle:baseline goal to the parent verify phase is a really, really good idea if bundle headers are going to be generated. Package versions MUST follow semver (bundle versions also, but to a lesser extent). Maven versions theoretically ought to too, but dependencies are usually point versions not ranges. (Of course, there's always guava, where version is a major release, except for bug fixes, which are minor.) The real work is getting the api and implementation(s) properly modularized so that the api isn't always affected by implementation changes. At least jigsaw has gotten people to start thinking about modules. Not always sensibly On Jun 2, 2017 2:38 PM, "Gary Gregory" <notificati...@github.com> wrote: > Hi, > > Should any of this work also apply to commons-parent? > > Gary > > â > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-compress/pull/26#issuecomment-305876373>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAZIG7Xv74lnd98TXW3kzw9huxG2US7Rks5sAFaZgaJpZM4NukX5> > . > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #26: COMPRESS-399 OSGI package versions are ov...
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/26 COMPRESS-399 OSGI package versions are overly pessimistic, except when they're overly optimisic - Add packageinfo files for per-package version settings. - Initialize to 1.14 - Copy packageinfo files in resource phase. - Use latest bundle plugin. - Remove headers from generate manifest. - Pretty-print the manifest. - Add bundle:baseline to the verify phase - Add bundle:baseline-report to the site phase - To change the base version from default (i.e. previous release) set comparisonVersion property - Change travis build to use verify instead of test Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-399 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
