Re: [COMPRESS] Travis build fail with JDK14
On 2020-05-14, Peter Lee wrote: > Unfortunately it seems commons-compress can not build on Java14. Maybe we > should provide a statement about this in README or somewhere else? Done. Also I added something to the "known limitations" page and will re-generate the website. Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COMPRESS] Travis build fail with JDK14
> adding a unpassable check in travis will makes all pull requests/commit > return builld failure, which will hide problem and make checker's life hard. I think this is a good solution for now. > If commons-compress doesn't support Java 14, that should likely be > stated somewhere clearly and then JDK 14 could be removed from Travis Unfortunately it seems commons-compress can not build on Java14. Maybe we should provide a statement about this in README or somewhere else? On Thu, May 14, 2020 at 12:36 AM Xeno Amess wrote: > I created a pr. > https://github.com/apache/commons-compress/pull/100 > > Xeno Amess 于2020年5月14日周四 上午12:00写道： > > > my opinion: until you are sure the master can pass jdk14, move it to > > [allow failure]. > > here is an example. > > > > > https://github.com/apache/commons-vfs/commit/249d1dc9fb3f2bd5209aaa299c4ed61414f1fd78#diff-354f30a63fb0907d4ad57269548329e3 > > > > > > adding a unpassable check in travis will makes all pull requests/commit > > return builld failure, which will hide problem and make checker's life > hard. > > > > Stefan Bodewig 于2020年5月13日周三 下午10:46写道： > > > >> On 2020-05-13, Peter Lee wrote: > >> > >> > Hi,all > >> > >> > The travis build of Compress is failing now cause the openjdk14 was > >> added > >> > to travis.yml recently. The reason is the Pack200 was removed from > JDK14 > >> > and there was a discussion about it in January. Emmanuel is working on > >> his > >> > replacement project(https://github.com/pack200/pack200) but not > >> finished > >> > yet. Seems we have no good replacement for now. > >> > >> > I'm thinking we should disable openjdk14 in travis before we have > find a > >> > solution for this. WDYT? > >> > >> I'm fine with disabling the travis build for now. > >> > >> Had a quick look through JIRA as I was totally sure there must be an > >> issue tracking this, but it seems I haven't created any. Anyway with the > >> last release announcement I promised we'd deal with JDK14 for the next > >> release - one way or the other. :-) > >> > >> Stefan > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> >
Re: [COMPRESS] Travis build fail with JDK14
I created a pr. https://github.com/apache/commons-compress/pull/100 Xeno Amess 于2020年5月14日周四 上午12:00写道： > my opinion: until you are sure the master can pass jdk14, move it to > [allow failure]. > here is an example. > > https://github.com/apache/commons-vfs/commit/249d1dc9fb3f2bd5209aaa299c4ed61414f1fd78#diff-354f30a63fb0907d4ad57269548329e3 > > > adding a unpassable check in travis will makes all pull requests/commit > return builld failure, which will hide problem and make checker's life hard. > > Stefan Bodewig 于2020年5月13日周三 下午10:46写道： > >> On 2020-05-13, Peter Lee wrote: >> >> > Hi,all >> >> > The travis build of Compress is failing now cause the openjdk14 was >> added >> > to travis.yml recently. The reason is the Pack200 was removed from JDK14 >> > and there was a discussion about it in January. Emmanuel is working on >> his >> > replacement project(https://github.com/pack200/pack200) but not >> finished >> > yet. Seems we have no good replacement for now. >> >> > I'm thinking we should disable openjdk14 in travis before we have find a >> > solution for this. WDYT? >> >> I'm fine with disabling the travis build for now. >> >> Had a quick look through JIRA as I was totally sure there must be an >> issue tracking this, but it seems I haven't created any. Anyway with the >> last release announcement I promised we'd deal with JDK14 for the next >> release - one way or the other. :-) >> >> Stefan >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>
Re: [COMPRESS] Travis build fail with JDK14
my opinion: until you are sure the master can pass jdk14, move it to [allow failure]. here is an example. https://github.com/apache/commons-vfs/commit/249d1dc9fb3f2bd5209aaa299c4ed61414f1fd78#diff-354f30a63fb0907d4ad57269548329e3 adding a unpassable check in travis will makes all pull requests/commit return builld failure, which will hide problem and make checker's life hard. Stefan Bodewig 于2020年5月13日周三 下午10:46写道： > On 2020-05-13, Peter Lee wrote: > > > Hi,all > > > The travis build of Compress is failing now cause the openjdk14 was added > > to travis.yml recently. The reason is the Pack200 was removed from JDK14 > > and there was a discussion about it in January. Emmanuel is working on > his > > replacement project(https://github.com/pack200/pack200) but not finished > > yet. Seems we have no good replacement for now. > > > I'm thinking we should disable openjdk14 in travis before we have find a > > solution for this. WDYT? > > I'm fine with disabling the travis build for now. > > Had a quick look through JIRA as I was totally sure there must be an > issue tracking this, but it seems I haven't created any. Anyway with the > last release announcement I promised we'd deal with JDK14 for the next > release - one way or the other. :-) > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [COMPRESS] Travis build fail with JDK14
On 2020-05-13, Peter Lee wrote: > Hi,all > The travis build of Compress is failing now cause the openjdk14 was added > to travis.yml recently. The reason is the Pack200 was removed from JDK14 > and there was a discussion about it in January. Emmanuel is working on his > replacement project(https://github.com/pack200/pack200) but not finished > yet. Seems we have no good replacement for now. > I'm thinking we should disable openjdk14 in travis before we have find a > solution for this. WDYT? I'm fine with disabling the travis build for now. Had a quick look through JIRA as I was totally sure there must be an issue tracking this, but it seems I haven't created any. Anyway with the last release announcement I promised we'd deal with JDK14 for the next release - one way or the other. :-) Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [COMPRESS] Travis build fail with JDK14
I think there is a bigger question here - Does commons-compress support Java 14? If it does, then the relevant code should be updated to raise an error on JDK 14 which should be expected in the test if on JDK 14. If commons-compress doesn't support Java 14, that should likely be stated somewhere clearly and then JDK 14 could be removed from Travis On Wed, 13 May 2020 at 14:28, Peter Lee wrote: > > Hi,all > > The travis build of Compress is failing now cause the openjdk14 was added > to travis.yml recently. The reason is the Pack200 was removed from JDK14 > and there was a discussion about it in January. Emmanuel is working on his > replacement project(https://github.com/pack200/pack200) but not finished > yet. Seems we have no good replacement for now. > > I'm thinking we should disable openjdk14 in travis before we have find a > solution for this. WDYT? -- Adam Retter skype: adam.retter tweet: adamretter http://www.adamretter.org.uk - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[COMPRESS] Travis build fail with JDK14
Hi,all The travis build of Compress is failing now cause the openjdk14 was added to travis.yml recently. The reason is the Pack200 was removed from JDK14 and there was a discussion about it in January. Emmanuel is working on his replacement project(https://github.com/pack200/pack200) but not finished yet. Seems we have no good replacement for now. I'm thinking we should disable openjdk14 in travis before we have find a solution for this. WDYT?
