[GitHub] commons-cli pull request #10: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/commons-cli/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-cli pull request #10: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-04-17 Thread schaumb
GitHub user schaumb opened a pull request:

https://github.com/apache/commons-cli/pull/10

[CLI-274] implement EXISTING_FILE_VALUE type handler

when the user pass option type FileInputStream.class, I think the expected 
behavior for the return value is the same type, which the user passed.
Before this there was no check whether the file exist.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/schaumb/commons-cli patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-cli/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit abfcc8211f529ab75f3b3edd4a827e484109eb0b
Author: Bela Schaum 
Date:   2017-04-17T11:45:09Z

implement EXISTING_FILE_VALUE type handler

when the user pass option type FileInputStream.class, I think the expected 
behavior for the return value is the same type, which the user passed.
Before this there was no check whether the file exist.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org