[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-07-21 Thread kinow
Github user kinow commented on the issue:

https://github.com/apache/commons-collections/pull/42
  
I was confused too. Maybe it was fixed recently, or it was run with the IDE 
or with some other setting.

Thanks for updating the issue so quickly. And feel free to submit other 
pull requests :-)


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-07-21 Thread sfuhrm
Github user sfuhrm commented on the issue:

https://github.com/apache/commons-collections/pull/42
  
Hi @kinow 

well I'm a little bit confused, neither

```
mvn checkstyle:checkstyle
```

nor 

```
mvn clean site
```

bring an error. I'm closing this.

Thank you!



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-07-21 Thread kinow
Github user kinow commented on the issue:

https://github.com/apache/commons-collections/pull/42
  
Hi @sfuhrm , thanks for your contribution.

I had a look running `mvn clean site` against master, and checkstyle report 
is empty. How did you get the warnings?

Note that the project's settings are defined in `src/conf/checkstyle.xml`, 
and at the pom.xml I believe it's using checkstyle 3.0.0 in master.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-06-13 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-collections/pull/42
  

[![Coverage 
Status](https://coveralls.io/builds/17473023/badge)](https://coveralls.io/builds/17473023)

Coverage remained the same at 87.386% when pulling 
**2a9a1105428fc37a1dea4b50baac3c5fce796b49 on sfuhrm:CheckStyleFixes** into 
**8f9e66fbf060b219ca810e7b8d1153699e410237 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org