[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/24#discussion_r128054680 --- Diff: src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java --- @@ -16,12 +16,14 @@ */ package org.apache.commons.collections4.iterators; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Comparator; -import java.util.List; - import org.apache.commons.collections4.comparators.ComparableComparator; +import org.junit.Test; + +import java.lang.reflect.Array; +import java.util.*; --- End diff -- Thanks for your advice! However, in general I've turned that feature in Intellij off. However again, I often reorganize imports manually to make the code more compact. And in the end often select the code developed by me and reformat it. Honestly, couldn't simply imagine that this is such a BIG THING in Open Source projects ... At first I thought some are joking or trying to play tricks on me ... Thanks for turning it back in this commit. Furthermore, if you want me to recheck this commit regarding this I'll do and push the changes. And I vow to try to keep this in mind and try to improve regarding this in Open Source projects. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/24#discussion_r127966801 --- Diff: src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java --- @@ -16,12 +16,14 @@ */ package org.apache.commons.collections4.iterators; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Comparator; -import java.util.List; - import org.apache.commons.collections4.comparators.ComparableComparator; +import org.junit.Test; + +import java.lang.reflect.Array; +import java.util.*; --- End diff -- This looks like you're using IntelliJ with the default settings. I've had to disable the change to `import package.name.*` for 5 or more from the same location. I would try to turn that off. Further it may not run on save as some folks suggested in https://github.com/apache/commons-text/pull/56 I think it runs when you do a file format command or "reorganize imports" command. Regardless I'll try to change it back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
