[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-rdf/pull/42


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[wikier]

Github user wikier commented on a diff in the pull request:

https://github.com/apache/commons-rdf/pull/42#discussion_r147886874
  
--- Diff: 
jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java ---
@@ -149,7 +149,7 @@ public long size() {
 @Override
 public String toString() {
 final StringWriter sw = new StringWriter();
-RDFDataMgr.write(sw, graph, Lang.NT);
--- End diff --

Attribute already renamed in `master` (see 151a8ea). 

So, please, rebase this PR to the current `HEAD` so we can ship this patch 
in the imminent `0.5.0` release. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[wikier]

Github user wikier commented on a diff in the pull request:

https://github.com/apache/commons-rdf/pull/42#discussion_r147883486
  
--- Diff: 
jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java ---
@@ -149,7 +149,7 @@ public long size() {
 @Override
 public String toString() {
 final StringWriter sw = new StringWriter();
-RDFDataMgr.write(sw, graph, Lang.NT);
--- End diff --

I'd keep both, parameter and attribute, as `datasetGraph`.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[wikier]

Github user wikier commented on a diff in the pull request:

https://github.com/apache/commons-rdf/pull/42#discussion_r147883290
  
--- Diff: 
jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java ---
@@ -7,7 +7,7 @@
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
- * http://www.apache.org/licenses/LICENSE-2.0
--- End diff --

Please, remove this changeset from the PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[christopher-johnson]

Github user christopher-johnson commented on a diff in the pull request:

https://github.com/apache/commons-rdf/pull/42#discussion_r147875892
  
--- Diff: 
jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java ---
@@ -149,7 +149,7 @@ public long size() {
 @Override
 public String toString() {
 final StringWriter sw = new StringWriter();
-RDFDataMgr.write(sw, graph, Lang.NT);
--- End diff --

right.  would something like this be ok?  
```java
private final DatasetGraph dg;

JenaDatasetImpl(final DatasetGraph datasetGraph, final UUID salt) {
this.dg = datasetGraph;
this.salt = salt;
this.factory = new JenaRDF(salt);
}
```
so `dg` is the private variable, and `datasetGraph` is only used in the 
constructor to match InternalJenaFactory.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[afs]

Github user afs commented on a diff in the pull request:

https://github.com/apache/commons-rdf/pull/42#discussion_r147701690
  
--- Diff: 
jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java ---
@@ -7,7 +7,7 @@
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
- * http://www.apache.org/licenses/LICENSE-2.0
--- End diff --

Accidental reformat of the license.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[afs]

Github user afs commented on a diff in the pull request:

https://github.com/apache/commons-rdf/pull/42#discussion_r147701840
  
--- Diff: 
jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java ---
@@ -149,7 +149,7 @@ public long size() {
 @Override
 public String toString() {
 final StringWriter sw = new StringWriter();
-RDFDataMgr.write(sw, graph, Lang.NT);
--- End diff --

It would good to rename graph (throughout the class) as `datasetGraph` or 
some such. It's not a graph.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

[christopher-johnson]

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/commons-rdf/pull/42

COMMONSRDF-66:  fixes RIOT exception in JenaDatasetImpl 

 Lang.NT is not supported by registryDataset.  Opts for Lang.NQUADS as a 
default replacement.
adds test

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pan-dora/commons-rdf commonsrdf-66

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rdf/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit e627ba43597a5f20a985bd9373d030d9797fc1e7
Author: Christopher Johnson 
Date:   2017-10-30T12:51:45Z

fixes RIOT exception thrown by JenaDatasetImpl.toString()
adds test




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org