[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 You're welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/56 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 Obviously a problem occurred with Travis: > The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed. Retrying, 2 of 3. > Error: JAVA_HOME is not defined correctly. > We cannot execute /usr/lib/jvm/java-7-oracle/bin/java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/56 [](https://coveralls.io/builds/12526449) Coverage increased (+0.9%) to 98.163% when pulling **12129b2beafc74f8f04957cc52b464a3eacdd3a9 on TheRealHaui:add-some-Unit-Tests** into **aaf4aba369ed0b97d17bc9343f763b0d099dbc2f on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/56 [](https://coveralls.io/builds/12526449) Coverage increased (+0.9%) to 98.163% when pulling **12129b2beafc74f8f04957cc52b464a3eacdd3a9 on TheRealHaui:add-some-Unit-Tests** into **aaf4aba369ed0b97d17bc9343f763b0d099dbc2f on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user jbduncan commented on the issue: https://github.com/apache/commons-text/pull/56 @TheRealHaui Yes, precisely. :) (With hindsight, I should have used the word "violations" instead of "cases"; it would have been clearer that I was referring to the errors that Checkstyle reports, rather than something else.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 You mean the cases reported by the checkstyle plugin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/56 [](https://coveralls.io/builds/12445709) Coverage increased (+1.04%) to 98.34% when pulling **04788b92e136e4e621c6b2799e2d86d52cd8f7d5 on TheRealHaui:add-some-Unit-Tests** into **aaf4aba369ed0b97d17bc9343f763b0d099dbc2f on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user jbduncan commented on the issue: https://github.com/apache/commons-text/pull/56 Thanks @TheRealHaui! I think handling the rest of the cases reported by Checkstyle should be done in a separate PR (or series of PRs if needed) by whoever feels up to it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/56 Reformatted requested code artifacts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/56 @ameyjadiye Try adding the same suppression as commons-lang: ``` ``` That should reduce the errors. Maybe their are other checks which can be reasonably suppressed for tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/56 @PascalSchumacher I just enabled in my local, seems very cumbersome task to me at this point. ``` [INFO] There are 2551 checkstyle errors. . . . [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 41.252 s [INFO] Finished at: 2017-07-18T23:18:57+05:30 [INFO] Final Memory: 36M/621M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (default-cli) on project commons-text: You have 2551 Checkstyle violations. -> [Help 1] . . . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/56 @jbduncan Check-style for commons-text does is currently not applied to tests. I think we should look into enabling it. @TheRealHaui Please fix the things @jbduncan suggested. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user jbduncan commented on the issue: https://github.com/apache/commons-text/pull/56 Oh sorry @TheRealHaui, I just reread my main comment in my review from a few minutes ago, and I realise that I may have sounded confrontational. I had not meant to come across as such, so I wish to apologise if it sounded that way. ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/56 [](https://coveralls.io/builds/12432497) Coverage increased (+1.04%) to 98.34% when pulling **91039cb23f79921238afebbb4bff3ccbbd049e6a on TheRealHaui:add-some-Unit-Tests** into **aaf4aba369ed0b97d17bc9343f763b0d099dbc2f on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
