[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-11 Thread arend-von-reinersdorff 
Github user arend-von-reinersdorff commented on the issue:

https://github.com/apache/commons-text/pull/68
  
@sermojohn Great, thanks :-)


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-10 Thread sermojohn 
Github user sermojohn commented on the issue:

https://github.com/apache/commons-text/pull/68
  
For backwards compatibility, it needs to be off by default, so recursive 
substitution applies by default.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-10 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/68
  
Do we want it to be off by default?


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-10 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/68
  
Seems reasonable to me.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/68
  

[![Coverage 
Status](https://coveralls.io/builds/13640479/badge)](https://coveralls.io/builds/13640479)

Coverage increased (+0.003%) to 98.239% when pulling 
**635cb80d1cb0d32fddfe86be75b0a30eb3d3fab7 on sermojohn:TEXT-74** into 
**317ae8452bb616d4dcbdd9b9d561d8daf2bb5260 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/68
  

[![Coverage 
Status](https://coveralls.io/builds/13640479/badge)](https://coveralls.io/builds/13640479)

Coverage increased (+0.003%) to 98.239% when pulling 
**635cb80d1cb0d32fddfe86be75b0a30eb3d3fab7 on sermojohn:TEXT-74** into 
**317ae8452bb616d4dcbdd9b9d561d8daf2bb5260 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-08 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/68
  
Thanks!

Imho this pull request is good to merge. Only thing that is missing are 
`@since 1.2` tags in the javadoc of the new methods.

@chtompki What do you think? 


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-08 Thread sermojohn 
Github user sermojohn commented on the issue:

https://github.com/apache/commons-text/pull/68
  
Thank you for the notice! 


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-08 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/68
  

[![Coverage 
Status](https://coveralls.io/builds/13620504/badge)](https://coveralls.io/builds/13620504)

Coverage increased (+0.003%) to 98.239% when pulling 
**5bd02a5f8ec870c27bc8995e7ada90997c142144 on sermojohn:TEXT-74** into 
**317ae8452bb616d4dcbdd9b9d561d8daf2bb5260 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

2017-10-08 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/68
  
Thanks for the pull request!

It would be nice if you could fix the checkstyle violations. See 
https://travis-ci.org/apache/commons-text/jobs/284821493 for details or run 
"mvn checkstyle:check" locally.

Thanks!


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org