[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user asfgit closed the pull request at: https://github.com/apache/commons-text/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121372102 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - mvn + - docker run -v `pwd`:/work library/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn" --- End diff -- I'm about to pull this in, but I wonder if we could put in either issues or PR's on the official "maven" docker image whose docker files are given here: https://github.com/carlossg/docker-maven such that we could get oracle java as well as ibm java supported. I've opened the following issue for tracking purposes: https://github.com/carlossg/docker-maven/issues/25 I'm not sure, but I could see licensing being the main blocker to those being brought into the project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121188654 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn" --- End diff -- Hi @britter @garydgregory @chtompki Flashed a though, can we use our own image for this ? we can build it from ```library/ibmjava:8-sdk```. Rather doing ```apt-get update``` and ```apt-get install -y maven``` again and again on fly we can just build our own with below Dockerfile on [Dockerhub](https://hub.docker.com), I also found we have [apache account](https://hub.docker.com/u/apache/) so it will be easy to publish it there. same can be reused by some other project in apache. _(that's why commons is made for anyway :blush: )_ ``` from library/ibmjava:8-sdk RUN apt-get update RUN apt-get install -y maven ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121184938 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk --- End diff -- Hi @chtompki , I just [compared](https://www.diffchecker.com/y4s7vOx6) them and found both Dockerfile belongs to same repository, I took the one from master. Official belongs to some past commit. I prefer to go with official ``` library/ibmjava:8-sdk ``` though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162806 --- Diff: pom.xml --- @@ -150,7 +150,7 @@ -clean test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc +clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc --- End diff -- +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162871 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk --- End diff -- This is a curiousity I'm not sure how to solve. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162778 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn" --- End diff -- The `apt-get update` here might take a long time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162518 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk --- End diff -- I would prefer to use `library/ibmjava:8-jsk` because it's marked on dockerhub as "official" whereas `ibmcom` is just public. It's a bit curious though. It seems that they both point to the same place (repository) one points to "master" and one points to a githash. `ibmcom/ibmjava:8-sdk` - https://github.com/ibmruntimes/ci.docker/blob/master/ibmjava/8/sdk/x86_64/ubuntu/Dockerfile `library/ibmjava:8-sdk` - https://github.com/ibmruntimes/ci.docker/blob/a9a184211f9feef1f2bdd0330ff8ae95e6c015cf/ibmjava/8/sdk/x86_64/ubuntu/Dockerfile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121062216 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc" --- End diff -- thanks @britter for pointing this out. fixed now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121055613 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc" --- End diff -- You can simply run `mvn` at the end without specifying any goals, because we have configured a `defaultGoal` in our pom. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/45 Added IBM Jdk8 build support to travis-ci configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text travis-ibmjdk8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/45.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #45 commit 4774bb19f318ee15232f4d5f3cc08245eb9b9b3a Author: Amey Jadiye Date: 2017-06-08T19:50:27Z adding ibmjdk8 support to commons-text commit 90b5426b33476d091b19eb50de8d352a2295b8c7 Author: Amey Jadiye Date: 2017-06-08T19:59:59Z assume yes for all apt-get install --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
