Re: [JEXL] Problem Integrating JEXL 1.x Branch and Cocoon 2.2.x

[Stefan Bodewig]

On 2010-07-01, Stefan Bodewig wrote:

> From a Gump POV if you ever expect to do another JEXL 1.x release we
> should keep tracking the branch and help the JEXL and Cocoon devs
> figure out which way to go.  If the branch is a dead-end anyway, we
> can as well stop tracking it and provide JEXL 1.1 to Cocoon which is
> known to work.

So I guess the question is whether anybody ever expects to do another
JEXL 1.x release from the branch (which, let me repeat, is incompatible
with JEXL 1.1).

Unless I hear anybody say anything else, I'm going to remove the JEXL
1.x branch builds from Gump and provide JEXL 1.1 to those projects that
depend on it sometime during the next week.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [JEXL] Problem Integrating JEXL 1.x Branch and Cocoon 2.2.x

[Stefan Bodewig]

On 2010-07-01, Stefan Bodewig wrote:

> On 2010-07-01, henrib wrote:

>> A cleaner more future-proof alternative might be to use jexl-2 and the
>> jexl-1 compatibility layer which is part of the distribution as source only
>> (
>> http://svn.apache.org/viewvc/commons/proper/jexl/trunk/jexl2-compat/src/main/java/org/apache/commons/jexl/
>> );

> OK, I see - I may look into building that inside Gump for starters.

Done.

The layer doesn't provide oac.jexl.util.* which means it wouldn't be
useful for the Cocoon case, though.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [JEXL] Problem Integrating JEXL 1.x Branch and Cocoon 2.2.x

[Stefan Bodewig]

Thank you for looking into this Henrib

On 2010-07-01, henrib wrote:

> I've had a quick look at the jexl-1.x source; the VelPropertyGet.isAlive
> method is not called anywhere in jexl's code or tests. Commenting it out
> from the interface does the trick.
> The real problem lies in changing this public interface which could be
> harmful to other projects that may depend on it.

The method has not been part of JEXL 1.1 so anybody who'd depend on the
method must be dependening on a never-released snapshot, right?

> The easiest (obvious) route would be for you to use a locally modified
> / built jexl-1.x snapshot.

Then we could stick with JEXL 1.1 right away.

> We could also create a specific 'gump' branch with that modification
> but this would be really odd process-wise...

And wouldn't make sense to me.

>From a Gump POV if you ever expect to do another JEXL 1.x release we
should keep tracking the branch and help the JEXL and Cocoon devs figure
out which way to go.  If the branch is a dead-end anyway, we can as well
stop tracking it and provide JEXL 1.1 to Cocoon which is known to work.

> A cleaner more future-proof alternative might be to use jexl-2 and the
> jexl-1 compatibility layer which is part of the distribution as source only
> (
> http://svn.apache.org/viewvc/commons/proper/jexl/trunk/jexl2-compat/src/main/java/org/apache/commons/jexl/
> );

OK, I see - I may look into building that inside Gump for starters.

Whether this would be an option for the Cocoon developers (likely only
if there was a binary release of the compatibility layer) is up to them
- I'm just the messenger ;-)

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [JEXL] Problem Integrating JEXL 1.x Branch and Cocoon 2.2.x

[henrib]

Hi Stefan,
I've had a quick look at the jexl-1.x source; the VelPropertyGet.isAlive
method is not called anywhere in jexl's code or tests. Commenting it out
from the interface does the trick.
The real problem lies in changing this public interface which could be
harmful to other projects that may depend on it. 

The easiest (obvious) route would be for you to use a locally modified /
built jexl-1.x snapshot. We could also create a specific 'gump' branch with
that modification but this would be really odd process-wise...

A cleaner more future-proof alternative might be to use jexl-2 and the
jexl-1 compatibility layer which is part of the distribution as source only
(
http://svn.apache.org/viewvc/commons/proper/jexl/trunk/jexl2-compat/src/main/java/org/apache/commons/jexl/
); I might help/check feasibility if needed. 

Cheers
Henrib
-- 
View this message in context: 
http://apache-commons.680414.n4.nabble.com/JEXL-Problem-Integrating-JEXL-1-x-Branch-and-Cocoon-2-2-x-tp2274718p2274885.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[JEXL] Problem Integrating JEXL 1.x Branch and Cocoon 2.2.x

[Stefan Bodewig]

Hi,

after a very long time Gump has started to build larger parts of Cocoon
again and we've run into an issue.  Cocoon's expression language uses
JEXL 1.x and in Gump it builds against the the 1.x svn branch of JEXL.

Unfortunately the VelPropertyGet interface inside that branch contains a
method that is new when compared to JEXL 1.1



A quick scan revealed the isAlive method has been introduced as part of
JEXL-13  in svn revision
543702

more than three years ago.

JEXL-13 claims 2.0.1 was the release to incorporate the fix, so to me it
looks as if the patch should have never been applied to the 1.x branch.
My suggestion would be to revert JEXL-13 from the branch, but then again
I'm neither familiar with JEXL nor Cocoon's usage of it.

If reverting the patch seems to be a bad idea, what would the JEXL
developers recommend to the Cocoon developers going forward?  I'm not
sure whether migrating Cocoon to JEXL 2.x would be an option.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org