Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
Am 16.07.2018 um 02:17 schrieb Gary Gregory: > Thank you for your review; more below. > ' > On Sun, Jul 15, 2018 at 12:20 PM Oliver Heger > wrote: > >> Build works fine on Windows 10 with Java 8. Artifacts and site look good. >> >> +1 >> >> I noticed the following things: >> * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. >> > > That is not the case here or in the git release branch: > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/RELEASE-NOTES.txt > > You should not look in git master. It is in the file that is included in the source and binary distributions. Oliver > > * In README.txt it is stated that "DBCP version 2 requires JDK 1.7.". >> This is not true for version 2.5. >> > > Bummer but not a blocker IMO since other sources make the correct reference > to Java 8. > > >> * I had some problems with the site build: My machine was under high >> load created by another process. While executing the unit tests there >> were some messages about ARJUNA, the build was hanging, and produced >> high CPU load. Another build (with no other processes running) was >> successful. I assume that some transactions ran in timeouts; maybe some >> parameters or timeout settings could be fine-tuned. Another point is >> that the site build printed some exception stack-traces, but this does >> not seem to have an effect. >> * There are some FindBugs warnings about internal state that is exposed, >> I think most of them are about arrays storing a user password. Should >> these be fixed by copying the arrays defensively? >> > > Sure, we can do that after this release IMO. Would you like to provide a > patch/PR/commit? > > Gary > > >> >> Oliver >> >> Am 13.07.2018 um 02:43 schrieb Gary Gregory: >>> We have fixed quite a few bugs and added some significant enhancements >>> since Apache Commons DBCP 2.4.0 was released, so I would like to release >>> Apache Commons DBCP 2.5.0. >>> >>> The most significant change is support for JDCB 4.2 which now requires >> Java >>> 8. >>> >>> Apache Commons DBCP 2.5.0 RC1 is available for review here: >>> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn >>> revision 28082) >>> >>> The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is >>> 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: >>> >>> >> https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 >>> >>> Maven artifacts are here: >>> >>> >> https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ >>> >>> These are the Maven artifacts and their hashes in Nexus: >>> >>> #Release SHA-1s >>> #Thu Jul 12 18:34:09 MDT 2018 >>> commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d >>> commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd >>> >> commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 >>> >> commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa >>> >> commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e >>> commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 >>> commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 >>> >> commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f >>> >> commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 >>> >> commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f >>> commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 >>> commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc >>> >> commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d >>> >> commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde >>> >> commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 >>> commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 >>> >> commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce >>> commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 >>> >>> #Release SHA-256s >>> #Thu Jul 12 18:34:09 MDT 2018 >>> >> commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad >>> >> commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 >>> >> commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 >>> >> commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 >>> >> commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 >>> >> commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a >>> >> commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 >>> >> commons-dbcp2-2.5.0-s
Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
+1: Signatures, Site, build (mvn clean test package site) with java8, java9 (with some weird erroneous stack traces associated with the maven-project-info-reports-plugin), and java10 (with similar erroneous stack traces) all look good. > On Jul 12, 2018, at 8:43 PM, Gary Gregory wrote: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.4.0 was released, so I would like to release > Apache Commons DBCP 2.5.0. > > The most significant change is support for JDCB 4.2 which now requires Java > 8. > > Apache Commons DBCP 2.5.0 RC1 is available for review here: >https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn > revision 28082) > > The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is > 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: > > https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-1s > #Thu Jul 12 18:34:09 MDT 2018 > commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d > commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd > commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 > commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa > commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e > commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 > commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 > commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f > commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 > commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f > commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 > commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc > commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d > commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde > commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 > commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 > commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce > commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 > > #Release SHA-256s > #Thu Jul 12 18:34:09 MDT 2018 > commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad > commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 > commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 > commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 > commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 > commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a > commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 > commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 > commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e > commons-dbcp2-2.5.0-javadoc-javadoc=15678544a25b091ad1922e69d1e0ebd7513a7d2d2e3fdfecbbe7d44b23f7840d > commons-dbcp2-2.5.0-bin-tar.gz=2e9da64b97af50951a3ac14b2269993fd8de323e00265d0e6a952fc108f05a22 > commons-dbcp2-2.5.0-pom.asc=a7b3a97deb8e8c90564754523440330f880b30ed8030bf74420c7974fbc404a8 > commons-dbcp2-2.5.0-tests-test-jar=3ddabb853de31e284ef5f8befdbc7c995c5d96ee892c53cb540d7f4fada4b81c > commons-dbcp2-2.5.0-test-sources-jar.asc=37af73c51355665cc61e75892e024d1413d5abc8fff9b1b6d327aee6366aa8b1 > commons-dbcp2-2.5.0-sources-java-source=e6e9fc84c99b7816ac5d7f39f5babaec509b61d6527170f92896ffb841081c94 > commons-dbcp2-2.5.0-bin-zip.asc=0de382c1bf65e696dc3d8c4dfcd03ff713e1cbde935bb0208bb06e3c138755ff > commons-dbcp2-2.5.0-tests-jar.asc=3fcb4bc5dd372c55f13a454f8052d5dbd49dd4ded83b9dce37c99d52d0131e53 > commons-dbcp2-2.5.0-jar.asc=88d6537e1df9cf2027222fea08494a74ce601a4e795cd4f5c986a4929ba8c7a0 > > > (no need for .asc hashes!) > > I have tested this with 'mvn clean install site' using: > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; > 2018-06-17T12:33:14-06:00) > Maven home: C:\Java\apache-maven-3.5.4\bin\.. > Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_172\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Details of changes since 2.4.0 are in the release n
Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
Thank you for your review; more below. ' On Sun, Jul 15, 2018 at 12:20 PM Oliver Heger wrote: > Build works fine on Windows 10 with Java 8. Artifacts and site look good. > > +1 > > I noticed the following things: > * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. > That is not the case here or in the git release branch: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/RELEASE-NOTES.txt You should not look in git master. * In README.txt it is stated that "DBCP version 2 requires JDK 1.7.". > This is not true for version 2.5. > Bummer but not a blocker IMO since other sources make the correct reference to Java 8. > * I had some problems with the site build: My machine was under high > load created by another process. While executing the unit tests there > were some messages about ARJUNA, the build was hanging, and produced > high CPU load. Another build (with no other processes running) was > successful. I assume that some transactions ran in timeouts; maybe some > parameters or timeout settings could be fine-tuned. Another point is > that the site build printed some exception stack-traces, but this does > not seem to have an effect. > * There are some FindBugs warnings about internal state that is exposed, > I think most of them are about arrays storing a user password. Should > these be fixed by copying the arrays defensively? > Sure, we can do that after this release IMO. Would you like to provide a patch/PR/commit? Gary > > Oliver > > Am 13.07.2018 um 02:43 schrieb Gary Gregory: > > We have fixed quite a few bugs and added some significant enhancements > > since Apache Commons DBCP 2.4.0 was released, so I would like to release > > Apache Commons DBCP 2.5.0. > > > > The most significant change is support for JDCB 4.2 which now requires > Java > > 8. > > > > Apache Commons DBCP 2.5.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn > > revision 28082) > > > > The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is > > 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: > > > > > https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ > > > > These are the Maven artifacts and their hashes in Nexus: > > > > #Release SHA-1s > > #Thu Jul 12 18:34:09 MDT 2018 > > commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d > > commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd > > > commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 > > > commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa > > > commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e > > commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 > > commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 > > > commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f > > > commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 > > > commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f > > commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 > > commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc > > > commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d > > > commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde > > > commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 > > commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 > > > commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce > > commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 > > > > #Release SHA-256s > > #Thu Jul 12 18:34:09 MDT 2018 > > > commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad > > > commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 > > > commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 > > > commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 > > > commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 > > > commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a > > > commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 > > > commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 > > > commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e > > > commons-dbcp2-2.5.0-javad
Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
Thanks Rob. Gary On Sun, Jul 15, 2018, 15:01 Rob Tompkins wrote: > I can get to it this evening/tonight (UTC-4). > > -Rob > > > On Jul 15, 2018, at 2:03 PM, Gary Gregory > wrote: > > > > My +1 and looking for more reviews. > > > > Gary > > > >> On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory > wrote: > >> > >> We have fixed quite a few bugs and added some significant enhancements > >> since Apache Commons DBCP 2.4.0 was released, so I would like to release > >> Apache Commons DBCP 2.5.0. > >> > >> The most significant change is support for JDCB 4.2 which now requires > >> Java 8. > >> > >> Apache Commons DBCP 2.5.0 RC1 is available for review here: > >>https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn > >> revision 28082) > >> > >> The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is > >> 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: > >> > >> > https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 > >> > >> Maven artifacts are here: > >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ > >> > >> These are the Maven artifacts and their hashes in Nexus: > >> > >> #Release SHA-1s > >> #Thu Jul 12 18:34:09 MDT 2018 > >> commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d > >> commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd > >> > >> > commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 > >> > commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa > >> > >> > commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e > >> commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 > >> commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 > >> > commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f > >> > >> > commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 > >> > >> > commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f > >> commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 > >> commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc > >> > commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d > >> > >> > commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde > >> > >> > commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 > >> commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 > >> > commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce > >> commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 > >> > >> #Release SHA-256s > >> #Thu Jul 12 18:34:09 MDT 2018 > >> > >> > commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad > >> > >> > commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 > >> > >> > commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 > >> > >> > commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 > >> > >> > commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 > >> > >> > commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a > >> > >> > commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 > >> > >> > commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 > >> > >> > commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e > >> > >> > commons-dbcp2-2.5.0-javadoc-javadoc=15678544a25b091ad1922e69d1e0ebd7513a7d2d2e3fdfecbbe7d44b23f7840d > >> > >> > commons-dbcp2-2.5.0-bin-tar.gz=2e9da64b97af50951a3ac14b2269993fd8de323e00265d0e6a952fc108f05a22 > >> > >> > commons-dbcp2-2.5.0-pom.asc=a7b3a97deb8e8c90564754523440330f880b30ed8030bf74420c7974fbc404a8 > >> > >> > commons-dbcp2-2.5.0-tests-test-jar=3ddabb853de31e284ef5f8befdbc7c995c5d96ee892c53cb540d7f4fada4b81c > >> > >> > commons-dbcp2-2.5.0-test-sources-jar.asc=37af73c51355665cc61e75892e024d1413d5abc8fff9b1b6d327aee6366aa8b1 > >> > >> > commons-dbcp2-2.5.0-sources-java-source=e6e9fc84c99b7816ac5d7f39f5babaec509b61d6527170f92896ffb841081c94 > >> > >> > commons-dbcp2-2.5.0-bin-zip.asc=0de382c1bf65e696dc3d8c4dfcd03ff713e1cbde935bb0208bb06e3c138755ff > >> > >> > commons-dbcp2-2.5.0-tests-jar.asc=3fcb4bc5dd372c55f13a454f8052d5dbd49dd4ded83b9dce37c99d52d0131e53 > >> > >> > commons-dbcp2-2.5.0-jar.asc=88d6537e1df9cf2027222fea08494a74ce601a4e795cd4f5c986a4929ba8c7a0 > >> > >> > >> (no need for .asc hashes!) > >> > >> I have tested this with 'mvn clean install site' using: > >> > >> Apache Maven 3.5.4 (1edded0938998ed
Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
I can get to it this evening/tonight (UTC-4). -Rob > On Jul 15, 2018, at 2:03 PM, Gary Gregory wrote: > > My +1 and looking for more reviews. > > Gary > >> On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory wrote: >> >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons DBCP 2.4.0 was released, so I would like to release >> Apache Commons DBCP 2.5.0. >> >> The most significant change is support for JDCB 4.2 which now requires >> Java 8. >> >> Apache Commons DBCP 2.5.0 RC1 is available for review here: >>https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn >> revision 28082) >> >> The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is >> 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: >> >> https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ >> >> These are the Maven artifacts and their hashes in Nexus: >> >> #Release SHA-1s >> #Thu Jul 12 18:34:09 MDT 2018 >> commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d >> commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd >> >> commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 >> commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa >> >> commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e >> commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 >> commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 >> commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f >> >> commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 >> >> commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f >> commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 >> commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc >> commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d >> >> commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde >> >> commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 >> commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 >> commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce >> commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 >> >> #Release SHA-256s >> #Thu Jul 12 18:34:09 MDT 2018 >> >> commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad >> >> commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 >> >> commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 >> >> commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 >> >> commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 >> >> commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a >> >> commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 >> >> commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 >> >> commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e >> >> commons-dbcp2-2.5.0-javadoc-javadoc=15678544a25b091ad1922e69d1e0ebd7513a7d2d2e3fdfecbbe7d44b23f7840d >> >> commons-dbcp2-2.5.0-bin-tar.gz=2e9da64b97af50951a3ac14b2269993fd8de323e00265d0e6a952fc108f05a22 >> >> commons-dbcp2-2.5.0-pom.asc=a7b3a97deb8e8c90564754523440330f880b30ed8030bf74420c7974fbc404a8 >> >> commons-dbcp2-2.5.0-tests-test-jar=3ddabb853de31e284ef5f8befdbc7c995c5d96ee892c53cb540d7f4fada4b81c >> >> commons-dbcp2-2.5.0-test-sources-jar.asc=37af73c51355665cc61e75892e024d1413d5abc8fff9b1b6d327aee6366aa8b1 >> >> commons-dbcp2-2.5.0-sources-java-source=e6e9fc84c99b7816ac5d7f39f5babaec509b61d6527170f92896ffb841081c94 >> >> commons-dbcp2-2.5.0-bin-zip.asc=0de382c1bf65e696dc3d8c4dfcd03ff713e1cbde935bb0208bb06e3c138755ff >> >> commons-dbcp2-2.5.0-tests-jar.asc=3fcb4bc5dd372c55f13a454f8052d5dbd49dd4ded83b9dce37c99d52d0131e53 >> >> commons-dbcp2-2.5.0-jar.asc=88d6537e1df9cf2027222fea08494a74ce601a4e795cd4f5c986a4929ba8c7a0 >> >> >> (no need for .asc hashes!) >> >> I have tested this with 'mvn clean install site' using: >> >> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> 2018-06-17T12:33:14-06:00) >> Maven home: C:\Java\apache-maven-3.5.4\bin\.. >> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program >> Files\Java\jdk1.8.0_172\jre >> Default locale: en_US, platform encoding: Cp1252 >> OS name: "windows 10", version: "
Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
Build works fine on Windows 10 with Java 8. Artifacts and site look good. +1 I noticed the following things: * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. * In README.txt it is stated that "DBCP version 2 requires JDK 1.7.". This is not true for version 2.5. * I had some problems with the site build: My machine was under high load created by another process. While executing the unit tests there were some messages about ARJUNA, the build was hanging, and produced high CPU load. Another build (with no other processes running) was successful. I assume that some transactions ran in timeouts; maybe some parameters or timeout settings could be fine-tuned. Another point is that the site build printed some exception stack-traces, but this does not seem to have an effect. * There are some FindBugs warnings about internal state that is exposed, I think most of them are about arrays storing a user password. Should these be fixed by copying the arrays defensively? Oliver Am 13.07.2018 um 02:43 schrieb Gary Gregory: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.4.0 was released, so I would like to release > Apache Commons DBCP 2.5.0. > > The most significant change is support for JDCB 4.2 which now requires Java > 8. > > Apache Commons DBCP 2.5.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn > revision 28082) > > The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is > 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: > > https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-1s > #Thu Jul 12 18:34:09 MDT 2018 > commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d > commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd > commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 > commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa > commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e > commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 > commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 > commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f > commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 > commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f > commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 > commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc > commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d > commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde > commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 > commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 > commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce > commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 > > #Release SHA-256s > #Thu Jul 12 18:34:09 MDT 2018 > commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad > commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 > commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 > commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 > commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 > commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a > commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 > commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 > commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e > commons-dbcp2-2.5.0-javadoc-javadoc=15678544a25b091ad1922e69d1e0ebd7513a7d2d2e3fdfecbbe7d44b23f7840d > commons-dbcp2-2.5.0-bin-tar.gz=2e9da64b97af50951a3ac14b2269993fd8de323e00265d0e6a952fc108f05a22 > commons-dbcp2-2.5.0-pom.asc=a7b3a97deb8e8c90564754523440330f880b30ed8030bf74420c7974fbc404a8 > commons-dbcp2-2.5.0-tests-test-jar=3ddabb853de31e284ef5f8befdbc7c995c5d96ee892c53cb540d7f4fada4b81c > commons-dbcp2-2.5.0-test-sources-jar.asc=37af73c51355665cc61e75892e024d1413d5abc8fff9b1b6d327aee6366aa8b1 > commons-dbcp2-2.5.0-sources-java-source=e6e9fc84c99b7816ac5d7f39f5babaec509b61d6527170f92896ffb841081c94 > commons-dbcp2-2.5.0-bin-zip.asc=0de382c1bf65e696dc3d8c4dfcd03ff7
Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
My +1 and looking for more reviews. Gary On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.4.0 was released, so I would like to release > Apache Commons DBCP 2.5.0. > > The most significant change is support for JDCB 4.2 which now requires > Java 8. > > Apache Commons DBCP 2.5.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn > revision 28082) > > The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is > 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: > > https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-1s > #Thu Jul 12 18:34:09 MDT 2018 > commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d > commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd > > commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 > commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa > > commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e > commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 > commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 > commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f > > commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 > > commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f > commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 > commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc > commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d > > commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde > > commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 > commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 > commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce > commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 > > #Release SHA-256s > #Thu Jul 12 18:34:09 MDT 2018 > > commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad > > commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 > > commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 > > commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 > > commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 > > commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a > > commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 > > commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 > > commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e > > commons-dbcp2-2.5.0-javadoc-javadoc=15678544a25b091ad1922e69d1e0ebd7513a7d2d2e3fdfecbbe7d44b23f7840d > > commons-dbcp2-2.5.0-bin-tar.gz=2e9da64b97af50951a3ac14b2269993fd8de323e00265d0e6a952fc108f05a22 > > commons-dbcp2-2.5.0-pom.asc=a7b3a97deb8e8c90564754523440330f880b30ed8030bf74420c7974fbc404a8 > > commons-dbcp2-2.5.0-tests-test-jar=3ddabb853de31e284ef5f8befdbc7c995c5d96ee892c53cb540d7f4fada4b81c > > commons-dbcp2-2.5.0-test-sources-jar.asc=37af73c51355665cc61e75892e024d1413d5abc8fff9b1b6d327aee6366aa8b1 > > commons-dbcp2-2.5.0-sources-java-source=e6e9fc84c99b7816ac5d7f39f5babaec509b61d6527170f92896ffb841081c94 > > commons-dbcp2-2.5.0-bin-zip.asc=0de382c1bf65e696dc3d8c4dfcd03ff713e1cbde935bb0208bb06e3c138755ff > > commons-dbcp2-2.5.0-tests-jar.asc=3fcb4bc5dd372c55f13a454f8052d5dbd49dd4ded83b9dce37c99d52d0131e53 > > commons-dbcp2-2.5.0-jar.asc=88d6537e1df9cf2027222fea08494a74ce601a4e795cd4f5c986a4929ba8c7a0 > > > (no need for .asc hashes!) > > I have tested this with 'mvn clean install site' using: > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; > 2018-06-17T12:33:14-06:00) > Maven home: C:\Java\apache-maven-3.5.4\bin\.. > Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_172\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Details of changes since 2.4.0 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/site/cha
[VOTE] Release Apache Commons DBCP 2.5.0 based on RC1
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.4.0 was released, so I would like to release Apache Commons DBCP 2.5.0. The most significant change is support for JDCB 4.2 which now requires Java 8. Apache Commons DBCP 2.5.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1 (svn revision 28082) The Git tag commons-dbcp-2.5.0-RC1 commit for this RC is 00fd9d9b69caffef91aabc4091a9fe2fda787c7e which you can browse here: https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.5.0-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1345/org/apache/commons/commons-dbcp2/2.5.0/ These are the Maven artifacts and their hashes in Nexus: #Release SHA-1s #Thu Jul 12 18:34:09 MDT 2018 commons-dbcp2-2.5.0-src-zip=334d6ca8f17af2b3cdfecefee80be9ef4c1b0a6d commons-dbcp2-2.5.0-src-zip.asc=9afc06323785921dd3b3fbbefdb7fc2305f5edcd commons-dbcp2-2.5.0-javadoc-jar.asc=ac52ea589eeadc010f94873b0ceda03526f960a8 commons-dbcp2-2.5.0-bin-tar.gz.asc=18307255d2067b0558ce27666e5521e58bb2b4fa commons-dbcp2-2.5.0-sources-jar.asc=56134e00f522745803afa4a00dbb5f559835461e commons-dbcp2-2.5.0-bin-zip=b700f62f9b227ab5678979cd82146e9f7fb6e668 commons-dbcp2-2.5.0-src-tar.gz=1c2322dbe89a23c626cc319e597547fe3d5b9c14 commons-dbcp2-2.5.0-src-tar.gz.asc=b8e4769bb919eb080c62e8219b9ada2b6ab2d42f commons-dbcp2-2.5.0-test-sources-java-source=951e09cf75664e14d9c2860881c806ec8b9a2776 commons-dbcp2-2.5.0-javadoc-javadoc=ffd04b019c2ce18bd7aaf72560b11bcabf2f676f commons-dbcp2-2.5.0-bin-tar.gz=b69ef36e143bfe60edffd2da361e27e59d97fc20 commons-dbcp2-2.5.0-pom.asc=af83bf99b904ddd1d913044c5f0bda17af0cf4bc commons-dbcp2-2.5.0-tests-test-jar=b09d7729f5475a98896cd7b54c62c1e7a79f085d commons-dbcp2-2.5.0-test-sources-jar.asc=139c97e3cfbb3212ddcbe557ddabb16271b89bde commons-dbcp2-2.5.0-sources-java-source=31049a1a792aa8f2cd4ef7069bf1bdbc2eb66846 commons-dbcp2-2.5.0-bin-zip.asc=fbe95bbdf474385465099fcb0e1298497b757e47 commons-dbcp2-2.5.0-tests-jar.asc=d0f9b231c86f35ac9afe8e96361fda9bbbd2d1ce commons-dbcp2-2.5.0-jar.asc=d70bcf8c312f33e4fd7a1d4ce4a014500cd81535 #Release SHA-256s #Thu Jul 12 18:34:09 MDT 2018 commons-dbcp2-2.5.0-src-zip=36ace59006596586e8ea8952b194dd376f81a6cfc4333ab628aa10420e0ea6ad commons-dbcp2-2.5.0-src-zip.asc=11da753c934ac4643ccee6efb21702cf1ffe2a81505954870174a4face46dd94 commons-dbcp2-2.5.0-javadoc-jar.asc=2423345b8316c5778d5025659bd675c803f88bc71a9b679880bd9285fa2e1d10 commons-dbcp2-2.5.0-bin-tar.gz.asc=762012c3aa5471cf530d5c030c226bb9fd21adf03a5356c7ff9c72ed06a00155 commons-dbcp2-2.5.0-sources-jar.asc=509e9dde87004d4f3deff97e951353d818fdd928c694e0db3c63bde8e17db0a2 commons-dbcp2-2.5.0-bin-zip=2d94088c7514fc375abb93f013bf46782d77594511881457e3b75f00bafa9c3a commons-dbcp2-2.5.0-src-tar.gz=a8b0f36bcb855705f94b9241c9dd0e2bc6343cd018f75f1c79a8cf923fdcea88 commons-dbcp2-2.5.0-src-tar.gz.asc=64eda94776b80f20a401061b2cffe8fac0504d086761b680e4bb3612e45dd2e7 commons-dbcp2-2.5.0-test-sources-java-source=2b81b5c366ee5d5db7bd11075fc267a6ce89728c0e059aa37ca2fc24be5f3e9e commons-dbcp2-2.5.0-javadoc-javadoc=15678544a25b091ad1922e69d1e0ebd7513a7d2d2e3fdfecbbe7d44b23f7840d commons-dbcp2-2.5.0-bin-tar.gz=2e9da64b97af50951a3ac14b2269993fd8de323e00265d0e6a952fc108f05a22 commons-dbcp2-2.5.0-pom.asc=a7b3a97deb8e8c90564754523440330f880b30ed8030bf74420c7974fbc404a8 commons-dbcp2-2.5.0-tests-test-jar=3ddabb853de31e284ef5f8befdbc7c995c5d96ee892c53cb540d7f4fada4b81c commons-dbcp2-2.5.0-test-sources-jar.asc=37af73c51355665cc61e75892e024d1413d5abc8fff9b1b6d327aee6366aa8b1 commons-dbcp2-2.5.0-sources-java-source=e6e9fc84c99b7816ac5d7f39f5babaec509b61d6527170f92896ffb841081c94 commons-dbcp2-2.5.0-bin-zip.asc=0de382c1bf65e696dc3d8c4dfcd03ff713e1cbde935bb0208bb06e3c138755ff commons-dbcp2-2.5.0-tests-jar.asc=3fcb4bc5dd372c55f13a454f8052d5dbd49dd4ded83b9dce37c99d52d0131e53 commons-dbcp2-2.5.0-jar.asc=88d6537e1df9cf2027222fea08494a74ce601a4e795cd4f5c986a4929ba8c7a0 (no need for .asc hashes!) I have tested this with 'mvn clean install site' using: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T12:33:14-06:00) Maven home: C:\Java\apache-maven-3.5.4\bin\.. Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_172\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Details of changes since 2.4.0 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.5.0-RC1/site (note some *relative* links are broken and the 2.5.0 directories are not yet created - these will be OK once the site is deployed.) CLIRR Report (compared to 2.4.0): https://dist.apache.org/re
